On 10/20/17 1:03 AM, Sundararajan Athijegannathan wrote:
Updated: http://cr.openjdk.java.net/~sundar/8189671/webrev.03/
Looks good.
Mandy
On 20/10/2017 09:03, Sundararajan Athijegannathan wrote:
Updated: http://cr.openjdk.java.net/~sundar/8189671/webrev.03/
Looks good.
-Alan
Updated: http://cr.openjdk.java.net/~sundar/8189671/webrev.03/
-Sundar
On 20/10/17, 12:46 PM, Alan Bateman wrote:
On 20/10/2017 04:53, Sundararajan Athijegannathan wrote:
Hi,
Updated to include location (when available) and formatting:
http://cr.openjdk.java.net/~sundar/8189671/webrev.02/
T
On 20/10/2017 04:53, Sundararajan Athijegannathan wrote:
Hi,
Updated to include location (when available) and formatting:
http://cr.openjdk.java.net/~sundar/8189671/webrev.02/
This looks right now. As jlink only supports packaged modules on the
file system then each module should have a locati
Hi,
Updated to include location (when available) and formatting:
http://cr.openjdk.java.net/~sundar/8189671/webrev.02/
-Sundar
On 20/10/17, 3:37 AM, mandy chung wrote:
Hi Sunder,
Updated: http://cr.openjdk.java.net/~sundar/8189671/webrev.01/
This version checks the resolved modules which
Hi Sunder,
Updated: http://cr.openjdk.java.net/~sundar/8189671/webrev.01/
This version checks the resolved modules which is good. One other comment:
444 throw new
IllegalArgumentException(taskHelper.getMessage("err.automatic.module",
modDesc.name()));It may be useful to include the pathnam
On 10/19/17 7:04 AM, Sundararajan Athijegannathan wrote:
Please review.
Bug: https://bugs.openjdk.java.net/browse/JDK-8189671
Webrev: http://cr.openjdk.java.net/~sundar/8189671/webrev.00/
441 ModuleFinder finder = config.finder();
442 for (String root : config.getModules()) { This should che
Right. Updated: http://cr.openjdk.java.net/~sundar/8189671/webrev.01/
Thanks,
-Sundar
On 19/10/17, 8:05 PM, Alan Bateman wrote:
On 19/10/2017 15:04, Sundararajan Athijegannathan wrote:
Please review.
Bug: https://bugs.openjdk.java.net/browse/JDK-8189671
Webrev: http://cr.openjdk.java.net/~sun
On 19/10/2017 15:04, Sundararajan Athijegannathan wrote:
Please review.
Bug: https://bugs.openjdk.java.net/browse/JDK-8189671
Webrev: http://cr.openjdk.java.net/~sundar/8189671/webrev.00/
Why do you want to treat the root modules differently? Shouldn't it
look at all modules in the configurati
Please review.
Bug: https://bugs.openjdk.java.net/browse/JDK-8189671
Webrev: http://cr.openjdk.java.net/~sundar/8189671/webrev.00/
Thanks,
-Sundar
10 matches
Mail list logo