Thanks for your reviews!
-Sundar
On 27/10/17, 3:01 AM, mandy chung wrote:
On 10/26/17 10:04 AM, Sundararajan Athijegannathan wrote:
Updated webrev:
http://cr.openjdk.java.net/~sundar/8189777/webrev.04/index.html
Looks good. Thanks for incorporating the comments.
Mandy
On 10/26/17 10:04 AM, Sundararajan Athijegannathan wrote:
Updated webrev:
http://cr.openjdk.java.net/~sundar/8189777/webrev.04/index.html
Looks good. Thanks for incorporating the comments.
Mandy
On 26/10/2017 18:04, Sundararajan Athijegannathan wrote:
Updated webrev:
http://cr.openjdk.java.net/~sundar/8189777/webrev.04/index.html
This is much cleaner and addresses the points that I brought up. So
looks good to me.
-Alan
Updated webrev:
http://cr.openjdk.java.net/~sundar/8189777/webrev.04/index.html
-Sundar
On 26/10/17, 10:17 PM, mandy chung wrote:
jlink --add-modules ALL-MODULE-PATH does not work in this patch since
the default module is added after the roots set is computed.
AppRuntimeImageBuilder could ca
jlink --add-modules ALL-MODULE-PATH does not work in this patch since
the default module is added after the roots set is computed.
AppRuntimeImageBuilder could calls its moduleFinder method (that calls
JlinkTask::newModuleFinder). packager may already provide the default
module path and we w
On 25/10/2017 14:43, Sundararajan Athijegannathan wrote:
Second constructor is used by packager (internal) api. I could move
getDefaultModulePath to JlinkTask..
Ugh, we need to get packager moved away from using this.
-Alan.
Second constructor is used by packager (internal) api. I could move
getDefaultModulePath to JlinkTask..
-Sundar
On 25/10/17, 6:25 PM, Alan Bateman wrote:
On 25/10/2017 11:23, Sundararajan Athijegannathan wrote:
Updated: http://cr.openjdk.java.net/~sundar/8189777/webrev.03/
This looks better.
On 25/10/2017 11:23, Sundararajan Athijegannathan wrote:
Updated: http://cr.openjdk.java.net/~sundar/8189777/webrev.03/
This looks better. A few comments/questions:
Does the JlinkConfiguration constructor that takes the ModuleFinder
still need the module path? I assume it shouldn't be needed n
Updated: http://cr.openjdk.java.net/~sundar/8189777/webrev.03/
Thanks
-Sundar
On 24/10/17, 10:40 PM, mandy chung wrote:
On 10/23/17 9:05 PM, Sundararajan Athijegannathan wrote:
Hi,
* ALL-MODULE-PATH case seems to be handled fine (in private
JlinkConfiguration initJlinkConfig() throws BadA
On 10/23/17 9:05 PM, Sundararajan Athijegannathan wrote:
Hi,
* ALL-MODULE-PATH case seems to be handled fine (in private
JlinkConfiguration initJlinkConfig() throws BadArgs { method). When no
--module-path is specified, default module path is used and all
default observable modules are add
Hi,
* ALL-MODULE-PATH case seems to be handled fine (in private
JlinkConfiguration initJlinkConfig() throws BadArgs { method). When no
--module-path is specified, default module path is used and all default
observable modules are added as root. I ran the command you mentioned
and it worked f
On 10/23/17 3:37 AM, Sundararajan Athijegannathan wrote:
Updated for getDefaultModulePath. moduleFinder uses three instance
fields - modulepaths, limitmods and modules. We may have to pass all
to the static method...
http://cr.openjdk.java.net/~sundar/8189777/webrev.01
What happens to this
On 23/10/2017 11:37, Sundararajan Athijegannathan wrote:
Updated for getDefaultModulePath. moduleFinder uses three instance
fields - modulepaths, limitmods and modules. We may have to pass all
to the static method...
Yes, if you want to avoid operating on a partly initialized
JlinkConfiguration
Updated for getDefaultModulePath. moduleFinder uses three instance
fields - modulepaths, limitmods and modules. We may have to pass all to
the static method...
http://cr.openjdk.java.net/~sundar/8189777/webrev.01
Thanks
-Sundar
On 23/10/17, 1:11 PM, Alan Bateman wrote:
On 23/10/2017 06:37, S
On 23/10/2017 06:37, Sundararajan Athijegannathan wrote:
Please review.
Bug: https://bugs.openjdk.java.net/browse/JDK-8189777
Webrev: http://cr.openjdk.java.net/~sundar/8189777/webrev.00/
This patch is very welcome as it makes jlink easier to use without any
impact to the cross building case.
Please review.
Bug: https://bugs.openjdk.java.net/browse/JDK-8189777
Webrev: http://cr.openjdk.java.net/~sundar/8189777/webrev.00/
Thanks,
-Sundar
16 matches
Mail list logo
