Re: RFR 8216535: tools/jimage/JImageExtractTest.java timed out

2019-05-30 Thread Sundararajan Athijegannathan
Hi Mandy, Sorry I pushed the change. I'll take care of these suggestions in future change in this area. Thanks, -Sundar On 31/05/19, 8:13 AM, Mandy Chung wrote: Hi Sundar, On 5/30/19 10:12 AM, Sundararajan Athijegannathan wrote: Please review. Bug: https://bugs.openjdk.java.net/browse/JDK

Re: RFR 8216535: tools/jimage/JImageExtractTest.java timed out

2019-05-30 Thread Mandy Chung
Hi Sundar, On 5/30/19 10:12 AM, Sundararajan Athijegannathan wrote: Please review. Bug: https://bugs.openjdk.java.net/browse/JDK-8216535 Webrev: https://cr.openjdk.java.net/~sundar/8216535/webrev.00/ Looks okay. It seems cleaner to have a new JImageCliTest constructor that takes the path t

Re: RFR 8216535: tools/jimage/JImageExtractTest.java timed out

2019-05-30 Thread Jim Laskey
+1 > On May 30, 2019, at 2:12 PM, Sundararajan Athijegannathan > wrote: > > Please review. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8216535 > Webrev: https://cr.openjdk.java.net/~sundar/8216535/webrev.00/ > > I'm creating a small jre image with just java.base and jdk.zipfs modules i

RFR 8216535: tools/jimage/JImageExtractTest.java timed out

2019-05-30 Thread Sundararajan Athijegannathan
Please review. Bug: https://bugs.openjdk.java.net/browse/JDK-8216535 Webrev: https://cr.openjdk.java.net/~sundar/8216535/webrev.00/ I'm creating a small jre image with just java.base and jdk.zipfs modules it. The lib/modules of that small jre is extracted for the test purpose. This reduces tim