Re: RFR 8220700: jlink generated launcher script needs quoting to avoid parameter expansion

On 8/21/19 4:33 AM, sundararajan.athijegannat...@oracle.com wrote: Thanks Severin for your test improvement suggestion! Updated: http://cr.openjdk.java.net/~sundar/8220700/webrev.02/index.html The test case is good. Mandy

Re: RFR 8220700: jlink generated launcher script needs quoting to avoid parameter expansion

On Wed, 2019-08-21 at 17:03 +0530, sundararajan.athijegannat...@oracle.com wrote: > Thanks Severin for your test improvement suggestion! > > Updated: http://cr.openjdk.java.net/~sundar/8220700/webrev.02/index.html Looks good. Thanks, Severin

Re: RFR 8220700: jlink generated launcher script needs quoting to avoid parameter expansion

Hi Alan, Thanks for your review. I'll add a comment in Adder and push. Thanks, -Sundar On 21/08/19 5:28 pm, Alan Bateman wrote: On 21/08/2019 12:33, sundararajan.athijegannat...@oracle.com wrote: Thanks Severin for your test improvement suggestion! Updated: http://cr.openjdk.java.net/~sunda

Re: RFR 8220700: jlink generated launcher script needs quoting to avoid parameter expansion

On 21/08/2019 12:33, sundararajan.athijegannat...@oracle.com wrote: Thanks Severin for your test improvement suggestion! Updated: http://cr.openjdk.java.net/~sundar/8220700/webrev.02/index.html This looks okay but would be nice if Adder had a comment to make it clear that it totals the argument

Re: RFR 8220700: jlink generated launcher script needs quoting to avoid parameter expansion

Thanks Severin for your test improvement suggestion! Updated: http://cr.openjdk.java.net/~sundar/8220700/webrev.02/index.html PS. This email is in response to https://mail.openjdk.java.net/pipermail/jigsaw-dev/2019-August/014273.html For some reason, I didn't get Severin's email. Checked it by

Re: RFR 8220700: jlink generated launcher script needs quoting to avoid parameter expansion

Hi, On Wed, 2019-08-21 at 12:23 +0530, sundararajan.athijegannat...@oracle.com wrote: > Updated to add a test: > > http://cr.openjdk.java.net/~sundar/8220700/webrev.01 > > PS. There are launcher tests in BasicTest.java and arguments are passed > even - but args are only printed. The new test p

Re: RFR 8220700: jlink generated launcher script needs quoting to avoid parameter expansion

Updated to add a test: http://cr.openjdk.java.net/~sundar/8220700/webrev.01 PS. There are launcher tests in BasicTest.java and arguments are passed even - but args are only printed. The new test passes args and checks the return value that is computed using the args. Thanks, -Sundar On 20/

Re: RFR 8220700: jlink generated launcher script needs quoting to avoid parameter expansion

On 20/08/2019 17:25, Mandy Chung wrote: +1 What we really want is to replace this stop-gap shell script some day with jlink to generate the native launcher [1]. I agree. One other thing for stop-gap is a test as we could easily regress without any of the existing tests catching it. -Alan

Re: RFR 8220700: jlink generated launcher script needs quoting to avoid parameter expansion

+1 What we really want is to replace this stop-gap shell script some day with jlink to generate the native launcher [1]. Mandy [1] JDK-8182555 On 8/20/19 4:52 AM, sundararajan.athijegannat...@oracle.com wrote: Oops. Wrong bug link. Correct one: https://bugs.openjdk.java.net/browse/JDK-82207

Re: RFR 8220700: jlink generated launcher script needs quoting to avoid parameter expansion

Oops. Wrong bug link. Correct one: https://bugs.openjdk.java.net/browse/JDK-8220700 -Sundar On 20/08/19 5:17 pm, sundararajan.athijegannat...@oracle.com wrote: Please review. Bug: https://bugs.openjdk.java.net/browse/JDK-8182555 Webrev: http://cr.openjdk.java.net/~sundar/8220700/webrev.00/

RFR 8220700: jlink generated launcher script needs quoting to avoid parameter expansion

Please review. Bug: https://bugs.openjdk.java.net/browse/JDK-8182555 Webrev: http://cr.openjdk.java.net/~sundar/8220700/webrev.00/ Thanks, -Sundar