Re: RFR JDK-8155005: java.lang.reflect.Module.WeakSet is not thread-safe

2016-04-26 Thread Peter Levart
On 04/26/2016 04:56 PM, Alan Bateman wrote: On 26/04/2016 15:42, Peter Levart wrote: I increased the timeout to 30 seconds. It is not exactly 30 seconds, but 300 iterations with sleep(100L) + check in each iteration. If the system is really overloaded then this loop should stretch automatic

Re: RFR JDK-8155005: java.lang.reflect.Module.WeakSet is not thread-safe

2016-04-26 Thread Alan Bateman
On 26/04/2016 15:42, Peter Levart wrote: I increased the timeout to 30 seconds. It is not exactly 30 seconds, but 300 iterations with sleep(100L) + check in each iteration. If the system is really overloaded then this loop should stretch automatically: http://cr.openjdk.java.net/~plevart/jdk

Re: RFR JDK-8155005: java.lang.reflect.Module.WeakSet is not thread-safe

2016-04-26 Thread Peter Levart
Hi Alan, On 04/25/2016 02:58 PM, Alan Bateman wrote: On 25/04/2016 12:13, Peter Levart wrote: Hi Alan, I created an issue for this: JDK-8155005: java.lang.reflect.Module.WeakSet is not thread-safe https://bugs.openjdk.java.net/browse/JDK-8155005 I did what you suggested, renamed ty

Re: RFR JDK-8155005: java.lang.reflect.Module.WeakSet is not thread-safe

2016-04-25 Thread Claes Redestad
On 2016-04-25 15:02, Alan Bateman wrote: On 25/04/2016 13:54, Claes Redestad wrote: Hi, I think this looks good, but since these WeakPairMaps won't be used for many applications I wonder if it's worth keeping the implementation lazy, for example by moving the maps to a holder class: http:

Re: RFR JDK-8155005: java.lang.reflect.Module.WeakSet is not thread-safe

2016-04-25 Thread Alan Bateman
On 25/04/2016 13:54, Claes Redestad wrote: Hi, I think this looks good, but since these WeakPairMaps won't be used for many applications I wonder if it's worth keeping the implementation lazy, for example by moving the maps to a holder class: http://cr.openjdk.java.net/~redestad/scratch/tran

Re: RFR JDK-8155005: java.lang.reflect.Module.WeakSet is not thread-safe

2016-04-25 Thread Alan Bateman
On 25/04/2016 12:13, Peter Levart wrote: Hi Alan, I created an issue for this: JDK-8155005: java.lang.reflect.Module.WeakSet is not thread-safe https://bugs.openjdk.java.net/browse/JDK-8155005 I did what you suggested, renamed type parameters to , split long line in Module and modif

Re: RFR JDK-8155005: java.lang.reflect.Module.WeakSet is not thread-safe

2016-04-25 Thread Claes Redestad
Hi, I think this looks good, but since these WeakPairMaps won't be used for many applications I wonder if it's worth keeping the implementation lazy, for example by moving the maps to a holder class: http://cr.openjdk.java.net/~redestad/scratch/transients.01/ I verified this avoids loading t

RFR JDK-8155005: java.lang.reflect.Module.WeakSet is not thread-safe

2016-04-25 Thread Peter Levart
Hi Alan, I created an issue for this: JDK-8155005: java.lang.reflect.Module.WeakSet is not thread-safe https://bugs.openjdk.java.net/browse/JDK-8155005 I did what you suggested, renamed type parameters to , split long line in Module and modified the test so that it now waits for entr