Re: Review Request: JDK-8173096 jmod files are not world-readable

> On Jan 22, 2017, at 3:17 AM, Peter Levart wrote: > > Hi Mandy, > > On 01/21/2017 03:32 AM, Mandy Chung wrote: >> Updated webrev to put the temporary file in the same containing directory of >> the target file: >> http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8173096/webrev.01 >>

Re: Review Request: JDK-8173096 jmod files are not world-readable

On 21/01/17 02:32, Mandy Chung wrote: Updated webrev to put the temporary file in the same containing directory of the target file: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8173096/webrev.01 Looks fine. Trivially, the test can now drop "-Djava.io.tmpdir=." . -Chris. I want to fix

Re: Review Request: JDK-8173096 jmod files are not world-readable

Hi Mandy, On 01/21/2017 03:32 AM, Mandy Chung wrote: Updated webrev to put the temporary file in the same containing directory of the target file: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8173096/webrev.01 That's ok. Maybe also specify ATOMIC_MOVE to CopyOption ... options in Files

Re: Review Request: JDK-8173096 jmod files are not world-readable

> On Jan 21, 2017, at 5:08 AM, Alan Bateman wrote: > > On 21/01/2017 02:32, Mandy Chung wrote: > >> Updated webrev to put the temporary file in the same containing directory of >> the target file: >> http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8173096/webrev.01 >> >> I want to fix this

Re: Review Request: JDK-8173096 jmod files are not world-readable

On 21/01/2017 02:32, Mandy Chung wrote: Updated webrev to put the temporary file in the same containing directory of the target file: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8173096/webrev.01 I want to fix this regression in jdk-9+154. We can revisit the approach after this fix if

Re: Review Request: JDK-8173096 jmod files are not world-readable

Updated webrev to put the temporary file in the same containing directory of the target file: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8173096/webrev.01 I want to fix this regression in jdk-9+154. We can revisit the approach after this fix if necessary. Mandy > On Jan 20, 2017, at 8:

Re: Review Request: JDK-8173096 jmod files are not world-readable

> On Jan 20, 2017, at 1:22 PM, Alan Bateman wrote: > > Mandy - a while back then Erik changed the build so that JMOD files are > created in JMODS_TEMPDIR rather than JMODS_DIR. I think this was to reduce > interference with concurrent execution of the `jmod` tool. This might mean > you can av

Re: Review Request: JDK-8173096 jmod files are not world-readable

On 20/01/2017 20:37, Peter Levart wrote: I guess the JmodTask is creating a temp file because it wants the file to not be observed by other processes while it is being written to, right? At the end when the tempTarget is fully written, it is renamed to its intended name with: Files.move(te

Re: Review Request: JDK-8173096 jmod files are not world-readable

> On Jan 20, 2017, at 12:37 PM, Peter Levart wrote: > > I guess the JmodTask is creating a temp file because it wants the file to not > be observed by other processes while it is being written to, right? At the > end when the tempTarget is fully written, it is renamed to its intended name > w

Re: Review Request: JDK-8173096 jmod files are not world-readable

Hi Mandy, On 01/20/2017 05:55 PM, Mandy Chung wrote: Webrev: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8173096/webrev.00/index.html A recent change in jmod tool [1] creates the JMOD file with no group and other readable permission as that’s the default permission when creating a tempo

Review Request: JDK-8173096 jmod files are not world-readable

Webrev: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8173096/webrev.00/index.html A recent change in jmod tool [1] creates the JMOD file with no group and other readable permission as that’s the default permission when creating a temporary file with Files::createTempFile. This fixes the per