Re: Review Request JDK-8177844: Ensure non-upgradeable modules cannot be upgraded even with --patch-module

2017-04-08 Thread Remi Forax
Ok, thanks. Rémi On April 8, 2017 4:49:13 PM GMT+02:00, Mandy Chung wrote: >No change in that regards. The updated test [1] in the webrev shows it >patches java.base/jdk.internal.modules.SystemModules > >Before this fix, you can do —patch-module jdk.internal.vm.compiler=.jar >—upgrade-module-

Re: Review Request JDK-8177844: Ensure non-upgradeable modules cannot be upgraded even with --patch-module

2017-04-08 Thread Mandy Chung
> On Apr 8, 2017, at 12:21 AM, Alan Bateman wrote: > > On 08/04/2017 06:50, Mandy Chung wrote: > >> http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8177844/webrev.01/ >> >> This fixes -—patch-module to do hash checking on the module being patched >> so that it will ensure that a non-upgradeabl

Re: Review Request JDK-8177844: Ensure non-upgradeable modules cannot be upgraded even with --patch-module

2017-04-08 Thread Mandy Chung
No change in that regards. The updated test [1] in the webrev shows it patches java.base/jdk.internal.modules.SystemModules Before this fix, you can do —patch-module jdk.internal.vm.compiler=.jar —upgrade-module-path graal.jar. The reason is that —patch-module disables the hash checking that m

Re: Review Request JDK-8177844: Ensure non-upgradeable modules cannot be upgraded even with --patch-module

2017-04-08 Thread Remi Forax
Hi Mandy, how can I test a change in java.lang after that patch ? Rémi On April 8, 2017 7:50:50 AM GMT+02:00, Mandy Chung wrote: >http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8177844/webrev.01/ > >This fixes -—patch-module to do hash checking on the module being >patched >so that it will en

Re: Review Request JDK-8177844: Ensure non-upgradeable modules cannot be upgraded even with --patch-module

2017-04-08 Thread Alan Bateman
On 08/04/2017 06:50, Mandy Chung wrote: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8177844/webrev.01/ This fixes -—patch-module to do hash checking on the module being patched so that it will ensure that a non-upgradeable module remains not upgradeable. The comment at L523 needs updatin

Review Request JDK-8177844: Ensure non-upgradeable modules cannot be upgraded even with --patch-module

2017-04-07 Thread Mandy Chung
http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8177844/webrev.01/ This fixes -—patch-module to do hash checking on the module being patched so that it will ensure that a non-upgradeable module remains not upgradeable. As Graal has been using —-patch-module option to disable the hash checking to