Re: Review for 8130344

2015-07-13 Thread Jean-Francois Denise
Ok, yes, I read too quickly your reply, I will keep the check and throw an OOME On 13 Jul 2015, at 13:10, David Holmes wrote: > On 13/07/2015 8:09 PM, Jean-Francois Denise wrote: >> In the Java code, I understand that it is useless, an OOM will be thrown. > > No, an OOM _may_ be thrown. That is

Re: Review for 8130344

2015-07-13 Thread David Holmes
On 13/07/2015 8:09 PM, Jean-Francois Denise wrote: In the Java code, I understand that it is useless, an OOM will be thrown. No, an OOM _may_ be thrown. That is what I said below - you still need the null check based on the JNI spec (as opposed to the hotspot VM). David JF On 13 Jul 2015,

Re: Review for 8130344

2015-07-13 Thread Jean-Francois Denise
The updated fix: http://cr.openjdk.java.net/~jfdenise/JDK-8130344-2/ On 13 Jul 2015, at 12:09, Jean-Francois Denise wrote: > In the Java code, I understand that it is useless, an OOM will be thrown. > JF > On 13 Jul 2015, at 11:16, David Holmes wrote: > >> On 13/07/2015 6:06 PM, Jean-Francois

Re: Review for 8130344

2015-07-13 Thread Jean-Francois Denise
In the Java code, I understand that it is useless, an OOM will be thrown. JF On 13 Jul 2015, at 11:16, David Holmes wrote: > On 13/07/2015 6:06 PM, Jean-Francois Denise wrote: >> Thank you, >> I am removing the null check and throw. > > Why are you removing them ?? > > David > >> JF >> >> On

Re: Review for 8130344

2015-07-13 Thread David Holmes
On 13/07/2015 6:06 PM, Jean-Francois Denise wrote: Thank you, I am removing the null check and throw. Why are you removing them ?? David JF On 13 Jul 2015, at 08:06, David Holmes wrote: On 11/07/2015 2:45 AM, Jean-Francois Denise wrote: Thanks Alan, I had read the spec from https://doc

Re: Review for 8130344

2015-07-13 Thread Jean-Francois Denise
Thank you, I am removing the null check and throw. JF On 13 Jul 2015, at 08:06, David Holmes wrote: > On 11/07/2015 2:45 AM, Jean-Francois Denise wrote: >> Thanks Alan, >> I had read the spec from >> https://docs.oracle.com/javase/8/docs/technotes/guides/jni/spec/functions.html#array_operations

Re: Review for 8130344

2015-07-12 Thread David Holmes
On 11/07/2015 2:45 AM, Jean-Francois Denise wrote: Thanks Alan, I had read the spec from https://docs.oracle.com/javase/8/docs/technotes/guides/jni/spec/functions.html#array_operations And it was not clear. FYI the spec has just been updated to clarify that the NewArray functions can throw OO

Re: Review for 8130344

2015-07-10 Thread Jean-Francois Denise
Thanks Alan, I had read the spec from https://docs.oracle.com/javase/8/docs/technotes/guides/jni/spec/functions.html#array_operations And it was not clear. On 10 Jul 2015, at 18:34, Alan Bateman wrote: > > > On 10/07/2015 16:46, Jean-Francois Denise wrote: >> Hi, >> asking review for this bug

Re: Review for 8130344

2015-07-10 Thread Alan Bateman
On 10/07/2015 16:46, Jean-Francois Denise wrote: Hi, asking review for this bug fix. http://cr.openjdk.java.net/~jfdenise/JDK-8130344/ I assume if JNI's NewByteArray returns NULL then it does so with a pending OOME. You might want to double check the JNI spec on this. If it guarantee it then

Review for 8130344

2015-07-10 Thread Jean-Francois Denise
Hi, asking review for this bug fix. http://cr.openjdk.java.net/~jfdenise/JDK-8130344/ Thanks. JF