Revised proposal for #AutomaticModuleNames

2017-05-04 Thread mark . reinhold
Thanks to everyone, and especially Stephen Colebourne, Brian Fox, and Robert Scholte, for the extensive feedback. http://mail.openjdk.java.net/pipermail/jpms-spec-experts/2017-May/000687.html TL;DR: Keep automatic modules, bring back the module-name JAR-file manifest attribute, and strongly rec

Re: Revised proposal for #AutomaticModuleNames

2017-05-04 Thread Stephen Colebourne
On 4 May 2017 at 18:38, wrote: > - Define a JAR-file manifest attribute, `Automatic-Module-Name`, whose > value is used as the name of the automatic module defined by that JAR > file when it is placed on the module path, as previously suggested This is a step forward wrt automatic modu

Re: Revised proposal for #AutomaticModuleNames

2017-05-04 Thread Remi Forax
On May 4, 2017 11:21:38 PM GMT+02:00, Stephen Colebourne wrote: >On 4 May 2017 at 18:38, wrote: ... >> - To increase awareness of when automatic modules are used, and of >the >> consequences of their use, suggest that Java language compilers >issue >> two new types of warnings, an

Re: Revised proposal for #AutomaticModuleNames

2017-05-04 Thread mark . reinhold
2017/5/4 14:21:38 -0700, Stephen Colebourne : > On 4 May 2017 at 18:38, mark.reinh...@oracle.com wrote: >> ... >> >> - Define a JAR-file manifest attribute, `Automatic-Module-Name`, whose >>value is used as the name of the automatic module defined by that JAR >>file when it is placed on t

Re: Revised proposal for #AutomaticModuleNames

2017-05-04 Thread Brian Fox
On Thu, May 4, 2017 at 1:39 PM, wrote: > Thanks to everyone, and especially Stephen Colebourne, Brian Fox, and > Robert Scholte, for the extensive feedback. > > http://mail.openjdk.java.net/pipermail/jpms-spec-experts/ > 2017-May/000687.html > > TL;DR: Keep automatic modules, bring back the mod

Re: Revised proposal for #AutomaticModuleNames

2017-05-04 Thread mark . reinhold
2017/5/4 17:58:31 -0700, bri...@infinity.nu: > On Thu, May 4, 2017 at 1:39 PM, wrote: >> Thanks to everyone, and especially Stephen Colebourne, Brian Fox, and >> Robert Scholte, for the extensive feedback. >> >> http://mail.openjdk.java.net/pipermail/jpms-spec-experts/ >> 2017-May/000687.html >>

Re: Revised proposal for #AutomaticModuleNames

2017-05-05 Thread Robert Scholte
Hi Mark, thanks for these adjustments. In general they look good, but it all depends on the details: Define a JAR-file manifest attribute, `Automatic-Module-Name`, whose value is used as the name of the automatic module defined by that JAR file when it is placed on the module path

Re: Revised proposal for #AutomaticModuleNames

2017-05-05 Thread Stephen Colebourne
On 5 May 2017 at 01:19, wrote: >> The application developer can write the module declarations above, and >> use them even though all the external dependencies are yet to be >> modularised. It seems clear to me that the application developer has >> modularised their application, even if not comple

Re: Revised proposal for #AutomaticModuleNames

2017-05-05 Thread Remi Forax
Hi Robert, - Mail original - > De: "Robert Scholte" > À: "mark reinhold" > Cc: jigsaw-dev@openjdk.java.net > Envoyé: Vendredi 5 Mai 2017 12:04:15 > Objet: Re: Revised proposal for #AutomaticModuleNames > Hi Mark, > > thanks for these adjust

Re: Revised proposal for #AutomaticModuleNames

2017-05-05 Thread mark . reinhold
2017/5/5 3:04:15 -0700, Robert Scholte : > thanks for these adjustments. In general they look good, but it all > depends on the details: > > Define a JAR-file manifest attribute, `Automatic-Module-Name`, whose > value is used as the name of the automatic module defined by that JAR >

Re: Revised proposal for #AutomaticModuleNames

2017-05-05 Thread Brian Fox
On Fri, May 5, 2017 at 10:41 AM, wrote: > I suspect what you really mean is "Never publish JARs that refer to > automatic modules that do not have `Automatic-Module-Name` attributes". > In general that's good advice. > +1 For me, the point of the attribute was to allow an intermediate step. >

Re: Revised proposal for #AutomaticModuleNames

2017-05-09 Thread Alan Bateman
Just a quick note to say that the initial support for the Automatic-Module-Name JAR file attribute is in the Jigsaw EA builds [1] for those that want to try it out. -Alan [1] http://jdk.java.net/jigsaw/

Re: Revised proposal for #AutomaticModuleNames

2017-05-12 Thread Stephen Colebourne
On 5 May 2017 at 15:41, wrote: > I suspect what you really mean is "Never publish JARs that refer to > automatic modules that do not have `Automatic-Module-Name` attributes". > In general that's good advice. It might even be reasonable for managers > of artifact repositories to insist upon it, a

Re: Revised proposal for #AutomaticModuleNames

2017-05-12 Thread Sander Mak
> module guava { > requires transient com.google.common; > } > I suspect you mean 'transitive' here. Sander

Re: Revised proposal for #AutomaticModuleNames

2017-05-12 Thread Stephen Colebourne
On 12 May 2017 at 18:29, Sander Mak wrote: >> module guava { >> requires transient com.google.common; >> } >> > > I suspect you mean 'transitive' here. Yes :-) Stephen

Re: Revised proposal for #AutomaticModuleNames

2017-05-12 Thread Nicolai Parlog
Hi Stephen, the shim only works partially. Qualified exports/opens for example will not get past it. I did not yet investigate further to see whether other problems occur. However much we try module names will never be 100% stable and providing an aliasing mechanism would solve this as well as o