Round #2: RFR: 8049365 - Update JDI and JDWP for modules

2016-01-20 Thread serguei.spit...@oracle.com
Please, review this initial fix for the Jigsaw Bill milestone task: https://bugs.openjdk.java.net/browse/JDK-8049365 Jdk webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2016/jdk/8049365-Jigsaw-jdk.2/ Hotspot webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2016/hotspot/8049365-Jigsaw-h

Re: Round #2: RFR: 8049365 - Update JDI and JDWP for modules

2016-01-21 Thread Alan Bateman
On 20/01/2016 22:35, serguei.spit...@oracle.com wrote: : Jdk webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2016/jdk/8049365-Jigsaw-jdk.2/ Hotspot webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2016/hotspot/8049365-Jigsaw-hs.2/ jvmti.xml - the module catagory has since="9" but the

Re: Round #2: RFR: 8049365 - Update JDI and JDWP for modules

2016-01-21 Thread serguei.spit...@oracle.com
On 1/21/16 04:51, Alan Bateman wrote: On 20/01/2016 22:35, serguei.spit...@oracle.com wrote: : Jdk webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2016/jdk/8049365-Jigsaw-jdk.2/ Hotspot webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2016/hotspot/8049365-Jigsaw-hs.2/ jvmti.xml - th

Re: Round #2: RFR: 8049365 - Update JDI and JDWP for modules

2016-01-22 Thread Alan Bateman
On 22/01/2016 03:34, serguei.spit...@oracle.com wrote: I saw the discussion but have no strong opinion yet. Changing to JVMTI_VERSION_9 will make it more consistent though. Thanks. We can always revert it if it turns out that there is a good reason not to move it to 9 and keep it in sync with t

Re: Round #2: RFR: 8049365 - Update JDI and JDWP for modules

2016-01-22 Thread serguei.spit...@oracle.com
On 1/22/16 00:35, Alan Bateman wrote: On 22/01/2016 03:34, serguei.spit...@oracle.com wrote: I saw the discussion but have no strong opinion yet. Changing to JVMTI_VERSION_9 will make it more consistent though. Thanks. We can always revert it if it turns out that there is a good reason not to

Re: Round #2: RFR: 8049365 - Update JDI and JDWP for modules

2016-01-22 Thread serguei.spit...@oracle.com
Hi Alan, Just wanted to provide some detailed update on your comments below. On 1/21/16 04:51, Alan Bateman wrote: On 20/01/2016 22:35, serguei.spit...@oracle.com wrote: : Jdk webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2016/jdk/8049365-Jigsaw-jdk.2/ Hotspot webrev: http://cr.openj