Re: Round #3: RFR: 8147467 - Add ClassFileTransformer transform method that provide the Module to the agent

2016-02-29 Thread Alan Bateman
On 29/02/2016 20:11, Remi Forax wrote: Hi Alan, hi Sergei, i see two issues with this patch, the first one is that before that change, ClassFileTransformer was a functional interface, it's not a functional interface anymore, so it will break code (note that ClassFileTransformer is not annotated

Re: Round #3: RFR: 8147467 - Add ClassFileTransformer transform method that provide the Module to the agent

2016-02-29 Thread Remi Forax
original - > De: "serguei spitsyn" > À: "Alan Bateman" , "jigsaw-dev" > > Envoyé: Lundi 29 Février 2016 19:29:28 > Objet: Re: Round #3: RFR: 8147467 - Add ClassFileTransformer transform > method that provide the Module to the agent &g

Re: Round #3: RFR: 8147467 - Add ClassFileTransformer transform method that provide the Module to the agent

2016-02-29 Thread serguei.spit...@oracle.com
On 2/29/16 04:29, Alan Bateman wrote: On 29/02/2016 08:32, serguei.spit...@oracle.com wrote: : Please, review the fix for: https://bugs.openjdk.java.net/browse/JDK-8147467 Jdk webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2016/jdk/8147467-Jigsaw-agents.jdk3/ This looks good and I ca

Re: Round #3: RFR: 8147467 - Add ClassFileTransformer transform method that provide the Module to the agent

2016-02-29 Thread Alan Bateman
On 29/02/2016 08:32, serguei.spit...@oracle.com wrote: : Please, review the fix for: https://bugs.openjdk.java.net/browse/JDK-8147467 Jdk webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2016/jdk/8147467-Jigsaw-agents.jdk3/ This looks good and I can get this into the jake/jdk repo for y

Re: Round #3: RFR: 8147467 - Add ClassFileTransformer transform method that provide the Module to the agent

2016-02-29 Thread serguei.spit...@oracle.com
Forgot to include the jigsaw-dev mailing list. On 2/29/16 00:29, serguei.spit...@oracle.com wrote: Please, review the fix for: https://bugs.openjdk.java.net/browse/JDK-8147467 Jdk webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2016/jdk/8147467-Jigsaw-agents.jdk3/ Summary: This ver