Re: The module implementation uses the wrong values for ACC_TRANSITIVE and ACC_STATIC_PHASE

2017-02-01 Thread Remi Forax
If the spec is updated, i really want to get ride of ACC_STATIC_PHASE and uses ACC_STATIC instead. Renaming public to transitive was the right move but I think we go a little over the top with static. In the module-info, the Java syntax already uses static, i do not see a lot of value to use a

Re: The module implementation uses the wrong values for ACC_TRANSITIVE and ACC_STATIC_PHASE

2017-02-01 Thread Alan Bateman
On 30/01/2017 22:15, Remi Forax wrote: Hi all, chasing a bug on ASM, i've found that the module implementation in the JDK uses the wrong values for ACC_TRANSITIVE and ACC_STATIC_PHASE, in the spec [1], 0x0020 (ACC_TRANSITIVE) 0x0040 (ACC_STATIC_PHASE) but in the implementation [2], pub

The module implementation uses the wrong values for ACC_TRANSITIVE and ACC_STATIC_PHASE

2017-01-30 Thread Remi Forax
Hi all, chasing a bug on ASM, i've found that the module implementation in the JDK uses the wrong values for ACC_TRANSITIVE and ACC_STATIC_PHASE, in the spec [1], 0x0020 (ACC_TRANSITIVE) 0x0040 (ACC_STATIC_PHASE) but in the implementation [2], public static final int ACC_TRANSITIVE= 0x00