[jira] [Commented] (ARROW-18371) [C++] Expose *FromJSON helpers

2022-12-15 Thread Yaron Gvili (Jira)
[ https://issues.apache.org/jira/browse/ARROW-18371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17647959#comment-17647959 ] Yaron Gvili commented on ARROW-18371: - The discussion went beyond the current subject of `*FromJSON`

[jira] [Commented] (ARROW-18371) [C++] Expose *FromJSON helpers

2022-11-30 Thread Antoine Pitrou (Jira)
[ https://issues.apache.org/jira/browse/ARROW-18371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17641250#comment-17641250 ] Antoine Pitrou commented on ARROW-18371: We would have to prefix those macros with {{ARROW_}}.

[jira] [Commented] (ARROW-18371) [C++] Expose *FromJSON helpers

2022-11-30 Thread Rok Mihevc (Jira)
[ https://issues.apache.org/jira/browse/ARROW-18371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17641241#comment-17641241 ] Rok Mihevc commented on ARROW-18371: Random array generators would indeed be useful. How about

[jira] [Commented] (ARROW-18371) [C++] Expose *FromJSON helpers

2022-11-21 Thread Weston Pace (Jira)
[ https://issues.apache.org/jira/browse/ARROW-18371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17636820#comment-17636820 ] Weston Pace commented on ARROW-18371: - {{MakeBasicBatches}} I agree is a definite no. The new

[jira] [Commented] (ARROW-18371) [C++] Expose *FromJSON helpers

2022-11-21 Thread Antoine Pitrou (Jira)
[ https://issues.apache.org/jira/browse/ARROW-18371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17636794#comment-17636794 ] Antoine Pitrou commented on ARROW-18371: > I assume the comment is regarding BatchesWithSchema

[jira] [Commented] (ARROW-18371) [C++] Expose *FromJSON helpers

2022-11-21 Thread Rok Mihevc (Jira)
[ https://issues.apache.org/jira/browse/ARROW-18371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17636755#comment-17636755 ] Rok Mihevc commented on ARROW-18371: I assume the comment regarding BatchesWithSchema and

[jira] [Commented] (ARROW-18371) [C++] Expose *FromJSON helpers

2022-11-21 Thread Li Jin (Jira)
[ https://issues.apache.org/jira/browse/ARROW-18371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17636754#comment-17636754 ] Li Jin commented on ARROW-18371: > Definitely not. These are functions generating ad hoc data tailored

[jira] [Commented] (ARROW-18371) [C++] Expose *FromJSON helpers

2022-11-21 Thread Antoine Pitrou (Jira)
[ https://issues.apache.org/jira/browse/ARROW-18371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17636747#comment-17636747 ] Antoine Pitrou commented on ARROW-18371: Definitely not. These are functions generating ad hoc

[jira] [Commented] (ARROW-18371) [C++] Expose *FromJSON helpers

2022-11-21 Thread Rok Mihevc (Jira)
[ https://issues.apache.org/jira/browse/ARROW-18371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17636736#comment-17636736 ] Rok Mihevc commented on ARROW-18371: *FromJSON functions seem clear cut. How about also adding