[ https://issues.apache.org/jira/browse/ARROW-4580?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17661603#comment-17661603 ]
Rok Mihevc commented on ARROW-4580: ----------------------------------- This issue has been migrated to [issue #21124|https://github.com/apache/arrow/issues/21124] on GitHub. Please see the [migration documentation|https://github.com/apache/arrow/issues/14542] for further details. > [JS] Accept Iterables in IntVector/FloatVector from() signatures > ---------------------------------------------------------------- > > Key: ARROW-4580 > URL: https://issues.apache.org/jira/browse/ARROW-4580 > Project: Apache Arrow > Issue Type: Improvement > Components: JavaScript > Affects Versions: JS-0.4.0 > Reporter: Paul Taylor > Assignee: Paul Taylor > Priority: Major > Fix For: JS-0.4.1 > > > Right now {{IntVector.from()}} and {{FloatVector.from()}} expect the data is > already in typed-array form. But if we know the desired Vector type before > hand (e.g. if {{Int32Vector.from()}} is called), we can accept any JS > iterable of the values. > In order to do this, we should ensure {{Float16Vector.from()}} properly > clamps incoming f32/f64 values to u16s, in case the source is a vanilla > 64-bit JS float. -- This message was sent by Atlassian Jira (v8.20.10#820010)