[jira] [Commented] (ARROW-9054) [C++] Add ScalarAggregateOptions

2020-06-29 Thread Wes McKinney (Jira)
[ https://issues.apache.org/jira/browse/ARROW-9054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17148240#comment-17148240 ] Wes McKinney commented on ARROW-9054: - This also needs to have a "minimum # valid val

[jira] [Commented] (ARROW-9054) [C++] Add ScalarAggregateOptions

2020-06-16 Thread Krisztian Szucs (Jira)
[ https://issues.apache.org/jira/browse/ARROW-9054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17137794#comment-17137794 ] Krisztian Szucs commented on ARROW-9054: Thanks! I simply wasn't sure whether it

[jira] [Commented] (ARROW-9054) [C++] Add ScalarAggregateOptions

2020-06-16 Thread Wes McKinney (Jira)
[ https://issues.apache.org/jira/browse/ARROW-9054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17136823#comment-17136823 ] Wes McKinney commented on ARROW-9054: - Right. Rather than debate this further, I'm go

[jira] [Commented] (ARROW-9054) [C++] Add ScalarAggregateOptions

2020-06-16 Thread Krisztian Szucs (Jira)
[ https://issues.apache.org/jira/browse/ARROW-9054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17136769#comment-17136769 ] Krisztian Szucs commented on ARROW-9054: If I understand correctly by not skippin

[jira] [Commented] (ARROW-9054) [C++] Add ScalarAggregateOptions

2020-06-16 Thread Krisztian Szucs (Jira)
[ https://issues.apache.org/jira/browse/ARROW-9054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17136765#comment-17136765 ] Krisztian Szucs commented on ARROW-9054: [~jorisvandenbossche] Right. > [C++] Ad

[jira] [Commented] (ARROW-9054) [C++] Add ScalarAggregateOptions

2020-06-16 Thread Wes McKinney (Jira)
[ https://issues.apache.org/jira/browse/ARROW-9054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17136755#comment-17136755 ] Wes McKinney commented on ARROW-9054: - I think there's still perhaps some value in sh

[jira] [Commented] (ARROW-9054) [C++] Add ScalarAggregateOptions

2020-06-16 Thread Joris Van den Bossche (Jira)
[ https://issues.apache.org/jira/browse/ARROW-9054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17136750#comment-17136750 ] Joris Van den Bossche commented on ARROW-9054: -- [~kszucs] regarding the orig

[jira] [Commented] (ARROW-9054) [C++] Add ScalarAggregateOptions

2020-06-16 Thread Krisztian Szucs (Jira)
[ https://issues.apache.org/jira/browse/ARROW-9054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17136744#comment-17136744 ] Krisztian Szucs commented on ARROW-9054: Great, the intent looks the same*. With

[jira] [Commented] (ARROW-9054) [C++] Add ScalarAggregateOptions

2020-06-16 Thread Wes McKinney (Jira)
[ https://issues.apache.org/jira/browse/ARROW-9054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17136734#comment-17136734 ] Wes McKinney commented on ARROW-9054: - [~kszucs] my desired approach for aggregating

[jira] [Commented] (ARROW-9054) [C++] Add ScalarAggregateOptions

2020-06-16 Thread Krisztian Szucs (Jira)
[ https://issues.apache.org/jira/browse/ARROW-9054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17136725#comment-17136725 ] Krisztian Szucs commented on ARROW-9054: I wonder if it would be better to add sp