[ 
https://issues.apache.org/jira/browse/ARROW-3906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rok Mihevc updated ARROW-3906:
------------------------------
    External issue URL: https://github.com/apache/arrow/issues/15888

> [C++] Break builder.cc into multiple compilation units
> ------------------------------------------------------
>
>                 Key: ARROW-3906
>                 URL: https://issues.apache.org/jira/browse/ARROW-3906
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: C++
>    Affects Versions: 0.11.1
>            Reporter: Antoine Pitrou
>            Assignee: Antoine Pitrou
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 0.12.0
>
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> To improve readability I suggest splitting {{builder.cc}} into independent 
> compilation units. Concrete builder classes are generally independent of each 
> other. The only concern is whether inlining some of the base class 
> implementations is important for performance.
> This would also make incremental compilation faster when changing one of the 
> concrete classes.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to