[ 
https://issues.apache.org/jira/browse/ARROW-7304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Antoine Pitrou updated ARROW-7304:
----------------------------------
    Component/s: Continuous Integration

> [C++] clang-tidy diagnostics not emitted for most headers
> ---------------------------------------------------------
>
>                 Key: ARROW-7304
>                 URL: https://issues.apache.org/jira/browse/ARROW-7304
>             Project: Apache Arrow
>          Issue Type: Bug
>          Components: C++, CI, Continuous Integration
>    Affects Versions: 0.15.1
>            Reporter: Elvis Stansvik
>            Priority: Minor
>
> The {{HeaderFilterRegex}} in {{.clang-tidy}} is written
> {code}
> HeaderFilterRegex: 
> '^(.*codegen.*|.*_generated.*|.*windows_compatibility.h|.*pyarrow_api.h|.*pyarrow_lib.h|.*python/config.h|.*python/platform.h|.*thirdparty/ae/.*|.*vendored/.*|.*RcppExports.cpp.*|)$'
> {code}
> as if it was an exclusion filter, but {{HeaderFilterRegex}} is in fact an 
> inclusion mechanism. So clang-tidy diagnostics are not emitted for I guess 
> most of the headers in Arrow.
> See 
> [https://github.com/apache/arrow/commit/72b553147e4bd47e100fbfd58ed49041561b7bc4#r36225046]
>  which is where I came across this.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to