[jira] [Created] (KAFKA-9934) Information and doc update needed for support of AclAuthorizer when protocol is PLAINTEXT

2020-04-28 Thread kaushik srinivas (Jira)
kaushik srinivas created KAFKA-9934: --- Summary: Information and doc update needed for support of AclAuthorizer when protocol is PLAINTEXT Key: KAFKA-9934 URL: https://issues.apache.org/jira/browse/KAFKA-9934

[jira] [Updated] (KAFKA-9921) Caching is not working properly with WindowStateStore when retaining duplicates

2020-04-28 Thread Georgi Petkov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Georgi Petkov updated KAFKA-9921: - Summary: Caching is not working properly with WindowStateStore when retaining duplicates (was: C

[jira] [Created] (KAFKA-9933) Need doc update on the AclAuthorizer when SASL_SSL is the protocol used.

2020-04-28 Thread kaushik srinivas (Jira)
kaushik srinivas created KAFKA-9933: --- Summary: Need doc update on the AclAuthorizer when SASL_SSL is the protocol used. Key: KAFKA-9933 URL: https://issues.apache.org/jira/browse/KAFKA-9933 Project:

[GitHub] [kafka] C0urante commented on a change in pull request #8554: KAFKA-9919: Add logging to KafkaBasedLog::readToLogEnd

2020-04-28 Thread GitBox
C0urante commented on a change in pull request #8554: URL: https://github.com/apache/kafka/pull/8554#discussion_r417070806 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/util/KafkaBasedLog.java ## @@ -281,9 +281,18 @@ private void readToLogEnd() {

[GitHub] [kafka] C0urante commented on pull request #8554: KAFKA-9919: Add logging to KafkaBasedLog::readToLogEnd

2020-04-28 Thread GitBox
C0urante commented on pull request #8554: URL: https://github.com/apache/kafka/pull/8554#issuecomment-620992508 Thanks @kkonstantine! These all seem like reasonable suggestions and I've applied them all. Ready for the next round when you have time.

[GitHub] [kafka] ijuma opened a new pull request #8582: KAFKA-9932: Don't load configs from ZK when the log has already been loaded

2020-04-28 Thread GitBox
ijuma opened a new pull request #8582: URL: https://github.com/apache/kafka/pull/8582 If a broker contains 8k replicas, we would previously issue 8k ZK calls to retrieve topic configs when processing the first LeaderAndIsr request. That should translate to 0 after these changes.

[jira] [Created] (KAFKA-9932) First LeaderAndIsrRequest can take long due to unnecessary ZK read

2020-04-28 Thread Ismael Juma (Jira)
Ismael Juma created KAFKA-9932: -- Summary: First LeaderAndIsrRequest can take long due to unnecessary ZK read Key: KAFKA-9932 URL: https://issues.apache.org/jira/browse/KAFKA-9932 Project: Kafka

[jira] [Updated] (KAFKA-9932) First LeaderAndIsrRequest can take long due to unnecessary ZK read

2020-04-28 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-9932: --- Fix Version/s: 2.6.0 > First LeaderAndIsrRequest can take long due to unnecessary ZK read > -

[GitHub] [kafka] kkonstantine commented on a change in pull request #8554: KAFKA-9919: Add logging to KafkaBasedLog::readToLogEnd

2020-04-28 Thread GitBox
kkonstantine commented on a change in pull request #8554: URL: https://github.com/apache/kafka/pull/8554#discussion_r417055199 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/util/KafkaBasedLog.java ## @@ -281,9 +281,18 @@ private void readToLogEnd() {

[GitHub] [kafka] vvcephei commented on pull request #8540: KAFKA-9127: don't create StreamThreads for global-only topology

2020-04-28 Thread GitBox
vvcephei commented on pull request #8540: URL: https://github.com/apache/kafka/pull/8540#issuecomment-620976620 Cherry-picked to 2.5 as 9e2785fd1ba0ed16604e01058bae6b60ff9f3d96 This is an automated message from the Apache Git

[GitHub] [kafka] showuon opened a new pull request #8581: MINOR: Fix typo and rephrase content in docs

2020-04-28 Thread GitBox
showuon opened a new pull request #8581: URL: https://github.com/apache/kafka/pull/8581 1. fix typo: `atleast` -> `at least` 2. add missing `--` to be consistent 3. rephrase a sentence, to make it more clear: before: `LinkedIn is currently running JDK 1.8 u5 (looking to upgrade

[GitHub] [kafka] vvcephei commented on pull request #8540: KAFKA-9127: don't create StreamThreads for global-only topology

2020-04-28 Thread GitBox
vvcephei commented on pull request #8540: URL: https://github.com/apache/kafka/pull/8540#issuecomment-620973163 Cherry-pick for 2.5 in progress... This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [kafka] kkonstantine commented on pull request #8204: KAFKA-9633: Ensure ConfigProviders are closed

2020-04-28 Thread GitBox
kkonstantine commented on pull request #8204: URL: https://github.com/apache/kafka/pull/8204#issuecomment-620971604 JDK8 build failed on a relevant test: https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/2007/testReport/junit/org.apache.kafka.connect.runtime/WorkerTest/testStartAndS

[GitHub] [kafka] vvcephei commented on pull request #8574: KAFKA-9925: decorate pseudo-topics with app id

2020-04-28 Thread GitBox
vvcephei commented on pull request #8574: URL: https://github.com/apache/kafka/pull/8574#issuecomment-620971180 Thanks, @arkins ! Shame is a powerful motivator :) This is an automated message from the Apache Git Service. To r

[GitHub] [kafka] vvcephei commented on pull request #8578: KAFKA-9875: Make integration tests more resilient

2020-04-28 Thread GitBox
vvcephei commented on pull request #8578: URL: https://github.com/apache/kafka/pull/8578#issuecomment-620970911 Thanks for the review, @guozhangwang . I've addressed (or responded to) your comments. This is an automated mess

[GitHub] [kafka] vvcephei commented on a change in pull request #8578: KAFKA-9875: Make integration tests more resilient

2020-04-28 Thread GitBox
vvcephei commented on a change in pull request #8578: URL: https://github.com/apache/kafka/pull/8578#discussion_r417047054 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/LagFetchIntegrationTest.java ## @@ -106,7 +108,7 @@ public void before() {

[GitHub] [kafka] vvcephei commented on a change in pull request #8578: KAFKA-9875: Make integration tests more resilient

2020-04-28 Thread GitBox
vvcephei commented on a change in pull request #8578: URL: https://github.com/apache/kafka/pull/8578#discussion_r417046624 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/ResetPartitionTimeIntegrationTest.java ## @@ -156,7 +157,7 @@ public void should

[GitHub] [kafka] ijuma commented on a change in pull request #8579: KAFKA-9930: Prevent ReplicaFetcherThread from throwing UnknownTopicOrPartitionException upon topic creation and deletion.

2020-04-28 Thread GitBox
ijuma commented on a change in pull request #8579: URL: https://github.com/apache/kafka/pull/8579#discussion_r417044882 ## File path: core/src/main/scala/kafka/server/AbstractFetcherThread.scala ## @@ -382,6 +382,11 @@ abstract class AbstractFetcherThread(name: String,

[GitHub] [kafka] vvcephei commented on a change in pull request #8578: KAFKA-9875: Make integration tests more resilient

2020-04-28 Thread GitBox
vvcephei commented on a change in pull request #8578: URL: https://github.com/apache/kafka/pull/8578#discussion_r417044713 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/utils/IntegrationTestUtils.java ## @@ -145,12 +162,12 @@ public static void clean

[GitHub] [kafka] kkonstantine commented on pull request #8442: KAFKA-9830: Implement AutoCloseable in ErrorReporter and subclasses

2020-04-28 Thread GitBox
kkonstantine commented on pull request #8442: URL: https://github.com/apache/kafka/pull/8442#issuecomment-620964908 retest this please This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [kafka] kkonstantine commented on pull request #8442: KAFKA-9830: Implement AutoCloseable in ErrorReporter and subclasses

2020-04-28 Thread GitBox
kkonstantine commented on pull request #8442: URL: https://github.com/apache/kafka/pull/8442#issuecomment-620964776 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] vvcephei commented on a change in pull request #8578: KAFKA-9875: Make integration tests more resilient

2020-04-28 Thread GitBox
vvcephei commented on a change in pull request #8578: URL: https://github.com/apache/kafka/pull/8578#discussion_r417040202 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/OptimizedKTableIntegrationTest.java ## @@ -215,13 +216,13 @@ public void onRestor

[GitHub] [kafka] vvcephei commented on pull request #8580: KAFKA-9832: fix attempt to commit non-running tasks

2020-04-28 Thread GitBox
vvcephei commented on pull request #8580: URL: https://github.com/apache/kafka/pull/8580#issuecomment-620962357 Hey @mjsax , do you have time for a quick review? This bug seems to have been introduced by https://github.com/apache/kafka/pull/8440/files#r407722022 , which attempts to

[GitHub] [kafka] vvcephei opened a new pull request #8580: KAFKA-9832: fix attempt to commit non-running tasks

2020-04-28 Thread GitBox
vvcephei opened a new pull request #8580: URL: https://github.com/apache/kafka/pull/8580 Fixes an attempt to commit potentially non-running tasks while recovering from task corruption. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation

[jira] [Comment Edited] (KAFKA-9931) Kafka Connect should accept '-1' as a valid replication factor

2020-04-28 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17094975#comment-17094975 ] Randall Hauch edited comment on KAFKA-9931 at 4/29/20, 1:52 AM: ---

[jira] [Comment Edited] (KAFKA-9931) Kafka Connect should accept '-1' as a valid replication factor

2020-04-28 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17094975#comment-17094975 ] Randall Hauch edited comment on KAFKA-9931 at 4/29/20, 1:51 AM: ---

[jira] [Commented] (KAFKA-9931) Kafka Connect should accept '-1' as a valid replication factor

2020-04-28 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17094975#comment-17094975 ] Randall Hauch commented on KAFKA-9931: -- We'll need a KIP for this change, but it sho

[jira] [Updated] (KAFKA-9931) Kafka Connect should accept '-1' as a valid replication factor

2020-04-28 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9931?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch updated KAFKA-9931: - Labels: needs-kip (was: ) > Kafka Connect should accept '-1' as a valid replication factor > ---

[jira] [Created] (KAFKA-9931) Kafka Connect should accept '-1' as a valid replication factor

2020-04-28 Thread Randall Hauch (Jira)
Randall Hauch created KAFKA-9931: Summary: Kafka Connect should accept '-1' as a valid replication factor Key: KAFKA-9931 URL: https://issues.apache.org/jira/browse/KAFKA-9931 Project: Kafka

[GitHub] [kafka] efeg opened a new pull request #8579: KAFKA-9930: Prevent ReplicaFetcherThread from throwing UnknownTopicOrPartitionException upon topic creation and deletion.

2020-04-28 Thread GitBox
efeg opened a new pull request #8579: URL: https://github.com/apache/kafka/pull/8579 When does UnknownTopicOrPartitionException typically occur? * Upon a topic creation, a follower broker of a new partition starts replica fetcher before the prospective leader broker of the new partition

[jira] [Created] (KAFKA-9930) Prevent ReplicaFetcherThread from throwing UnknownTopicOrPartitionException upon topic creation and deletion.

2020-04-28 Thread Adem Efe Gencer (Jira)
Adem Efe Gencer created KAFKA-9930: -- Summary: Prevent ReplicaFetcherThread from throwing UnknownTopicOrPartitionException upon topic creation and deletion. Key: KAFKA-9930 URL: https://issues.apache.org/jira/brow

[GitHub] [kafka] guozhangwang commented on a change in pull request #8578: KAFKA-9875: Make integration tests more resilient

2020-04-28 Thread GitBox
guozhangwang commented on a change in pull request #8578: URL: https://github.com/apache/kafka/pull/8578#discussion_r417015562 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/OptimizedKTableIntegrationTest.java ## @@ -215,13 +216,13 @@ public void onRe

[GitHub] [kafka] gwenshap commented on pull request #8518: MINOR: add support for kafka 2.4 and 2.5 to downgrade test

2020-04-28 Thread GitBox
gwenshap commented on pull request #8518: URL: https://github.com/apache/kafka/pull/8518#issuecomment-620932278 No failures, nice :) Great update @lbradstreet and thanks for contributing. This is an automated message from

[GitHub] [kafka] bseenu commented on a change in pull request #7577: KAFKA-9076: support consumer offset sync across clusters in MM 2.0

2020-04-28 Thread GitBox
bseenu commented on a change in pull request #7577: URL: https://github.com/apache/kafka/pull/7577#discussion_r417002126 ## File path: connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorCheckpointTask.java ## @@ -190,4 +227,103 @@ public void commitRecord(Sourc

[GitHub] [kafka] ning2008wisc commented on a change in pull request #7577: KAFKA-9076: support consumer offset sync across clusters in MM 2.0

2020-04-28 Thread GitBox
ning2008wisc commented on a change in pull request #7577: URL: https://github.com/apache/kafka/pull/7577#discussion_r416995009 ## File path: connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorCheckpointTask.java ## @@ -190,4 +227,103 @@ public void commitRecord

[GitHub] [kafka] zhaohaidao commented on pull request #8550: KAFKA-9850 Move KStream#repartition operator validation during Topolo…

2020-04-28 Thread GitBox
zhaohaidao commented on pull request #8550: URL: https://github.com/apache/kafka/pull/8550#issuecomment-620915590 @abbccdda Hi, pr updated. Could you continue to review it? This is an automated message from the Apache Git Ser

[GitHub] [kafka] ableegoldman commented on pull request #8540: KAFKA-9127: don't create StreamThreads for global-only topology

2020-04-28 Thread GitBox
ableegoldman commented on pull request #8540: URL: https://github.com/apache/kafka/pull/8540#issuecomment-620909428 One unrelated failure: `MetricsDuringTopicCreationDeletionTest.testMetricsDuringTopicCreateDelete` This is a

[jira] [Created] (KAFKA-9929) Support reverse iterator on WindowStore

2020-04-28 Thread Jorge Esteban Quilcate Otoya (Jira)
Jorge Esteban Quilcate Otoya created KAFKA-9929: --- Summary: Support reverse iterator on WindowStore Key: KAFKA-9929 URL: https://issues.apache.org/jira/browse/KAFKA-9929 Project: Kafka

[GitHub] [kafka] vvcephei commented on a change in pull request #8578: KAFKA-9875: Make integration tests more resilient

2020-04-28 Thread GitBox
vvcephei commented on a change in pull request #8578: URL: https://github.com/apache/kafka/pull/8578#discussion_r416969713 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/GlobalThreadShutDownOrderTest.java ## @@ -101,8 +102,8 @@ public void before() th

[GitHub] [kafka] vvcephei opened a new pull request #8578: KAFKA-9875: Make integration tests more resilient

2020-04-28 Thread GitBox
vvcephei opened a new pull request #8578: URL: https://github.com/apache/kafka/pull/8578 The ticket is for a flaky test that failed to clean up topics _after_ the test, which isn't strictly necessary for test success. * alter the "clean up after test" method to never throw an exce

[GitHub] [kafka] steverod commented on pull request #8542: [KAFKA-9826] Handle an unaligned first dirty offset during log cleani…

2020-04-28 Thread GitBox
steverod commented on pull request #8542: URL: https://github.com/apache/kafka/pull/8542#issuecomment-620893016 retest this please This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [kafka] cmccabe commented on a change in pull request #8569: KIP-551: Expose disk read and write metrics

2020-04-28 Thread GitBox
cmccabe commented on a change in pull request #8569: URL: https://github.com/apache/kafka/pull/8569#discussion_r416961523 ## File path: core/src/main/scala/kafka/metrics/LinuxIoMetricsCollector.scala ## @@ -0,0 +1,96 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] ijuma commented on pull request #8567: KAFKA-9652: Fix throttle metric in RequestChannel and request log due to KIP-219

2020-04-28 Thread GitBox
ijuma commented on pull request #8567: URL: https://github.com/apache/kafka/pull/8567#issuecomment-620887867 2 jobs passed, 1 unrelated flaky test failed: > org.apache.kafka.streams.integration.QueryableStateIntegrationTest.shouldAllowConcurrentAccesses

[jira] [Comment Edited] (KAFKA-9921) Caching is not working properly with WindowStateStore when rataining duplicates

2020-04-28 Thread Georgi Petkov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17094900#comment-17094900 ] Georgi Petkov edited comment on KAFKA-9921 at 4/28/20, 10:23 PM: --

[jira] [Commented] (KAFKA-9928) Flaky GlobalKTableEOSIntegrationTest#shouldKStreamGlobalKTableLeftJoin[exactly_once_beta]

2020-04-28 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17094902#comment-17094902 ] Guozhang Wang commented on KAFKA-9928: -- I found that for the failed run, around the

[jira] [Commented] (KAFKA-9921) Caching is not working properly with WindowStateStore when rataining duplicates

2020-04-28 Thread Georgi Petkov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17094900#comment-17094900 ] Georgi Petkov commented on KAFKA-9921: -- [~ableegoldman] Yeah, I agree that probably

[GitHub] [kafka] cmccabe edited a comment on pull request #8569: KIP-551: Expose disk read and write metrics

2020-04-28 Thread GitBox
cmccabe edited a comment on pull request #8569: URL: https://github.com/apache/kafka/pull/8569#issuecomment-620884289 > In addition to block-level read/write, would there be a benefit to expose file system read/write metrics? It's better to have that discussion on the mailing list.

[GitHub] [kafka] cmccabe commented on pull request #8569: KIP-551: Expose disk read and write metrics

2020-04-28 Thread GitBox
cmccabe commented on pull request #8569: URL: https://github.com/apache/kafka/pull/8569#issuecomment-620884289 > In addition to block-level read/write, would there be a benefit to expose file system read/write metrics? It's better to have that discussion on the mailing list. This PR is

[GitHub] [kafka] junrao commented on pull request #8542: [KAFKA-9826] Handle an unaligned first dirty offset during log cleani…

2020-04-28 Thread GitBox
junrao commented on pull request #8542: URL: https://github.com/apache/kafka/pull/8542#issuecomment-620880304 @steverod : Does the JDK 8 and Scala 2.12 tests pass for you locally? Not sure why the jenkins test failed. This i

[GitHub] [kafka] guozhangwang commented on pull request #8568: KAFKA-9176: Retry on getting local stores from KafkaStreams

2020-04-28 Thread GitBox
guozhangwang commented on pull request #8568: URL: https://github.com/apache/kafka/pull/8568#issuecomment-620879654 Merged to trunk. This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] junrao commented on pull request #8543: [KAFKA-9826] Handle an unaligned first dirty offset during log cleani…

2020-04-28 Thread GitBox
junrao commented on pull request #8543: URL: https://github.com/apache/kafka/pull/8543#issuecomment-620879490 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] vvcephei commented on a change in pull request #8568: KAFKA-9176: Retry on getting local stores from KafkaStreams

2020-04-28 Thread GitBox
vvcephei commented on a change in pull request #8568: URL: https://github.com/apache/kafka/pull/8568#discussion_r416947800 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/utils/IntegrationTestUtils.java ## @@ -269,24 +271,20 @@ public static void clean

[GitHub] [kafka] guozhangwang commented on a change in pull request #8568: KAFKA-9176: Retry on getting local stores from KafkaStreams

2020-04-28 Thread GitBox
guozhangwang commented on a change in pull request #8568: URL: https://github.com/apache/kafka/pull/8568#discussion_r416944392 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/utils/IntegrationTestUtils.java ## @@ -269,24 +271,20 @@ public static void c

[GitHub] [kafka] guozhangwang commented on a change in pull request #8568: KAFKA-9176: Retry on getting local stores from KafkaStreams

2020-04-28 Thread GitBox
guozhangwang commented on a change in pull request #8568: URL: https://github.com/apache/kafka/pull/8568#discussion_r416943907 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/StoreUpgradeIntegrationTest.java ## @@ -337,8 +336,11 @@ public void shouldP

[GitHub] [kafka] guozhangwang commented on a change in pull request #8568: KAFKA-9176: Retry on getting local stores from KafkaStreams

2020-04-28 Thread GitBox
guozhangwang commented on a change in pull request #8568: URL: https://github.com/apache/kafka/pull/8568#discussion_r416942992 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/EosIntegrationTest.java ## @@ -810,21 +808,9 @@ private void writeInputData(f

[GitHub] [kafka] fantayeneh opened a new pull request #8577: use appropriate fn for readability. (maybe)

2020-04-28 Thread GitBox
fantayeneh opened a new pull request #8577: URL: https://github.com/apache/kafka/pull/8577 using the min, max might make the code a little easier to read. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage a

[jira] [Assigned] (KAFKA-9875) Flaky Test SuppressionDurabilityIntegrationTest.shouldRecoverBufferAfterShutdown[exactly_once]

2020-04-28 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler reassigned KAFKA-9875: --- Assignee: John Roesler > Flaky Test > SuppressionDurabilityIntegrationTest.shouldRecoverBuf

[GitHub] [kafka] vvcephei commented on a change in pull request #8568: KAFKA-9176: Retry on getting local stores from KafkaStreams

2020-04-28 Thread GitBox
vvcephei commented on a change in pull request #8568: URL: https://github.com/apache/kafka/pull/8568#discussion_r416921971 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/EosIntegrationTest.java ## @@ -810,21 +808,9 @@ private void writeInputData(final

[jira] [Assigned] (KAFKA-9928) Flaky GlobalKTableEOSIntegrationTest#shouldKStreamGlobalKTableLeftJoin[exactly_once_beta]

2020-04-28 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax reassigned KAFKA-9928: -- Assignee: Matthias J. Sax > Flaky > GlobalKTableEOSIntegrationTest#shouldKStreamGloba

[jira] [Updated] (KAFKA-9928) Flaky GlobalKTableEOSIntegrationTest#shouldKStreamGlobalKTableLeftJoin[exactly_once_beta]

2020-04-28 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-9928: --- Component/s: unit tests streams > Flaky > GlobalKTableEOSIntegrationTest#sh

[GitHub] [kafka] fantayeneh opened a new pull request #8576: format with correct syntax

2020-04-28 Thread GitBox
fantayeneh opened a new pull request #8576: URL: https://github.com/apache/kafka/pull/8576 small change fix string formatting ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Ve

[GitHub] [kafka] vvcephei commented on a change in pull request #8541: KAFKA-6145: KIP-441: Add TaskAssignor class config

2020-04-28 Thread GitBox
vvcephei commented on a change in pull request #8541: URL: https://github.com/apache/kafka/pull/8541#discussion_r416916295 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/assignment/HighAvailabilityTaskAssignorTest.java ## @@ -41,132 +54,107 @@

[GitHub] [kafka] guozhangwang commented on pull request #8568: KAFKA-9176: Retry on getting local stores from KafkaStreams

2020-04-28 Thread GitBox
guozhangwang commented on pull request #8568: URL: https://github.com/apache/kafka/pull/8568#issuecomment-620847306 I looked at the three failed tests: * `OptimizedKTableIntegrationTest.shouldApplyUpdatesToStandbyStore` is actually due to the issue that https://github.com/apache/kafk

[GitHub] [kafka] vvcephei commented on pull request #8254: KIP-557: Add Emit On Change Support

2020-04-28 Thread GitBox
vvcephei commented on pull request #8254: URL: https://github.com/apache/kafka/pull/8254#issuecomment-620847005 Whew! System tests passed: http://confluent-kafka-branch-builder-system-test-results.s3-us-west-2.amazonaws.com/2020-04-28--001.1588064884--ConcurrencyPractitioner--EMIT-ON-CHANGE

[GitHub] [kafka] vvcephei commented on pull request #8540: KAFKA-9127: don't create StreamThreads for global-only topology

2020-04-28 Thread GitBox
vvcephei commented on pull request #8540: URL: https://github.com/apache/kafka/pull/8540#issuecomment-620846462 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [kafka] vvcephei commented on pull request #8540: KAFKA-9127: don't create StreamThreads for global-only topology

2020-04-28 Thread GitBox
vvcephei commented on pull request #8540: URL: https://github.com/apache/kafka/pull/8540#issuecomment-620846265 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [kafka] guozhangwang commented on a change in pull request #8568: KAFKA-9176: Retry on getting local stores from KafkaStreams

2020-04-28 Thread GitBox
guozhangwang commented on a change in pull request #8568: URL: https://github.com/apache/kafka/pull/8568#discussion_r416910725 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/GlobalKTableEOSIntegrationTest.java ## @@ -158,8 +158,9 @@ public void should

[jira] [Created] (KAFKA-9928) Flaky GlobalKTableEOSIntegrationTest#shouldKStreamGlobalKTableLeftJoin[exactly_once_beta]

2020-04-28 Thread Guozhang Wang (Jira)
Guozhang Wang created KAFKA-9928: Summary: Flaky GlobalKTableEOSIntegrationTest#shouldKStreamGlobalKTableLeftJoin[exactly_once_beta] Key: KAFKA-9928 URL: https://issues.apache.org/jira/browse/KAFKA-9928

[jira] [Updated] (KAFKA-9921) Caching is not working properly with WindowStateStore when rataining duplicates

2020-04-28 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sophie Blee-Goldman updated KAFKA-9921: --- Fix Version/s: 2.5.1 > Caching is not working properly with WindowStateStore when rat

[GitHub] [kafka] gwenshap commented on pull request #8518: MINOR: add support for kafka 2.4 and 2.5 to downgrade test

2020-04-28 Thread GitBox
gwenshap commented on pull request #8518: URL: https://github.com/apache/kafka/pull/8518#issuecomment-620826970 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Commented] (KAFKA-9921) Caching is not working properly with WindowStateStore when rataining duplicates

2020-04-28 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17094844#comment-17094844 ] Sophie Blee-Goldman commented on KAFKA-9921: I'm resolving the ticket because

[jira] [Commented] (KAFKA-9921) Caching is not working properly with WindowStateStore when rataining duplicates

2020-04-28 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17094839#comment-17094839 ] Sophie Blee-Goldman commented on KAFKA-9921: I take it you're using rocksdb,

[jira] [Commented] (KAFKA-9921) Caching is not working properly with WindowStateStore when rataining duplicates

2020-04-28 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17094835#comment-17094835 ] Sophie Blee-Goldman commented on KAFKA-9921: > For 2 puts I would expect 2 en

[GitHub] [kafka] abbccdda commented on a change in pull request #8518: MINOR: add support for kafka 2.4 and 2.5 to downgrade test

2020-04-28 Thread GitBox
abbccdda commented on a change in pull request #8518: URL: https://github.com/apache/kafka/pull/8518#discussion_r416879514 ## File path: tests/kafkatest/tests/core/downgrade_test.py ## @@ -67,11 +67,18 @@ def setup_services(self, kafka_version, compression_types, security_prot

[GitHub] [kafka] kkonstantine commented on a change in pull request #8204: KAFKA-9633: Ensure ConfigProviders are closed

2020-04-28 Thread GitBox
kkonstantine commented on a change in pull request #8204: URL: https://github.com/apache/kafka/pull/8204#discussion_r416866064 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java ## @@ -220,6 +220,8 @@ public void stop() { worker

[GitHub] [kafka] kkonstantine commented on pull request #8204: KAFKA-9633: Ensure ConfigProviders are closed

2020-04-28 Thread GitBox
kkonstantine commented on pull request #8204: URL: https://github.com/apache/kafka/pull/8204#issuecomment-620803829 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on

[jira] [Commented] (KAFKA-9925) Non-key KTable Joining may result in duplicate schema name in confluence schema registry

2020-04-28 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17094805#comment-17094805 ] Guozhang Wang commented on KAFKA-9925: -- Ah yes!! Hope we can get KIP-591 by 2.6 :)

[jira] [Commented] (KAFKA-7317) Use collections subscription for main consumer to reduce metadata

2020-04-28 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17094800#comment-17094800 ] Matthias J. Sax commented on KAFKA-7317: Sweet! > Use collections subscription f

[jira] [Commented] (KAFKA-9127) Needless group coordination overhead for GlobalKTables

2020-04-28 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17094801#comment-17094801 ] Sophie Blee-Goldman commented on KAFKA-9127: Yep, if you can kick off tests o

[jira] [Commented] (KAFKA-9925) Non-key KTable Joining may result in duplicate schema name in confluence schema registry

2020-04-28 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17094799#comment-17094799 ] Matthias J. Sax commented on KAFKA-9925: {quote}I'm wondering if now is a good ti

[GitHub] [kafka] kkonstantine commented on pull request #8204: Ensure ConfigProviders are closed

2020-04-28 Thread GitBox
kkonstantine commented on pull request #8204: URL: https://github.com/apache/kafka/pull/8204#issuecomment-620795402 retest this please This is an automated message from the Apache Git Service. To respond to the message, pleas

[jira] [Commented] (KAFKA-7317) Use collections subscription for main consumer to reduce metadata

2020-04-28 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17094797#comment-17094797 ] Sophie Blee-Goldman commented on KAFKA-7317: Also fixed via [https://github.c

[jira] [Commented] (KAFKA-9127) Needless group coordination overhead for GlobalKTables

2020-04-28 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17094791#comment-17094791 ] Matthias J. Sax commented on KAFKA-9127: {quote}Does it qualify as a regression w

[jira] [Comment Edited] (KAFKA-9127) Needless group coordination overhead for GlobalKTables

2020-04-28 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17092826#comment-17092826 ] Matthias J. Sax edited comment on KAFKA-9127 at 4/28/20, 6:54 PM: -

[jira] [Commented] (KAFKA-7317) Use collections subscription for main consumer to reduce metadata

2020-04-28 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17094781#comment-17094781 ] Matthias J. Sax commented on KAFKA-7317: As reported on SO, when setting number o

[jira] [Commented] (KAFKA-9916) Materialize Table-Table Join Result to Avoid Performing Same Join Twice

2020-04-28 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17094777#comment-17094777 ] Matthias J. Sax commented on KAFKA-9916: The original example was slightly differ

[GitHub] [kafka] guozhangwang commented on pull request #8574: KAFKA-9925: decorate pseudo-topics with app id

2020-04-28 Thread GitBox
guozhangwang commented on pull request #8574: URL: https://github.com/apache/kafka/pull/8574#issuecomment-620787049 cc @abbccdda @mjsax to take a look? This is an automated message from the Apache Git Service. To respond to t

[jira] [Commented] (KAFKA-9925) Non-key KTable Joining may result in duplicate schema name in confluence schema registry

2020-04-28 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17094772#comment-17094772 ] Guozhang Wang commented on KAFKA-9925: -- [~vvcephei] Thanks for getting a look into t

[GitHub] [kafka] guozhangwang commented on pull request #8564: KAFKA-9921: disable caching on stores configured to retain duplicates

2020-04-28 Thread GitBox
guozhangwang commented on pull request #8564: URL: https://github.com/apache/kafka/pull/8564#issuecomment-620783397 Also cherry-picked to 2.5. This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [kafka] ableegoldman commented on a change in pull request #8568: KAFKA-9176: Retry on getting local stores from KafkaStreams

2020-04-28 Thread GitBox
ableegoldman commented on a change in pull request #8568: URL: https://github.com/apache/kafka/pull/8568#discussion_r416814163 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/GlobalKTableEOSIntegrationTest.java ## @@ -158,8 +158,9 @@ public void should

[jira] [Commented] (KAFKA-9925) Non-key KTable Joining may result in duplicate schema name in confluence schema registry

2020-04-28 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17094729#comment-17094729 ] John Roesler commented on KAFKA-9925: - Ok, I've opened [https://github.com/apache/kaf

[GitHub] [kafka] ableegoldman commented on a change in pull request #8541: KAFKA-6145: KIP-441: Add TaskAssignor class config

2020-04-28 Thread GitBox
ableegoldman commented on a change in pull request #8541: URL: https://github.com/apache/kafka/pull/8541#discussion_r416810713 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/assignment/HighAvailabilityTaskAssignorTest.java ## @@ -41,132 +54,10

[GitHub] [kafka] ableegoldman commented on a change in pull request #8568: KAFKA-9176: Retry on getting local stores from KafkaStreams

2020-04-28 Thread GitBox
ableegoldman commented on a change in pull request #8568: URL: https://github.com/apache/kafka/pull/8568#discussion_r416809469 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/OptimizedKTableIntegrationTest.java ## @@ -163,8 +159,10 @@ public void shoul

[jira] [Updated] (KAFKA-9923) Join window store duplicates can be compacted in changelog

2020-04-28 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9923?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sophie Blee-Goldman updated KAFKA-9923: --- Fix Version/s: 2.6.0 > Join window store duplicates can be compacted in changelog >

[jira] [Updated] (KAFKA-9923) Join window store duplicates can be compacted in changelog

2020-04-28 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9923?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sophie Blee-Goldman updated KAFKA-9923: --- Priority: Blocker (was: Critical) > Join window store duplicates can be compacted in

[GitHub] [kafka] hachikuji commented on pull request #8562: Test compilation fixes for Scala 2.11

2020-04-28 Thread GitBox
hachikuji commented on pull request #8562: URL: https://github.com/apache/kafka/pull/8562#issuecomment-620749977 retest this please This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [kafka] hachikuji commented on pull request #8562: Test compilation fixes for Scala 2.11

2020-04-28 Thread GitBox
hachikuji commented on pull request #8562: URL: https://github.com/apache/kafka/pull/8562#issuecomment-620749686 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] hachikuji commented on pull request #8562: Test compilation fixes for Scala 2.11

2020-04-28 Thread GitBox
hachikuji commented on pull request #8562: URL: https://github.com/apache/kafka/pull/8562#issuecomment-620749823 retest this please This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [kafka] pan3793 commented on pull request #7112: KAFKA-8713: JsonConverter NULL Values are replaced by default values even in NULLABLE fields

2020-04-28 Thread GitBox
pan3793 commented on pull request #7112: URL: https://github.com/apache/kafka/pull/7112#issuecomment-620746182 I do a new implement at https://github.com/apache/kafka/pull/8575 follow the [KIP-581](https://cwiki.apache.org/confluence/display/KAFKA/KIP-581:+Value+of+optional+null+field+which

[GitHub] [kafka] pan3793 opened a new pull request #8575: KAFKA-8713 KIP-581 Add accept.optional.null to solve optional null

2020-04-28 Thread GitBox
pan3793 opened a new pull request #8575: URL: https://github.com/apache/kafka/pull/8575 https://issues.apache.org/jira/browse/KAFKA-8713 https://cwiki.apache.org/confluence/display/KAFKA/KIP-581:+Value+of+optional+null+field+which+has+default+value ### Committer Checklist (exc

  1   2   >