[GitHub] [kafka] jwijgerd opened a new pull request #8645: KAFKA-9953

2020-05-10 Thread GitBox
jwijgerd opened a new pull request #8645: URL: https://github.com/apache/kafka/pull/8645 TransactionManager now supports caching of multiple consumerGroupCoordinator nodes avoiding the need find coordinators again when multiple consumer groups are used with a single transactional KafkaProd

[jira] [Created] (KAFKA-9977) Kafka Connect Task level error metrics exposed via JMX not removed on connector delete

2020-05-10 Thread Tharindu (Jira)
Tharindu created KAFKA-9977: --- Summary: Kafka Connect Task level error metrics exposed via JMX not removed on connector delete Key: KAFKA-9977 URL: https://issues.apache.org/jira/browse/KAFKA-9977 Project: K

[jira] [Commented] (KAFKA-2419) Allow certain Sensors to be garbage collected after inactivity

2020-05-10 Thread Chenxin (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-2419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17104106#comment-17104106 ] Chenxin commented on KAFKA-2419: [~guozhang] Ok.Thanks.I will try released 2.5.0. Thanks

[GitHub] [kafka] ijuma edited a comment on pull request #8639: KAFKA-9962: Make the auth operations fields ignorable

2020-05-10 Thread GitBox
ijuma edited a comment on pull request #8639: URL: https://github.com/apache/kafka/pull/8639#issuecomment-626483766 The system test `client_compatibility_features_test.py` (also see `ClientCompatibilityTest.java`). This is a

[GitHub] [kafka] ijuma commented on pull request #8639: KAFKA-9962: Make the auth operations fields ignorable

2020-05-10 Thread GitBox
ijuma commented on pull request #8639: URL: https://github.com/apache/kafka/pull/8639#issuecomment-626483766 The system test `client_compatibility_features_test.py`. This is an automated message from the Apache Git Service. T

[GitHub] [kafka] ijuma commented on pull request #8640: MINOR: equals() should check _unknownTaggedFields

2020-05-10 Thread GitBox
ijuma commented on pull request #8640: URL: https://github.com/apache/kafka/pull/8640#issuecomment-626483136 It would be useful to include a bit more motivation for this change. This is an automated message from the Apache Gi

[GitHub] [kafka] ijuma commented on pull request #8642: MINOR: Use `forEach` and `ifPresent` to simplify Scala code

2020-05-10 Thread GitBox
ijuma commented on pull request #8642: URL: https://github.com/apache/kafka/pull/8642#issuecomment-626482663 Similar Streams failures again, doesn't seem related: > org.apache.kafka.streams.integration.EosBetaUpgradeIntegrationTest.shouldUpgradeFromEosAlphaToEosBeta[false] > org.

[GitHub] [kafka] chia7712 commented on pull request #6915: KAFKA-8334 Executor to retry delayed operations failed to obtain lock

2020-05-10 Thread GitBox
chia7712 commented on pull request #6915: URL: https://github.com/apache/kafka/pull/6915#issuecomment-626473865 @junrao You are right and thanks for your suggestion! Let me fix what we truly need. @windkit feel free to join this party. I will file another PR to address @junrao comm

[jira] [Commented] (KAFKA-9339) Increased CPU utilization in brokers in 2.4.0

2020-05-10 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17104061#comment-17104061 ] Ismael Juma commented on KAFKA-9339: I suspect KAFKA-9731 may be the reason for this.

[jira] [Commented] (KAFKA-9953) support multiple consumerGroupCoordinators in TransactionManager

2020-05-10 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17104059#comment-17104059 ] Ismael Juma commented on KAFKA-9953: [~jwijgerd] Can you please submit a pull request

[GitHub] [kafka] jeffhuang26 edited a comment on pull request #8638: KAFAKA-9958: Add metrics support to Authorizer

2020-05-10 Thread GitBox
jeffhuang26 edited a comment on pull request #8638: URL: https://github.com/apache/kafka/pull/8638#issuecomment-626269228 I am thinking we might move the class AuthorizerMetrics(metrics: Metrics) from AclAuthorizer.scala to the package org.kafka.server.authorizer, so that other Authorizer

[GitHub] [kafka] LMnet commented on a change in pull request #8049: MINOR: Added missing default serdes to the streams.scala.Serdes

2020-05-10 Thread GitBox
LMnet commented on a change in pull request #8049: URL: https://github.com/apache/kafka/pull/8049#discussion_r422753972 ## File path: streams/streams-scala/src/main/scala/org/apache/kafka/streams/scala/Serdes.scala ## @@ -30,12 +32,15 @@ object Serdes { implicit def JavaLon

[GitHub] [kafka] junrao commented on pull request #6915: KAFKA-8334 Executor to retry delayed operations failed to obtain lock

2020-05-10 Thread GitBox
junrao commented on pull request #6915: URL: https://github.com/apache/kafka/pull/6915#issuecomment-626423986 @chia7712 : Yes, using a separate thread pool for checking completeness in Purgatory is another option. It adds its own complexity though: (1) we have to size and monitor the pool

[GitHub] [kafka] badaiaqrandista opened a new pull request #8644: KAFKA-9313: [WIP] Make use_all_dns_ips as the default for client.dns.lookup

2020-05-10 Thread GitBox
badaiaqrandista opened a new pull request #8644: URL: https://github.com/apache/kafka/pull/8644 Modified ClientUtils#resolve to use "use_all_dns_ips" as default Added "use_first_dns_ips" to get the old behaviour. *More detailed description of your change, if necessary. The P

[GitHub] [kafka] ijuma commented on pull request #8642: MINOR: Use `forEach` and `ifPresent` to simplify Scala code

2020-05-10 Thread GitBox
ijuma commented on pull request #8642: URL: https://github.com/apache/kafka/pull/8642#issuecomment-626395883 Unrelated flaky failures: > org.apache.kafka.connect.mirror.MirrorConnectorsIntegrationTest.testReplication > org.apache.kafka.streams.integration.EosBetaUpgradeIntegratio

[GitHub] [kafka] ijuma commented on pull request #8642: MINOR: Use `forEach` and `ifPresent` to simplify Scala code

2020-05-10 Thread GitBox
ijuma commented on pull request #8642: URL: https://github.com/apache/kafka/pull/8642#issuecomment-626395898 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [kafka] ijuma opened a new pull request #8643: KAFKA-9956: Authorizer APIs may be invoked more than once for a given request

2020-05-10 Thread GitBox
ijuma opened a new pull request #8643: URL: https://github.com/apache/kafka/pull/8643 * Fix describeConfigs and alterConfigs not to invoke authorizer more than once * Add tests to KafkaApisTest to verify the fixes * Rename `filterAuthorized` to `filterByAuthorized` * Tweak `filte

[jira] [Commented] (KAFKA-9972) Corrupted standby task could be committed

2020-05-10 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17103949#comment-17103949 ] Matthias J. Sax commented on KAFKA-9972: {quote}the TaskManager shouldn't have to

[jira] [Updated] (KAFKA-9359) Controller does not handle requests while broker is being shutdown

2020-05-10 Thread Lucas Bradstreet (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucas Bradstreet updated KAFKA-9359: Description: When a broker is shutdown it first tries to go through a controlled shutdown,

[GitHub] [kafka] ijuma opened a new pull request #8642: MINOR: Use `forEach` to simplify code

2020-05-10 Thread GitBox
ijuma opened a new pull request #8642: URL: https://github.com/apache/kafka/pull/8642 TBD ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrad

[jira] [Commented] (KAFKA-9617) Replica Fetcher can mark partition as failed when max.message.bytes is changed

2020-05-10 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17103798#comment-17103798 ] Chia-Ping Tsai commented on KAFKA-9617: --- [~ijuma] Could I take over this ticket? >

[GitHub] [kafka] cmccabe commented on pull request #8610: KAKFA-9942: --entity-default flag is not working for alternating / describing configs in AdminClient

2020-05-10 Thread GitBox
cmccabe commented on pull request #8610: URL: https://github.com/apache/kafka/pull/8610#issuecomment-626324149 resolved by #8628 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] cmccabe edited a comment on pull request #8628: KAFKA-9942: Fixes ConfigCommand client quotas w/ default users.

2020-05-10 Thread GitBox
cmccabe edited a comment on pull request #8628: URL: https://github.com/apache/kafka/pull/8628#issuecomment-626322719 2 failing tests are `EosBetaUpgradeIntegrationTest.shouldUpgradeFromEosAlphaToEosBeta` and `GlobalKTableIntegrationTest.shouldKStreamGlobalKTableLeftJoin`, which are not r

[GitHub] [kafka] cmccabe commented on pull request #8628: KAFKA-9942: Fixes ConfigCommand client quotas w/ default users.

2020-05-10 Thread GitBox
cmccabe commented on pull request #8628: URL: https://github.com/apache/kafka/pull/8628#issuecomment-626322719 2 failing tests are `EosBetaUpgradeIntegrationTest.shouldUpgradeFromEosAlphaToEosBeta` and `GlobalKTableIntegrationTest.shouldKStreamGlobalKTableLeftJoin`, which are not related

[jira] [Commented] (KAFKA-9617) Replica Fetcher can mark partition as failed when max.message.bytes is changed

2020-05-10 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17103768#comment-17103768 ] Luke Chen commented on KAFKA-9617: -- No, I haven't started to work on this. Go ahead to t

[GitHub] [kafka] chia7712 edited a comment on pull request #8640: MINOR: equals() should check _unknownTaggedFields

2020-05-10 Thread GitBox
chia7712 edited a comment on pull request #8640: URL: https://github.com/apache/kafka/pull/8640#issuecomment-626298211 just curious. As ```toStruct``` doesn't include ```_unknownTaggedFields```, the object_A which is NOT equal to object_B has *same* struct to object_B. Is it fine? ```

[GitHub] [kafka] chia7712 commented on pull request #8640: MINOR: equals() should check _unknownTaggedFields

2020-05-10 Thread GitBox
chia7712 commented on pull request #8640: URL: https://github.com/apache/kafka/pull/8640#issuecomment-626298211 just cusious. As ```toStruct``` doesn't include ```_unknownTaggedFields```, the object_A which is NOT equal to object_B has *same* struct to object_B. Is it fine? ``` val a

[GitHub] [kafka] chia7712 commented on pull request #6915: KAFKA-8334 Executor to retry delayed operations failed to obtain lock

2020-05-10 Thread GitBox
chia7712 commented on pull request #6915: URL: https://github.com/apache/kafka/pull/6915#issuecomment-626292057 @junrao Thanks for feedback. There are many execution paths which need to complete "delayed requests". It seems to me all of them are possible to encounter deadlock if they