[jira] [Commented] (KAFKA-8638) Preferred Leader Blacklist (deprioritized list)

2020-05-20 Thread GEORGE LI (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17111858#comment-17111858 ] GEORGE LI commented on KAFKA-8638: -- [~hai_lin] some of the recent activities about KIP-

[GitHub] [kafka] feyman2016 commented on pull request #8589: KAFKA-9146: KIP-571 Add option to force delete active members in StreamsResetter

2020-05-20 Thread GitBox
feyman2016 commented on pull request #8589: URL: https://github.com/apache/kafka/pull/8589#issuecomment-631299671 @abbccdda Thanks, will try my best to get this into 2.6 This is an automated message from the Apache Git Servic

[jira] [Commented] (KAFKA-6579) Consolidate window store and session store unit tests into a single class

2020-05-20 Thread Bartosz Mikulski (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-6579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17111880#comment-17111880 ] Bartosz Mikulski commented on KAFKA-6579: - If nobody is working on it right now,

[jira] [Commented] (KAFKA-9747) No tasks created for a connector

2020-05-20 Thread Le Thanh Duong (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17111918#comment-17111918 ] Le Thanh Duong commented on KAFKA-9747: --- I also stuck with the sample problem, task

[GitHub] [kafka] nizhikov edited a comment on pull request #8695: KAFKA-9320: KIP-573 - Enable TLSv1.3 by default

2020-05-20 Thread GitBox
nizhikov edited a comment on pull request #8695: URL: https://github.com/apache/kafka/pull/8695#issuecomment-631328373 @ijuma Looks like tests are OK. Please, take a look at this preliminary PR. This is an automated messag

[GitHub] [kafka] nizhikov commented on pull request #8695: KAFKA-9320: KIP-573 - Enable TLSv1.3 by default

2020-05-20 Thread GitBox
nizhikov commented on pull request #8695: URL: https://github.com/apache/kafka/pull/8695#issuecomment-631328373 @ijuma Looks like tests is OK. Please, take a look at this preliminary PR. This is an automated message from t

[GitHub] [kafka] ake1234 commented on pull request #7070: KAFKA-7157: Fix handling of nulls in TimestampConverter

2020-05-20 Thread GitBox
ake1234 commented on pull request #7070: URL: https://github.com/apache/kafka/pull/7070#issuecomment-631346141 I'm also using this SMT but its throws null pointer exception for null timestamp values. Can someone help us how to implement this changes. -

[jira] [Updated] (KAFKA-9755) Implement versioning scheme for features

2020-05-20 Thread Kowshik Prakasam (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9755?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kowshik Prakasam updated KAFKA-9755: Description: Details are in this wiki: [https://cwiki.apache.org/confluence/display/KAFKA/

[jira] [Created] (KAFKA-10026) KIP-584: Implement read path for versioning scheme for features

2020-05-20 Thread Kowshik Prakasam (Jira)
Kowshik Prakasam created KAFKA-10026: Summary: KIP-584: Implement read path for versioning scheme for features Key: KAFKA-10026 URL: https://issues.apache.org/jira/browse/KAFKA-10026 Project: Kafk

[jira] [Created] (KAFKA-10027) KIP-584: Implement read path for versioning scheme for features

2020-05-20 Thread Kowshik Prakasam (Jira)
Kowshik Prakasam created KAFKA-10027: Summary: KIP-584: Implement read path for versioning scheme for features Key: KAFKA-10027 URL: https://issues.apache.org/jira/browse/KAFKA-10027 Project: Kafk

[jira] [Resolved] (KAFKA-10026) KIP-584: Implement read path for versioning scheme for features

2020-05-20 Thread Kowshik Prakasam (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kowshik Prakasam resolved KAFKA-10026. -- Resolution: Duplicate Duplicate of KAFKA-10027 > KIP-584: Implement read path for ver

[GitHub] [kafka] kowshik commented on a change in pull request #8680: KAFKA-9755: Implement read path for feature versioning system (KIP-584)

2020-05-20 Thread GitBox
kowshik commented on a change in pull request #8680: URL: https://github.com/apache/kafka/pull/8680#discussion_r427022316 ## File path: clients/src/main/java/org/apache/kafka/common/feature/Features.java ## @@ -0,0 +1,143 @@ +package org.apache.kafka.common.feature; + +import j

[jira] [Commented] (KAFKA-6520) When a Kafka Stream can't communicate with the server, it's Status stays RUNNING

2020-05-20 Thread Vince Mu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-6520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17112118#comment-17112118 ] Vince Mu commented on KAFKA-6520: - I think the easiest and perhaps simplest way is to che

[jira] [Comment Edited] (KAFKA-6520) When a Kafka Stream can't communicate with the server, it's Status stays RUNNING

2020-05-20 Thread Vince Mu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-6520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17112118#comment-17112118 ] Vince Mu edited comment on KAFKA-6520 at 5/20/20, 12:58 PM: I

[GitHub] [kafka] ijuma commented on a change in pull request #8695: KAFKA-9320: KIP-573 - Enable TLSv1.3 by default

2020-05-20 Thread GitBox
ijuma commented on a change in pull request #8695: URL: https://github.com/apache/kafka/pull/8695#discussion_r428020072 ## File path: clients/src/test/java/org/apache/kafka/common/network/SslTransportLayerTest.java ## @@ -622,6 +622,34 @@ public void testUnsupportedTLSVersion(

[jira] [Assigned] (KAFKA-7631) NullPointerException when SCRAM is allowed bu ScramLoginModule is not in broker's jaas.conf

2020-05-20 Thread Jun Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Wang reassigned KAFKA-7631: --- Assignee: (was: Jun Wang) > NullPointerException when SCRAM is allowed bu ScramLoginModule is no

[GitHub] [kafka] vvcephei commented on a change in pull request #8679: KAFKA-10003: Mark KStream.through() as deprecated

2020-05-20 Thread GitBox
vvcephei commented on a change in pull request #8679: URL: https://github.com/apache/kafka/pull/8679#discussion_r428055668 ## File path: streams/streams-scala/src/main/scala/org/apache/kafka/streams/scala/kstream/KStream.scala ## @@ -232,10 +232,53 @@ class KStream[K, V](val i

[GitHub] [kafka] nizhikov commented on a change in pull request #8695: KAFKA-9320: KIP-573 - Enable TLSv1.3 by default

2020-05-20 Thread GitBox
nizhikov commented on a change in pull request #8695: URL: https://github.com/apache/kafka/pull/8695#discussion_r428114569 ## File path: clients/src/test/java/org/apache/kafka/common/network/SslTransportLayerTest.java ## @@ -622,6 +622,34 @@ public void testUnsupportedTLSVersi

[GitHub] [kafka] rhauch commented on pull request #8357: KAFKA-9767: Add logging to basic auth rest extension

2020-05-20 Thread GitBox
rhauch commented on pull request #8357: URL: https://github.com/apache/kafka/pull/8357#issuecomment-631562562 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [kafka] xinzhuxiansheng closed pull request #8694: KAFKA-10022: console-producer supports the setting of client.id

2020-05-20 Thread GitBox
xinzhuxiansheng closed pull request #8694: URL: https://github.com/apache/kafka/pull/8694 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [kafka] xinzhuxiansheng opened a new pull request #8698: console-producer supports the setting of client.id

2020-05-20 Thread GitBox
xinzhuxiansheng opened a new pull request #8698: URL: https://github.com/apache/kafka/pull/8698 https://issues.apache.org/jira/browse/KAFKA-10022 "console-producer" supports the setting of "client.id", which is a reasonable requirement, and the way "console consumer" and "console pro

[jira] [Updated] (KAFKA-10022) console-producer supports the setting of client.id

2020-05-20 Thread Young Chou (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10022?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Young Chou updated KAFKA-10022: --- Description: "console-producer" supports the setting of "client.id", which is a reasonable requirem

[GitHub] [kafka] wj1918 commented on pull request #8612: KAFKA-8120 Getting NegativeArraySizeException when using Kafka Connect

2020-05-20 Thread GitBox
wj1918 commented on pull request #8612: URL: https://github.com/apache/kafka/pull/8612#issuecomment-631579687 call for reviewers @kkonstantine @phstudy @ewencp @hachikuji should have separate refactoring code with the bug fix code. but it is a fairly safe fix.

[GitHub] [kafka] wj1918 edited a comment on pull request #8612: KAFKA-8120 Getting NegativeArraySizeException when using Kafka Connect

2020-05-20 Thread GitBox
wj1918 edited a comment on pull request #8612: URL: https://github.com/apache/kafka/pull/8612#issuecomment-631579687 call for reviewers @kkonstantine @phstudy @ewencp @hachikuji should have separate commit of refactoring and bug fix. but it is a fairly safe fix. --

[GitHub] [kafka] rhauch commented on a change in pull request #8357: KAFKA-9767: Add logging to basic auth rest extension

2020-05-20 Thread GitBox
rhauch commented on a change in pull request #8357: URL: https://github.com/apache/kafka/pull/8357#discussion_r428132065 ## File path: connect/basic-auth-extension/src/main/java/org/apache/kafka/connect/rest/basic/auth/extension/JaasBasicAuthFilter.java ## @@ -67,36 +87,60 @@

[GitHub] [kafka] ijuma commented on a change in pull request #8695: KAFKA-9320: KIP-573 - Enable TLSv1.3 by default

2020-05-20 Thread GitBox
ijuma commented on a change in pull request #8695: URL: https://github.com/apache/kafka/pull/8695#discussion_r428020072 ## File path: clients/src/test/java/org/apache/kafka/common/network/SslTransportLayerTest.java ## @@ -622,6 +622,34 @@ public void testUnsupportedTLSVersion(

[GitHub] [kafka] ijuma commented on a change in pull request #8695: KAFKA-9320: KIP-573 - Enable TLSv1.3 by default

2020-05-20 Thread GitBox
ijuma commented on a change in pull request #8695: URL: https://github.com/apache/kafka/pull/8695#discussion_r428153104 ## File path: clients/src/test/java/org/apache/kafka/common/network/SslTransportLayerTest.java ## @@ -622,6 +622,34 @@ public void testUnsupportedTLSVersion(

[GitHub] [kafka] vvcephei commented on a change in pull request #8677: KAFKA-9999: Make internal topic creation error non-fatal

2020-05-20 Thread GitBox
vvcephei commented on a change in pull request #8677: URL: https://github.com/apache/kafka/pull/8677#discussion_r428152062 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopicManager.java ## @@ -171,7 +173,7 @@ public InternalTopicMana

[GitHub] [kafka] ableegoldman commented on a change in pull request #8677: KAFKA-9999: Make internal topic creation error non-fatal

2020-05-20 Thread GitBox
ableegoldman commented on a change in pull request #8677: URL: https://github.com/apache/kafka/pull/8677#discussion_r428166926 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopicManager.java ## @@ -171,7 +173,7 @@ public InternalTopic

[GitHub] [kafka] ijuma commented on pull request #8695: KAFKA-9320: KIP-573 - Enable TLSv1.3 by default

2020-05-20 Thread GitBox
ijuma commented on pull request #8695: URL: https://github.com/apache/kafka/pull/8695#issuecomment-631601762 One question: any downside to setting `ssl.protocol=TLSv1.3` instead of `ssl.protocol=TLSv1.2`? This is an automate

[jira] [Commented] (KAFKA-6579) Consolidate window store and session store unit tests into a single class

2020-05-20 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-6579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17112447#comment-17112447 ] Guozhang Wang commented on KAFKA-6579: -- [~mikulskibartosz] please feel free to take

[GitHub] [kafka] guozhangwang merged pull request #8671: KAFKA-9859 / Add topics generated by KTable FK join to internal topic matching logic

2020-05-20 Thread GitBox
guozhangwang merged pull request #8671: URL: https://github.com/apache/kafka/pull/8671 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] nizhikov commented on a change in pull request #8695: KAFKA-9320: KIP-573 - Enable TLSv1.3 by default

2020-05-20 Thread GitBox
nizhikov commented on a change in pull request #8695: URL: https://github.com/apache/kafka/pull/8695#discussion_r428173640 ## File path: clients/src/test/java/org/apache/kafka/common/network/SslTransportLayerTest.java ## @@ -622,6 +622,34 @@ public void testUnsupportedTLSVersi

[jira] [Commented] (KAFKA-9899) LogCleaner Tries To Clean Single Partition Over 1000x/Minute

2020-05-20 Thread Jeff Nadler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17112460#comment-17112460 ] Jeff Nadler commented on KAFKA-9899: upgraded to 2.5.0, still experiencing this issue

[GitHub] [kafka] nizhikov commented on pull request #8695: KAFKA-9320: KIP-573 - Enable TLSv1.3 by default

2020-05-20 Thread GitBox
nizhikov commented on pull request #8695: URL: https://github.com/apache/kafka/pull/8695#issuecomment-631614084 @ijuma I can't see downside in forcing usage of the latest TLS version. Added this change to PR. This is an au

[jira] [Resolved] (KAFKA-9859) kafka-streams-application-reset tool doesn't take into account topics generated by KTable foreign key join operation

2020-05-20 Thread Levani Kokhreidze (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Levani Kokhreidze resolved KAFKA-9859. -- Fix Version/s: 2.6.0 Resolution: Fixed fixed with PR [https://github.com/apache/

[GitHub] [kafka] xiaodongdu commented on a change in pull request #8691: KAFKA-9960: implement KIP-606 to add metadata context to MetricsReporter

2020-05-20 Thread GitBox
xiaodongdu commented on a change in pull request #8691: URL: https://github.com/apache/kafka/pull/8691#discussion_r428201738 ## File path: connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorMaker.java ## @@ -233,17 +233,18 @@ private void addHerder(SourceAndTar

[GitHub] [kafka] xiaodongdu commented on a change in pull request #8691: KAFKA-9960: implement KIP-606 to add metadata context to MetricsReporter

2020-05-20 Thread GitBox
xiaodongdu commented on a change in pull request #8691: URL: https://github.com/apache/kafka/pull/8691#discussion_r428202016 ## File path: connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorMaker.java ## @@ -233,17 +233,18 @@ private void addHerder(SourceAndTar

[GitHub] [kafka] xiaodongdu commented on a change in pull request #8691: KAFKA-9960: implement KIP-606 to add metadata context to MetricsReporter

2020-05-20 Thread GitBox
xiaodongdu commented on a change in pull request #8691: URL: https://github.com/apache/kafka/pull/8691#discussion_r428202270 ## File path: connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorMaker.java ## @@ -233,17 +233,18 @@ private void addHerder(SourceAndTar

[GitHub] [kafka] xiaodongdu commented on a change in pull request #8691: KAFKA-9960: implement KIP-606 to add metadata context to MetricsReporter

2020-05-20 Thread GitBox
xiaodongdu commented on a change in pull request #8691: URL: https://github.com/apache/kafka/pull/8691#discussion_r428202532 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/cli/ConnectDistributed.java ## @@ -101,24 +101,25 @@ public Connect startConnect(Ma

[GitHub] [kafka] xiaodongdu commented on a change in pull request #8691: KAFKA-9960: implement KIP-606 to add metadata context to MetricsReporter

2020-05-20 Thread GitBox
xiaodongdu commented on a change in pull request #8691: URL: https://github.com/apache/kafka/pull/8691#discussion_r428203009 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/cli/ConnectDistributed.java ## @@ -101,24 +101,25 @@ public Connect startConnect(Ma

[GitHub] [kafka] xiaodongdu commented on a change in pull request #8691: KAFKA-9960: implement KIP-606 to add metadata context to MetricsReporter

2020-05-20 Thread GitBox
xiaodongdu commented on a change in pull request #8691: URL: https://github.com/apache/kafka/pull/8691#discussion_r428202742 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/cli/ConnectDistributed.java ## @@ -101,24 +101,25 @@ public Connect startConnect(Ma

[GitHub] [kafka] xiaodongdu commented on a change in pull request #8691: KAFKA-9960: implement KIP-606 to add metadata context to MetricsReporter

2020-05-20 Thread GitBox
xiaodongdu commented on a change in pull request #8691: URL: https://github.com/apache/kafka/pull/8691#discussion_r428203600 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/cli/ConnectStandalone.java ## @@ -93,7 +93,7 @@ public static void main(String[] ar

[GitHub] [kafka] xiaodongdu commented on a change in pull request #8691: KAFKA-9960: implement KIP-606 to add metadata context to MetricsReporter

2020-05-20 Thread GitBox
xiaodongdu commented on a change in pull request #8691: URL: https://github.com/apache/kafka/pull/8691#discussion_r428203369 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/cli/ConnectDistributed.java ## @@ -101,24 +101,25 @@ public Connect startConnect(Ma

[GitHub] [kafka] xiaodongdu commented on a change in pull request #8691: KAFKA-9960: implement KIP-606 to add metadata context to MetricsReporter

2020-05-20 Thread GitBox
xiaodongdu commented on a change in pull request #8691: URL: https://github.com/apache/kafka/pull/8691#discussion_r428203784 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java ## @@ -92,6 +93,7 @@ private final ExecutorService executo

[GitHub] [kafka] C0urante commented on pull request #8511: KAFKA-9888: Copy connector configs before passing to REST extensions

2020-05-20 Thread GitBox
C0urante commented on pull request #8511: URL: https://github.com/apache/kafka/pull/8511#issuecomment-631633951 Thanks @kkonstantine, I've addressed both of your comments. Ready for another round when you have time. This is

[GitHub] [kafka] xiaodongdu commented on a change in pull request #8691: KAFKA-9960: implement KIP-606 to add metadata context to MetricsReporter

2020-05-20 Thread GitBox
xiaodongdu commented on a change in pull request #8691: URL: https://github.com/apache/kafka/pull/8691#discussion_r428205238 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java ## @@ -92,6 +93,7 @@ private final ExecutorService executo

[jira] [Commented] (KAFKA-4084) automated leader rebalance causes replication downtime for clusters with too many partitions

2020-05-20 Thread Hai Lin (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-4084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17112508#comment-17112508 ] Hai Lin commented on KAFKA-4084: Thanks [~sql_consulting] point me to this ticket. [~junr

[jira] [Comment Edited] (KAFKA-4084) automated leader rebalance causes replication downtime for clusters with too many partitions

2020-05-20 Thread Hai Lin (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-4084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17112508#comment-17112508 ] Hai Lin edited comment on KAFKA-4084 at 5/20/20, 6:18 PM: -- Thank

[jira] [Comment Edited] (KAFKA-4084) automated leader rebalance causes replication downtime for clusters with too many partitions

2020-05-20 Thread Hai Lin (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-4084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17112508#comment-17112508 ] Hai Lin edited comment on KAFKA-4084 at 5/20/20, 6:18 PM: -- Thank

[jira] [Commented] (KAFKA-8159) Built-in serdes for signed numbers do not obey lexicographical ordering

2020-05-20 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17112511#comment-17112511 ] Guozhang Wang commented on KAFKA-8159: -- Hey John, What I was asking is actually bey

[GitHub] [kafka] omkreddy opened a new pull request #8700: MINOR: Increase gradle daemon’s heap size to 2g

2020-05-20 Thread GitBox
omkreddy opened a new pull request #8700: URL: https://github.com/apache/kafka/pull/8700 We have seen out of memory error in builds. This PR is to increase the gradle heap memory to 2g. ``` [Error] : Error while emitting kafka/log/LogTest [2020-05-20T11:33:15.133Z] GC overhead

[GitHub] [kafka] tombentley opened a new pull request #8699: KAFKA-9673: Filter and Conditional SMTs

2020-05-20 Thread GitBox
tombentley opened a new pull request #8699: URL: https://github.com/apache/kafka/pull/8699 * Add Predicate interface * Add Filter SMT * Add the predicate implementations defined in the KIP. * Create abstraction in ConnectorConfig for configuring Transformations and Connectors with

[GitHub] [kafka] tombentley commented on pull request #8699: KAFKA-9673: Filter and Conditional SMTs

2020-05-20 Thread GitBox
tombentley commented on pull request #8699: URL: https://github.com/apache/kafka/pull/8699#issuecomment-631651186 Still need to review test coverage, but @kkonstantine, @mimaison, @bbejeck you might want to give it an initial pass. -

[jira] [Commented] (KAFKA-9987) Improve sticky partition assignor algorithm

2020-05-20 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17112535#comment-17112535 ] Sophie Blee-Goldman commented on KAFKA-9987: [~hai_lin] I put this on pause t

[GitHub] [kafka] xiaodongdu commented on a change in pull request #8691: KAFKA-9960: implement KIP-606 to add metadata context to MetricsReporter

2020-05-20 Thread GitBox
xiaodongdu commented on a change in pull request #8691: URL: https://github.com/apache/kafka/pull/8691#discussion_r428255598 ## File path: connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorMaker.java ## @@ -233,17 +233,18 @@ private void addHerder(SourceAndTar

[GitHub] [kafka] omkreddy commented on pull request #8700: MINOR: Increase gradle daemon’s heap size to 2g

2020-05-20 Thread GitBox
omkreddy commented on pull request #8700: URL: https://github.com/apache/kafka/pull/8700#issuecomment-631677805 retest this please This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [kafka] C0urante commented on a change in pull request #8357: KAFKA-9767: Add logging to basic auth rest extension

2020-05-20 Thread GitBox
C0urante commented on a change in pull request #8357: URL: https://github.com/apache/kafka/pull/8357#discussion_r428260448 ## File path: connect/basic-auth-extension/src/main/java/org/apache/kafka/connect/rest/basic/auth/extension/JaasBasicAuthFilter.java ## @@ -67,36 +87,60 @

[GitHub] [kafka] C0urante commented on a change in pull request #8357: KAFKA-9767: Add logging to basic auth rest extension

2020-05-20 Thread GitBox
C0urante commented on a change in pull request #8357: URL: https://github.com/apache/kafka/pull/8357#discussion_r428260801 ## File path: connect/basic-auth-extension/src/main/java/org/apache/kafka/connect/rest/basic/auth/extension/JaasBasicAuthFilter.java ## @@ -67,36 +87,60 @

[GitHub] [kafka] C0urante commented on pull request #8357: KAFKA-9767: Add logging to basic auth rest extension

2020-05-20 Thread GitBox
C0urante commented on pull request #8357: URL: https://github.com/apache/kafka/pull/8357#issuecomment-631682508 Thanks @rhauch; I've added the requested unit test. This is ready for another round when you have time This is a

[GitHub] [kafka] tombentley commented on pull request #8699: KAFKA-9673: Filter and Conditional SMTs

2020-05-20 Thread GitBox
tombentley commented on pull request #8699: URL: https://github.com/apache/kafka/pull/8699#issuecomment-631683003 @C0urante you might also want to take a look. This is an automated message from the Apache Git Service. To resp

[GitHub] [kafka] apovzner commented on pull request #8650: MINOR: Added unit tests for ConnectionQuotas

2020-05-20 Thread GitBox
apovzner commented on pull request #8650: URL: https://github.com/apache/kafka/pull/8650#issuecomment-631702750 One of the build failures failed due to one of the unit tests added in this PR. It was bug in the test, that was waiting on the wrong future, which had a name similar to another

[GitHub] [kafka] guozhangwang commented on pull request #8661: KAFKA-9603: Do not turn on bulk loading for segmented stores on stand-by tasks

2020-05-20 Thread GitBox
guozhangwang commented on pull request #8661: URL: https://github.com/apache/kafka/pull/8661#issuecomment-631737464 test this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] guozhangwang commented on pull request #8661: KAFKA-9603: Do not turn on bulk loading for segmented stores on stand-by tasks

2020-05-20 Thread GitBox
guozhangwang commented on pull request #8661: URL: https://github.com/apache/kafka/pull/8661#issuecomment-631737855 test this This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] guozhangwang commented on pull request #8661: KAFKA-9603: Do not turn on bulk loading for segmented stores on stand-by tasks

2020-05-20 Thread GitBox
guozhangwang commented on pull request #8661: URL: https://github.com/apache/kafka/pull/8661#issuecomment-631738264 test this This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] guozhangwang commented on pull request #8698: KAFKA-10022:console-producer supports the setting of client.id

2020-05-20 Thread GitBox
guozhangwang commented on pull request #8698: URL: https://github.com/apache/kafka/pull/8698#issuecomment-631738575 test this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] rhauch commented on pull request #8270: KAFKA-9216: Enforce connect internal topic configuration at startup

2020-05-20 Thread GitBox
rhauch commented on pull request #8270: URL: https://github.com/apache/kafka/pull/8270#issuecomment-631747698 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [kafka] rhauch commented on a change in pull request #8654: KAFKA-9931: Implement KIP-605 to expand support for Connect worker internal topic configurations

2020-05-20 Thread GitBox
rhauch commented on a change in pull request #8654: URL: https://github.com/apache/kafka/pull/8654#discussion_r428333268 ## File path: connect/runtime/src/test/java/org/apache/kafka/connect/integration/InternalTopicsIntegrationTest.java ## @@ -0,0 +1,187 @@ +/* + * Licensed to

[GitHub] [kafka] rhauch commented on a change in pull request #8654: KAFKA-9931: Implement KIP-605 to expand support for Connect worker internal topic configurations

2020-05-20 Thread GitBox
rhauch commented on a change in pull request #8654: URL: https://github.com/apache/kafka/pull/8654#discussion_r428334196 ## File path: connect/runtime/src/test/java/org/apache/kafka/connect/integration/InternalTopicsIntegrationTest.java ## @@ -0,0 +1,187 @@ +/* + * Licensed to

[GitHub] [kafka] rhauch commented on a change in pull request #8654: KAFKA-9931: Implement KIP-605 to expand support for Connect worker internal topic configurations

2020-05-20 Thread GitBox
rhauch commented on a change in pull request #8654: URL: https://github.com/apache/kafka/pull/8654#discussion_r428333268 ## File path: connect/runtime/src/test/java/org/apache/kafka/connect/integration/InternalTopicsIntegrationTest.java ## @@ -0,0 +1,187 @@ +/* + * Licensed to

[jira] [Updated] (KAFKA-9878) Block AddPartitionsToTxn call until the txn markers are committed

2020-05-20 Thread Boyang Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Boyang Chen updated KAFKA-9878: --- Description: Currently the EndTxn call from Producer will immediately return as the control record i

[GitHub] [kafka] guozhangwang merged pull request #8661: KAFKA-9603: Do not turn on bulk loading for segmented stores on stand-by tasks

2020-05-20 Thread GitBox
guozhangwang merged pull request #8661: URL: https://github.com/apache/kafka/pull/8661 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] guozhangwang commented on pull request #8698: KAFKA-10022:console-producer supports the setting of client.id

2020-05-20 Thread GitBox
guozhangwang commented on pull request #8698: URL: https://github.com/apache/kafka/pull/8698#issuecomment-631755813 There are known flaky tests that may fail, I'm validating that there's no consistent test failures. @xinzhuxiansheng ---

[GitHub] [kafka] bbejeck commented on pull request #8504: KAFKA-9298: reuse mapped stream error in joins

2020-05-20 Thread GitBox
bbejeck commented on pull request #8504: URL: https://github.com/apache/kafka/pull/8504#issuecomment-631757206 > @bbejeck Are the any backward compatibility concerns for KAFKA-9976 ? Good point, maybe we should just leave this one alone for now. If you agree I'll close that PR. --

[GitHub] [kafka] bbejeck commented on a change in pull request #8504: KAFKA-9298: reuse mapped stream error in joins

2020-05-20 Thread GitBox
bbejeck commented on a change in pull request #8504: URL: https://github.com/apache/kafka/pull/8504#discussion_r428343055 ## File path: streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoinTest.java ## @@ -77,6 +79,38 @@ public void shouldLogAndM

[GitHub] [kafka] rhauch commented on pull request #8654: KAFKA-9931: Implement KIP-605 to expand support for Connect worker internal topic configurations

2020-05-20 Thread GitBox
rhauch commented on pull request #8654: URL: https://github.com/apache/kafka/pull/8654#issuecomment-631762530 Thanks for the review, @kkonstantine. I think I've incorporated all of your suggestions. This is an automated mess

[GitHub] [kafka] rhauch commented on pull request #8654: KAFKA-9931: Implement KIP-605 to expand support for Connect worker internal topic configurations

2020-05-20 Thread GitBox
rhauch commented on pull request #8654: URL: https://github.com/apache/kafka/pull/8654#issuecomment-631762616 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [kafka] C0urante commented on a change in pull request #8699: KAFKA-9673: Filter and Conditional SMTs

2020-05-20 Thread GitBox
C0urante commented on a change in pull request #8699: URL: https://github.com/apache/kafka/pull/8699#discussion_r428333743 ## File path: connect/transforms/src/main/java/org/apache/kafka/connect/transforms/predicates/RecordIsTombstone.java ## @@ -0,0 +1,48 @@ +/* + * Licensed

[GitHub] [kafka] xvrl commented on a change in pull request #8691: KAFKA-9960: implement KIP-606 to add metadata context to MetricsReporter

2020-05-20 Thread GitBox
xvrl commented on a change in pull request #8691: URL: https://github.com/apache/kafka/pull/8691#discussion_r428351889 ## File path: connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorConnectorConfig.java ## @@ -270,9 +272,15 @@ Duration adminTimeout() { L

[GitHub] [kafka] xvrl commented on a change in pull request #8691: KAFKA-9960: implement KIP-606 to add metadata context to MetricsReporter

2020-05-20 Thread GitBox
xvrl commented on a change in pull request #8691: URL: https://github.com/apache/kafka/pull/8691#discussion_r428352951 ## File path: connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorConnectorConfig.java ## @@ -270,9 +272,15 @@ Duration adminTimeout() { L

[GitHub] [kafka] hachikuji opened a new pull request #8701: MINOR: Add reason to log message when incrementing the log start offset

2020-05-20 Thread GitBox
hachikuji opened a new pull request #8701: URL: https://github.com/apache/kafka/pull/8701 Sometimes logging leaves us guessing at the cause of an increment to the log start offset. Since this results in deletion of user data, I think the logging should be clear about the reason. ###

[GitHub] [kafka] omkreddy commented on pull request #8700: MINOR: Increase gradle daemon’s heap size to 2g

2020-05-20 Thread GitBox
omkreddy commented on pull request #8700: URL: https://github.com/apache/kafka/pull/8700#issuecomment-631785818 retest this please This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [kafka] hachikuji commented on pull request #8701: MINOR: Add reason to log message when incrementing the log start offset

2020-05-20 Thread GitBox
hachikuji commented on pull request #8701: URL: https://github.com/apache/kafka/pull/8701#issuecomment-631789824 Need to fix some of the uses in test cases. Debating whether I should create an enum for the reason and get rid of the overload... -

[jira] [Commented] (KAFKA-6520) When a Kafka Stream can't communicate with the server, it's Status stays RUNNING

2020-05-20 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-6520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17112676#comment-17112676 ] Matthias J. Sax commented on KAFKA-6520: The consumer only stores/caches the last

[jira] [Resolved] (KAFKA-1056) Evenly Distribute Intervals in OffsetIndex

2020-05-20 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-1056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang resolved KAFKA-1056. -- Resolution: Fixed > Evenly Distribute Intervals in OffsetIndex > --

[GitHub] [kafka] mjsax commented on a change in pull request #8504: KAFKA-9298: reuse mapped stream error in joins

2020-05-20 Thread GitBox
mjsax commented on a change in pull request #8504: URL: https://github.com/apache/kafka/pull/8504#discussion_r424060697 ## File path: streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoinTest.java ## @@ -77,6 +79,38 @@ public void shouldLogAndMet

[GitHub] [kafka] mjsax commented on a change in pull request #8504: KAFKA-9298: reuse mapped stream error in joins

2020-05-20 Thread GitBox
mjsax commented on a change in pull request #8504: URL: https://github.com/apache/kafka/pull/8504#discussion_r424060697 ## File path: streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoinTest.java ## @@ -77,6 +79,38 @@ public void shouldLogAndMet

[GitHub] [kafka] mjsax commented on a change in pull request #8504: KAFKA-9298: reuse mapped stream error in joins

2020-05-20 Thread GitBox
mjsax commented on a change in pull request #8504: URL: https://github.com/apache/kafka/pull/8504#discussion_r428376734 ## File path: streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoinTest.java ## @@ -77,6 +79,38 @@ public void shouldLogAndMet

[GitHub] [kafka] mjsax commented on pull request #8637: KAFKA-9976: Reuse repartition node in all cases for KGroupedStream and KGroupedTable aggregates

2020-05-20 Thread GitBox
mjsax commented on pull request #8637: URL: https://github.com/apache/kafka/pull/8637#issuecomment-631803677 Seems you agree to my last comment: https://github.com/apache/kafka/pull/8504#issuecomment-631757206 I think it's best to close this PR and also the ticker (either as "not a

[GitHub] [kafka] mjsax commented on pull request #8650: MINOR: Added unit tests for ConnectionQuotas

2020-05-20 Thread GitBox
mjsax commented on pull request #8650: URL: https://github.com/apache/kafka/pull/8650#issuecomment-631804240 Retest this please. This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] mjsax commented on pull request #8650: MINOR: Added unit tests for ConnectionQuotas

2020-05-20 Thread GitBox
mjsax commented on pull request #8650: URL: https://github.com/apache/kafka/pull/8650#issuecomment-631804131 Retest this please This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [kafka] mjsax commented on pull request #8679: KAFKA-10003: Mark KStream.through() as deprecated

2020-05-20 Thread GitBox
mjsax commented on pull request #8679: URL: https://github.com/apache/kafka/pull/8679#issuecomment-631809507 Added the test. Will merge after Jenkins passed. This is an automated message from the Apache Git Service. To respon

[GitHub] [kafka] guozhangwang commented on pull request #8698: KAFKA-10022:console-producer supports the setting of client.id

2020-05-20 Thread GitBox
guozhangwang commented on pull request #8698: URL: https://github.com/apache/kafka/pull/8698#issuecomment-631810146 test this This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] hachikuji opened a new pull request #8702: MINOR: Fix join group request timeout lower bound

2020-05-20 Thread GitBox
hachikuji opened a new pull request #8702: URL: https://github.com/apache/kafka/pull/8702 If the request timeout is larger than the rebalance timeout, we should use the former as the JoinGroup request timeout. ### Committer Checklist (excluded from commit message) - [ ] Verify des

[jira] [Commented] (KAFKA-9981) Running a dedicated mm2 cluster with more than one nodes,When the configuration is updated the task is not aware and will lose the update operation.

2020-05-20 Thread victor (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17112690#comment-17112690 ] victor commented on KAFKA-9981: --- [~ChrisEgerton] mm2 has realized data backup. How does kaf

[GitHub] [kafka] hachikuji commented on a change in pull request #8702: MINOR: Fix join group request timeout lower bound

2020-05-20 Thread GitBox
hachikuji commented on a change in pull request #8702: URL: https://github.com/apache/kafka/pull/8702#discussion_r428389929 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java ## @@ -565,8 +566,8 @@ private void recordRebala

[GitHub] [kafka] omkreddy commented on pull request #8700: MINOR: Increase gradle daemon’s heap size to 2g

2020-05-20 Thread GitBox
omkreddy commented on pull request #8700: URL: https://github.com/apache/kafka/pull/8700#issuecomment-631829621 Merging as test failures are not related, This is an automated message from the Apache Git Service. To respond to

[GitHub] [kafka] omkreddy merged pull request #8700: MINOR: Increase gradle daemon’s heap size to 2g

2020-05-20 Thread GitBox
omkreddy merged pull request #8700: URL: https://github.com/apache/kafka/pull/8700 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] guozhangwang commented on pull request #8698: KAFKA-10022:console-producer supports the setting of client.id

2020-05-20 Thread GitBox
guozhangwang commented on pull request #8698: URL: https://github.com/apache/kafka/pull/8698#issuecomment-631837548 test this This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] guozhangwang commented on pull request #8698: KAFKA-10022:console-producer supports the setting of client.id

2020-05-20 Thread GitBox
guozhangwang commented on pull request #8698: URL: https://github.com/apache/kafka/pull/8698#issuecomment-631837772 test this please This is an automated message from the Apache Git Service. To respond to the message, please

  1   2   >