[GitHub] [kafka] guozhangwang merged pull request #8671: KAFKA-9859 / Add topics generated by KTable FK join to internal topic matching logic

2020-05-20 Thread GitBox
guozhangwang merged pull request #8671: URL: https://github.com/apache/kafka/pull/8671 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (KAFKA-6579) Consolidate window store and session store unit tests into a single class

2020-05-20 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-6579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17112447#comment-17112447 ] Guozhang Wang commented on KAFKA-6579: -- [~mikulskibartosz] please feel free to take

[GitHub] [kafka] ijuma commented on pull request #8695: KAFKA-9320: KIP-573 - Enable TLSv1.3 by default

2020-05-20 Thread GitBox
ijuma commented on pull request #8695: URL: https://github.com/apache/kafka/pull/8695#issuecomment-631601762 One question: any downside to setting `ssl.protocol=TLSv1.3` instead of `ssl.protocol=TLSv1.2`? This is an automate

[GitHub] [kafka] ableegoldman commented on a change in pull request #8677: KAFKA-9999: Make internal topic creation error non-fatal

2020-05-20 Thread GitBox
ableegoldman commented on a change in pull request #8677: URL: https://github.com/apache/kafka/pull/8677#discussion_r428166926 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopicManager.java ## @@ -171,7 +173,7 @@ public InternalTopic

[GitHub] [kafka] vvcephei commented on a change in pull request #8677: KAFKA-9999: Make internal topic creation error non-fatal

2020-05-20 Thread GitBox
vvcephei commented on a change in pull request #8677: URL: https://github.com/apache/kafka/pull/8677#discussion_r428152062 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopicManager.java ## @@ -171,7 +173,7 @@ public InternalTopicMana

[GitHub] [kafka] ijuma commented on a change in pull request #8695: KAFKA-9320: KIP-573 - Enable TLSv1.3 by default

2020-05-20 Thread GitBox
ijuma commented on a change in pull request #8695: URL: https://github.com/apache/kafka/pull/8695#discussion_r428153104 ## File path: clients/src/test/java/org/apache/kafka/common/network/SslTransportLayerTest.java ## @@ -622,6 +622,34 @@ public void testUnsupportedTLSVersion(

[GitHub] [kafka] ijuma commented on a change in pull request #8695: KAFKA-9320: KIP-573 - Enable TLSv1.3 by default

2020-05-20 Thread GitBox
ijuma commented on a change in pull request #8695: URL: https://github.com/apache/kafka/pull/8695#discussion_r428020072 ## File path: clients/src/test/java/org/apache/kafka/common/network/SslTransportLayerTest.java ## @@ -622,6 +622,34 @@ public void testUnsupportedTLSVersion(

[GitHub] [kafka] rhauch commented on a change in pull request #8357: KAFKA-9767: Add logging to basic auth rest extension

2020-05-20 Thread GitBox
rhauch commented on a change in pull request #8357: URL: https://github.com/apache/kafka/pull/8357#discussion_r428132065 ## File path: connect/basic-auth-extension/src/main/java/org/apache/kafka/connect/rest/basic/auth/extension/JaasBasicAuthFilter.java ## @@ -67,36 +87,60 @@

[GitHub] [kafka] wj1918 edited a comment on pull request #8612: KAFKA-8120 Getting NegativeArraySizeException when using Kafka Connect

2020-05-20 Thread GitBox
wj1918 edited a comment on pull request #8612: URL: https://github.com/apache/kafka/pull/8612#issuecomment-631579687 call for reviewers @kkonstantine @phstudy @ewencp @hachikuji should have separate commit of refactoring and bug fix. but it is a fairly safe fix. --

[GitHub] [kafka] wj1918 commented on pull request #8612: KAFKA-8120 Getting NegativeArraySizeException when using Kafka Connect

2020-05-20 Thread GitBox
wj1918 commented on pull request #8612: URL: https://github.com/apache/kafka/pull/8612#issuecomment-631579687 call for reviewers @kkonstantine @phstudy @ewencp @hachikuji should have separate refactoring code with the bug fix code. but it is a fairly safe fix.

[jira] [Updated] (KAFKA-10022) console-producer supports the setting of client.id

2020-05-20 Thread Young Chou (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10022?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Young Chou updated KAFKA-10022: --- Description: "console-producer" supports the setting of "client.id", which is a reasonable requirem

[GitHub] [kafka] xinzhuxiansheng opened a new pull request #8698: console-producer supports the setting of client.id

2020-05-20 Thread GitBox
xinzhuxiansheng opened a new pull request #8698: URL: https://github.com/apache/kafka/pull/8698 https://issues.apache.org/jira/browse/KAFKA-10022 "console-producer" supports the setting of "client.id", which is a reasonable requirement, and the way "console consumer" and "console pro

[GitHub] [kafka] xinzhuxiansheng closed pull request #8694: KAFKA-10022: console-producer supports the setting of client.id

2020-05-20 Thread GitBox
xinzhuxiansheng closed pull request #8694: URL: https://github.com/apache/kafka/pull/8694 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [kafka] rhauch commented on pull request #8357: KAFKA-9767: Add logging to basic auth rest extension

2020-05-20 Thread GitBox
rhauch commented on pull request #8357: URL: https://github.com/apache/kafka/pull/8357#issuecomment-631562562 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [kafka] nizhikov commented on a change in pull request #8695: KAFKA-9320: KIP-573 - Enable TLSv1.3 by default

2020-05-20 Thread GitBox
nizhikov commented on a change in pull request #8695: URL: https://github.com/apache/kafka/pull/8695#discussion_r428114569 ## File path: clients/src/test/java/org/apache/kafka/common/network/SslTransportLayerTest.java ## @@ -622,6 +622,34 @@ public void testUnsupportedTLSVersi

[GitHub] [kafka] vvcephei commented on a change in pull request #8679: KAFKA-10003: Mark KStream.through() as deprecated

2020-05-20 Thread GitBox
vvcephei commented on a change in pull request #8679: URL: https://github.com/apache/kafka/pull/8679#discussion_r428055668 ## File path: streams/streams-scala/src/main/scala/org/apache/kafka/streams/scala/kstream/KStream.scala ## @@ -232,10 +232,53 @@ class KStream[K, V](val i

[jira] [Assigned] (KAFKA-7631) NullPointerException when SCRAM is allowed bu ScramLoginModule is not in broker's jaas.conf

2020-05-20 Thread Jun Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7631?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Wang reassigned KAFKA-7631: --- Assignee: (was: Jun Wang) > NullPointerException when SCRAM is allowed bu ScramLoginModule is no

[GitHub] [kafka] ijuma commented on a change in pull request #8695: KAFKA-9320: KIP-573 - Enable TLSv1.3 by default

2020-05-20 Thread GitBox
ijuma commented on a change in pull request #8695: URL: https://github.com/apache/kafka/pull/8695#discussion_r428020072 ## File path: clients/src/test/java/org/apache/kafka/common/network/SslTransportLayerTest.java ## @@ -622,6 +622,34 @@ public void testUnsupportedTLSVersion(

[jira] [Comment Edited] (KAFKA-6520) When a Kafka Stream can't communicate with the server, it's Status stays RUNNING

2020-05-20 Thread Vince Mu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-6520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17112118#comment-17112118 ] Vince Mu edited comment on KAFKA-6520 at 5/20/20, 12:58 PM: I

[jira] [Commented] (KAFKA-6520) When a Kafka Stream can't communicate with the server, it's Status stays RUNNING

2020-05-20 Thread Vince Mu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-6520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17112118#comment-17112118 ] Vince Mu commented on KAFKA-6520: - I think the easiest and perhaps simplest way is to che

[GitHub] [kafka] kowshik commented on a change in pull request #8680: KAFKA-9755: Implement read path for feature versioning system (KIP-584)

2020-05-20 Thread GitBox
kowshik commented on a change in pull request #8680: URL: https://github.com/apache/kafka/pull/8680#discussion_r427022316 ## File path: clients/src/main/java/org/apache/kafka/common/feature/Features.java ## @@ -0,0 +1,143 @@ +package org.apache.kafka.common.feature; + +import j

[jira] [Resolved] (KAFKA-10026) KIP-584: Implement read path for versioning scheme for features

2020-05-20 Thread Kowshik Prakasam (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kowshik Prakasam resolved KAFKA-10026. -- Resolution: Duplicate Duplicate of KAFKA-10027 > KIP-584: Implement read path for ver

[jira] [Created] (KAFKA-10027) KIP-584: Implement read path for versioning scheme for features

2020-05-20 Thread Kowshik Prakasam (Jira)
Kowshik Prakasam created KAFKA-10027: Summary: KIP-584: Implement read path for versioning scheme for features Key: KAFKA-10027 URL: https://issues.apache.org/jira/browse/KAFKA-10027 Project: Kafk

[jira] [Created] (KAFKA-10026) KIP-584: Implement read path for versioning scheme for features

2020-05-20 Thread Kowshik Prakasam (Jira)
Kowshik Prakasam created KAFKA-10026: Summary: KIP-584: Implement read path for versioning scheme for features Key: KAFKA-10026 URL: https://issues.apache.org/jira/browse/KAFKA-10026 Project: Kafk

[jira] [Updated] (KAFKA-9755) Implement versioning scheme for features

2020-05-20 Thread Kowshik Prakasam (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9755?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kowshik Prakasam updated KAFKA-9755: Description: Details are in this wiki: [https://cwiki.apache.org/confluence/display/KAFKA/

[GitHub] [kafka] ake1234 commented on pull request #7070: KAFKA-7157: Fix handling of nulls in TimestampConverter

2020-05-20 Thread GitBox
ake1234 commented on pull request #7070: URL: https://github.com/apache/kafka/pull/7070#issuecomment-631346141 I'm also using this SMT but its throws null pointer exception for null timestamp values. Can someone help us how to implement this changes. -

[GitHub] [kafka] nizhikov edited a comment on pull request #8695: KAFKA-9320: KIP-573 - Enable TLSv1.3 by default

2020-05-20 Thread GitBox
nizhikov edited a comment on pull request #8695: URL: https://github.com/apache/kafka/pull/8695#issuecomment-631328373 @ijuma Looks like tests are OK. Please, take a look at this preliminary PR. This is an automated messag

[GitHub] [kafka] nizhikov commented on pull request #8695: KAFKA-9320: KIP-573 - Enable TLSv1.3 by default

2020-05-20 Thread GitBox
nizhikov commented on pull request #8695: URL: https://github.com/apache/kafka/pull/8695#issuecomment-631328373 @ijuma Looks like tests is OK. Please, take a look at this preliminary PR. This is an automated message from t

[jira] [Commented] (KAFKA-9747) No tasks created for a connector

2020-05-20 Thread Le Thanh Duong (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17111918#comment-17111918 ] Le Thanh Duong commented on KAFKA-9747: --- I also stuck with the sample problem, task

[jira] [Commented] (KAFKA-6579) Consolidate window store and session store unit tests into a single class

2020-05-20 Thread Bartosz Mikulski (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-6579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17111880#comment-17111880 ] Bartosz Mikulski commented on KAFKA-6579: - If nobody is working on it right now,

[GitHub] [kafka] feyman2016 commented on pull request #8589: KAFKA-9146: KIP-571 Add option to force delete active members in StreamsResetter

2020-05-20 Thread GitBox
feyman2016 commented on pull request #8589: URL: https://github.com/apache/kafka/pull/8589#issuecomment-631299671 @abbccdda Thanks, will try my best to get this into 2.6 This is an automated message from the Apache Git Servic

[jira] [Commented] (KAFKA-8638) Preferred Leader Blacklist (deprioritized list)

2020-05-20 Thread GEORGE LI (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17111858#comment-17111858 ] GEORGE LI commented on KAFKA-8638: -- [~hai_lin] some of the recent activities about KIP-

<    1   2