[GitHub] [kafka] asdaraujo opened a new pull request #8730: KAFKA-10048: Possible data gap for a consumer after a failover when u…

2020-05-26 Thread GitBox
asdaraujo opened a new pull request #8730: URL: https://github.com/apache/kafka/pull/8730 Changed the MM2 checkpoint mirror task to ensure it replicates consumer offsets even when they are equal to zero to avoid issues with consumers after failovers. Modified the test case to cover

[GitHub] [kafka] kkonstantine commented on a change in pull request #8699: KAFKA-9673: Filter and Conditional SMTs

2020-05-26 Thread GitBox
kkonstantine commented on a change in pull request #8699: URL: https://github.com/apache/kafka/pull/8699#discussion_r430867370 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/ConnectorConfig.java ## @@ -257,12 +274,23 @@ public boolean includeRecor

[jira] [Created] (KAFKA-10048) Possible data gap for a consumer after a failover when using MM2

2020-05-26 Thread Andre Araujo (Jira)
Andre Araujo created KAFKA-10048: Summary: Possible data gap for a consumer after a failover when using MM2 Key: KAFKA-10048 URL: https://issues.apache.org/jira/browse/KAFKA-10048 Project: Kafka

[GitHub] [kafka] aakashnshah commented on a change in pull request #8720: KAFKA-9971: Error Reporting in Sink Connectors

2020-05-26 Thread GitBox
aakashnshah commented on a change in pull request #8720: URL: https://github.com/apache/kafka/pull/8720#discussion_r430866479 ## File path: connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerErrantRecordReporterTest.java ## @@ -0,0 +1,63 @@ +/* + * Licensed t

[GitHub] [kafka] aakashnshah commented on a change in pull request #8720: KAFKA-9971: Error Reporting in Sink Connectors

2020-05-26 Thread GitBox
aakashnshah commented on a change in pull request #8720: URL: https://github.com/apache/kafka/pull/8720#discussion_r430866143 ## File path: connect/runtime/src/test/java/org/apache/kafka/connect/integration/ExampleConnectIntegrationTest.java ## @@ -214,6 +218,72 @@ public void

[GitHub] [kafka] aakashnshah commented on a change in pull request #8720: KAFKA-9971: Error Reporting in Sink Connectors

2020-05-26 Thread GitBox
aakashnshah commented on a change in pull request #8720: URL: https://github.com/apache/kafka/pull/8720#discussion_r430865592 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerErrantRecordReporter.java ## @@ -0,0 +1,198 @@ +/* + * Licensed to t

[GitHub] [kafka] aakashnshah commented on a change in pull request #8720: KAFKA-9971: Error Reporting in Sink Connectors

2020-05-26 Thread GitBox
aakashnshah commented on a change in pull request #8720: URL: https://github.com/apache/kafka/pull/8720#discussion_r430865210 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerErrantRecordReporter.java ## @@ -0,0 +1,198 @@ +/* + * Licensed to t

[GitHub] [kafka] aakashnshah commented on a change in pull request #8720: KAFKA-9971: Error Reporting in Sink Connectors

2020-05-26 Thread GitBox
aakashnshah commented on a change in pull request #8720: URL: https://github.com/apache/kafka/pull/8720#discussion_r430864187 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerErrantRecordReporter.java ## @@ -0,0 +1,198 @@ +/* + * Licensed to t

[GitHub] [kafka] aakashnshah commented on a change in pull request #8720: KAFKA-9971: Error Reporting in Sink Connectors

2020-05-26 Thread GitBox
aakashnshah commented on a change in pull request #8720: URL: https://github.com/apache/kafka/pull/8720#discussion_r430863637 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java ## @@ -695,6 +705,32 @@ ErrorHandlingMetrics errorHandlingMetr

[GitHub] [kafka] aakashnshah commented on a change in pull request #8720: KAFKA-9971: Error Reporting in Sink Connectors

2020-05-26 Thread GitBox
aakashnshah commented on a change in pull request #8720: URL: https://github.com/apache/kafka/pull/8720#discussion_r430863006 ## File path: connect/api/src/main/java/org/apache/kafka/connect/sink/ErrantRecordReporter.java ## @@ -0,0 +1,41 @@ +/* + * Licensed to the Apache Soft

[jira] [Updated] (KAFKA-5295) Allow Kafka Connect source connectors to specify topic-specific settings for new topics

2020-05-26 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-5295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis updated KAFKA-5295: -- Fix Version/s: 2.6.0 > Allow Kafka Connect source connectors to specify topic-s

[jira] [Resolved] (KAFKA-5295) Allow Kafka Connect source connectors to specify topic-specific settings for new topics

2020-05-26 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-5295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis resolved KAFKA-5295. --- Resolution: Fixed > Allow Kafka Connect source connectors to specify topic-sp

[GitHub] [kafka] aakashnshah commented on a change in pull request #8720: KAFKA-9971: Error Reporting in Sink Connectors

2020-05-26 Thread GitBox
aakashnshah commented on a change in pull request #8720: URL: https://github.com/apache/kafka/pull/8720#discussion_r430860854 ## File path: connect/api/src/main/java/org/apache/kafka/connect/sink/ErrantRecordReporter.java ## @@ -0,0 +1,41 @@ +/* + * Licensed to the Apache Soft

[GitHub] [kafka] kkonstantine merged pull request #8722: KAFKA-5295: Allow source connectors to specify topic-specific settings for new topics (KIP-158)

2020-05-26 Thread GitBox
kkonstantine merged pull request #8722: URL: https://github.com/apache/kafka/pull/8722 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] kkonstantine commented on pull request #8722: KAFKA-5295: Allow source connectors to specify topic-specific settings for new topics (KIP-158)

2020-05-26 Thread GitBox
kkonstantine commented on pull request #8722: URL: https://github.com/apache/kafka/pull/8722#issuecomment-634430019 jdk8: success jdk11: only two failures on a known flaky streams test (`EosBetaUpgradeIntegrationTest`) jdk14: a single failure on another unrelated streams test (`KTabl

[GitHub] [kafka] mjsax commented on pull request #7886: KAFKA-9353: Add groupInstanceId to DescribeGroup for better visibility

2020-05-26 Thread GitBox
mjsax commented on pull request #7886: URL: https://github.com/apache/kafka/pull/7886#issuecomment-634407508 Retest this please. This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] vvcephei commented on a change in pull request #8697: KAFKA-9983: KIP-613, add INFO level e2e latency metrics

2020-05-26 Thread GitBox
vvcephei commented on a change in pull request #8697: URL: https://github.com/apache/kafka/pull/8697#discussion_r430846939 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java ## @@ -586,6 +606,7 @@ public boolean process(final long

[GitHub] [kafka] ableegoldman commented on a change in pull request #8248: KAFKA-9501: convert between active and standby without closing stores

2020-05-26 Thread GitBox
ableegoldman commented on a change in pull request #8248: URL: https://github.com/apache/kafka/pull/8248#discussion_r430838846 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/ChangelogReader.java ## @@ -45,12 +44,6 @@ */ Set complete

[GitHub] [kafka] ijuma merged pull request #8708: MINOR: avoid unnecessary seq iteration in ApiVersion.lastVersion

2020-05-26 Thread GitBox
ijuma merged pull request #8708: URL: https://github.com/apache/kafka/pull/8708 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] abbccdda commented on pull request #8549: KAFKA-9911: Add new PRODUCER_FENCED error code

2020-05-26 Thread GitBox
abbccdda commented on pull request #8549: URL: https://github.com/apache/kafka/pull/8549#issuecomment-633787779 Only failed with known flaky test: ``` org.apache.kafka.streams.integration.EosBetaUpgradeIntegrationTest.shouldUpgradeFromEosAlphaToEosBeta[true] ``` -

[GitHub] [kafka] chia7712 commented on a change in pull request #8657: KAFKA-8334 Make sure the thread which tries to complete delayed reque…

2020-05-26 Thread GitBox
chia7712 commented on a change in pull request #8657: URL: https://github.com/apache/kafka/pull/8657#discussion_r430253921 ## File path: core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala ## @@ -769,20 +813,25 @@ class GroupCoordinator(val brokerId: Int,

[GitHub] [kafka] hachikuji commented on a change in pull request #8709: KAFKA-9952; Remove immediate fetch completion logic on high watermark updates

2020-05-26 Thread GitBox
hachikuji commented on a change in pull request #8709: URL: https://github.com/apache/kafka/pull/8709#discussion_r430546391 ## File path: core/src/main/scala/kafka/server/DelayedFetch.scala ## @@ -120,14 +119,6 @@ class DelayedFetch(delayMs: Long, accumulated

[GitHub] [kafka] mjsax merged pull request #8395: Added doc for KIP-535 and updated it for KIP-562

2020-05-26 Thread GitBox
mjsax merged pull request #8395: URL: https://github.com/apache/kafka/pull/8395 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] ableegoldman commented on a change in pull request #8697: KAFKA-9983: KIP-613, add INFO level e2e latency metrics

2020-05-26 Thread GitBox
ableegoldman commented on a change in pull request #8697: URL: https://github.com/apache/kafka/pull/8697#discussion_r430707581 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorContextImpl.java ## @@ -223,6 +223,9 @@ public StateStore ge

[GitHub] [kafka] nizhikov commented on pull request #8695: KAFKA-9320: KIP-573 - Enable TLSv1.3 by default

2020-05-26 Thread GitBox
nizhikov commented on pull request #8695: URL: https://github.com/apache/kafka/pull/8695#issuecomment-634055561 retest this, please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] ijuma opened a new pull request #8726: MINOR: Remove unused `Json.legacyEncodeAsString`

2020-05-26 Thread GitBox
ijuma opened a new pull request #8726: URL: https://github.com/apache/kafka/pull/8726 Updated a couple of test usages not to rely on it and removed the tests for the removed method. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation

[GitHub] [kafka] vvcephei commented on a change in pull request #8716: KAFKA-6145: KIP-441: Fix assignor config passthough

2020-05-26 Thread GitBox
vvcephei commented on a change in pull request #8716: URL: https://github.com/apache/kafka/pull/8716#discussion_r430668785 ## File path: streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java ## @@ -1148,6 +1148,9 @@ private void verifyMaxInFlightRequestPerConnection

[GitHub] [kafka] abbccdda opened a new pull request #8725: KAFKA-9608: Transaction Event Simulation Test

2020-05-26 Thread GitBox
abbccdda opened a new pull request #8725: URL: https://github.com/apache/kafka/pull/8725 Start the basic template for transaction event simulation. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI bu

[GitHub] [kafka] ijuma commented on a change in pull request #8605: MINOR: align the constructor of KafkaConsumer to KafkaProducer

2020-05-26 Thread GitBox
ijuma commented on a change in pull request #8605: URL: https://github.com/apache/kafka/pull/8605#discussion_r430426504 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerConfig.java ## @@ -573,18 +573,6 @@ private void maybeOverrideClientId(Map con

[GitHub] [kafka] abbccdda opened a new pull request #8729: KC-276: Enhanced raft exception handling

2020-05-26 Thread GitBox
abbccdda opened a new pull request #8729: URL: https://github.com/apache/kafka/pull/8729 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of testing

[GitHub] [kafka] vvcephei removed a comment on pull request #6824: KAFKA-7523: Add ConnectedStoreProvider to Processor API

2020-05-26 Thread GitBox
vvcephei removed a comment on pull request #6824: URL: https://github.com/apache/kafka/pull/6824#issuecomment-634107013 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [kafka] vvcephei commented on pull request #6824: KAFKA-7523: Add ConnectedStoreProvider to Processor API

2020-05-26 Thread GitBox
vvcephei commented on pull request #6824: URL: https://github.com/apache/kafka/pull/6824#issuecomment-634107013 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [kafka] mjsax commented on a change in pull request #6824: KAFKA-7523: Add ConnectedStoreProvider to Processor API

2020-05-26 Thread GitBox
mjsax commented on a change in pull request #6824: URL: https://github.com/apache/kafka/pull/6824#discussion_r430786602 ## File path: docs/streams/developer-guide/dsl-api.html ## @@ -3533,10 +3533,17 @@ KTable-KTable Foreign-Key Tip

[GitHub] [kafka] aakashnshah commented on a change in pull request #8720: KAFKA-9971: Error Reporting in Sink Connectors

2020-05-26 Thread GitBox
aakashnshah commented on a change in pull request #8720: URL: https://github.com/apache/kafka/pull/8720#discussion_r430831919 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerErrantRecordReporter.java ## @@ -0,0 +1,198 @@ +/* + * Licensed to t

[GitHub] [kafka] abbccdda commented on a change in pull request #8549: KAFKA-9911: Add new PRODUCER_FENCED error code

2020-05-26 Thread GitBox
abbccdda commented on a change in pull request #8549: URL: https://github.com/apache/kafka/pull/8549#discussion_r430137301 ## File path: clients/src/main/java/org/apache/kafka/common/errors/InvalidProducerEpochException.java ## @@ -0,0 +1,31 @@ +/* + * Licensed to the Apache S

[GitHub] [kafka] vvcephei commented on pull request #8716: KAFKA-6145: KIP-441: Fix assignor config passthough

2020-05-26 Thread GitBox
vvcephei commented on pull request #8716: URL: https://github.com/apache/kafka/pull/8716#issuecomment-634333269 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [kafka] vvcephei commented on a change in pull request #8697: KAFKA-9983: KIP-613, add INFO level e2e latency metrics

2020-05-26 Thread GitBox
vvcephei commented on a change in pull request #8697: URL: https://github.com/apache/kafka/pull/8697#discussion_r430575822 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/metrics/StreamsMetricsImpl.java ## @@ -149,6 +154,10 @@ public int hashCo

[GitHub] [kafka] ijuma commented on pull request #8695: KAFKA-9320: KIP-573 - Enable TLSv1.3 by default

2020-05-26 Thread GitBox
ijuma commented on pull request #8695: URL: https://github.com/apache/kafka/pull/8695#issuecomment-633687352 A few failures seem related to the changes in this PR: > kafka.network.SocketServerTest.testConnectionIdReuse > kafka.network.SocketServerTest.remoteCloseWithBufferedReceive

[GitHub] [kafka] xvrl commented on a change in pull request #8691: KAFKA-9960: implement KIP-606 to add metadata context to MetricsReporter

2020-05-26 Thread GitBox
xvrl commented on a change in pull request #8691: URL: https://github.com/apache/kafka/pull/8691#discussion_r430557121 ## File path: clients/src/main/java/org/apache/kafka/common/metrics/MetricsContext.java ## @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] rhauch commented on a change in pull request #8722: KAFKA-5295: Allow source connectors to specify topic-specific settings for new topics (KIP-158)

2020-05-26 Thread GitBox
rhauch commented on a change in pull request #8722: URL: https://github.com/apache/kafka/pull/8722#discussion_r429994168 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java ## @@ -678,7 +701,8 @@ ErrorHandlingMetrics errorHandlingMetrics(Co

[GitHub] [kafka] ijuma commented on pull request #8709: KAFKA-9952; Remove immediate fetch completion logic on high watermark updates

2020-05-26 Thread GitBox
ijuma commented on pull request #8709: URL: https://github.com/apache/kafka/pull/8709#issuecomment-634126643 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [kafka] ijuma commented on pull request #8728: MINOR: Slight MetadataCache tweaks to avoid unnecessary work

2020-05-26 Thread GitBox
ijuma commented on pull request #8728: URL: https://github.com/apache/kafka/pull/8728#issuecomment-634194854 `foreachEntry` doesn't exist in Scala 2.12, so will have to revert that change. This is an automated message from t

[GitHub] [kafka] vvcephei commented on a change in pull request #6824: KAFKA-7523: Add ConnectedStoreProvider to Processor API

2020-05-26 Thread GitBox
vvcephei commented on a change in pull request #6824: URL: https://github.com/apache/kafka/pull/6824#discussion_r430521738 ## File path: docs/streams/developer-guide/processor-api.html ## @@ -409,7 +405,31 @@ Connecting Processors and State Stores"sink-topic" Kafka topic (not

[GitHub] [kafka] hachikuji commented on pull request #8709: KAFKA-9952; Remove immediate fetch completion logic on high watermark updates

2020-05-26 Thread GitBox
hachikuji commented on pull request #8709: URL: https://github.com/apache/kafka/pull/8709#issuecomment-634124729 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka] MuqadderIqbal commented on pull request #6329: KAFKA-1194: Fix renaming open files on Windows

2020-05-26 Thread GitBox
MuqadderIqbal commented on pull request #6329: URL: https://github.com/apache/kafka/pull/6329#issuecomment-633726540 Hi all, very pleased to see the contributors/maintainers taking a longer but safer approach in getting this fixed on Windows. Much appreciated! Can someone please look into

[GitHub] [kafka] kkonstantine commented on a change in pull request #8722: KAFKA-5295: Allow source connectors to specify topic-specific settings for new topics (KIP-158)

2020-05-26 Thread GitBox
kkonstantine commented on a change in pull request #8722: URL: https://github.com/apache/kafka/pull/8722#discussion_r430089754 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java ## @@ -678,7 +701,8 @@ ErrorHandlingMetrics errorHandlingMetr

[GitHub] [kafka] wj1918 opened a new pull request #8727: KAFKA-8120 Getting NegativeArraySizeException when using Kafka Connect

2020-05-26 Thread GitBox
wj1918 opened a new pull request #8727: URL: https://github.com/apache/kafka/pull/8727 Bug fix only, [JIRA]( https://issues.apache.org/jira/browse/KAFKA-8120) 1. The Outer loop Issue, at Original line 134 of FileStreamSourceTask.java while (readerCopy.ready()) { Since the

[GitHub] [kafka] mumrah commented on a change in pull request #8691: KAFKA-9960: implement KIP-606 to add metadata context to MetricsReporter

2020-05-26 Thread GitBox
mumrah commented on a change in pull request #8691: URL: https://github.com/apache/kafka/pull/8691#discussion_r430482879 ## File path: core/src/main/scala/kafka/server/KafkaServer.scala ## @@ -129,7 +129,10 @@ class KafkaServer(val config: KafkaConfig, time: Time = Time.SYSTEM

[GitHub] [kafka] ijuma commented on pull request #8726: MINOR: Remove unused `Json.legacyEncodeAsString`

2020-05-26 Thread GitBox
ijuma commented on pull request #8726: URL: https://github.com/apache/kafka/pull/8726#issuecomment-634290104 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [kafka] hachikuji commented on pull request #8376: KAFKA-9724 Newer clients not always sending fetch request to older brokers

2020-05-26 Thread GitBox
hachikuji commented on pull request #8376: URL: https://github.com/apache/kafka/pull/8376#issuecomment-633682056 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka] rajinisivaram commented on pull request #8705: KAFKA-10029; Don't update completedReceives when channels are closed to avoid ConcurrentModificationException

2020-05-26 Thread GitBox
rajinisivaram commented on pull request #8705: URL: https://github.com/apache/kafka/pull/8705#issuecomment-633934633 @ijuma By not updating `completedReceives` when the channel is closed, we retain a reference to the channel until the next `poll()`. In terms of receives themselves, there i

[GitHub] [kafka] cemo commented on pull request #8540: KAFKA-9127: don't create StreamThreads for global-only topology

2020-05-26 Thread GitBox
cemo commented on pull request #8540: URL: https://github.com/apache/kafka/pull/8540#issuecomment-634010610 @mjarvie when this fix will be released? This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] pgwhalen commented on a change in pull request #6824: KAFKA-7523: Add ConnectedStoreProvider to Processor API

2020-05-26 Thread GitBox
pgwhalen commented on a change in pull request #6824: URL: https://github.com/apache/kafka/pull/6824#discussion_r430608121 ## File path: streams/examples/src/main/java/org/apache/kafka/streams/examples/wordcount/WordCountProcessorDemo.java ## @@ -93,8 +93,6 @@ public void proc

[GitHub] [kafka] junrao commented on a change in pull request #8657: KAFKA-8334 Make sure the thread which tries to complete delayed reque…

2020-05-26 Thread GitBox
junrao commented on a change in pull request #8657: URL: https://github.com/apache/kafka/pull/8657#discussion_r428949769 ## File path: core/src/main/scala/kafka/server/ReplicaManager.scala ## @@ -550,19 +584,22 @@ class ReplicaManager(val config: KafkaConfig, * Append messa

[GitHub] [kafka] mimaison commented on pull request #8238: KAFKA-9130: KIP-518 Allow listing consumer groups per state

2020-05-26 Thread GitBox
mimaison commented on pull request #8238: URL: https://github.com/apache/kafka/pull/8238#issuecomment-634249266 @hachikuji Yes I think it's better this way. I'll update the KIP This is an automated message from the Apache Git

[GitHub] [kafka] rhauch commented on pull request #8691: KAFKA-9960: implement KIP-606 to add metadata context to MetricsReporter

2020-05-26 Thread GitBox
rhauch commented on pull request #8691: URL: https://github.com/apache/kafka/pull/8691#issuecomment-634339348 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [kafka] rhauch commented on a change in pull request #8720: KAFKA-9971: Error Reporting in Sink Connectors

2020-05-26 Thread GitBox
rhauch commented on a change in pull request #8720: URL: https://github.com/apache/kafka/pull/8720#discussion_r429975231 ## File path: connect/api/src/main/java/org/apache/kafka/connect/sink/ErrantRecordReporter.java ## @@ -0,0 +1,41 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] ijuma edited a comment on pull request #8709: KAFKA-9952; Remove immediate fetch completion logic on high watermark updates

2020-05-26 Thread GitBox
ijuma edited a comment on pull request #8709: URL: https://github.com/apache/kafka/pull/8709#issuecomment-634126643 Makes sense, let me review this one as it stands then. This is an automated message from the Apache Git Servi

[GitHub] [kafka] ijuma commented on pull request #8376: KAFKA-9724 Newer clients not always sending fetch request to older brokers

2020-05-26 Thread GitBox
ijuma commented on pull request #8376: URL: https://github.com/apache/kafka/pull/8376#issuecomment-633684708 Sounds good. This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [kafka] guozhangwang commented on pull request #8698: KAFKA-10022:console-producer supports the setting of client.id

2020-05-26 Thread GitBox
guozhangwang commented on pull request #8698: URL: https://github.com/apache/kafka/pull/8698#issuecomment-633667449 Before this patch, the client.id set in the config file would be overridden. This is an automated message fro

[GitHub] [kafka] kowshik commented on a change in pull request #8680: KAFKA-10027: Implement read path for feature versioning system (KIP-584)

2020-05-26 Thread GitBox
kowshik commented on a change in pull request #8680: URL: https://github.com/apache/kafka/pull/8680#discussion_r429593151 ## File path: core/src/main/scala/kafka/server/FinalizedFeatureChangeListener.scala ## @@ -0,0 +1,232 @@ +package kafka.server + +import java.util.concurren

[GitHub] [kafka] hachikuji commented on pull request #7886: KAFKA-9353: Add groupInstanceId to DescribeGroup for better visibility

2020-05-26 Thread GitBox
hachikuji commented on pull request #7886: URL: https://github.com/apache/kafka/pull/7886#issuecomment-634362859 retest this please This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [kafka] guozhangwang removed a comment on pull request #8221: KAFKA-9561: update task input partitions after rebalance

2020-05-26 Thread GitBox
guozhangwang removed a comment on pull request #8221: URL: https://github.com/apache/kafka/pull/8221#issuecomment-634135838 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] d8tltanc closed pull request #8615: KAFKA-9954: Config command didn't validate the unsupported user config change

2020-05-26 Thread GitBox
d8tltanc closed pull request #8615: URL: https://github.com/apache/kafka/pull/8615 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] abbccdda commented on pull request #8589: KAFKA-9146: KIP-571 Add option to force delete active members in StreamsResetter

2020-05-26 Thread GitBox
abbccdda commented on pull request #8589: URL: https://github.com/apache/kafka/pull/8589#issuecomment-633733992 Only known flaky EOS tests are failing: ``` org.apache.kafka.streams.integration.EosBetaUpgradeIntegrationTest.shouldUpgradeFromEosAlphaToEosBeta[false] org.apache.kafka

[GitHub] [kafka] xiaodongdu commented on a change in pull request #8691: KAFKA-9960: implement KIP-606 to add metadata context to MetricsReporter

2020-05-26 Thread GitBox
xiaodongdu commented on a change in pull request #8691: URL: https://github.com/apache/kafka/pull/8691#discussion_r430590488 ## File path: core/src/main/scala/kafka/server/KafkaServer.scala ## @@ -129,7 +129,10 @@ class KafkaServer(val config: KafkaConfig, time: Time = Time.SY

[GitHub] [kafka] mjsax commented on pull request #8697: KAFKA-9983: KIP-613, add INFO level e2e latency metrics

2020-05-26 Thread GitBox
mjsax commented on pull request #8697: URL: https://github.com/apache/kafka/pull/8697#issuecomment-634329391 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [kafka] mjsax commented on pull request #8395: Added doc for KIP-535 and updated it for KIP-562

2020-05-26 Thread GitBox
mjsax commented on pull request #8395: URL: https://github.com/apache/kafka/pull/8395#issuecomment-634332833 Merged to `trunk` and cherry-picked to `2.5`. Thanks for the PR @brary! Can you also do a PR against `kafka-site` repository so we can get this updates into the web page right

[GitHub] [kafka] chia7712 commented on pull request #8685: KAFKA-10014 Always try to close all channels in Selector#close

2020-05-26 Thread GitBox
chia7712 commented on pull request #8685: URL: https://github.com/apache/kafka/pull/8685#issuecomment-634167948 retest this please This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [kafka] viktorsomogyi commented on pull request #5620: KAFKA-1880: Add support for checking binary/source compatibility

2020-05-26 Thread GitBox
viktorsomogyi commented on pull request #5620: URL: https://github.com/apache/kafka/pull/5620#issuecomment-634040488 @cmccabe just checking back, would you please let me know if you have time ro review this or shall we postpone it? -

[GitHub] [kafka] pgwhalen commented on pull request #6824: KAFKA-7523: Add ConnectedStoreProvider to Processor API

2020-05-26 Thread GitBox
pgwhalen commented on pull request #6824: URL: https://github.com/apache/kafka/pull/6824#issuecomment-633703760 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [kafka] mjsax commented on a change in pull request #8697: KAFKA-9983: KIP-613, add INFO level e2e latency metrics

2020-05-26 Thread GitBox
mjsax commented on a change in pull request #8697: URL: https://github.com/apache/kafka/pull/8697#discussion_r430753853 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/metrics/StreamsMetricsImpl.java ## @@ -149,6 +154,10 @@ public int hashCode(

[GitHub] [kafka] guozhangwang commented on pull request #8248: KAFKA-9501: convert between active and standby without closing stores

2020-05-26 Thread GitBox
guozhangwang commented on pull request #8248: URL: https://github.com/apache/kafka/pull/8248#issuecomment-634133973 `streams:test-utils:checkstyleMain` failed. This is an automated message from the Apache Git Service. To resp

[GitHub] [kafka] d8tltanc commented on pull request #8615: KAFKA-9954: Config command didn't validate the unsupported user config change

2020-05-26 Thread GitBox
d8tltanc commented on pull request #8615: URL: https://github.com/apache/kafka/pull/8615#issuecomment-634304819 closed due to https://github.com/apache/kafka/pull/8628 This is an automated message from the Apache Git Service.

[GitHub] [kafka] hachikuji merged pull request #8701: MINOR: Add reason to log message when incrementing the log start offset

2020-05-26 Thread GitBox
hachikuji merged pull request #8701: URL: https://github.com/apache/kafka/pull/8701 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] ijuma commented on a change in pull request #4090: [KAFKA-6084] Propagate JSON parsing errors in ReassignPartitionsCommand

2020-05-26 Thread GitBox
ijuma commented on a change in pull request #4090: URL: https://github.com/apache/kafka/pull/4090#discussion_r430348986 ## File path: core/src/main/scala/kafka/utils/Json.scala ## @@ -34,7 +34,7 @@ object Json { * Parse a JSON string into a JsonValue if possible. `None` is

[GitHub] [kafka] abbccdda commented on pull request #8221: KAFKA-9561: update task input partitions after rebalance

2020-05-26 Thread GitBox
abbccdda commented on pull request #8221: URL: https://github.com/apache/kafka/pull/8221#issuecomment-633753970 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [kafka] ijuma commented on a change in pull request #8709: KAFKA-9952; Remove immediate fetch completion logic on high watermark updates

2020-05-26 Thread GitBox
ijuma commented on a change in pull request #8709: URL: https://github.com/apache/kafka/pull/8709#discussion_r429653946 ## File path: core/src/main/scala/kafka/server/DelayedFetch.scala ## @@ -120,14 +119,6 @@ class DelayedFetch(delayMs: Long, accumulatedSize

[GitHub] [kafka] chia7712 closed pull request #8685: KAFKA-10014 Always try to close all channels in Selector#close

2020-05-26 Thread GitBox
chia7712 closed pull request #8685: URL: https://github.com/apache/kafka/pull/8685 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] mjsax commented on a change in pull request #8589: KAFKA-9146: KIP-571 Add option to force delete active members in StreamsResetter

2020-05-26 Thread GitBox
mjsax commented on a change in pull request #8589: URL: https://github.com/apache/kafka/pull/8589#discussion_r430826643 ## File path: core/src/main/scala/kafka/tools/StreamsResetter.java ## @@ -186,9 +192,19 @@ private void validateNoActiveConsumers(final String groupId,

[GitHub] [kafka] ijuma commented on pull request #8705: KAFKA-10029; Don't update completedReceives when channels are closed to avoid ConcurrentModificationException

2020-05-26 Thread GitBox
ijuma commented on pull request #8705: URL: https://github.com/apache/kafka/pull/8705#issuecomment-633725248 @rajinisivaram What's the implication of not removing the completed receive in `doClose`? This is an automated mess

[GitHub] [kafka] ijuma opened a new pull request #8728: MINOR: Slight MetadataCache tweaks to avoid unnecessary work

2020-05-26 Thread GitBox
ijuma opened a new pull request #8728: URL: https://github.com/apache/kafka/pull/8728 - Avoid tuple allocations by using `foreachEntry` and `update` methods - Use `empty` instead of `apply` to avoid unnecessary array allocation ### Committer Checklist (excluded from commit message)

[GitHub] [kafka] ableegoldman commented on a change in pull request #8248: KAFKA-9501: convert between active and standby without closing stores

2020-05-26 Thread GitBox
ableegoldman commented on a change in pull request #8248: URL: https://github.com/apache/kafka/pull/8248#discussion_r430787299 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorContextImpl.java ## @@ -42,48 +41,36 @@ import static org.

[GitHub] [kafka] nresare commented on pull request #8605: MINOR: align the constructor of KafkaConsumer to KafkaProducer

2020-05-26 Thread GitBox
nresare commented on pull request #8605: URL: https://github.com/apache/kafka/pull/8605#issuecomment-634019994 @chia7712 did you get around to update the PR with a variant that removes the no-longer-used `addDeserializerToConfig()` method? -

[GitHub] [kafka] mjsax commented on pull request #6824: KAFKA-7523: Add ConnectedStoreProvider to Processor API

2020-05-26 Thread GitBox
mjsax commented on pull request #6824: URL: https://github.com/apache/kafka/pull/6824#issuecomment-634347693 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [kafka] rajinisivaram commented on a change in pull request #8705: KAFKA-10029; Don't update completedReceives when channels are closed to avoid ConcurrentModificationException

2020-05-26 Thread GitBox
rajinisivaram commented on a change in pull request #8705: URL: https://github.com/apache/kafka/pull/8705#discussion_r430299529 ## File path: core/src/test/scala/unit/kafka/network/SocketServerTest.scala ## @@ -1742,6 +1746,12 @@ class SocketServerTest { selector =

[GitHub] [kafka] hachikuji commented on pull request #8724: KAFKA-10040; Make computing the PreferredReplicaImbalanceCount metric more efficient

2020-05-26 Thread GitBox
hachikuji commented on pull request #8724: URL: https://github.com/apache/kafka/pull/8724#issuecomment-634134203 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] dajac opened a new pull request #8724: KAFKA-10040; Make computing the PreferredReplicaImbalanceCount metric more efficient

2020-05-26 Thread GitBox
dajac opened a new pull request #8724: URL: https://github.com/apache/kafka/pull/8724 TODO ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgra

[GitHub] [kafka] ableegoldman commented on a change in pull request #8716: KAFKA-6145: KIP-441: Fix assignor config passthough

2020-05-26 Thread GitBox
ableegoldman commented on a change in pull request #8716: URL: https://github.com/apache/kafka/pull/8716#discussion_r430778603 ## File path: streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java ## @@ -1148,6 +1148,9 @@ private void verifyMaxInFlightRequestPerConnec

[GitHub] [kafka] guozhangwang commented on pull request #8589: KAFKA-9146: KIP-571 Add option to force delete active members in StreamsResetter

2020-05-26 Thread GitBox
guozhangwang commented on pull request #8589: URL: https://github.com/apache/kafka/pull/8589#issuecomment-633667548 test this This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] chia7712 commented on a change in pull request #8605: MINOR: align the constructor of KafkaConsumer to KafkaProducer

2020-05-26 Thread GitBox
chia7712 commented on a change in pull request #8605: URL: https://github.com/apache/kafka/pull/8605#discussion_r430420853 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerConfig.java ## @@ -573,18 +573,6 @@ private void maybeOverrideClientId(Map

[GitHub] [kafka] viktorsomogyi commented on pull request #4090: [KAFKA-6084] Propagate JSON parsing errors in ReassignPartitionsCommand

2020-05-26 Thread GitBox
viktorsomogyi commented on pull request #4090: URL: https://github.com/apache/kafka/pull/4090#issuecomment-633909772 @ijuma @omkreddy would you please have a look at this? This is an automated message from the Apache Git Serv

[jira] [Created] (KAFKA-10047) Unnecessary widening of (int to long) scope in FloatSerializer

2020-05-26 Thread Guru Tahasildar (Jira)
Guru Tahasildar created KAFKA-10047: --- Summary: Unnecessary widening of (int to long) scope in FloatSerializer Key: KAFKA-10047 URL: https://issues.apache.org/jira/browse/KAFKA-10047 Project: Kafka

[GitHub] [kafka] abbccdda commented on a change in pull request #8680: KAFKA-10027: Implement read path for feature versioning system (KIP-584)

2020-05-26 Thread GitBox
abbccdda commented on a change in pull request #8680: URL: https://github.com/apache/kafka/pull/8680#discussion_r430737606 ## File path: core/src/main/scala/kafka/server/FinalizedFeatureChangeListener.scala ## @@ -0,0 +1,232 @@ +package kafka.server + +import java.util.concurre

[GitHub] [kafka] mimaison commented on a change in pull request #8644: KAFKA-9313: [WIP] Make use_all_dns_ips as the default for client.dns.lookup

2020-05-26 Thread GitBox
mimaison commented on a change in pull request #8644: URL: https://github.com/apache/kafka/pull/8644#discussion_r430721875 ## File path: clients/src/main/java/org/apache/kafka/clients/ClientDnsLookup.java ## @@ -22,7 +22,8 @@ DEFAULT("default"), USE_ALL_DNS_IPS("use

[GitHub] [kafka] kkonstantine commented on pull request #8722: KAFKA-5295: Allow source connectors to specify topic-specific settings for new topics (KIP-158)

2020-05-26 Thread GitBox
kkonstantine commented on pull request #8722: URL: https://github.com/apache/kafka/pull/8722#issuecomment-633730773 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [kafka] bbejeck commented on pull request #8504: KAFKA-9298: reuse mapped stream error in joins

2020-05-26 Thread GitBox
bbejeck commented on pull request #8504: URL: https://github.com/apache/kafka/pull/8504#issuecomment-633763929 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [kafka] gharris1727 commented on a change in pull request #8720: KAFKA-9971: Error Reporting in Sink Connectors

2020-05-26 Thread GitBox
gharris1727 commented on a change in pull request #8720: URL: https://github.com/apache/kafka/pull/8720#discussion_r430761599 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerErrantRecordReporter.java ## @@ -0,0 +1,198 @@ +/* + * Licensed to t

[GitHub] [kafka] ijuma commented on pull request #8708: MINOR: avoid unnecessary seq iteration in ApiVersion.lastVersion

2020-05-26 Thread GitBox
ijuma commented on pull request #8708: URL: https://github.com/apache/kafka/pull/8708#issuecomment-633805226 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [kafka] guozhangwang commented on a change in pull request #8549: KAFKA-9911: Add new PRODUCER_FENCED error code

2020-05-26 Thread GitBox
guozhangwang commented on a change in pull request #8549: URL: https://github.com/apache/kafka/pull/8549#discussion_r430034971 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java ## @@ -1415,8 +1419,10 @@ public void handleRe

  1   2   >