kkonstantine commented on pull request #8750:
URL: https://github.com/apache/kafka/pull/8750#issuecomment-636415779
ok to test
This is an automated message from the Apache Git Service.
To respond to the message, please log
abbccdda commented on a change in pull request #8759:
URL: https://github.com/apache/kafka/pull/8759#discussion_r432901618
##
File path:
streams/test-utils/src/test/java/org/apache/kafka/streams/TopologyTestDriverTest.java
##
@@ -711,6 +715,56 @@ public void
abbccdda commented on a change in pull request #8760:
URL: https://github.com/apache/kafka/pull/8760#discussion_r432900674
##
File path: docs/streams/developer-guide/app-reset-tool.html
##
@@ -117,6 +118,9 @@ Step 1: Run the application reset tool
Prerequisites
[
https://issues.apache.org/jira/browse/KAFKA-10066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
John Roesler updated KAFKA-10066:
-
Fix Version/s: 2.5.1
> TopologyTestDriver isn't taking record headers into account during
>
[
https://issues.apache.org/jira/browse/KAFKA-10066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120370#comment-17120370
]
John Roesler commented on KAFKA-10066:
--
Great! Thanks.
> TopologyTestDriver isn't taking record
[
https://issues.apache.org/jira/browse/KAFKA-10066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120366#comment-17120366
]
Matthias J. Sax commented on KAFKA-10066:
-
Including it in 2.5.1 was my intention :)
>
dajac commented on pull request #6737:
URL: https://github.com/apache/kafka/pull/6737#issuecomment-636369480
@huxihx I think that something similar has been implemented. Could we close
this one?
This is an automated message
[
https://issues.apache.org/jira/browse/KAFKA-9891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120333#comment-17120333
]
Mateusz Jadczyk commented on KAFKA-9891:
On trunk I can't seem to reproduce this particular
chia7712 commented on a change in pull request #8605:
URL: https://github.com/apache/kafka/pull/8605#discussion_r432874506
##
File path: clients/src/test/java/org/apache/kafka/common/utils/UtilsTest.java
##
@@ -681,4 +683,15 @@ public void testDiff() {
chia7712 opened a new pull request #8762:
URL: https://github.com/apache/kafka/pull/8762
45f2261763eac5caaebf860daab32ef5337c9293 introduced another way to loader
plugins and so ReflectionsUtil is unused anymore.
### Committer Checklist (excluded from commit message)
- [ ] Verify
vinothchandar commented on a change in pull request #8737:
URL: https://github.com/apache/kafka/pull/8737#discussion_r432868431
##
File path: core/src/main/scala/kafka/admin/TopicCommand.scala
##
@@ -290,42 +299,50 @@ object TopicCommand extends Logging {
override def
vinothchandar commented on a change in pull request #8737:
URL: https://github.com/apache/kafka/pull/8737#discussion_r432868132
##
File path: core/src/main/scala/kafka/admin/TopicCommand.scala
##
@@ -290,42 +299,50 @@ object TopicCommand extends Logging {
override def
[
https://issues.apache.org/jira/browse/KAFKA-10066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120291#comment-17120291
]
John Roesler commented on KAFKA-10066:
--
Hey, @mjsax, since you’re already proposing a PR, what do
ijuma merged pull request #8636:
URL: https://github.com/apache/kafka/pull/8636
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
ijuma commented on pull request #8640:
URL: https://github.com/apache/kafka/pull/8640#issuecomment-636350073
Sorry, I noticed a couple of things after approving, so would like
clarification on those before we merge. Thanks.
ijuma commented on a change in pull request #8640:
URL: https://github.com/apache/kafka/pull/8640#discussion_r432865696
##
File path:
generator/src/main/java/org/apache/kafka/message/MessageDataGenerator.java
##
@@ -2033,15 +2033,21 @@ private void generateClassEquals(String
ijuma commented on a change in pull request #8640:
URL: https://github.com/apache/kafka/pull/8640#discussion_r432865628
##
File path:
clients/src/test/java/org/apache/kafka/common/message/MessageTest.java
##
@@ -962,4 +962,23 @@ private void verifyWriteSucceeds(short version,
ijuma commented on pull request #8640:
URL: https://github.com/apache/kafka/pull/8640#issuecomment-636349596
@cmccabe please include your clarification in the PR description and commit
description.
This is an automated
ijuma commented on a change in pull request #8644:
URL: https://github.com/apache/kafka/pull/8644#discussion_r432865228
##
File path:
clients/src/main/java/org/apache/kafka/clients/CommonClientConfigs.java
##
@@ -42,9 +42,11 @@
omkreddy commented on a change in pull request #7956:
URL: https://github.com/apache/kafka/pull/7956#discussion_r432865277
##
File path:
clients/src/main/java/org/apache/kafka/server/authorizer/Authorizer.java
##
@@ -114,6 +114,21 @@
* This is an asynchronous API that
ijuma commented on pull request #8684:
URL: https://github.com/apache/kafka/pull/8684#issuecomment-636348427
@navina it's a native call (implying JNI overhead) and somewhat inflexible.
We'd want to add a JMH benchmark to understand the full impact.
ijuma commented on a change in pull request #8605:
URL: https://github.com/apache/kafka/pull/8605#discussion_r432864648
##
File path: clients/src/test/java/org/apache/kafka/common/utils/UtilsTest.java
##
@@ -681,4 +683,15 @@ public void testDiff() {
assertThat(diff,
ijuma commented on a change in pull request #8741:
URL: https://github.com/apache/kafka/pull/8741#discussion_r432864242
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java
##
@@ -519,7 +519,7 @@ public void
ijuma commented on pull request #8742:
URL: https://github.com/apache/kafka/pull/8742#issuecomment-636347366
ok to test
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
ijuma commented on pull request #8707:
URL: https://github.com/apache/kafka/pull/8707#issuecomment-636347175
Closing in favor of #8605.
This is an automated message from the Apache Git Service.
To respond to the message,
ijuma closed pull request #8707:
URL: https://github.com/apache/kafka/pull/8707
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
ijuma merged pull request #8761:
URL: https://github.com/apache/kafka/pull/8761
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
[
https://issues.apache.org/jira/browse/KAFKA-9891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120253#comment-17120253
]
Mateusz Jadczyk commented on KAFKA-9891:
I think I wanted to be sure that keyOne is committed
[
https://issues.apache.org/jira/browse/KAFKA-9891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120253#comment-17120253
]
Mateusz Jadczyk edited comment on KAFKA-9891 at 5/30/20, 1:57 PM:
--
tswstarplanet opened a new pull request #8761:
URL: https://github.com/apache/kafka/pull/8761
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of
[
https://issues.apache.org/jira/browse/KAFKA-10064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120240#comment-17120240
]
feyman commented on KAFKA-10064:
[~bchen225242], create a PR for this as in the issue links, thanks!
>
[
https://issues.apache.org/jira/browse/KAFKA-10064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120240#comment-17120240
]
feyman edited comment on KAFKA-10064 at 5/30/20, 12:50 PM:
---
[~bchen225242],
feyman2016 opened a new pull request #8760:
URL: https://github.com/apache/kafka/pull/8760
Update the documentation to describe the change in KIP-571
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI
[
https://issues.apache.org/jira/browse/KAFKA-9982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17120173#comment-17120173
]
Qinghui Xu commented on KAFKA-9982:
---
Thanks [~ChrisEgerton], very nice pointers, now it starts to make
cmccabe commented on pull request #8639:
URL: https://github.com/apache/kafka/pull/8639#issuecomment-636286034
@rajinisivaram wrote:
> @cmccabe found a compatibility issue with the KIP and made some changes. I
think the change was to allow ConsumerGroupDescription#authorizedOperations
cmccabe commented on a change in pull request #8737:
URL: https://github.com/apache/kafka/pull/8737#discussion_r432814786
##
File path:
core/src/test/scala/unit/kafka/admin/TopicCommandWithAdminClientTest.scala
##
@@ -223,8 +224,20 @@ class TopicCommandWithAdminClientTest
cmccabe commented on pull request #8737:
URL: https://github.com/apache/kafka/pull/8737#issuecomment-636283732
Thanks for working on this, @vinothchandar. I think it's almost ready to
go. I left two comments.
This is an
vinothchandar commented on a change in pull request #8737:
URL: https://github.com/apache/kafka/pull/8737#discussion_r432814420
##
File path: core/src/main/scala/kafka/admin/TopicCommand.scala
##
@@ -290,42 +299,50 @@ object TopicCommand extends Logging {
override def
cmccabe commented on a change in pull request #8737:
URL: https://github.com/apache/kafka/pull/8737#discussion_r432814325
##
File path: core/src/main/scala/kafka/admin/TopicCommand.scala
##
@@ -290,42 +299,50 @@ object TopicCommand extends Logging {
override def
cmccabe commented on a change in pull request #8737:
URL: https://github.com/apache/kafka/pull/8737#discussion_r432814353
##
File path: core/src/main/scala/kafka/admin/TopicCommand.scala
##
@@ -290,42 +299,50 @@ object TopicCommand extends Logging {
override def
40 matches
Mail list logo
