[GitHub] [kafka] kkonstantine opened a new pull request #8805: KAFKA-9848: Avoid triggering scheduled rebalance delay when task assignment fails but Connect workers remain in the group

2020-06-04 Thread GitBox
kkonstantine opened a new pull request #8805: URL: https://github.com/apache/kafka/pull/8805 tbd ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including

[GitHub] [kafka] kkonstantine opened a new pull request #8804: KAFKA-9851: Revoking Connect tasks due to connectivity issues should also clear the running assignment

2020-06-04 Thread GitBox
kkonstantine opened a new pull request #8804: URL: https://github.com/apache/kafka/pull/8804 Until recently revocation of connectors and tasks was the result of a rebalance that contained a new assignment. Therefore the view of the running assignment was kept consistent outside the call to

[GitHub] [kafka] hachikuji commented on pull request #8486: KAFKA-9840: Skip End Offset validation when the leader epoch is not reliable

2020-06-04 Thread GitBox
hachikuji commented on pull request #8486: URL: https://github.com/apache/kafka/pull/8486#issuecomment-639286547 retest this please This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [kafka] hachikuji commented on pull request #8486: KAFKA-9840: Skip End Offset validation when the leader epoch is not reliable

2020-06-04 Thread GitBox
hachikuji commented on pull request #8486: URL: https://github.com/apache/kafka/pull/8486#issuecomment-639286462 retest this please This is an automated message from the Apache Git Service. To respond to the message, please l

[jira] [Commented] (KAFKA-9377) Refactor StreamsPartitionAssignor Repartition Count logic

2020-06-04 Thread feyman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17126442#comment-17126442 ] feyman commented on KAFKA-9377: --- [~bchen225242], I'm very glad to take it and even feel exc

[jira] [Comment Edited] (KAFKA-9377) Refactor StreamsPartitionAssignor Repartition Count logic

2020-06-04 Thread feyman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17126442#comment-17126442 ] feyman edited comment on KAFKA-9377 at 6/5/20, 6:28 AM: [~bchen22

[jira] [Updated] (KAFKA-10106) log time taken to handle LeaderAndIsr request

2020-06-04 Thread NIKHIL (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] NIKHIL updated KAFKA-10106: --- Summary: log time taken to handle LeaderAndIsr request (was: measure and log time taken to handle LeaderAn

[jira] [Updated] (KAFKA-10106) log time taken to handle LeaderAndIsr request

2020-06-04 Thread NIKHIL (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] NIKHIL updated KAFKA-10106: --- Priority: Minor (was: Trivial) > log time taken to handle LeaderAndIsr request > -

[GitHub] [kafka] ning2008wisc commented on pull request #7577: KAFKA-9076: support consumer offset sync across clusters in MM 2.0

2020-06-04 Thread GitBox
ning2008wisc commented on pull request #7577: URL: https://github.com/apache/kafka/pull/7577#issuecomment-639276582 Hello @mimaison thanks for your comments. I have addressed them in the latest push and please take another review. Thanks ---

[GitHub] [kafka] ning2008wisc commented on a change in pull request #7577: KAFKA-9076: support consumer offset sync across clusters in MM 2.0

2020-06-04 Thread GitBox
ning2008wisc commented on a change in pull request #7577: URL: https://github.com/apache/kafka/pull/7577#discussion_r435705249 ## File path: connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorConnectorsIntegrationTest.java ## @@ -316,6 +316,69 @@ public void te

[jira] [Commented] (KAFKA-10090) Misleading warnings: The configuration was supplied but isn't a known config

2020-06-04 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17126412#comment-17126412 ] Chia-Ping Tsai commented on KAFKA-10090: It seems to me that the PR should inclu

[jira] [Created] (KAFKA-10106) measure and log time taken to handle LeaderAndIsr request

2020-06-04 Thread NIKHIL (Jira)
NIKHIL created KAFKA-10106: -- Summary: measure and log time taken to handle LeaderAndIsr request Key: KAFKA-10106 URL: https://issues.apache.org/jira/browse/KAFKA-10106 Project: Kafka Issue Type: Im

[GitHub] [kafka] abbccdda commented on pull request #8486: KAFKA-9840: Skip End Offset validation when the leader epoch is not reliable

2020-06-04 Thread GitBox
abbccdda commented on pull request #8486: URL: https://github.com/apache/kafka/pull/8486#issuecomment-639265937 retest please This is an automated message from the Apache Git Service. To respond to the message, please log

[jira] [Created] (KAFKA-10105) Regression in group coordinator dealing with flaky clients joining while leaving

2020-06-04 Thread William Reynolds (Jira)
William Reynolds created KAFKA-10105: Summary: Regression in group coordinator dealing with flaky clients joining while leaving Key: KAFKA-10105 URL: https://issues.apache.org/jira/browse/KAFKA-10105

[GitHub] [kafka] guozhangwang commented on a change in pull request #8799: KAFKA-8011: Fix flaky RegexSourceIntegrationTest

2020-06-04 Thread GitBox
guozhangwang commented on a change in pull request #8799: URL: https://github.com/apache/kafka/pull/8799#discussion_r435684743 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/RegexSourceIntegrationTest.java ## @@ -124,7 +124,7 @@ public void setUp() th

[GitHub] [kafka] ableegoldman opened a new pull request #8803: KAFKA-10102: update ProcessorTopology instead of rebuilding it

2020-06-04 Thread GitBox
ableegoldman opened a new pull request #8803: URL: https://github.com/apache/kafka/pull/8803 Rather than recreate the entire topology when we find new regex matched input partitions, we can just update the relevant pieces. Only the SourceNodes and ProcessorTopology seem to care about

[GitHub] [kafka] ableegoldman commented on pull request #8803: KAFKA-10102: update ProcessorTopology instead of rebuilding it

2020-06-04 Thread GitBox
ableegoldman commented on pull request #8803: URL: https://github.com/apache/kafka/pull/8803#issuecomment-639245176 Ready for review @abbccdda @guozhangwang This is an automated message from the Apache Git Service. To respon

[GitHub] [kafka] hachikuji commented on pull request #8486: KAFKA-9840: Skip End Offset validation when the leader epoch is not reliable

2020-06-04 Thread GitBox
hachikuji commented on pull request #8486: URL: https://github.com/apache/kafka/pull/8486#issuecomment-639211997 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] ableegoldman commented on a change in pull request #8787: KAFKA-10085: correctly compute lag for optimized source changelogs

2020-06-04 Thread GitBox
ableegoldman commented on a change in pull request #8787: URL: https://github.com/apache/kafka/pull/8787#discussion_r435647575 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java ## @@ -763,18 +778,36 @@ private boolea

[GitHub] [kafka] ableegoldman commented on pull request #8787: KAFKA-10085: correctly compute lag for optimized source changelogs

2020-06-04 Thread GitBox
ableegoldman commented on pull request #8787: URL: https://github.com/apache/kafka/pull/8787#issuecomment-639205947 Hey @vvcephei, I addressed your comments and added tests. Let me know if there's any test coverage that still seems missing

[jira] [Commented] (KAFKA-9991) Flaky Test KTableSourceTopicRestartIntegrationTest.shouldRestoreAndProgressWhenTopicWrittenToDuringRestorationWithEosAlphaEnabled

2020-06-04 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17126303#comment-17126303 ] Sophie Blee-Goldman commented on KAFKA-9991: Different test method:  [https:/

[jira] [Commented] (KAFKA-9991) Flaky Test KTableSourceTopicRestartIntegrationTest.shouldRestoreAndProgressWhenTopicWrittenToDuringRestorationWithEosAlphaEnabled

2020-06-04 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17126302#comment-17126302 ] Sophie Blee-Goldman commented on KAFKA-9991: [https://builds.apache.org/job/k

[GitHub] [kafka] guozhangwang commented on a change in pull request #8776: KAFKA-9441: Improve Kafka Streams task management

2020-06-04 Thread GitBox
guozhangwang commented on a change in pull request #8776: URL: https://github.com/apache/kafka/pull/8776#discussion_r435636306 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java ## @@ -247,48 +251,75 @@ public void completeRestorat

[GitHub] [kafka] guozhangwang commented on pull request #8776: KAFKA-9441: Improve Kafka Streams task management

2020-06-04 Thread GitBox
guozhangwang commented on pull request #8776: URL: https://github.com/apache/kafka/pull/8776#issuecomment-639196728 test this please This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Commented] (KAFKA-9203) kafka-client 2.3.1 fails to consume lz4 compressed topic

2020-06-04 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17126293#comment-17126293 ] Ismael Juma commented on KAFKA-9203: Hi [~manthanit]. Thanks for providing this infor

[GitHub] [kafka] hachikuji merged pull request #8724: KAFKA-10040; Make computing the PreferredReplicaImbalanceCount metric more efficient

2020-06-04 Thread GitBox
hachikuji merged pull request #8724: URL: https://github.com/apache/kafka/pull/8724 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Resolved] (KAFKA-10040) Make computing the PreferredReplicaImbalanceCount metric more efficient

2020-06-04 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-10040. - Fix Version/s: 2.7.0 Resolution: Fixed > Make computing the PreferredReplicaImbal

[GitHub] [kafka] hachikuji commented on pull request #8724: KAFKA-10040; Make computing the PreferredReplicaImbalanceCount metric more efficient

2020-06-04 Thread GitBox
hachikuji commented on pull request #8724: URL: https://github.com/apache/kafka/pull/8724#issuecomment-639189300 I will go ahead and merge this. I build locally with JDK11 and Scala 2.13. This is an automated message from the

[GitHub] [kafka] vitojeng commented on pull request #8789: MINOR: Fix the javadoc broken links of streams

2020-06-04 Thread GitBox
vitojeng commented on pull request #8789: URL: https://github.com/apache/kafka/pull/8789#issuecomment-639186748 Thanks @bbejeck . This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] ableegoldman commented on pull request #8775: KAFKA-10079: improve thread-level stickiness

2020-06-04 Thread GitBox
ableegoldman commented on pull request #8775: URL: https://github.com/apache/kafka/pull/8775#issuecomment-639184354 Java8 failed with `KTableSourceTopicRestartIntegrationTest.shouldRestoreAndProgressWhenTopicNotWrittenToDuringRestoration` Java14 failed with `KTableSourceTopicRes

[GitHub] [kafka] junrao commented on a change in pull request #8680: KAFKA-10027: Implement read path for feature versioning system (KIP-584)

2020-06-04 Thread GitBox
junrao commented on a change in pull request #8680: URL: https://github.com/apache/kafka/pull/8680#discussion_r435558683 ## File path: clients/src/main/java/org/apache/kafka/common/requests/ApiVersionsResponse.java ## @@ -113,14 +127,44 @@ public static ApiVersionsResponse fro

[jira] [Assigned] (KAFKA-10102) Source node references not updated after rebuilding topology

2020-06-04 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sophie Blee-Goldman reassigned KAFKA-10102: --- Assignee: Sophie Blee-Goldman > Source node references not updated after re

[jira] [Assigned] (KAFKA-9923) Join window store duplicates can be compacted in changelog

2020-06-04 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9923?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sophie Blee-Goldman reassigned KAFKA-9923: -- Assignee: Bruno Cadonna > Join window store duplicates can be compacted in cha

[jira] [Assigned] (KAFKA-10102) Source node references not updated after rebuilding topology

2020-06-04 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sophie Blee-Goldman reassigned KAFKA-10102: --- Assignee: Sophie Blee-Goldman > Source node references not updated after re

[jira] [Assigned] (KAFKA-10102) Source node references not updated after rebuilding topology

2020-06-04 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sophie Blee-Goldman reassigned KAFKA-10102: --- Assignee: (was: Sophie Blee-Goldman) > Source node references not updat

[GitHub] [kafka] hachikuji opened a new pull request #8802: MINOR: Fix fetch session epoch comment in `FetchRequest.json`

2020-06-04 Thread GitBox
hachikuji opened a new pull request #8802: URL: https://github.com/apache/kafka/pull/8802 The current "about" string incorrectly describes the session epoch as the partition epoch. Rename to `SessionEpoch` to make usage clearer. Also rename `MaxWait` to `MaxWaitTimeMs` and `FetchableTopic`

[GitHub] [kafka] mjsax commented on pull request #8759: KAFKA-10066: TestOutputTopic should pass record headers into deserializers

2020-06-04 Thread GitBox
mjsax commented on pull request #8759: URL: https://github.com/apache/kafka/pull/8759#issuecomment-639170115 Merged to `trunk` and cherry-picked to `2.6` and `2.5` branches. This is an automated message from the Apache Git Se

[GitHub] [kafka] mjsax commented on pull request #8771: MINOR: Add explanation for disabling forwarding from value transformers

2020-06-04 Thread GitBox
mjsax commented on pull request #8771: URL: https://github.com/apache/kafka/pull/8771#issuecomment-639157574 Thanks for the PR @astubbs! Merged to `trunk` and cherry-picked to `2.6`. This is an automated message from t

[GitHub] [kafka] mjsax merged pull request #8759: KAFKA-10066: TestOutputTopic should pass record headers into deserializers

2020-06-04 Thread GitBox
mjsax merged pull request #8759: URL: https://github.com/apache/kafka/pull/8759 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] mjsax commented on a change in pull request #8799: KAFKA-8011: Fix flaky RegexSourceIntegrationTest

2020-06-04 Thread GitBox
mjsax commented on a change in pull request #8799: URL: https://github.com/apache/kafka/pull/8799#discussion_r435597397 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/RegexSourceIntegrationTest.java ## @@ -142,83 +142,89 @@ public void tearDown() thro

[GitHub] [kafka] mjsax commented on a change in pull request #8799: KAFKA-8011: Fix flaky RegexSourceIntegrationTest

2020-06-04 Thread GitBox
mjsax commented on a change in pull request #8799: URL: https://github.com/apache/kafka/pull/8799#discussion_r435597397 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/RegexSourceIntegrationTest.java ## @@ -142,83 +142,89 @@ public void tearDown() thro

[GitHub] [kafka] ableegoldman commented on a change in pull request #8787: KAFKA-10085: correctly compute lag for optimized source changelogs

2020-06-04 Thread GitBox
ableegoldman commented on a change in pull request #8787: URL: https://github.com/apache/kafka/pull/8787#discussion_r435593477 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StoreChangelogReader.java ## @@ -562,23 +564,18 @@ private void resto

[jira] [Commented] (KAFKA-10097) Avoid getting null map for task checkpoint

2020-06-04 Thread feyman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17126244#comment-17126244 ] feyman commented on KAFKA-10097: Cool, thanks a lot! [~bchen225242] > Avoid getting nul

[GitHub] [kafka] mjsax merged pull request #8771: MINOR: Add explanation for disabling forwarding from value transformers

2020-06-04 Thread GitBox
mjsax merged pull request #8771: URL: https://github.com/apache/kafka/pull/8771 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] ableegoldman commented on a change in pull request #8787: KAFKA-10085: correctly compute lag for optimized source changelogs

2020-06-04 Thread GitBox
ableegoldman commented on a change in pull request #8787: URL: https://github.com/apache/kafka/pull/8787#discussion_r435590436 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StoreChangelogReader.java ## @@ -562,23 +564,18 @@ private void resto

[GitHub] [kafka] mjsax commented on pull request #8776: KAFKA-9441: Improve Kafka Streams task management

2020-06-04 Thread GitBox
mjsax commented on pull request #8776: URL: https://github.com/apache/kafka/pull/8776#issuecomment-639154057 > I'm mildly concerned that we're using the state to implement idempotence of processing steps, but the states aren't 1:1 with the steps. For example, when we go from RUNNING to CLO

[GitHub] [kafka] mjsax commented on a change in pull request #8776: KAFKA-9441: Improve Kafka Streams task management

2020-06-04 Thread GitBox
mjsax commented on a change in pull request #8776: URL: https://github.com/apache/kafka/pull/8776#discussion_r435589707 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -613,10 +604,14 @@ private long sumOfChangelogOffsets

[GitHub] [kafka] ableegoldman commented on a change in pull request #8799: KAFKA-8011: Fix flaky RegexSourceIntegrationTest

2020-06-04 Thread GitBox
ableegoldman commented on a change in pull request #8799: URL: https://github.com/apache/kafka/pull/8799#discussion_r435588847 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/RegexSourceIntegrationTest.java ## @@ -142,83 +142,89 @@ public void tearDown

[GitHub] [kafka] mjsax commented on a change in pull request #8776: KAFKA-9441: Improve Kafka Streams task management

2020-06-04 Thread GitBox
mjsax commented on a change in pull request #8776: URL: https://github.com/apache/kafka/pull/8776#discussion_r435588028 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -613,10 +604,14 @@ private long sumOfChangelogOffsets

[GitHub] [kafka] mjsax commented on a change in pull request #8799: KAFKA-8011: Fix flaky RegexSourceIntegrationTest

2020-06-04 Thread GitBox
mjsax commented on a change in pull request #8799: URL: https://github.com/apache/kafka/pull/8799#discussion_r435587017 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/RegexSourceIntegrationTest.java ## @@ -142,83 +142,89 @@ public void tearDown() thro

[GitHub] [kafka] ableegoldman commented on a change in pull request #8775: KAFKA-10079: improve thread-level stickiness

2020-06-04 Thread GitBox
ableegoldman commented on a change in pull request #8775: URL: https://github.com/apache/kafka/pull/8775#discussion_r435585609 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/ClientState.java ## @@ -302,14 +300,19 @@ public void comp

[GitHub] [kafka] ableegoldman commented on a change in pull request #8799: KAFKA-8011: Fix flaky RegexSourceIntegrationTest

2020-06-04 Thread GitBox
ableegoldman commented on a change in pull request #8799: URL: https://github.com/apache/kafka/pull/8799#discussion_r435584438 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/RegexSourceIntegrationTest.java ## @@ -142,83 +142,89 @@ public void tearDown

[GitHub] [kafka] mjsax commented on a change in pull request #8799: KAFKA-8011: Fix flaky RegexSourceIntegrationTest

2020-06-04 Thread GitBox
mjsax commented on a change in pull request #8799: URL: https://github.com/apache/kafka/pull/8799#discussion_r435583650 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/RegexSourceIntegrationTest.java ## @@ -142,83 +142,89 @@ public void tearDown() thro

[jira] [Updated] (KAFKA-10069) The user-defined "predicate" and "negate" are not removed from Transformation

2020-06-04 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis updated KAFKA-10069: --- Fix Version/s: 2.6.0 > The user-defined "predicate" and "negate" are not rem

[jira] [Resolved] (KAFKA-10069) The user-defined "predicate" and "negate" are not removed from Transformation

2020-06-04 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis resolved KAFKA-10069. Resolution: Fixed > The user-defined "predicate" and "negate" are not remo

[GitHub] [kafka] vvcephei commented on pull request #8775: KAFKA-10079: improve thread-level stickiness

2020-06-04 Thread GitBox
vvcephei commented on pull request #8775: URL: https://github.com/apache/kafka/pull/8775#issuecomment-639128329 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [kafka] vvcephei commented on pull request #8107: MINOR: Remove Diamond and code code Alignment

2020-06-04 Thread GitBox
vvcephei commented on pull request #8107: URL: https://github.com/apache/kafka/pull/8107#issuecomment-639124739 Ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] vvcephei commented on a change in pull request #8776: KAFKA-9441: Improve Kafka Streams task management

2020-06-04 Thread GitBox
vvcephei commented on a change in pull request #8776: URL: https://github.com/apache/kafka/pull/8776#discussion_r435559860 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -613,10 +604,14 @@ private long sumOfChangelogOffs

[jira] [Created] (KAFKA-10104) Remove deprecated --zookeeper flags as specified in KIP-604

2020-06-04 Thread Colin McCabe (Jira)
Colin McCabe created KAFKA-10104: Summary: Remove deprecated --zookeeper flags as specified in KIP-604 Key: KAFKA-10104 URL: https://issues.apache.org/jira/browse/KAFKA-10104 Project: Kafka

[GitHub] [kafka] ableegoldman commented on a change in pull request #8776: KAFKA-9441: Improve Kafka Streams task management

2020-06-04 Thread GitBox
ableegoldman commented on a change in pull request #8776: URL: https://github.com/apache/kafka/pull/8776#discussion_r43000 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -613,10 +604,14 @@ private long sumOfChangelog

[GitHub] [kafka] ableegoldman commented on a change in pull request #8776: KAFKA-9441: Improve Kafka Streams task management

2020-06-04 Thread GitBox
ableegoldman commented on a change in pull request #8776: URL: https://github.com/apache/kafka/pull/8776#discussion_r435552502 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -613,10 +604,14 @@ private long sumOfChangelog

[GitHub] [kafka] szalapski commented on pull request #5876: KAFKA-7509: Avoid passing most non-applicable properties to producer, consumer, and admin client

2020-06-04 Thread GitBox
szalapski commented on pull request #5876: URL: https://github.com/apache/kafka/pull/5876#issuecomment-639110680 I still hope this can be fixed soon. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] vvcephei commented on a change in pull request #8776: KAFKA-9441: Improve Kafka Streams task management

2020-06-04 Thread GitBox
vvcephei commented on a change in pull request #8776: URL: https://github.com/apache/kafka/pull/8776#discussion_r435523829 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -613,10 +604,14 @@ private long sumOfChangelogOffs

[GitHub] [kafka] hachikuji commented on pull request #8486: KAFKA-9840: Skip End Offset validation when the leader epoch is not reliable

2020-06-04 Thread GitBox
hachikuji commented on pull request #8486: URL: https://github.com/apache/kafka/pull/8486#issuecomment-639102074 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Commented] (KAFKA-9377) Refactor StreamsPartitionAssignor Repartition Count logic

2020-06-04 Thread Boyang Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17126166#comment-17126166 ] Boyang Chen commented on KAFKA-9377: [~feyman] Hey I'm assigning this ticket to you.

[jira] [Assigned] (KAFKA-9377) Refactor StreamsPartitionAssignor Repartition Count logic

2020-06-04 Thread Boyang Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Boyang Chen reassigned KAFKA-9377: -- Assignee: feyman (was: Boyang Chen) > Refactor StreamsPartitionAssignor Repartition Count log

[GitHub] [kafka] dajac opened a new pull request #8801: KAFKA-10100; LiveLeaders field in LeaderAndIsrRequest is not used anymore

2020-06-04 Thread GitBox
dajac opened a new pull request #8801: URL: https://github.com/apache/kafka/pull/8801 We have noticed that the `LiveLeaders` field in the LeaderAndIsrRequest is not used anywhere but still populated by the controller. It seems that that field was introduced in AK `0.8.0` and was supp

[GitHub] [kafka] rhauch commented on pull request #8069: KAFKA-9374: Make connector interactions asynchronous

2020-06-04 Thread GitBox
rhauch commented on pull request #8069: URL: https://github.com/apache/kafka/pull/8069#issuecomment-639076340 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] abbccdda commented on a change in pull request #8486: KAFKA-9840: Skip End Offset validation when the leader epoch is not reliable

2020-06-04 Thread GitBox
abbccdda commented on a change in pull request #8486: URL: https://github.com/apache/kafka/pull/8486#discussion_r435505756 ## File path: clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java ## @@ -585,34 +585,29 @@ public void testFetchProgressWithMi

[GitHub] [kafka] vvcephei commented on pull request #8775: KAFKA-10079: improve thread-level stickiness

2020-06-04 Thread GitBox
vvcephei commented on pull request #8775: URL: https://github.com/apache/kafka/pull/8775#issuecomment-639068238 Test this please This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] d8tltanc commented on a change in pull request #8421: KAFKA-9800: [KIP-580] Admin Client Exponential Backoff Implementation

2020-06-04 Thread GitBox
d8tltanc commented on a change in pull request #8421: URL: https://github.com/apache/kafka/pull/8421#discussion_r435492178 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java ## @@ -683,21 +686,65 @@ public Node provide() { }

[GitHub] [kafka] xvrl opened a new pull request #8800: [MINOR] fix incorrect GC log size with JDK9+

2020-06-04 Thread GitBox
xvrl opened a new pull request #8800: URL: https://github.com/apache/kafka/pull/8800 file size was incorrectly set to 100KB instead of 100MB This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [kafka] omkreddy commented on pull request #8717: KAFKA-10033: Throw UnknownTopicOrPartitionException when modifying a non-existent topic's config

2020-06-04 Thread GitBox
omkreddy commented on pull request #8717: URL: https://github.com/apache/kafka/pull/8717#issuecomment-639036963 @bdbyrne Can you rebase the PR? This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [kafka] omkreddy commented on a change in pull request #8717: KAFKA-10033: Throw UnknownTopicOrPartitionException when modifying a non-existent topic's config

2020-06-04 Thread GitBox
omkreddy commented on a change in pull request #8717: URL: https://github.com/apache/kafka/pull/8717#discussion_r435468757 ## File path: core/src/main/scala/kafka/server/AdminManager.scala ## @@ -454,6 +454,9 @@ class AdminManager(val config: KafkaConfig, private def alterTo

[GitHub] [kafka] omkreddy closed pull request #8715: KAFKA-10033: AdminClient should throw UnknownTopicOrPartitionException instead of UnknownServerException if altering configs of non-existing topic

2020-06-04 Thread GitBox
omkreddy closed pull request #8715: URL: https://github.com/apache/kafka/pull/8715 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] hachikuji commented on pull request #8724: KAFKA-10040; Make computing the PreferredReplicaImbalanceCount metric more efficient

2020-06-04 Thread GitBox
hachikuji commented on pull request #8724: URL: https://github.com/apache/kafka/pull/8724#issuecomment-639033169 retest this please This is an automated message from the Apache Git Service. To respond to the message, please l

[jira] [Commented] (KAFKA-10090) Misleading warnings: The configuration was supplied but isn't a known config

2020-06-04 Thread Robert Wruck (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17126132#comment-17126132 ] Robert Wruck commented on KAFKA-10090: -- [~chia7712] That would be great. I'm not re

[GitHub] [kafka] omkreddy commented on pull request #8715: KAFKA-10033: AdminClient should throw UnknownTopicOrPartitionException instead of UnknownServerException if altering configs of non-existing

2020-06-04 Thread GitBox
omkreddy commented on pull request #8715: URL: https://github.com/apache/kafka/pull/8715#issuecomment-639031210 @gnkoshelev Thanks for the PR. LGTM. I think, we can merge both PRs (#8717 ). `AdminZkClient.validateTopicConfig()` is used in command line tools (This will go when remove ZK d

[GitHub] [kafka] rhauch commented on pull request #8135: KAFKA-9570: Define SSL configs in all worker config classes, not just distributed

2020-06-04 Thread GitBox
rhauch commented on pull request #8135: URL: https://github.com/apache/kafka/pull/8135#issuecomment-639015817 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [kafka] C0urante commented on pull request #8135: KAFKA-9570: Define SSL configs in all worker config classes, not just distributed

2020-06-04 Thread GitBox
C0urante commented on pull request #8135: URL: https://github.com/apache/kafka/pull/8135#issuecomment-639008252 @rhauch would it be possible to backport this to 2.6 before the upcoming release? This is an automated message f

[GitHub] [kafka] vvcephei commented on a change in pull request #8775: KAFKA-10079: improve thread-level stickiness

2020-06-04 Thread GitBox
vvcephei commented on a change in pull request #8775: URL: https://github.com/apache/kafka/pull/8775#discussion_r43547 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/ClientState.java ## @@ -302,14 +300,19 @@ public void computeT

[GitHub] [kafka] vvcephei commented on a change in pull request #8787: KAFKA-10085: correctly compute lag for optimized source changelogs

2020-06-04 Thread GitBox
vvcephei commented on a change in pull request #8787: URL: https://github.com/apache/kafka/pull/8787#discussion_r435416204 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StoreChangelogReader.java ## @@ -562,23 +564,18 @@ private void restoreCh

[GitHub] [kafka] heritamas commented on a change in pull request #8730: KAFKA-10048: Possible data gap for a consumer after a failover when u…

2020-06-04 Thread GitBox
heritamas commented on a change in pull request #8730: URL: https://github.com/apache/kafka/pull/8730#discussion_r435424111 ## File path: connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorCheckpointTask.java ## @@ -132,7 +132,7 @@ public String version() {

[GitHub] [kafka] rhauch edited a comment on pull request #8069: KAFKA-9374: Make connector interactions asynchronous

2020-06-04 Thread GitBox
rhauch edited a comment on pull request #8069: URL: https://github.com/apache/kafka/pull/8069#issuecomment-638991218 This should be backported at least to the `2.6` branch. This is an automated message from the Apache Git Ser

[GitHub] [kafka] rhauch commented on pull request #8069: KAFKA-9374: Make connector interactions asynchronous

2020-06-04 Thread GitBox
rhauch commented on pull request #8069: URL: https://github.com/apache/kafka/pull/8069#issuecomment-638991218 This should be backported to the `2.6` branch. This is an automated message from the Apache Git Service. To respond

[GitHub] [kafka] rhauch commented on pull request #8069: KAFKA-9374: Make connector interactions asynchronous

2020-06-04 Thread GitBox
rhauch commented on pull request #8069: URL: https://github.com/apache/kafka/pull/8069#issuecomment-638990957 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] bbejeck commented on pull request #8789: MINOR: Fix the javadoc broken links of streams

2020-06-04 Thread GitBox
bbejeck commented on pull request #8789: URL: https://github.com/apache/kafka/pull/8789#issuecomment-638979955 Thanks for the contribution, @vitojeng. This PR looks good to me, I'd like to verify the links locally, but after that, we'll get this merged. --

[jira] [Created] (KAFKA-10103) JDBC Sink Connector doesn't support numerical values in event keys

2020-06-04 Thread Jakub (Jira)
Jakub created KAFKA-10103: - Summary: JDBC Sink Connector doesn't support numerical values in event keys Key: KAFKA-10103 URL: https://issues.apache.org/jira/browse/KAFKA-10103 Project: Kafka Issue T

[jira] [Commented] (KAFKA-10090) Misleading warnings: The configuration was supplied but isn't a known config

2020-06-04 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17126067#comment-17126067 ] Chia-Ping Tsai commented on KAFKA-10090: [~rwruck] Are you working at it? I can

[jira] [Created] (KAFKA-10102) Source node references not updated after rebuilding topology

2020-06-04 Thread Sophie Blee-Goldman (Jira)
Sophie Blee-Goldman created KAFKA-10102: --- Summary: Source node references not updated after rebuilding topology Key: KAFKA-10102 URL: https://issues.apache.org/jira/browse/KAFKA-10102 Project: K

[GitHub] [kafka] hachikuji commented on pull request #8724: KAFKA-10040; Make computing the PreferredReplicaImbalanceCount metric more efficient

2020-06-04 Thread GitBox
hachikuji commented on pull request #8724: URL: https://github.com/apache/kafka/pull/8724#issuecomment-638962844 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] ableegoldman commented on a change in pull request #8775: KAFKA-10079: improve thread-level stickiness

2020-06-04 Thread GitBox
ableegoldman commented on a change in pull request #8775: URL: https://github.com/apache/kafka/pull/8775#discussion_r435374125 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/assignment/ClientStateTest.java ## @@ -300,20 +302,71 @@ public void

[jira] [Commented] (KAFKA-10101) recovery point is advanced without flushing the data after recovery

2020-06-04 Thread Jun Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17126036#comment-17126036 ] Jun Rao commented on KAFKA-10101: - If this is an issue, one way to fix that is to simply

[GitHub] [kafka] bbejeck commented on pull request #8789: MINOR: Fix the javadoc broken links of streams

2020-06-04 Thread GitBox
bbejeck commented on pull request #8789: URL: https://github.com/apache/kafka/pull/8789#issuecomment-638945282 Java 11 failed with `java.lang.OutOfMemoryError: unable to create native thread: possibly out of memory or process/resource limits reached` --

[jira] [Commented] (KAFKA-10101) recovery point is advanced without flushing the data after recovery

2020-06-04 Thread Jun Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17126023#comment-17126023 ] Jun Rao commented on KAFKA-10101: - [~ijuma] : Could you double check if this is an issue

[jira] [Resolved] (KAFKA-9576) Topic creation failure causing Stream thread death

2020-06-04 Thread Boyang Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Boyang Chen resolved KAFKA-9576. Resolution: Duplicate > Topic creation failure causing Stream thread death > --

[jira] [Created] (KAFKA-10101) recovery point is advanced without flushing the data after recovery

2020-06-04 Thread Jun Rao (Jira)
Jun Rao created KAFKA-10101: --- Summary: recovery point is advanced without flushing the data after recovery Key: KAFKA-10101 URL: https://issues.apache.org/jira/browse/KAFKA-10101 Project: Kafka Is

[jira] [Commented] (KAFKA-10097) Avoid getting null map for task checkpoint

2020-06-04 Thread Boyang Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10097?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17126001#comment-17126001 ] Boyang Chen commented on KAFKA-10097: - [~feyman] Thank you for the interest! Unfortu

[jira] [Commented] (KAFKA-10100) LiveLeaders field in LeaderAndIsrRequest is not used anymore

2020-06-04 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17125984#comment-17125984 ] Ismael Juma commented on KAFKA-10100: - I had noticed this too. I was wondering if it

[GitHub] [kafka] mimaison merged pull request #8311: KAFKA-9434: automated protocol for alterReplicaLogDirs

2020-06-04 Thread GitBox
mimaison merged pull request #8311: URL: https://github.com/apache/kafka/pull/8311 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

  1   2   >