[GitHub] [kafka] VinceMu commented on pull request #8666: KAFKA-9479: Describe consumer group --state --all-groups show header once

2020-06-20 Thread GitBox
VinceMu commented on pull request #8666: URL: https://github.com/apache/kafka/pull/8666#issuecomment-646962690 @dajac just following up on this PR, I've addressed your feedback. Ready for a re-review. This is an automated me

[GitHub] [kafka] Hangleton closed pull request #7160: [KIP-498][KAFKA-4090] Add client-side configuration for maximum response size

2020-06-20 Thread GitBox
Hangleton closed pull request #7160: URL: https://github.com/apache/kafka/pull/7160 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] vitojeng opened a new pull request #8907: MINOR: code cleanup for `VOut` inconsistent naming

2020-06-20 Thread GitBox
vitojeng opened a new pull request #8907: URL: https://github.com/apache/kafka/pull/8907 There are two kind of naming of VOut in Streams module: VOut / Vout. This PR rename the naming of Vout to VOut. ### Committer Checklist (excluded from commit message) - [ ] Verify design and

[GitHub] [kafka] vitojeng opened a new pull request #8908: MINOR: fix warning of javadoc task

2020-06-20 Thread GitBox
vitojeng opened a new pull request #8908: URL: https://github.com/apache/kafka/pull/8908 Fix following task warning: ``` > Task :streams:javadoc /Users/vitojeng/kafka/streams/src/main/java/org/apache/kafka/streams/kstream/CogroupedKStream.java:187: warning - invalid usage of tag <

[GitHub] [kafka] dongjinleekr commented on pull request #8130: MINOR: trivial cleanups, javadoc errors, omitted StateStore tests, etc.

2020-06-20 Thread GitBox
dongjinleekr commented on pull request #8130: URL: https://github.com/apache/kafka/pull/8130#issuecomment-646991777 @mjsax Here is the fix. I investigated the problem and found the following. The root of the problem is: the consturctors of `XXXStoreBuilder` classes omit the MetricsSc

[GitHub] [kafka] dongjinleekr edited a comment on pull request #8130: MINOR: trivial cleanups, javadoc errors, omitted StateStore tests, etc.

2020-06-20 Thread GitBox
dongjinleekr edited a comment on pull request #8130: URL: https://github.com/apache/kafka/pull/8130#issuecomment-646991777 @mjsax Here is the fix. I investigated the problem and found the following. The root of the problem is: the consturctors of `XXXStoreBuilder` classes omit the Me

[GitHub] [kafka] chia7712 commented on a change in pull request #8905: KAFKA-10173: Directly use Arrays.equals for version comparison

2020-06-20 Thread GitBox
chia7712 commented on a change in pull request #8905: URL: https://github.com/apache/kafka/pull/8905#discussion_r443137719 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/InMemoryTimeOrderedKeyValueBuffer.java ## @@ -58,10 +59,12 @@ public final c

[GitHub] [kafka] chia7712 commented on a change in pull request #8905: KAFKA-10173: Directly use Arrays.equals for version comparison

2020-06-20 Thread GitBox
chia7712 commented on a change in pull request #8905: URL: https://github.com/apache/kafka/pull/8905#discussion_r443137945 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/InMemoryTimeOrderedKeyValueBuffer.java ## @@ -299,16 +311,6 @@ private void r

[GitHub] [kafka] chia7712 commented on pull request #8840: KAFKA-10129 Fail QA if there are javadoc warnings

2020-06-20 Thread GitBox
chia7712 commented on pull request #8840: URL: https://github.com/apache/kafka/pull/8840#issuecomment-647008308 @ijuma @hachikuji Could you take a look? This is an automated message from the Apache Git Service. To respond to

[GitHub] [kafka] junrao commented on pull request #8657: KAFKA-8334 Make sure the thread which tries to complete delayed reque…

2020-06-20 Thread GitBox
junrao commented on pull request #8657: URL: https://github.com/apache/kafka/pull/8657#issuecomment-647020292 This is a second run of the system tests. http://testing.confluent.io/confluent-kafka-branch-builder-system-test-results/?prefix=2020-06-19--001.1592614513--chia7712--fix_8334_avoid

[GitHub] [kafka] abbccdda commented on pull request #8549: KAFKA-9911: Add new PRODUCER_FENCED error code

2020-06-20 Thread GitBox
abbccdda commented on pull request #8549: URL: https://github.com/apache/kafka/pull/8549#issuecomment-647041336 @zhaohaidao Thanks for taking a look. I think the KIP description is wrong about this scenario, as for a transaction coordinator RPC, it will: 1. return INVALID_PRODUCER_EPOCH

[GitHub] [kafka] mmolimar commented on a change in pull request #7496: KAFKA-9018: Throw clearer exceptions on serialisation errors

2020-06-20 Thread GitBox
mmolimar commented on a change in pull request #7496: URL: https://github.com/apache/kafka/pull/7496#discussion_r443157994 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSinkTask.java ## @@ -507,6 +508,18 @@ private SinkRecord convertAndTran

[GitHub] [kafka] abbccdda commented on a change in pull request #8887: KAFKA-10135: Extract Task#executeAndMaybeSwallow to be a general utility function into TaskManager…

2020-06-20 Thread GitBox
abbccdda commented on a change in pull request #8887: URL: https://github.com/apache/kafka/pull/8887#discussion_r443159967 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -741,29 +741,23 @@ void shutdown(final boolean cle

[GitHub] [kafka] abbccdda closed pull request #8498: MINOR: make serialize function naming more explicit

2020-06-20 Thread GitBox
abbccdda closed pull request #8498: URL: https://github.com/apache/kafka/pull/8498 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[jira] [Commented] (KAFKA-10121) Streams Task Assignment optimization design

2020-06-20 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17141289#comment-17141289 ] Guozhang Wang commented on KAFKA-10121: --- Thanks for filing this ticket John! Since

[GitHub] [kafka] guozhangwang commented on a change in pull request #8905: KAFKA-10173: Directly use Arrays.equals for version comparison

2020-06-20 Thread GitBox
guozhangwang commented on a change in pull request #8905: URL: https://github.com/apache/kafka/pull/8905#discussion_r443180740 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/InMemoryTimeOrderedKeyValueBuffer.java ## @@ -58,10 +59,12 @@ public fin

[jira] [Updated] (KAFKA-10173) BufferUnderflowException during Kafka Streams Upgrade

2020-06-20 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-10173: -- Labels: suppress (was: ) > BufferUnderflowException during Kafka Streams Upgrade > --

[GitHub] [kafka] chia7712 commented on a change in pull request #8905: KAFKA-10173: Directly use Arrays.equals for version comparison

2020-06-20 Thread GitBox
chia7712 commented on a change in pull request #8905: URL: https://github.com/apache/kafka/pull/8905#discussion_r443184029 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/InMemoryTimeOrderedKeyValueBuffer.java ## @@ -58,10 +59,12 @@ public final c