[GitHub] [kafka] abbccdda opened a new pull request #8940: KAFKA-10181: AlterConfig/IncrementalAlterConfig should route to the controller for topic resource changes

2020-06-27 Thread GitBox
abbccdda opened a new pull request #8940: URL: https://github.com/apache/kafka/pull/8940 Per KIP-590 requirement, we need to route the AlterConfig protocols toward the controller, instead of letting individual brokers handle them. ### Committer Checklist (excluded from commit

[jira] [Created] (KAFKA-10208) org.apache.kafka.clients.consumer.internals.ConsumerCoordinator.OffsetFetchResponseHandler return null when Broker unexpectedly doesn't support requireStable flag on ver

2020-06-27 Thread lqjacklee (Jira)
lqjacklee created KAFKA-10208: - Summary: org.apache.kafka.clients.consumer.internals.ConsumerCoordinator.OffsetFetchResponseHandler return null when Broker unexpectedly doesn't support requireStable flag on version while not any information

[GitHub] [kafka] chia7712 commented on a change in pull request #8910: KAFKA-10188: Prevent SinkTask::preCommit from being called after SinkTask::stop

2020-06-27 Thread GitBox
chia7712 commented on a change in pull request #8910: URL: https://github.com/apache/kafka/pull/8910#discussion_r446600419 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSinkTask.java ## @@ -138,6 +139,7 @@ public

[jira] [Commented] (KAFKA-10205) NullPointerException in StreamTask (Kafka Streams 2.5.0)

2020-06-27 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17147171#comment-17147171 ] John Roesler commented on KAFKA-10205: -- Hi Brian, I’m sorry to hear that. I’ll try and take a look

[GitHub] [kafka] C0urante commented on a change in pull request #8910: KAFKA-10188: Prevent SinkTask::preCommit from being called after SinkTask::stop

2020-06-27 Thread GitBox
C0urante commented on a change in pull request #8910: URL: https://github.com/apache/kafka/pull/8910#discussion_r446586612 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSinkTask.java ## @@ -138,6 +139,7 @@ public

[GitHub] [kafka] d8tltanc commented on pull request #8683: KAFKA-9893: Configurable TCP connection timeout and improve the initial metadata fetch

2020-06-27 Thread GitBox
d8tltanc commented on pull request #8683: URL: https://github.com/apache/kafka/pull/8683#issuecomment-650651194 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka] vitojeng opened a new pull request #8939: MINOR: rename class `RecordTimeDefintion` to `RecordTimeDefinition`

2020-06-27 Thread GitBox
vitojeng opened a new pull request #8939: URL: https://github.com/apache/kafka/pull/8939 The naming of internal class `RecordTimeDefintion` in streams module should be a typo. This PR fix it to `RecordTimeDefinition`. ### Committer Checklist (excluded from commit message) - [

[GitHub] [kafka] vvcephei commented on a change in pull request #8938: KAFKA-10173: Use SmokeTest for upgrade system tests

2020-06-27 Thread GitBox
vvcephei commented on a change in pull request #8938: URL: https://github.com/apache/kafka/pull/8938#discussion_r446551977 ## File path: streams/src/test/java/org/apache/kafka/streams/tests/SmokeTestClient.java ## @@ -38,107 +37,128 @@ import

[jira] [Commented] (KAFKA-10173) BufferUnderflowException during Kafka Streams Upgrade

2020-06-27 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17147049#comment-17147049 ] John Roesler commented on KAFKA-10173: -- Here's the system test PR:

[GitHub] [kafka] vvcephei opened a new pull request #8938: KAFKA-10173: Use SmokeTest for upgrade system tests

2020-06-27 Thread GitBox
vvcephei opened a new pull request #8938: URL: https://github.com/apache/kafka/pull/8938 Replaces the previous upgrade test's trivial Streams app with the commonly used SmokeTest, exercising many more features. Also adjust the test matrix to test upgrading from each released

[GitHub] [kafka] chia7712 commented on a change in pull request #8826: KAFKA-10090 Misleading warnings: The configuration was supplied but i…

2020-06-27 Thread GitBox
chia7712 commented on a change in pull request #8826: URL: https://github.com/apache/kafka/pull/8826#discussion_r446547308 ## File path: clients/src/main/java/org/apache/kafka/common/network/ChannelBuilders.java ## @@ -159,24 +159,23 @@ private static ChannelBuilder

[GitHub] [kafka] chia7712 commented on pull request #8657: KAFKA-8334 Make sure the thread which tries to complete delayed reque…

2020-06-27 Thread GitBox
chia7712 commented on pull request #8657: URL: https://github.com/apache/kafka/pull/8657#issuecomment-650586275 > Perhaps you can rebase again. done This is an automated message from the Apache Git Service. To respond

[GitHub] [kafka] abbccdda commented on a change in pull request #8826: KAFKA-10090 Misleading warnings: The configuration was supplied but i…

2020-06-27 Thread GitBox
abbccdda commented on a change in pull request #8826: URL: https://github.com/apache/kafka/pull/8826#discussion_r446543686 ## File path: clients/src/main/java/org/apache/kafka/common/network/ChannelBuilders.java ## @@ -159,24 +159,23 @@ private static ChannelBuilder

[GitHub] [kafka] junrao commented on pull request #8917: KAFKA-10180: Fix security_config caching.

2020-06-27 Thread GitBox
junrao commented on pull request #8917: URL: https://github.com/apache/kafka/pull/8917#issuecomment-650583823 @rhauch : This PR may fix a bunch of system tests in 2.6 too. Since 2.6.0 is code freeze now, I will let you decide if you want to merge this PR to 2.6.

[GitHub] [kafka] junrao commented on pull request #8657: KAFKA-8334 Make sure the thread which tries to complete delayed reque…

2020-06-27 Thread GitBox
junrao commented on pull request #8657: URL: https://github.com/apache/kafka/pull/8657#issuecomment-650583070 @chia7712 I just merged the PR for KAFKA-10180. Perhaps you can rebase again. This is an automated message from

[GitHub] [kafka] junrao merged pull request #8917: KAFKA-10180: Fix security_config caching.

2020-06-27 Thread GitBox
junrao merged pull request #8917: URL: https://github.com/apache/kafka/pull/8917 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] junrao commented on pull request #8917: KAFKA-10180: Fix security_config caching.

2020-06-27 Thread GitBox
junrao commented on pull request #8917: URL: https://github.com/apache/kafka/pull/8917#issuecomment-650582039 Results of the system tests: Down to 13 failures and all benchmark related failures are gone.

[GitHub] [kafka] omkreddy opened a new pull request #8937: MINOR: Create ChannelBuilder for each connection in ConnectionStressWorker workload

2020-06-27 Thread GitBox
omkreddy opened a new pull request #8937: URL: https://github.com/apache/kafka/pull/8937 - Currently we create single channel builder and reuse it in ConnectStressor workload. This will fail when testing with secure connections, as we close channel builder after first connection. This

[GitHub] [kafka] feyman2016 commented on pull request #8832: KAFKA-9377: Refactor StreamsPartitionAssignor Repartition Count Logic

2020-06-27 Thread GitBox
feyman2016 commented on pull request #8832: URL: https://github.com/apache/kafka/pull/8832#issuecomment-650535027 @abbccdda I merged the trunk and found that `StreamsPartitionAssignor` has been updated by other PRs so it's `ClassFanOutComplexity` goes up to 49, and it will definitely

[GitHub] [kafka] feyman2016 commented on a change in pull request #8832: KAFKA-9377: Refactor StreamsPartitionAssignor Repartition Count Logic

2020-06-27 Thread GitBox
feyman2016 commented on a change in pull request #8832: URL: https://github.com/apache/kafka/pull/8832#discussion_r446507665 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java ## @@ -147,6 +147,71 @@ public String

[GitHub] [kafka] feyman2016 commented on a change in pull request #8832: KAFKA-9377: Refactor StreamsPartitionAssignor Repartition Count Logic

2020-06-27 Thread GitBox
feyman2016 commented on a change in pull request #8832: URL: https://github.com/apache/kafka/pull/8832#discussion_r446507613 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java ## @@ -147,6 +147,71 @@ public String

[GitHub] [kafka] chia7712 commented on a change in pull request #8910: KAFKA-10188: Prevent SinkTask::preCommit from being called after SinkTask::stop

2020-06-27 Thread GitBox
chia7712 commented on a change in pull request #8910: URL: https://github.com/apache/kafka/pull/8910#discussion_r446496984 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSinkTask.java ## @@ -138,6 +139,7 @@ public

[GitHub] [kafka] chia7712 commented on pull request #8657: KAFKA-8334 Make sure the thread which tries to complete delayed reque…

2020-06-27 Thread GitBox
chia7712 commented on pull request #8657: URL: https://github.com/apache/kafka/pull/8657#issuecomment-650503360 > For comparison, 29 test failures in trunk http://testing.confluent.io/confluent-kafka-system-test-results/?prefix=2020-06-25--001.1593132363--apache--trunk--3348fc49d/

[GitHub] [kafka] C0urante commented on a change in pull request #8910: KAFKA-10188: Prevent SinkTask::preCommit from being called after SinkTask::stop

2020-06-27 Thread GitBox
C0urante commented on a change in pull request #8910: URL: https://github.com/apache/kafka/pull/8910#discussion_r446490310 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSinkTask.java ## @@ -689,6 +692,10 @@ else if

[GitHub] [kafka] C0urante commented on a change in pull request #8910: KAFKA-10188: Prevent SinkTask::preCommit from being called after SinkTask::stop

2020-06-27 Thread GitBox
C0urante commented on a change in pull request #8910: URL: https://github.com/apache/kafka/pull/8910#discussion_r446490310 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSinkTask.java ## @@ -689,6 +692,10 @@ else if