[GitHub] [kafka] abbccdda commented on pull request #8974: KAFKA-10225 Increase default zk session timeout for system tests

2020-07-01 Thread GitBox
abbccdda commented on pull request #8974: URL: https://github.com/apache/kafka/pull/8974#issuecomment-652814853 cc @hachikuji This is an automated message from the Apache Git Service. To respond to the message, please log on

[jira] [Assigned] (KAFKA-10175) MetadataCache::getClusterMetadata returns null for offline replicas

2020-07-01 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma reassigned KAFKA-10175: --- Assignee: Ismael Juma > MetadataCache::getClusterMetadata returns null for offline replicas

[GitHub] [kafka] chia7712 commented on a change in pull request #8974: KAFKA-10225 Increase default zk session timeout for system tests

2020-07-01 Thread GitBox
chia7712 commented on a change in pull request #8974: URL: https://github.com/apache/kafka/pull/8974#discussion_r448768019 ## File path: tests/kafkatest/services/kafka/config.py ## @@ -25,7 +25,7 @@ class KafkaConfig(dict): config_property.PORT: 9092, config_p

[GitHub] [kafka] chia7712 opened a new pull request #8974: KAFKA-10225 Increase default zk session timeout for system tests

2020-07-01 Thread GitBox
chia7712 opened a new pull request #8974: URL: https://github.com/apache/kafka/pull/8974 I'm digging in the flaky system tests and then I noticed there are many flaky caused by following check. ```python with node.account.monitor_log(KafkaService.STDOUT_STDERR_CAPTURE) as mon

[jira] [Updated] (KAFKA-10225) Increase default zk session timeout for system tests

2020-07-01 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-10225: --- Summary: Increase default zk session timeout for system tests (was: Increase default zk ses

[jira] [Commented] (KAFKA-10225) Increase default zk session timeout for system test

2020-07-01 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17149936#comment-17149936 ] Chia-Ping Tsai commented on KAFKA-10225: I increased the timeout to 6 seconds an

[jira] [Created] (KAFKA-10225) Increase default zk session timeout for system test

2020-07-01 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-10225: -- Summary: Increase default zk session timeout for system test Key: KAFKA-10225 URL: https://issues.apache.org/jira/browse/KAFKA-10225 Project: Kafka Issue

[GitHub] [kafka] ijuma commented on pull request #8579: KAFKA-9930: Prevent ReplicaFetcherThread from throwing UnknownTopicOrPartitionException upon topic creation and deletion.

2020-07-01 Thread GitBox
ijuma commented on pull request #8579: URL: https://github.com/apache/kafka/pull/8579#issuecomment-652800669 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [kafka] ijuma commented on pull request #7283: KAFKA-8862: Use consistent exception messages for nonexistent partition

2020-07-01 Thread GitBox
ijuma commented on pull request #7283: URL: https://github.com/apache/kafka/pull/7283#issuecomment-652800558 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log o

[jira] [Updated] (KAFKA-10223) ReplicaNotAvailableException must be retriable to handle reassignments

2020-07-01 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-10223: Priority: Critical (was: Major) > ReplicaNotAvailableException must be retriable to handle reassi

[GitHub] [kafka] ijuma commented on pull request #8972: MINOR: Update Netty to 4.1.50.Final

2020-07-01 Thread GitBox
ijuma commented on pull request #8972: URL: https://github.com/apache/kafka/pull/8972#issuecomment-652800251 Merged to trunk and cherry-picked to 2.6, 2.5 and 2.4 branches. This is an automated message from the Apache Git Ser

[GitHub] [kafka] ijuma merged pull request #8972: MINOR: Update Netty to 4.1.50.Final

2020-07-01 Thread GitBox
ijuma merged pull request #8972: URL: https://github.com/apache/kafka/pull/8972 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] ijuma commented on pull request #8972: MINOR: Update Netty to 4.1.50.Final

2020-07-01 Thread GitBox
ijuma commented on pull request #8972: URL: https://github.com/apache/kafka/pull/8972#issuecomment-652793777 Same set of tests failed again. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] abbccdda commented on pull request #8712: KAFKA-10006: Don't create internal topics when LeaderNotAvailableException

2020-07-01 Thread GitBox
abbccdda commented on pull request #8712: URL: https://github.com/apache/kafka/pull/8712#issuecomment-652778801 retest this please This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [kafka] ijuma commented on a change in pull request #8970: MINOR: Improve logging around initial log loading

2020-07-01 Thread GitBox
ijuma commented on a change in pull request #8970: URL: https://github.com/apache/kafka/pull/8970#discussion_r448743973 ## File path: core/src/main/scala/kafka/log/LogManager.scala ## @@ -321,25 +325,32 @@ class LogManager(logDirs: Seq[File], recoveryPoints = this.re

[GitHub] [kafka] ijuma commented on a change in pull request #8970: MINOR: Improve logging around initial log loading

2020-07-01 Thread GitBox
ijuma commented on a change in pull request #8970: URL: https://github.com/apache/kafka/pull/8970#discussion_r448743973 ## File path: core/src/main/scala/kafka/log/LogManager.scala ## @@ -321,25 +325,32 @@ class LogManager(logDirs: Seq[File], recoveryPoints = this.re

[GitHub] [kafka] ijuma commented on pull request #8963: KAFKA-10017: fix flaky EosBetaUpgradeIntegrationTest

2020-07-01 Thread GitBox
ijuma commented on pull request #8963: URL: https://github.com/apache/kafka/pull/8963#issuecomment-652774552 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [kafka] ijuma commented on pull request #8963: KAFKA-10017: fix flaky EosBetaUpgradeIntegrationTest

2020-07-01 Thread GitBox
ijuma commented on pull request #8963: URL: https://github.com/apache/kafka/pull/8963#issuecomment-652774323 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [kafka] ableegoldman edited a comment on pull request #8963: KAFKA-10017: fix flaky EosBetaUpgradeIntegrationTest

2020-07-01 Thread GitBox
ableegoldman edited a comment on pull request #8963: URL: https://github.com/apache/kafka/pull/8963#issuecomment-652773774 Looks like it only failed one time across all three builds in the last run. But I pushed some fixes for the remaining flakiness: 1. Use the IntegrationTestUtils `#ge

[GitHub] [kafka] ableegoldman commented on pull request #8963: KAFKA-10017: fix flaky EosBetaUpgradeIntegrationTest

2020-07-01 Thread GitBox
ableegoldman commented on pull request #8963: URL: https://github.com/apache/kafka/pull/8963#issuecomment-652773774 Looks like it only failed one time across all three builds in the last run. But I pushed some fixes for the remaining flakiness: 1. Use the IntegrationTestUtils `#getStore`

[GitHub] [kafka] ijuma commented on pull request #8972: MINOR: Update Netty to 4.1.50.Final

2020-07-01 Thread GitBox
ijuma commented on pull request #8972: URL: https://github.com/apache/kafka/pull/8972#issuecomment-652773655 Looks like these tests are extremely flaky: > org.apache.kafka.connect.mirror.MirrorConnectorsIntegrationTest.testOneWayReplicationWithAutorOffsetSync1 > org.apache.kafka.

[jira] [Commented] (KAFKA-10134) High CPU issue during rebalance in Kafka consumer after upgrading to 2.5

2020-07-01 Thread Sean Guo (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17149812#comment-17149812 ] Sean Guo commented on KAFKA-10134: -- [~guozhang] Looks like this also resolves our issue

[GitHub] [kafka] ijuma commented on a change in pull request #8970: MINOR: Improve logging around initial log loading

2020-07-01 Thread GitBox
ijuma commented on a change in pull request #8970: URL: https://github.com/apache/kafka/pull/8970#discussion_r448723895 ## File path: core/src/main/scala/kafka/log/LogManager.scala ## @@ -308,11 +312,11 @@ class LogManager(logDirs: Seq[File], threadPools.append(pool)

[GitHub] [kafka] chia7712 commented on a change in pull request #8936: KAFKA-10207: Fixed padded timeindex causing premature data deletion

2020-07-01 Thread GitBox
chia7712 commented on a change in pull request #8936: URL: https://github.com/apache/kafka/pull/8936#discussion_r448723974 ## File path: core/src/test/scala/unit/kafka/log/TimeIndexTest.scala ## @@ -148,5 +148,39 @@ class TimeIndexTest { idx.close() } -} + /** +

[GitHub] [kafka] ijuma commented on pull request #8972: MINOR: Update Netty to 4.1.50.Final

2020-07-01 Thread GitBox
ijuma commented on pull request #8972: URL: https://github.com/apache/kafka/pull/8972#issuecomment-652749665 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [kafka] ableegoldman commented on a change in pull request #8962: KAFKA-10166: checkpoint recycled standbys and ignore empty rocksdb base directory

2020-07-01 Thread GitBox
ableegoldman commented on a change in pull request #8962: URL: https://github.com/apache/kafka/pull/8962#discussion_r448715259 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorStateManager.java ## @@ -578,4 +580,14 @@ private StateStore

[GitHub] [kafka] ableegoldman commented on a change in pull request #8962: KAFKA-10166: checkpoint recycled standbys and ignore empty rocksdb base directory

2020-07-01 Thread GitBox
ableegoldman commented on a change in pull request #8962: URL: https://github.com/apache/kafka/pull/8962#discussion_r448714590 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -270,8 +270,11 @@ public void handleAssignment

[GitHub] [kafka] ableegoldman commented on a change in pull request #8962: KAFKA-10166: checkpoint recycled standbys and ignore empty rocksdb base directory

2020-07-01 Thread GitBox
ableegoldman commented on a change in pull request #8962: URL: https://github.com/apache/kafka/pull/8962#discussion_r448712536 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -270,8 +270,11 @@ public void handleAssignment

[GitHub] [kafka] chia7712 commented on a change in pull request #8913: KAFKA-10191 fix flaky StreamsOptimizedTest

2020-07-01 Thread GitBox
chia7712 commented on a change in pull request #8913: URL: https://github.com/apache/kafka/pull/8913#discussion_r448711625 ## File path: core/src/main/scala/kafka/tools/StreamsResetter.java ## @@ -168,7 +168,7 @@ public int run(final String[] args, consumerConfig.p

[GitHub] [kafka] vvcephei commented on a change in pull request #8962: KAFKA-10166: checkpoint recycled standbys and ignore empty rocksdb base directory

2020-07-01 Thread GitBox
vvcephei commented on a change in pull request #8962: URL: https://github.com/apache/kafka/pull/8962#discussion_r448706412 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -270,8 +270,11 @@ public void handleAssignment(fin

[GitHub] [kafka] vvcephei commented on a change in pull request #8962: KAFKA-10166: checkpoint recycled standbys and ignore empty rocksdb base directory

2020-07-01 Thread GitBox
vvcephei commented on a change in pull request #8962: URL: https://github.com/apache/kafka/pull/8962#discussion_r448704778 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StateDirectory.java ## @@ -136,7 +143,59 @@ private boolean taskDirEmpty(

[GitHub] [kafka] vvcephei commented on pull request #8971: MINOR: prune the metadata upgrade test matrix

2020-07-01 Thread GitBox
vvcephei commented on pull request #8971: URL: https://github.com/apache/kafka/pull/8971#issuecomment-652732162 great success! http://confluent-kafka-branch-builder-system-test-results.s3-us-west-2.amazonaws.com/2020-07-01--001.1593639364--vvcephei--minor-prune-meta-upgrade-test-matrix--9d1

[GitHub] [kafka] vvcephei commented on a change in pull request #8938: KAFKA-10173: Use SmokeTest for upgrade system tests

2020-07-01 Thread GitBox
vvcephei commented on a change in pull request #8938: URL: https://github.com/apache/kafka/pull/8938#discussion_r448704043 ## File path: tests/kafkatest/tests/streams/streams_application_upgrade_test.py ## @@ -0,0 +1,297 @@ +# Licensed to the Apache Software Foundation (ASF) un

[GitHub] [kafka] ableegoldman commented on a change in pull request #8962: KAFKA-10166: checkpoint recycled standbys and ignore empty rocksdb base directory

2020-07-01 Thread GitBox
ableegoldman commented on a change in pull request #8962: URL: https://github.com/apache/kafka/pull/8962#discussion_r448703709 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StateDirectory.java ## @@ -136,7 +143,59 @@ private boolean taskDirEm

[GitHub] [kafka] ableegoldman commented on a change in pull request #8913: KAFKA-10191 fix flaky StreamsOptimizedTest

2020-07-01 Thread GitBox
ableegoldman commented on a change in pull request #8913: URL: https://github.com/apache/kafka/pull/8913#discussion_r448698768 ## File path: tests/kafkatest/services/streams.py ## @@ -445,6 +449,40 @@ def __init__(self, test_context, kafka, configs):

[GitHub] [kafka] guozhangwang commented on a change in pull request #8964: KAFKA-9450: Decouple flushing state from commiting

2020-07-01 Thread GitBox
guozhangwang commented on a change in pull request #8964: URL: https://github.com/apache/kafka/pull/8964#discussion_r448690022 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -478,9 +479,11 @@ void handleRevocation(final

[GitHub] [kafka] showuon commented on pull request #8712: KAFKA-10006: Don't create internal topics when LeaderNotAvailableException

2020-07-01 Thread GitBox
showuon commented on pull request #8712: URL: https://github.com/apache/kafka/pull/8712#issuecomment-652713031 @abbccdda , thanks for pointing out the duplicate line. I didn't notice it, My bad! I've fixed. Thanks. This is a

[GitHub] [kafka] showuon commented on a change in pull request #8712: KAFKA-10006: Don't create internal topics when LeaderNotAvailableException

2020-07-01 Thread GitBox
showuon commented on a change in pull request #8712: URL: https://github.com/apache/kafka/pull/8712#discussion_r448685224 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/InternalTopicManagerTest.java ## @@ -287,12 +290,124 @@ public void shoul

[GitHub] [kafka] ableegoldman commented on pull request #8962: KAFKA-10166: checkpoint recycled standbys and ignore empty rocksdb base directory

2020-07-01 Thread GitBox
ableegoldman commented on pull request #8962: URL: https://github.com/apache/kafka/pull/8962#issuecomment-652710895 1. The problem occurs when the original standby task does reach RUNNING and delete the checkpoint, then gets recycled to an active task. If the new active task doesn't get ou

[GitHub] [kafka] ableegoldman commented on a change in pull request #8962: KAFKA-10166: checkpoint recycled standbys and ignore empty rocksdb base directory

2020-07-01 Thread GitBox
ableegoldman commented on a change in pull request #8962: URL: https://github.com/apache/kafka/pull/8962#discussion_r448681797 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -270,8 +270,11 @@ public void handleAssignment

[GitHub] [kafka] guozhangwang commented on pull request #8963: KAFKA-10017: fix flaky EosBetaUpgradeIntegrationTest

2020-07-01 Thread GitBox
guozhangwang commented on pull request #8963: URL: https://github.com/apache/kafka/pull/8963#issuecomment-652709044 test this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] ableegoldman commented on a change in pull request #8962: KAFKA-10166: checkpoint recycled standbys and ignore empty rocksdb base directory

2020-07-01 Thread GitBox
ableegoldman commented on a change in pull request #8962: URL: https://github.com/apache/kafka/pull/8962#discussion_r448680662 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StateDirectory.java ## @@ -136,7 +143,59 @@ private boolean taskDirEm

[GitHub] [kafka] ableegoldman commented on a change in pull request #8962: KAFKA-10166: checkpoint recycled standbys and ignore empty rocksdb base directory

2020-07-01 Thread GitBox
ableegoldman commented on a change in pull request #8962: URL: https://github.com/apache/kafka/pull/8962#discussion_r448680586 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StateDirectory.java ## @@ -136,7 +143,59 @@ private boolean taskDirEm

[GitHub] [kafka] guozhangwang commented on pull request #8962: KAFKA-10166: checkpoint recycled standbys and ignore empty rocksdb base directory

2020-07-01 Thread GitBox
guozhangwang commented on pull request #8962: URL: https://github.com/apache/kafka/pull/8962#issuecomment-652708018 > 2\. But just opening a rocksdb store creates a `rocksdb` base dir in the task directory, so the `taskDirIsEmpty` check always fails and we always throw TaskCorrupted even i

[GitHub] [kafka] guozhangwang commented on pull request #8962: KAFKA-10166: checkpoint recycled standbys and ignore empty rocksdb base directory

2020-07-01 Thread GitBox
guozhangwang commented on pull request #8962: URL: https://github.com/apache/kafka/pull/8962#issuecomment-652701636 > * Need to write the checkpoint when recycling a standby: although we do preserve the changelog offsets when recycling a task, and should therefore write the offsets when th

[GitHub] [kafka] omkreddy merged pull request #8969: MINOR: Update introduction.html

2020-07-01 Thread GitBox
omkreddy merged pull request #8969: URL: https://github.com/apache/kafka/pull/8969 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] guozhangwang commented on pull request #8938: KAFKA-10173: Use SmokeTest for upgrade system tests

2020-07-01 Thread GitBox
guozhangwang commented on pull request #8938: URL: https://github.com/apache/kafka/pull/8938#issuecomment-652681930 LGTM. This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [kafka] guozhangwang commented on a change in pull request #8938: KAFKA-10173: Use SmokeTest for upgrade system tests

2020-07-01 Thread GitBox
guozhangwang commented on a change in pull request #8938: URL: https://github.com/apache/kafka/pull/8938#discussion_r448653507 ## File path: tests/kafkatest/tests/streams/streams_application_upgrade_test.py ## @@ -0,0 +1,297 @@ +# Licensed to the Apache Software Foundation (ASF

[jira] [Resolved] (KAFKA-9678) Introduce bounded exponential backoff in clients

2020-07-01 Thread Sanjana Kaundinya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sanjana Kaundinya resolved KAFKA-9678. -- Resolution: Duplicate > Introduce bounded exponential backoff in clients >

[jira] [Reopened] (KAFKA-9678) Introduce bounded exponential backoff in clients

2020-07-01 Thread Sanjana Kaundinya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sanjana Kaundinya reopened KAFKA-9678: -- > Introduce bounded exponential backoff in clients > --

[jira] [Resolved] (KAFKA-9893) Configurable TCP connection timeout and improve the initial metadata fetch

2020-07-01 Thread Sanjana Kaundinya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sanjana Kaundinya resolved KAFKA-9893. -- Resolution: Implemented > Configurable TCP connection timeout and improve the initial m

[GitHub] [kafka] C0urante opened a new pull request #8973: KAFKA-10218: Stop reading config topic in every subsequent tick if catchup fails once

2020-07-01 Thread GitBox
C0urante opened a new pull request #8973: URL: https://github.com/apache/kafka/pull/8973 [Jira](https://issues.apache.org/jira/browse/KAFKA-10218) We added a `canReadConfigs` field to the `DistributedHerder` a while back that gets set to `false` if the herder fails to catch up to the

[jira] [Commented] (KAFKA-4090) JVM runs into OOM if (Java) client uses a SSL port without setting the security protocol

2020-07-01 Thread David Mollitor (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-4090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17149702#comment-17149702 ] David Mollitor commented on KAFKA-4090: --- [~adupriez] Any thoughts on this? > JVM r

[GitHub] [kafka] ableegoldman edited a comment on pull request #8913: KAFKA-10191 fix flaky StreamsOptimizedTest

2020-07-01 Thread GitBox
ableegoldman edited a comment on pull request #8913: URL: https://github.com/apache/kafka/pull/8913#issuecomment-652633092 Alright I checked this out and pulled in [this fix](https://github.com/apache/kafka/pull/8961) to add retries to the failing curl commands: let's give this yet another

[GitHub] [kafka] ableegoldman commented on pull request #8913: KAFKA-10191 fix flaky StreamsOptimizedTest

2020-07-01 Thread GitBox
ableegoldman commented on pull request #8913: URL: https://github.com/apache/kafka/pull/8913#issuecomment-652633092 Alright I checked this out and pulled in this fix to add retries to the failing curl commands: let's give this yet another try: https://jenkins.confluent.io/job/system-test-k

[GitHub] [kafka] vvcephei commented on a change in pull request #8962: KAFKA-10166: checkpoint recycled standbys and ignore empty rocksdb base directory

2020-07-01 Thread GitBox
vvcephei commented on a change in pull request #8962: URL: https://github.com/apache/kafka/pull/8962#discussion_r448598854 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -270,8 +270,11 @@ public void handleAssignment(fin

[GitHub] [kafka] vvcephei commented on pull request #8971: MINOR: prune the metadata upgrade test matrix

2020-07-01 Thread GitBox
vvcephei commented on pull request #8971: URL: https://github.com/apache/kafka/pull/8971#issuecomment-652625710 Oh, I realized this could plausibly impact the broker test also, so I kicked off a test of the whole file: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/4008/

[GitHub] [kafka] rajinisivaram merged pull request #8959: MINOR: Fix log entry in FetchSessionHandler to specify throttle correctly

2020-07-01 Thread GitBox
rajinisivaram merged pull request #8959: URL: https://github.com/apache/kafka/pull/8959 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] rajinisivaram commented on pull request #8959: MINOR: Fix log entry in FetchSessionHandler to specify throttle correctly

2020-07-01 Thread GitBox
rajinisivaram commented on pull request #8959: URL: https://github.com/apache/kafka/pull/8959#issuecomment-652624512 @dajac @omkreddy @cmccabe Thanks for the review, merging to trunk. This is an automated message from the Apa

[GitHub] [kafka] ijuma opened a new pull request #8972: MINOR: Update Netty to 4.1.50.Final

2020-07-01 Thread GitBox
ijuma opened a new pull request #8972: URL: https://github.com/apache/kafka/pull/8972 This includes important fixes. Netty is required by ZooKeeper if TLS is enabled. I verified that the netty jars were changed from 4.1.48 to 4.1.50 with this PR, `find . -name '*netty*'`:

[GitHub] [kafka] vvcephei commented on a change in pull request #8938: KAFKA-10173: Use SmokeTest for upgrade system tests

2020-07-01 Thread GitBox
vvcephei commented on a change in pull request #8938: URL: https://github.com/apache/kafka/pull/8938#discussion_r448586796 ## File path: tests/kafkatest/tests/streams/streams_application_upgrade_test.py ## @@ -0,0 +1,297 @@ +# Licensed to the Apache Software Foundation (ASF) un

[GitHub] [kafka] vvcephei commented on a change in pull request #8938: KAFKA-10173: Use SmokeTest for upgrade system tests

2020-07-01 Thread GitBox
vvcephei commented on a change in pull request #8938: URL: https://github.com/apache/kafka/pull/8938#discussion_r448584762 ## File path: tests/kafkatest/tests/streams/streams_upgrade_test.py ## @@ -189,54 +189,6 @@ def test_upgrade_downgrade_brokers(self, from_version, to_vers

[GitHub] [kafka] vvcephei opened a new pull request #8971: MINOR: prune the metadata upgrade test matrix

2020-07-01 Thread GitBox
vvcephei opened a new pull request #8971: URL: https://github.com/apache/kafka/pull/8971 Most of the values in the metadata upgrade test matrix are just testing the upgrade/downgrade path between two previous releases. This is unnecessary. We run the tests for all supported branches, s

[GitHub] [kafka] vvcephei commented on a change in pull request #8938: KAFKA-10173: Use SmokeTest for upgrade system tests

2020-07-01 Thread GitBox
vvcephei commented on a change in pull request #8938: URL: https://github.com/apache/kafka/pull/8938#discussion_r448583306 ## File path: tests/kafkatest/services/streams.py ## @@ -48,6 +48,15 @@ class StreamsTestBaseService(KafkaPathResolverMixin, JmxMixin, Service):

[GitHub] [kafka] vvcephei commented on a change in pull request #8938: KAFKA-10173: Use SmokeTest for upgrade system tests

2020-07-01 Thread GitBox
vvcephei commented on a change in pull request #8938: URL: https://github.com/apache/kafka/pull/8938#discussion_r448581607 ## File path: streams/src/test/java/org/apache/kafka/streams/tests/SmokeTestClient.java ## @@ -38,107 +37,128 @@ import org.apache.kafka.streams.kstream.

[jira] [Created] (KAFKA-10224) The license term about jersey is not correct

2020-07-01 Thread jaredli2020 (Jira)
jaredli2020 created KAFKA-10224: --- Summary: The license term about jersey is not correct Key: KAFKA-10224 URL: https://issues.apache.org/jira/browse/KAFKA-10224 Project: Kafka Issue Type: Bug

[GitHub] [kafka] guozhangwang commented on a change in pull request #8938: KAFKA-10173: Use SmokeTest for upgrade system tests

2020-07-01 Thread GitBox
guozhangwang commented on a change in pull request #8938: URL: https://github.com/apache/kafka/pull/8938#discussion_r448569679 ## File path: streams/src/test/java/org/apache/kafka/streams/tests/SmokeTestClient.java ## @@ -38,107 +37,128 @@ import org.apache.kafka.streams.kstr

[GitHub] [kafka] andrewchoi5 commented on a change in pull request #8479: KAFKA-9769: Finish operations for leaderEpoch-updated partitions up to point ZK Exception

2020-07-01 Thread GitBox
andrewchoi5 commented on a change in pull request #8479: URL: https://github.com/apache/kafka/pull/8479#discussion_r448569922 ## File path: core/src/main/scala/kafka/cluster/Partition.scala ## @@ -499,7 +500,15 @@ class Partition(val topicPartition: TopicPartition, add

[GitHub] [kafka] hachikuji opened a new pull request #8970: MINOR: Improve logging around initial log loading

2020-07-01 Thread GitBox
hachikuji opened a new pull request #8970: URL: https://github.com/apache/kafka/pull/8970 Users often get confused after an unclean shutdown when log recovery takes a long time. This patch attempts to make the logging clearer and provide a simple indication of loading progress. ###

[GitHub] [kafka] Wavez opened a new pull request #8969: Update introduction.html - fixed grammar

2020-07-01 Thread GitBox
Wavez opened a new pull request #8969: URL: https://github.com/apache/kafka/pull/8969 fixed grammar *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *S

[jira] [Resolved] (KAFKA-9018) Kafka Connect - throw clearer exceptions on serialisation errors

2020-07-01 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9018?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch resolved KAFKA-9018. -- Resolution: Fixed > Kafka Connect - throw clearer exceptions on serialisation errors >

[GitHub] [kafka] rhauch merged pull request #7496: KAFKA-9018: Throw clearer exceptions on serialisation errors

2020-07-01 Thread GitBox
rhauch merged pull request #7496: URL: https://github.com/apache/kafka/pull/7496 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] guozhangwang commented on pull request #8938: KAFKA-10173: Use SmokeTest for upgrade system tests

2020-07-01 Thread GitBox
guozhangwang commented on pull request #8938: URL: https://github.com/apache/kafka/pull/8938#issuecomment-652591278 > There's a bit of a chicken-and-egg problem here, since we can't add the downgrade tests _yet_, but what I can do is to create the tickets to both fix the known downgrade is

[GitHub] [kafka] guozhangwang commented on pull request #8934: KAFKA-10134: Use long poll if we do not have fetchable partitions

2020-07-01 Thread GitBox
guozhangwang commented on pull request #8934: URL: https://github.com/apache/kafka/pull/8934#issuecomment-652573659 > @guozhangwang Looks like the code is not compiling. I think you grabbed `binaryExponentialElectionBackoffMs` from the prototype Raft implementation, but we need to initiali

[GitHub] [kafka] vvcephei commented on pull request #8938: KAFKA-10173: Use SmokeTest for upgrade system tests

2020-07-01 Thread GitBox
vvcephei commented on pull request #8938: URL: https://github.com/apache/kafka/pull/8938#issuecomment-652572009 The existing `streams_upgrade_test.py` passes: http://confluent-kafka-branch-builder-system-test-results.s3-us-west-2.amazonaws.com/2020-07-01--001.1593623647--vvcephei--kafka-

[GitHub] [kafka] vvcephei commented on a change in pull request #8938: KAFKA-10173: Use SmokeTest for upgrade system tests

2020-07-01 Thread GitBox
vvcephei commented on a change in pull request #8938: URL: https://github.com/apache/kafka/pull/8938#discussion_r448531033 ## File path: tests/kafkatest/services/streams.py ## @@ -48,6 +48,15 @@ class StreamsTestBaseService(KafkaPathResolverMixin, JmxMixin, Service):

[GitHub] [kafka] vvcephei commented on pull request #8962: KAFKA-10166: checkpoint recycled standbys and ignore empty rocksdb base directory

2020-07-01 Thread GitBox
vvcephei commented on pull request #8962: URL: https://github.com/apache/kafka/pull/8962#issuecomment-652566866 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [kafka] vvcephei merged pull request #8961: MINOR: add retry to system test curl commands

2020-07-01 Thread GitBox
vvcephei merged pull request #8961: URL: https://github.com/apache/kafka/pull/8961 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] vvcephei commented on pull request #8961: MINOR: add retry to system test curl commands

2020-07-01 Thread GitBox
vvcephei commented on pull request #8961: URL: https://github.com/apache/kafka/pull/8961#issuecomment-652566225 Thanks @kkonstantine and @abbccdda ! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] junrao commented on a change in pull request #8479: KAFKA-9769: Finish operations for leaderEpoch-updated partitions up to point ZK Exception

2020-07-01 Thread GitBox
junrao commented on a change in pull request #8479: URL: https://github.com/apache/kafka/pull/8479#discussion_r448527321 ## File path: core/src/main/scala/kafka/cluster/Partition.scala ## @@ -499,7 +500,15 @@ class Partition(val topicPartition: TopicPartition, addingRe

[GitHub] [kafka] abbccdda commented on pull request #8961: MINOR: add retry to system test curl commands

2020-07-01 Thread GitBox
abbccdda commented on pull request #8961: URL: https://github.com/apache/kafka/pull/8961#issuecomment-652554760 Failed tests should be non-related as we only change on system test run. This is an automated message from the Ap

[GitHub] [kafka] andrewchoi5 commented on a change in pull request #8479: KAFKA-9769: Finish operations for leaderEpoch-updated partitions up to point ZK Exception

2020-07-01 Thread GitBox
andrewchoi5 commented on a change in pull request #8479: URL: https://github.com/apache/kafka/pull/8479#discussion_r448505615 ## File path: core/src/main/scala/kafka/cluster/Partition.scala ## @@ -499,7 +500,15 @@ class Partition(val topicPartition: TopicPartition, add

[jira] [Commented] (KAFKA-9009) Flaky Test kafka.integration.MetricsDuringTopicCreationDeletionTest.testMetricsDuringTopicCreateDelete

2020-07-01 Thread Boyang Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17149560#comment-17149560 ] Boyang Chen commented on KAFKA-9009: Failed again:[https://builds.apache.org/job/kaf

[jira] [Updated] (KAFKA-9009) Flaky Test kafka.integration.MetricsDuringTopicCreationDeletionTest.testMetricsDuringTopicCreateDelete

2020-07-01 Thread Boyang Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Boyang Chen updated KAFKA-9009: --- Affects Version/s: 2.6.0 2.5.0 > Flaky Test > kafka.integration.MetricsDuring

[GitHub] [kafka] hachikuji edited a comment on pull request #8934: KAFKA-10134: Use long poll if we do not have fetchable partitions

2020-07-01 Thread GitBox
hachikuji edited a comment on pull request #8934: URL: https://github.com/apache/kafka/pull/8934#issuecomment-652518999 @guozhangwang Looks like the code is not compiling. I think you grabbed `binaryExponentialElectionBackoffMs` from the prototype Raft implementation, but we need to initia

[GitHub] [kafka] hachikuji commented on pull request #8934: KAFKA-10134: Use long poll if we do not have fetchable partitions

2020-07-01 Thread GitBox
hachikuji commented on pull request #8934: URL: https://github.com/apache/kafka/pull/8934#issuecomment-652518999 @guozhangwang Looks like the code is not compiling. I think you grabbed `binaryExponentialElectionBackoffMs` from the Raft implementation, but we need to initialize the max valu

[jira] [Commented] (KAFKA-9062) Handle stalled writes to RocksDB

2020-07-01 Thread Bradley Peterson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17149541#comment-17149541 ] Bradley Peterson commented on KAFKA-9062: - [~ableegoldman] great, thanks. That bu

[jira] [Commented] (KAFKA-9062) Handle stalled writes to RocksDB

2020-07-01 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17149532#comment-17149532 ] Sophie Blee-Goldman commented on KAFKA-9062: Sorry, I didn't actually answer

[GitHub] [kafka] dajac opened a new pull request #8968: KAFKA-10164; Throttle Create Topic, Create Partition and Delete Topic Operations (KIP-599, Part II, Admin Changes)

2020-07-01 Thread GitBox
dajac opened a new pull request #8968: URL: https://github.com/apache/kafka/pull/8968 TODO ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgra

[GitHub] [kafka] abbccdda commented on a change in pull request #8712: KAFKA-10006: Don't create internal topics when LeaderNotAvailableException

2020-07-01 Thread GitBox
abbccdda commented on a change in pull request #8712: URL: https://github.com/apache/kafka/pull/8712#discussion_r448460197 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/InternalTopicManagerTest.java ## @@ -287,12 +290,124 @@ public void shou

[jira] [Commented] (KAFKA-9062) Handle stalled writes to RocksDB

2020-07-01 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17149530#comment-17149530 ] Sophie Blee-Goldman commented on KAFKA-9062:  [~thebearmayor] I think you cou

[GitHub] [kafka] abbccdda commented on a change in pull request #8712: KAFKA-10006: Don't create internal topics when LeaderNotAvailableException

2020-07-01 Thread GitBox
abbccdda commented on a change in pull request #8712: URL: https://github.com/apache/kafka/pull/8712#discussion_r448457381 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopicManager.java ## @@ -100,13 +100,19 @@ public InternalTopicMa

[GitHub] [kafka] ableegoldman commented on pull request #8963: KAFKA-10017: fix flaky EosBetaUpgradeIntegrationTest

2020-07-01 Thread GitBox
ableegoldman commented on pull request #8963: URL: https://github.com/apache/kafka/pull/8963#issuecomment-652494651 EosBetaUpgradeIntegrationTest still failed a few times on the PR builds, but it seems to be actual flakiness and not a new bug in eos-beta. I'll try and tighten up the test a

[GitHub] [kafka] rhauch commented on pull request #7496: KAFKA-9018: Throw clearer exceptions on serialisation errors

2020-07-01 Thread GitBox
rhauch commented on pull request #7496: URL: https://github.com/apache/kafka/pull/7496#issuecomment-652482529 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[jira] [Resolved] (KAFKA-10153) Error Reporting in Connect Documentation

2020-07-01 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch resolved KAFKA-10153. --- Reviewer: Randall Hauch Resolution: Fixed > Error Reporting in Connect Documentation >

[jira] [Updated] (KAFKA-10153) Error Reporting in Connect Documentation

2020-07-01 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch updated KAFKA-10153: -- Fix Version/s: 2.7.0 2.6.0 > Error Reporting in Connect Documentation > ---

[GitHub] [kafka] rhauch merged pull request #8858: KAFKA-10153: Error Reporting in Connect Documentation

2020-07-01 Thread GitBox
rhauch merged pull request #8858: URL: https://github.com/apache/kafka/pull/8858 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Commented] (KAFKA-9247) ERROR - NoSuchMethodError: org.apache.zookeeper.ZooKeeper.multi

2020-07-01 Thread Amit (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17149509#comment-17149509 ] Amit commented on KAFKA-9247: - My ~/.bashrc file i'm using ubuntu 20 i'm using apache-zookee

[jira] [Comment Edited] (KAFKA-9247) ERROR - NoSuchMethodError: org.apache.zookeeper.ZooKeeper.multi

2020-07-01 Thread Amit (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17149509#comment-17149509 ] Amit edited comment on KAFKA-9247 at 7/1/20, 3:10 PM: -- My ~/.bashrc

[jira] [Commented] (KAFKA-6520) When a Kafka Stream can't communicate with the server, it's Status stays RUNNING

2020-07-01 Thread Vince Mu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-6520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17149490#comment-17149490 ] Vince Mu commented on KAFKA-6520: - Created a work in progress PR. > When a Kafka Stream

  1   2   >