[GitHub] [kafka] showuon commented on pull request #8966: KAFKA-10220: add null check for configurationKey

showuon commented on pull request #8966: URL: https://github.com/apache/kafka/pull/8966#issuecomment-654638829 jdk 11 - org.apache.kafka.streams.integration.EosBetaUpgradeIntegrationTest.shouldUpgradeFromEosAlphaToEosBeta[false] org.apache.kafka.streams.integration.EosBetaUpg

[GitHub] [kafka] mingaliu commented on pull request #8982: Adding metrics to measure the idempotent producers

mingaliu commented on pull request #8982: URL: https://github.com/apache/kafka/pull/8982#issuecomment-654612942 Thanks @abbccdda. The JIRA is https://issues.apache.org/jira/browse/KAFKA-10242. I wonder why do we need a KIP here? Given there is no public interface or any protocol chang

[jira] [Created] (KAFKA-10242) Adding metrics to track the total count of idempotent producers that Broker need to track

Ming Liu created KAFKA-10242: Summary: Adding metrics to track the total count of idempotent producers that Broker need to track Key: KAFKA-10242 URL: https://issues.apache.org/jira/browse/KAFKA-10242 Pro

[jira] [Commented] (KAFKA-10242) Adding metrics to track the total count of idempotent producers that Broker need to track

[ https://issues.apache.org/jira/browse/KAFKA-10242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17152494#comment-17152494 ] Ming Liu commented on KAFKA-10242: -- The PR is [https://github.com/apache/kafka/pull/898

[jira] [Commented] (KAFKA-4273) Streams DSL - Add TTL / retention period support for intermediate topics and state stores

[ https://issues.apache.org/jira/browse/KAFKA-4273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17152480#comment-17152480 ] Matthias J. Sax commented on KAFKA-4273: A windowed-store is basically a kv-store

[jira] [Commented] (KAFKA-10205) NullPointerException in StreamTask (Kafka Streams 2.5.0)

[ https://issues.apache.org/jira/browse/KAFKA-10205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17152477#comment-17152477 ] Matthias J. Sax commented on KAFKA-10205: - [~brianforkan] What you do exactly me

[jira] [Reopened] (KAFKA-6453) Reconsider timestamp propagation semantics

[ https://issues.apache.org/jira/browse/KAFKA-6453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax reopened KAFKA-6453: IMHO, the PR only covers part of this ticket. We should also document how timestamps are compu

[jira] [Commented] (KAFKA-9986) Snapshotting API for State Stores

[ https://issues.apache.org/jira/browse/KAFKA-9986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17152472#comment-17152472 ] Matthias J. Sax commented on KAFKA-9986: > where the snapshot location can be eit

[GitHub] [kafka] chia7712 commented on pull request #8913: KAFKA-10191 fix flaky StreamsOptimizedTest

chia7712 commented on pull request #8913: URL: https://github.com/apache/kafka/pull/8913#issuecomment-654594491 @vvcephei thanks for all reviews. > processor.node.account.ssh(cmd, allow_fail=False) Did you mean that we can reuse one of processor to call ```kafka-streams-applic

[GitHub] [kafka] chia7712 commented on a change in pull request #8981: KAFKA-10235 Fix flaky transactions_test.py

chia7712 commented on a change in pull request #8981: URL: https://github.com/apache/kafka/pull/8981#discussion_r450601160 ## File path: tests/kafkatest/tests/core/transactions_test.py ## @@ -53,7 +53,11 @@ def __init__(self, test_context): self.zk = ZookeeperService(t

[GitHub] [kafka] guozhangwang commented on pull request #8683: KAFKA-9893: Configurable TCP connection timeout and improve the initial metadata fetch

guozhangwang commented on pull request #8683: URL: https://github.com/apache/kafka/pull/8683#issuecomment-654585011 @d8tltanc @rajinisivaram @dajac We observed some exception thrown from our soak with the following stack trace: ``` java.util.ConcurrentModificationException

[GitHub] [kafka] guozhangwang commented on a change in pull request #8934: KAFKA-10134: Use long poll if we do not have fetchable partitions

guozhangwang commented on a change in pull request #8934: URL: https://github.com/apache/kafka/pull/8934#discussion_r450597622 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java ## @@ -416,7 +428,13 @@ boolean joinGroupIfNe

[GitHub] [kafka] abbccdda commented on pull request #8795: KAFKA-10095: Simplify calls in LogCleanerManagerTest

abbccdda commented on pull request #8795: URL: https://github.com/apache/kafka/pull/8795#issuecomment-654583118 @sarahgonsalves223 Could you address @hachikuji 's comment? This is an automated message from the Apache Git Serv

[GitHub] [kafka] guozhangwang commented on a change in pull request #8934: KAFKA-10134: Use long poll if we do not have fetchable partitions

guozhangwang commented on a change in pull request #8934: URL: https://github.com/apache/kafka/pull/8934#discussion_r450594795 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java ## @@ -1218,17 +1218,20 @@ public void assign(Collection par

[jira] [Resolved] (KAFKA-10239) The groupInstanceId field in DescribeGroup response should be ignorable

[ https://issues.apache.org/jira/browse/KAFKA-10239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Boyang Chen resolved KAFKA-10239. - Resolution: Fixed > The groupInstanceId field in DescribeGroup response should be ignorable > --

[GitHub] [kafka] abbccdda commented on pull request #8989: KAFKA-10239: Make GroupInstanceId ignorable in DescribeGroups

abbccdda commented on pull request #8989: URL: https://github.com/apache/kafka/pull/8989#issuecomment-654578798 Cherry-picked to 2.4, 2.5, 2.6, with slight test modification. (DescribeGroupsResponse#duplicate was not available in 2.4 & 2.5)

[GitHub] [kafka] ryannedolan commented on pull request #8918: Use debug level logging for noisy log messages in Connect

ryannedolan commented on pull request #8918: URL: https://github.com/apache/kafka/pull/8918#issuecomment-654570254 makes sense to me, thanks This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] guozhangwang commented on a change in pull request #8964: KAFKA-9450: Decouple flushing state from commiting

guozhangwang commented on a change in pull request #8964: URL: https://github.com/apache/kafka/pull/8964#discussion_r450576103 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StateManagerUtil.java ## @@ -38,13 +41,39 @@ */ final class StateM

[GitHub] [kafka] guozhangwang commented on a change in pull request #8964: KAFKA-9450: Decouple flushing state from commiting

guozhangwang commented on a change in pull request #8964: URL: https://github.com/apache/kafka/pull/8964#discussion_r450577191 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorStateManager.java ## @@ -454,6 +456,41 @@ public void flush(

[jira] [Created] (KAFKA-10241) Pursue a better way to cover ignorable RPC fields

Boyang Chen created KAFKA-10241: --- Summary: Pursue a better way to cover ignorable RPC fields Key: KAFKA-10241 URL: https://issues.apache.org/jira/browse/KAFKA-10241 Project: Kafka Issue Type:

[GitHub] [kafka] vitojeng commented on pull request #8939: MINOR: rename class `RecordTimeDefintion` to `RecordTimeDefinition`

vitojeng commented on pull request #8939: URL: https://github.com/apache/kafka/pull/8939#issuecomment-654551605 Thanks @abbccdda ! This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [kafka] abbccdda merged pull request #8989: KAFKA-10239: Make GroupInstanceId ignorable in DescribeGroups

abbccdda merged pull request #8989: URL: https://github.com/apache/kafka/pull/8989 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] ijuma merged pull request #8579: KAFKA-9930: Prevent ReplicaFetcherThread from throwing UnknownTopicOrPartitionException upon topic creation and deletion.

ijuma merged pull request #8579: URL: https://github.com/apache/kafka/pull/8579 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] cyrusv commented on pull request #8918: Use debug level logging for noisy log messages in Connect

cyrusv commented on pull request #8918: URL: https://github.com/apache/kafka/pull/8918#issuecomment-654549765 @wicknicks, @C0urante, @ryannedolan: Any feedback on this one? It will make logs on many systems much less expensive in the normal case. ---

[GitHub] [kafka] chia7712 commented on a change in pull request #8974: KAFKA-10225 Increase default zk session timeout for system tests

chia7712 commented on a change in pull request #8974: URL: https://github.com/apache/kafka/pull/8974#discussion_r450560682 ## File path: tests/kafkatest/services/kafka/config.py ## @@ -25,7 +25,8 @@ class KafkaConfig(dict): config_property.PORT: 9092, config_p

[GitHub] [kafka] mjsax commented on pull request #8920: DOCS-4446: document timestamped state stores

mjsax commented on pull request #8920: URL: https://github.com/apache/kafka/pull/8920#issuecomment-654540735 Thanks @JimGalasyn. Merged to `trunk` and cherry-picked to `2.6` branch. This is an automated message from th

[GitHub] [kafka] mjsax merged pull request #8920: DOCS-4446: document timestamped state stores

mjsax merged pull request #8920: URL: https://github.com/apache/kafka/pull/8920 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] spal1 commented on a change in pull request #8863: KAFKA-8528: Expose Trogdor-specific JMX metrics for Tasks and Agents

spal1 commented on a change in pull request #8863: URL: https://github.com/apache/kafka/pull/8863#discussion_r450545145 ## File path: tools/src/main/java/org/apache/kafka/trogdor/agent/Agent.java ## @@ -92,6 +93,8 @@ private final Time time; +final TrogdorMetrics t

[GitHub] [kafka] spal1 commented on a change in pull request #8863: KAFKA-8528: Expose Trogdor-specific JMX metrics for Tasks and Agents

spal1 commented on a change in pull request #8863: URL: https://github.com/apache/kafka/pull/8863#discussion_r450545145 ## File path: tools/src/main/java/org/apache/kafka/trogdor/agent/Agent.java ## @@ -92,6 +93,8 @@ private final Time time; +final TrogdorMetrics t

[jira] [Commented] (KAFKA-10166) Excessive TaskCorruptedException seen in testing

[ https://issues.apache.org/jira/browse/KAFKA-10166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17152381#comment-17152381 ] Guozhang Wang commented on KAFKA-10166: --- I've merged in [~ableegoldman]'s PR, and

[GitHub] [kafka] guozhangwang commented on pull request #8962: KAFKA-10166: checkpoint recycled standbys and ignore empty rocksdb base directory

guozhangwang commented on pull request #8962: URL: https://github.com/apache/kafka/pull/8962#issuecomment-654527170 Cherry-picked to 2.6 This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [kafka] guozhangwang merged pull request #8962: KAFKA-10166: checkpoint recycled standbys and ignore empty rocksdb base directory

guozhangwang merged pull request #8962: URL: https://github.com/apache/kafka/pull/8962 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (KAFKA-10017) Flaky Test EosBetaUpgradeIntegrationTest.shouldUpgradeFromEosAlphaToEosBeta

[ https://issues.apache.org/jira/browse/KAFKA-10017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17152377#comment-17152377 ] Guozhang Wang commented on KAFKA-10017: --- Thanks for the confirmation Sophie! I'm c

[GitHub] [kafka] vvcephei commented on pull request #8971: MINOR: prune the metadata upgrade test matrix

vvcephei commented on pull request #8971: URL: https://github.com/apache/kafka/pull/8971#issuecomment-654520073 This also needs to be backported. I'll do it once I'm done backporting https://github.com/apache/kafka/pull/8938

[GitHub] [kafka] vvcephei merged pull request #8971: MINOR: prune the metadata upgrade test matrix

vvcephei merged pull request #8971: URL: https://github.com/apache/kafka/pull/8971 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] vvcephei commented on pull request #8971: MINOR: prune the metadata upgrade test matrix

vvcephei commented on pull request #8971: URL: https://github.com/apache/kafka/pull/8971#issuecomment-654519320 Thanks, @guozhangwang ! I'll go ahead and merge it, despite the failures, since it couldn't possibly have caused any integration test failures. -

[GitHub] [kafka] vvcephei commented on a change in pull request #8864: KAFKA-9274: Mark `retries` config as deprecated and add new `task.timeout.ms` config

vvcephei commented on a change in pull request #8864: URL: https://github.com/apache/kafka/pull/8864#discussion_r450533229 ## File path: clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java ## @@ -662,6 +662,7 @@ public void testInvalidTopicNames() th

[jira] [Commented] (KAFKA-10017) Flaky Test EosBetaUpgradeIntegrationTest.shouldUpgradeFromEosAlphaToEosBeta

[ https://issues.apache.org/jira/browse/KAFKA-10017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17152370#comment-17152370 ] Sophie Blee-Goldman commented on KAFKA-10017: - The local runs just completed

[GitHub] [kafka] ijuma commented on pull request #8579: KAFKA-9930: Prevent ReplicaFetcherThread from throwing UnknownTopicOrPartitionException upon topic creation and deletion.

ijuma commented on pull request #8579: URL: https://github.com/apache/kafka/pull/8579#issuecomment-654513658 Unrelated flaky test failures: ``` org.apache.kafka.streams.integration.EosBetaUpgradeIntegrationTest.shouldUpgradeFromEosAlphaToEosBeta[false] org.apache.kafka.streams

[GitHub] [kafka] vvcephei commented on pull request #8913: KAFKA-10191 fix flaky StreamsOptimizedTest

vvcephei commented on pull request #8913: URL: https://github.com/apache/kafka/pull/8913#issuecomment-654512188 Hey @chia7712 , I'm sorry it took me so long to take a look. I think what you've done here is fine for now, so feel free to push back, but I'm wondering if the "Service" mo

[GitHub] [kafka] hachikuji commented on a change in pull request #8891: KAFKA-10143: Improve test coverage for throttle changes during reassignment

hachikuji commented on a change in pull request #8891: URL: https://github.com/apache/kafka/pull/8891#discussion_r450517031 ## File path: core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala ## @@ -962,22 +963,18 @@ object ReassignPartitionsCommand extends Logging {

[GitHub] [kafka] hachikuji commented on a change in pull request #8989: KAFKA-10239: Make GroupInstanceId ignorable in DescribeGroups

hachikuji commented on a change in pull request #8989: URL: https://github.com/apache/kafka/pull/8989#discussion_r450514285 ## File path: clients/src/test/java/org/apache/kafka/common/message/MessageTest.java ## @@ -218,6 +220,59 @@ public void testOffsetCommitDefaultGroupInst

[GitHub] [kafka] vvcephei commented on a change in pull request #8962: KAFKA-10166: checkpoint recycled standbys and ignore empty rocksdb base directory

vvcephei commented on a change in pull request #8962: URL: https://github.com/apache/kafka/pull/8962#discussion_r450513288 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -270,8 +270,11 @@ public void handleAssignment(fin

[GitHub] [kafka] abbccdda commented on a change in pull request #8989: KAFKA-10239: Make GroupInstanceId ignorable in DescribeGroups

abbccdda commented on a change in pull request #8989: URL: https://github.com/apache/kafka/pull/8989#discussion_r450510257 ## File path: clients/src/test/java/org/apache/kafka/common/message/MessageTest.java ## @@ -218,6 +220,59 @@ public void testOffsetCommitDefaultGroupInsta

[GitHub] [kafka] hachikuji commented on a change in pull request #8934: KAFKA-10134: Use long poll if we do not have fetchable partitions

hachikuji commented on a change in pull request #8934: URL: https://github.com/apache/kafka/pull/8934#discussion_r450504028 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java ## @@ -416,7 +428,13 @@ boolean joinGroupIfNeede

[GitHub] [kafka] cmccabe commented on a change in pull request #8863: KAFKA-8528: Expose Trogdor-specific JMX metrics for Tasks and Agents

cmccabe commented on a change in pull request #8863: URL: https://github.com/apache/kafka/pull/8863#discussion_r450505811 ## File path: tools/src/main/java/org/apache/kafka/trogdor/coordinator/Coordinator.java ## @@ -70,6 +70,8 @@ private final Time time; +final T

[GitHub] [kafka] cmccabe commented on a change in pull request #8863: KAFKA-8528: Expose Trogdor-specific JMX metrics for Tasks and Agents

cmccabe commented on a change in pull request #8863: URL: https://github.com/apache/kafka/pull/8863#discussion_r450505717 ## File path: tools/src/main/java/org/apache/kafka/trogdor/common/Platform.java ## @@ -54,6 +62,29 @@ public static Platform parse(String curNodeName, Strin

[jira] [Updated] (KAFKA-10220) NPE when describing resources

[ https://issues.apache.org/jira/browse/KAFKA-10220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-10220: Priority: Blocker (was: Major) > NPE when describing resources > - >

[GitHub] [kafka] vvcephei commented on pull request #8962: KAFKA-10166: checkpoint recycled standbys and ignore empty rocksdb base directory

vvcephei commented on pull request #8962: URL: https://github.com/apache/kafka/pull/8962#issuecomment-654490080 Test this please This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] vvcephei commented on pull request #8962: KAFKA-10166: checkpoint recycled standbys and ignore empty rocksdb base directory

vvcephei commented on pull request #8962: URL: https://github.com/apache/kafka/pull/8962#issuecomment-654490231 Retest this please This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [kafka] vvcephei commented on pull request #8962: KAFKA-10166: checkpoint recycled standbys and ignore empty rocksdb base directory

vvcephei commented on pull request #8962: URL: https://github.com/apache/kafka/pull/8962#issuecomment-654490129 Test this please This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] vvcephei commented on pull request #8962: KAFKA-10166: checkpoint recycled standbys and ignore empty rocksdb base directory

vvcephei commented on pull request #8962: URL: https://github.com/apache/kafka/pull/8962#issuecomment-654489992 Test this please This is an automated message from the Apache Git Service. To respond to the message, please log

[jira] [Updated] (KAFKA-10220) NPE when describing resources

[ https://issues.apache.org/jira/browse/KAFKA-10220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-10220: Fix Version/s: 2.7.0 > NPE when describing resources > - > >

[GitHub] [kafka] cmccabe commented on a change in pull request #8863: KAFKA-8528: Expose Trogdor-specific JMX metrics for Tasks and Agents

cmccabe commented on a change in pull request #8863: URL: https://github.com/apache/kafka/pull/8863#discussion_r450504757 ## File path: tools/src/main/java/org/apache/kafka/trogdor/coordinator/TaskManager.java ## @@ -395,11 +401,13 @@ public Void call() throws Exception {

[GitHub] [kafka] cmccabe commented on a change in pull request #8863: KAFKA-8528: Expose Trogdor-specific JMX metrics for Tasks and Agents

cmccabe commented on a change in pull request #8863: URL: https://github.com/apache/kafka/pull/8863#discussion_r450504170 ## File path: tools/src/main/java/org/apache/kafka/trogdor/coordinator/TaskManager.java ## @@ -127,7 +127,12 @@ */ private long nextWorkerId;

[GitHub] [kafka] cmccabe commented on a change in pull request #8863: KAFKA-8528: Expose Trogdor-specific JMX metrics for Tasks and Agents

cmccabe commented on a change in pull request #8863: URL: https://github.com/apache/kafka/pull/8863#discussion_r450503568 ## File path: tools/src/main/java/org/apache/kafka/trogdor/agent/Agent.java ## @@ -92,6 +93,8 @@ private final Time time; +final TrogdorMetrics

[GitHub] [kafka] ijuma commented on pull request #8742: KAFKA-10057 optimize class ConfigCommand method alterConfig parameters

ijuma commented on pull request #8742: URL: https://github.com/apache/kafka/pull/8742#issuecomment-654486027 @sasukerui Can you please change the PR to target `master`? This is an automated message from the Apache Git Service

[GitHub] [kafka] hachikuji commented on a change in pull request #8864: KAFKA-9274: Mark `retries` config as deprecated and add new `task.timeout.ms` config

hachikuji commented on a change in pull request #8864: URL: https://github.com/apache/kafka/pull/8864#discussion_r450493796 ## File path: clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java ## @@ -1447,6 +1451,7 @@ public void testListConsumerGroups

[GitHub] [kafka] ijuma commented on pull request #8985: MINOR; KafkaAdminClient#alterReplicaLogDirs should not fail all the futures when only one call fails

ijuma commented on pull request #8985: URL: https://github.com/apache/kafka/pull/8985#issuecomment-654484579 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [kafka] ijuma commented on pull request #8983: KAFKA-8398: Prevent NPE in `forceUnmap`

ijuma commented on pull request #8983: URL: https://github.com/apache/kafka/pull/8983#issuecomment-654483830 Merged to trunk and cherry-picked to 2.6 since it's extremely low risk (checked with @rhauch that this was OK). Thi

[GitHub] [kafka] hachikuji commented on a change in pull request #8989: KAFKA-10239: Make GroupInstanceId ignorable in DescribeGroups

hachikuji commented on a change in pull request #8989: URL: https://github.com/apache/kafka/pull/8989#discussion_r450490649 ## File path: clients/src/test/java/org/apache/kafka/common/message/MessageTest.java ## @@ -218,6 +220,59 @@ public void testOffsetCommitDefaultGroupInst

[GitHub] [kafka] guozhangwang commented on a change in pull request #8971: MINOR: prune the metadata upgrade test matrix

guozhangwang commented on a change in pull request #8971: URL: https://github.com/apache/kafka/pull/8971#discussion_r450488992 ## File path: tests/kafkatest/tests/streams/streams_upgrade_test.py ## @@ -189,9 +185,8 @@ def test_upgrade_downgrade_brokers(self, from_version, to_v

[GitHub] [kafka] guozhangwang commented on a change in pull request #8971: MINOR: prune the metadata upgrade test matrix

guozhangwang commented on a change in pull request #8971: URL: https://github.com/apache/kafka/pull/8971#discussion_r450488992 ## File path: tests/kafkatest/tests/streams/streams_upgrade_test.py ## @@ -189,9 +185,8 @@ def test_upgrade_downgrade_brokers(self, from_version, to_v

[GitHub] [kafka] guozhangwang commented on pull request #8971: MINOR: prune the metadata upgrade test matrix

guozhangwang commented on pull request #8971: URL: https://github.com/apache/kafka/pull/8971#issuecomment-654474451 LGTM! This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [kafka] hachikuji commented on pull request #8989: KAFKA-10239: Make GroupInstanceId ignorable in DescribeGroups

hachikuji commented on pull request #8989: URL: https://github.com/apache/kafka/pull/8989#issuecomment-654473843 Oh, sorry, I missed the version check. So above looks fine. This is an automated message from the Apache Git Ser

[GitHub] [kafka] hachikuji commented on pull request #8989: KAFKA-10239: Make GroupInstanceId ignorable in DescribeGroups

hachikuji commented on pull request #8989: URL: https://github.com/apache/kafka/pull/8989#issuecomment-654473290 @abbccdda Thanks for the quick fix. I am wondering if we have a similar problem with authorized operations: ``` { "name": "AuthorizedOperations", "type": "int32", "ve

[GitHub] [kafka] guozhangwang commented on pull request #8963: KAFKA-10017: fix flaky EosBetaUpgradeIntegrationTest

guozhangwang commented on pull request #8963: URL: https://github.com/apache/kafka/pull/8963#issuecomment-654472201 Merged to 2.6 as well and re-enabled the integration test. This is an automated message from the Apache Git S

[GitHub] [kafka] abbccdda opened a new pull request #8989: KAFKA-10239: Make GroupInstanceId ignorable in DescribeGroups

abbccdda opened a new pull request #8989: URL: https://github.com/apache/kafka/pull/8989 This is a bug fix for older admin clients using static membership and call DescribeGroups. By making `groupInstanceId` ignorable, it would not crash upon handling the response. Added test covera

[jira] [Commented] (KAFKA-10017) Flaky Test EosBetaUpgradeIntegrationTest.shouldUpgradeFromEosAlphaToEosBeta

[ https://issues.apache.org/jira/browse/KAFKA-10017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17152329#comment-17152329 ] Guozhang Wang commented on KAFKA-10017: --- Hi [~rhauch] I've just pushed a PR from

[GitHub] [kafka] guozhangwang merged pull request #8963: KAFKA-10017: fix flaky EosBetaUpgradeIntegrationTest

guozhangwang merged pull request #8963: URL: https://github.com/apache/kafka/pull/8963 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] guozhangwang opened a new pull request #8988: KAFKA-10199: Separate restore threads [WIP]

guozhangwang opened a new pull request #8988: URL: https://github.com/apache/kafka/pull/8988 Main Ideas: 1) keep the StoreChangelogReader to be thread-safe, and restrict the shared access only on a few methods. 2) having N restore threads with N stream threads, with a 1-1 mapping

[GitHub] [kafka] guozhangwang commented on pull request #8988: KAFKA-10199: Separate restore threads [WIP]

guozhangwang commented on pull request #8988: URL: https://github.com/apache/kafka/pull/8988#issuecomment-654459797 @ableegoldman @cadonna for taking a look at the synchronization mechanism. This is an automated message from

[GitHub] [kafka] guozhangwang commented on a change in pull request #8962: KAFKA-10166: checkpoint recycled standbys and ignore empty rocksdb base directory

guozhangwang commented on a change in pull request #8962: URL: https://github.com/apache/kafka/pull/8962#discussion_r450471701 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -270,8 +270,11 @@ public void handleAssignment

[GitHub] [kafka] guozhangwang commented on a change in pull request #8962: KAFKA-10166: checkpoint recycled standbys and ignore empty rocksdb base directory

guozhangwang commented on a change in pull request #8962: URL: https://github.com/apache/kafka/pull/8962#discussion_r450471701 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -270,8 +270,11 @@ public void handleAssignment

[jira] [Created] (KAFKA-10240) Sink tasks should not throw WakeupException on shutdown

Chris Egerton created KAFKA-10240: - Summary: Sink tasks should not throw WakeupException on shutdown Key: KAFKA-10240 URL: https://issues.apache.org/jira/browse/KAFKA-10240 Project: Kafka Iss

[jira] [Assigned] (KAFKA-10239) The groupInstanceId field in DescribeGroup response should be ignorable

[ https://issues.apache.org/jira/browse/KAFKA-10239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Boyang Chen reassigned KAFKA-10239: --- Assignee: Boyang Chen > The groupInstanceId field in DescribeGroup response should be ignor

[GitHub] [kafka] ijuma commented on pull request #8579: KAFKA-9930: Prevent ReplicaFetcherThread from throwing UnknownTopicOrPartitionException upon topic creation and deletion.

ijuma commented on pull request #8579: URL: https://github.com/apache/kafka/pull/8579#issuecomment-654436916 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [kafka] ijuma commented on pull request #8742: KAFKA-10057 optimize class ConfigCommand method alterConfig parameters

ijuma commented on pull request #8742: URL: https://github.com/apache/kafka/pull/8742#issuecomment-654436295 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[jira] [Updated] (KAFKA-10239) The groupInstanceId field in DescribeGroup response should be ignorable

[ https://issues.apache.org/jira/browse/KAFKA-10239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson updated KAFKA-10239: Fix Version/s: 2.5.1 2.4.2 > The groupInstanceId field in DescribeGroup

[jira] [Updated] (KAFKA-10239) The groupInstanceId field in DescribeGroup response should be ignorable

[ https://issues.apache.org/jira/browse/KAFKA-10239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson updated KAFKA-10239: Affects Version/s: 2.5.0 2.4.1 > The groupInstanceId field in Descr

[jira] [Commented] (KAFKA-4169) Calculation of message size is too conservative for compressed messages

[ https://issues.apache.org/jira/browse/KAFKA-4169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17152281#comment-17152281 ] Jorge Esteban Quilcate Otoya commented on KAFKA-4169: - I'm wondering

[jira] [Created] (KAFKA-10239) The groupInstanceId field in DescribeGroup response should be ignorable

Jason Gustafson created KAFKA-10239: --- Summary: The groupInstanceId field in DescribeGroup response should be ignorable Key: KAFKA-10239 URL: https://issues.apache.org/jira/browse/KAFKA-10239 Project

[GitHub] [kafka] cadonna commented on pull request #8987: KAFKA-10221: Backport fix for KAFKA-9603 to 2.5

cadonna commented on pull request #8987: URL: https://github.com/apache/kafka/pull/8987#issuecomment-654433640 Call for review: @vvcephei @ableegoldman @guozhangwang @mjsax @abbccdda This is an automated message from the Apa

[GitHub] [kafka] cadonna opened a new pull request #8987: KAFKA-10221: Backport fix for KAFKA-9603 to 2.5

cadonna opened a new pull request #8987: URL: https://github.com/apache/kafka/pull/8987 KAFKA-9603 reports that the number of open files keeps increasing in RocksDB. The reason is that bulk loading is turned on but never turned off in segmented state stores for standby tasks. Th

[jira] [Created] (KAFKA-10238) kafka-console-producer null value

Ryan created KAFKA-10238: Summary: kafka-console-producer null value Key: KAFKA-10238 URL: https://issues.apache.org/jira/browse/KAFKA-10238 Project: Kafka Issue Type: Improvement Component

[GitHub] [kafka] ableegoldman commented on a change in pull request #8962: KAFKA-10166: checkpoint recycled standbys and ignore empty rocksdb base directory

ableegoldman commented on a change in pull request #8962: URL: https://github.com/apache/kafka/pull/8962#discussion_r450429655 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -270,8 +270,11 @@ public void handleAssignment

[GitHub] [kafka] ableegoldman commented on a change in pull request #8962: KAFKA-10166: checkpoint recycled standbys and ignore empty rocksdb base directory

ableegoldman commented on a change in pull request #8962: URL: https://github.com/apache/kafka/pull/8962#discussion_r450429655 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -270,8 +270,11 @@ public void handleAssignment

[GitHub] [kafka] junrao commented on a change in pull request #8981: KAFKA-10235 Fix flaky transactions_test.py

junrao commented on a change in pull request #8981: URL: https://github.com/apache/kafka/pull/8981#discussion_r450430604 ## File path: tests/kafkatest/tests/core/transactions_test.py ## @@ -53,7 +53,11 @@ def __init__(self, test_context): self.zk = ZookeeperService(tes

[GitHub] [kafka] ableegoldman commented on a change in pull request #8962: KAFKA-10166: checkpoint recycled standbys and ignore empty rocksdb base directory

ableegoldman commented on a change in pull request #8962: URL: https://github.com/apache/kafka/pull/8962#discussion_r450429655 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -270,8 +270,11 @@ public void handleAssignment

[jira] [Commented] (KAFKA-10173) BufferUnderflowException during Kafka Streams Upgrade

[ https://issues.apache.org/jira/browse/KAFKA-10173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17152259#comment-17152259 ] John Roesler commented on KAFKA-10173: -- Hey all, I'm resolving this ticket to unblo

[jira] [Updated] (KAFKA-10173) BufferUnderflowException during Kafka Streams Upgrade

[ https://issues.apache.org/jira/browse/KAFKA-10173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler updated KAFKA-10173: - Fix Version/s: 2.5.1 2.4.2 > BufferUnderflowException during Kafka Streams Up

[jira] [Resolved] (KAFKA-10173) BufferUnderflowException during Kafka Streams Upgrade

[ https://issues.apache.org/jira/browse/KAFKA-10173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler resolved KAFKA-10173. -- Fix Version/s: (was: 2.5.1) (was: 2.4.2) Resolution: Fixed >

[jira] [Created] (KAFKA-10237) Properly handle in-memory stores OOM

Boyang Chen created KAFKA-10237: --- Summary: Properly handle in-memory stores OOM Key: KAFKA-10237 URL: https://issues.apache.org/jira/browse/KAFKA-10237 Project: Kafka Issue Type: Improvement

[GitHub] [kafka] hachikuji commented on pull request #8979: KAFKA-10223; Make ReplicaNotAvailableException retriable metadata exception

hachikuji commented on pull request #8979: URL: https://github.com/apache/kafka/pull/8979#issuecomment-654410668 I agree it's a little weird. Renaming NOT_LEADER is not a bad idea. I think what we want the error to convey is that the recipient is not a valid request target for the given pa

[GitHub] [kafka] junrao commented on a change in pull request #8974: KAFKA-10225 Increase default zk session timeout for system tests

junrao commented on a change in pull request #8974: URL: https://github.com/apache/kafka/pull/8974#discussion_r450419922 ## File path: tests/kafkatest/services/kafka/kafka.py ## @@ -185,7 +185,11 @@ def __init__(self, context, num_nodes, zk, security_protocol=SecurityConfig.PL

[jira] [Assigned] (KAFKA-10017) Flaky Test EosBetaUpgradeIntegrationTest.shouldUpgradeFromEosAlphaToEosBeta

[ https://issues.apache.org/jira/browse/KAFKA-10017?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sophie Blee-Goldman reassigned KAFKA-10017: --- Assignee: Sophie Blee-Goldman (was: Matthias J. Sax) > Flaky Test EosBetaU

[jira] [Commented] (KAFKA-10017) Flaky Test EosBetaUpgradeIntegrationTest.shouldUpgradeFromEosAlphaToEosBeta

[ https://issues.apache.org/jira/browse/KAFKA-10017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17152247#comment-17152247 ] Randall Hauch commented on KAFKA-10017: --- [~guozhang], do you have an ETA on this?

[jira] [Commented] (KAFKA-10017) Flaky Test EosBetaUpgradeIntegrationTest.shouldUpgradeFromEosAlphaToEosBeta

[ https://issues.apache.org/jira/browse/KAFKA-10017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17152245#comment-17152245 ] Randall Hauch commented on KAFKA-10017: --- These seem to fail pretty regularly in AK

[GitHub] [kafka] abbccdda commented on a change in pull request #8913: KAFKA-10191 fix flaky StreamsOptimizedTest

abbccdda commented on a change in pull request #8913: URL: https://github.com/apache/kafka/pull/8913#discussion_r450409097 ## File path: tests/kafkatest/services/streams.py ## @@ -448,6 +452,41 @@ def __init__(self, test_context, kafka, configs):

[GitHub] [kafka] abbccdda commented on a change in pull request #8913: KAFKA-10191 fix flaky StreamsOptimizedTest

abbccdda commented on a change in pull request #8913: URL: https://github.com/apache/kafka/pull/8913#discussion_r450408632 ## File path: tests/kafkatest/tests/streams/streams_optimized_test.py ## @@ -90,6 +93,12 @@ def test_upgrade_optimized_topology(self): self.kafka.

  1   2   >