[GitHub] [kafka] kowshik commented on a change in pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

2020-10-02 Thread GitBox
kowshik commented on a change in pull request #9001: URL: https://github.com/apache/kafka/pull/9001#discussion_r498574911 ## File path: clients/src/main/java/org/apache/kafka/common/feature/SupportedVersionRange.java ## @@ -17,9 +17,16 @@ package org.apache.kafka.common.featu

[GitHub] [kafka] mimaison commented on pull request #9281: KAFKA-10478: Allow duplicated ports in advertised.listeners

2020-10-02 Thread GitBox
mimaison commented on pull request #9281: URL: https://github.com/apache/kafka/pull/9281#issuecomment-702608031 Test failures are not related, merging This is an automated message from the Apache Git Service. To respond to th

[GitHub] [kafka] mimaison merged pull request #9281: KAFKA-10478: Allow duplicated ports in advertised.listeners

2020-10-02 Thread GitBox
mimaison merged pull request #9281: URL: https://github.com/apache/kafka/pull/9281 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[jira] [Resolved] (KAFKA-10478) advertised.listeners should allow duplicated ports

2020-10-02 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison resolved KAFKA-10478. Fix Version/s: 2.7.0 Resolution: Fixed > advertised.listeners should allow duplicat

[GitHub] [kafka] RamanVerma opened a new pull request #9364: KAFKA-10471 Mark broker crash during log loading as unclean shutdown

2020-10-02 Thread GitBox
RamanVerma opened a new pull request #9364: URL: https://github.com/apache/kafka/pull/9364 LogManager writes a clean shutdown file when the broker shuts down. The presence of this file indicates that the broker had a clean shutdown and log recovery is not needed upon the next boot up.

[GitHub] [kafka] mimaison commented on pull request #9360: KAFKA-10557: Missing docs when describing topic configs including

2020-10-02 Thread GitBox
mimaison commented on pull request #9360: URL: https://github.com/apache/kafka/pull/9360#issuecomment-702614729 Thanks @rajinisivaram for the review. Test failures are not related, merging. This is an automated message fro

[GitHub] [kafka] kowshik commented on a change in pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

2020-10-02 Thread GitBox
kowshik commented on a change in pull request #9001: URL: https://github.com/apache/kafka/pull/9001#discussion_r498574911 ## File path: clients/src/main/java/org/apache/kafka/common/feature/SupportedVersionRange.java ## @@ -17,9 +17,16 @@ package org.apache.kafka.common.featu

[jira] [Commented] (KAFKA-10471) TimeIndex handling may cause data loss in certain back to back failure

2020-10-02 Thread Raman Verma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17206053#comment-17206053 ] Raman Verma commented on KAFKA-10471: - PR available for review https://github.com/ap

[jira] [Issue Comment Deleted] (KAFKA-10471) TimeIndex handling may cause data loss in certain back to back failure

2020-10-02 Thread Raman Verma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Raman Verma updated KAFKA-10471: Comment: was deleted (was: PR available for review https://github.com/apache/kafka/pull/9364) > T

[GitHub] [kafka] mimaison merged pull request #9360: KAFKA-10557: Missing docs when describing topic configs including

2020-10-02 Thread GitBox
mimaison merged pull request #9360: URL: https://github.com/apache/kafka/pull/9360 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[jira] [Updated] (KAFKA-10557) Missing docs when describing topic configs including documentation

2020-10-02 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10557?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison updated KAFKA-10557: --- Affects Version/s: (was: 2.7.0) > Missing docs when describing topic configs including d

[GitHub] [kafka] mimaison commented on pull request #9360: KAFKA-10557: Missing docs when describing topic configs including

2020-10-02 Thread GitBox
mimaison commented on pull request #9360: URL: https://github.com/apache/kafka/pull/9360#issuecomment-702617314 I'll also merge into 2.6 This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [kafka] kowshik commented on a change in pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

2020-10-02 Thread GitBox
kowshik commented on a change in pull request #9001: URL: https://github.com/apache/kafka/pull/9001#discussion_r498574911 ## File path: clients/src/main/java/org/apache/kafka/common/feature/SupportedVersionRange.java ## @@ -17,9 +17,16 @@ package org.apache.kafka.common.featu

[GitHub] [kafka] kowshik commented on a change in pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

2020-10-02 Thread GitBox
kowshik commented on a change in pull request #9001: URL: https://github.com/apache/kafka/pull/9001#discussion_r498574911 ## File path: clients/src/main/java/org/apache/kafka/common/feature/SupportedVersionRange.java ## @@ -17,9 +17,16 @@ package org.apache.kafka.common.featu

[GitHub] [kafka] kowshik commented on pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

2020-10-02 Thread GitBox
kowshik commented on pull request #9001: URL: https://github.com/apache/kafka/pull/9001#issuecomment-702621705 @junrao Thanks for the review comments! I have done the change proposed in https://github.com/apache/kafka/pull/9001#discussion_r498574911 in the most recent commit: 4218f95904989

[GitHub] [kafka] kowshik edited a comment on pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

2020-10-02 Thread GitBox
kowshik edited a comment on pull request #9001: URL: https://github.com/apache/kafka/pull/9001#issuecomment-702621705 @junrao Thanks for the review comments! I have done the change proposed in https://github.com/apache/kafka/pull/9001#discussion_r498574911 in the most recent commit: 4218f9

[GitHub] [kafka] kowshik commented on a change in pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

2020-10-02 Thread GitBox
kowshik commented on a change in pull request #9001: URL: https://github.com/apache/kafka/pull/9001#discussion_r498574911 ## File path: clients/src/main/java/org/apache/kafka/common/feature/SupportedVersionRange.java ## @@ -17,9 +17,16 @@ package org.apache.kafka.common.featu

[jira] [Created] (KAFKA-10566) Erroneous unknown config warnings about ssl and sasl configs

2020-10-02 Thread Tom Bentley (Jira)
Tom Bentley created KAFKA-10566: --- Summary: Erroneous unknown config warnings about ssl and sasl configs Key: KAFKA-10566 URL: https://issues.apache.org/jira/browse/KAFKA-10566 Project: Kafka I

[jira] [Resolved] (KAFKA-10557) Missing docs when describing topic configs including documentation

2020-10-02 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10557?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison resolved KAFKA-10557. Fix Version/s: 2.6.1 2.7.0 Resolution: Fixed > Missing docs when

[jira] [Updated] (KAFKA-10557) Missing docs when describing topic configs including documentation

2020-10-02 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10557?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison updated KAFKA-10557: --- Issue Type: Bug (was: Improvement) > Missing docs when describing topic configs including d

[GitHub] [kafka] dajac commented on a change in pull request #9318: KAFKA-10497 Convert group coordinator metadata schemas to use generat…

2020-10-02 Thread GitBox
dajac commented on a change in pull request #9318: URL: https://github.com/apache/kafka/pull/9318#discussion_r498717745 ## File path: core/src/main/resources/common/message/OffsetCommitKey.json ## @@ -0,0 +1,25 @@ +// Licensed to the Apache Software Foundation (ASF) under one o

[jira] [Commented] (KAFKA-7383) Verify leader epoch in produce requests (KIP-359)

2020-10-02 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17206122#comment-17206122 ] David Jacot commented on KAFKA-7383: [~hachikuji] It seems that we have implemented t

[jira] [Created] (KAFKA-10567) Choose ip address while producing messages to kafka broker.

2020-10-02 Thread shriram (Jira)
shriram created KAFKA-10567: --- Summary: Choose ip address while producing messages to kafka broker. Key: KAFKA-10567 URL: https://issues.apache.org/jira/browse/KAFKA-10567 Project: Kafka Issue Type

[jira] [Commented] (KAFKA-10567) Choose ip address while producing messages to kafka broker.

2020-10-02 Thread shriram (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17206129#comment-17206129 ] shriram commented on KAFKA-10567: - Gone through the API's which doesn't have any api to

[GitHub] [kafka] rhauch commented on pull request #9306: KAFKA-10477: Enabling the same behavior of NULL JsonNodeType to MISSI…

2020-10-02 Thread GitBox
rhauch commented on pull request #9306: URL: https://github.com/apache/kafka/pull/9306#issuecomment-702745660 No green jobs, but all of the Connect and MirrorMaker2 tests in all of the jobs passed. All of the failures in the tests were (flaky) client, broker, or streams tests. --

[GitHub] [kafka] rhauch merged pull request #9306: KAFKA-10477: Enabling the same behavior of NULL JsonNodeType to MISSI…

2020-10-02 Thread GitBox
rhauch merged pull request #9306: URL: https://github.com/apache/kafka/pull/9306 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] yeralin commented on pull request #6592: KAFKA-8326: Introduce List Serde

2020-10-02 Thread GitBox
yeralin commented on pull request #6592: URL: https://github.com/apache/kafka/pull/6592#issuecomment-702774321 @mjsax Let me know when I can jump back to it :) This is an automated message from the Apache Git Service. To resp

[GitHub] [kafka] vvcephei commented on a change in pull request #9361: KAFKA-10535: Split ProcessorContext into Processor/StateStore/Record Contexts

2020-10-02 Thread GitBox
vvcephei commented on a change in pull request #9361: URL: https://github.com/apache/kafka/pull/9361#discussion_r498871305 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java ## @@ -692,8 +690,7 @@ public boolean process(final long

[GitHub] [kafka] rosibaj commented on pull request #8103: KAFKA-7061: KIP-280 Enhanced log compaction

2020-10-02 Thread GitBox
rosibaj commented on pull request #8103: URL: https://github.com/apache/kafka/pull/8103#issuecomment-702791679 @mjsax @junrao @guozhangwang is there a schedule for release of this feature? This is an automated message from th

[GitHub] [kafka] senthilm-ms commented on pull request #8103: KAFKA-7061: KIP-280 Enhanced log compaction

2020-10-02 Thread GitBox
senthilm-ms commented on pull request #8103: URL: https://github.com/apache/kafka/pull/8103#issuecomment-702793843 I will work on it in the coming week to close the code review… Sorry for the delays! Thanks, Senthil From: Rosi Bajari Sent: Friday, October 2, 2020

[GitHub] [kafka] nym3r0s commented on pull request #9280: KAFKA-10186: Abort transaction with pending data with TransactionAbortedException

2020-10-02 Thread GitBox
nym3r0s commented on pull request #9280: URL: https://github.com/apache/kafka/pull/9280#issuecomment-702794731 @hachikuji @ableegoldman - I've added a test for the same exception. Can you pls take a look and let me know if any changes are needed? -

[jira] [Created] (KAFKA-10568) transforms.InsertField.type

2020-10-02 Thread Nikos Nikoloutsakos (Jira)
Nikos Nikoloutsakos created KAFKA-10568: --- Summary: transforms.InsertField.type Key: KAFKA-10568 URL: https://issues.apache.org/jira/browse/KAFKA-10568 Project: Kafka Issue Type: Bug

[GitHub] [kafka] vvcephei commented on a change in pull request #9361: KAFKA-10535: Split ProcessorContext into Processor/StateStore/Record Contexts

2020-10-02 Thread GitBox
vvcephei commented on a change in pull request #9361: URL: https://github.com/apache/kafka/pull/9361#discussion_r498904526 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/api/ProcessorContext.java ## @@ -55,6 +52,16 @@ */ TaskId taskId(); +

[GitHub] [kafka] vvcephei commented on a change in pull request #9361: KAFKA-10535: Split ProcessorContext into Processor/StateStore/Record Contexts

2020-10-02 Thread GitBox
vvcephei commented on a change in pull request #9361: URL: https://github.com/apache/kafka/pull/9361#discussion_r498905668 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/api/ProcessorContext.java ## @@ -55,6 +52,16 @@ */ TaskId taskId(); +

[GitHub] [kafka] tombentley opened a new pull request #9365: KAFKA-10566: Fix erroneous config usage warnings

2020-10-02 Thread GitBox
tombentley opened a new pull request #9365: URL: https://github.com/apache/kafka/pull/9365 Fix warn log messages caused by making HashMap copies of configs prior to using. This is not an ideal solution, but because the `Map`s are passed through `Configurable.configure(Map)` it's not possib

[GitHub] [kafka] tombentley commented on pull request #9365: KAFKA-10566: Fix erroneous config usage warnings

2020-10-02 Thread GitBox
tombentley commented on pull request #9365: URL: https://github.com/apache/kafka/pull/9365#issuecomment-702817414 @rajinisivaram @omkreddy perhaps one of you could review? This is an automated message from the Apache Git Serv

[GitHub] [kafka] vvcephei commented on a change in pull request #9361: KAFKA-10535: Split ProcessorContext into Processor/StateStore/Record Contexts

2020-10-02 Thread GitBox
vvcephei commented on a change in pull request #9361: URL: https://github.com/apache/kafka/pull/9361#discussion_r498914034 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorContextImpl.java ## @@ -159,84 +157,123 @@ public StateStore get

[GitHub] [kafka] vvcephei commented on a change in pull request #9361: KAFKA-10535: Split ProcessorContext into Processor/StateStore/Record Contexts

2020-10-02 Thread GitBox
vvcephei commented on a change in pull request #9361: URL: https://github.com/apache/kafka/pull/9361#discussion_r498915601 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorContextImpl.java ## @@ -159,84 +157,123 @@ public StateStore get

[GitHub] [kafka] mimaison merged pull request #8730: KAFKA-10048: Possible data gap for a consumer after a failover when u…

2020-10-02 Thread GitBox
mimaison merged pull request #8730: URL: https://github.com/apache/kafka/pull/8730 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[jira] [Updated] (KAFKA-10048) Possible data gap for a consumer after a failover when using MM2

2020-10-02 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison updated KAFKA-10048: --- Affects Version/s: 2.6.0 > Possible data gap for a consumer after a failover when using MM2

[GitHub] [kafka] ning2008wisc commented on pull request #8730: KAFKA-10048: Possible data gap for a consumer after a failover when u…

2020-10-02 Thread GitBox
ning2008wisc commented on pull request #8730: URL: https://github.com/apache/kafka/pull/8730#issuecomment-702836102 Hi @mimaison I will rebase my pr https://github.com/apache/kafka/pull/9224 on top of this one over this weekend and hope you may have time soon to review it as your next one.

[GitHub] [kafka] chia7712 commented on a change in pull request #9318: KAFKA-10497 Convert group coordinator metadata schemas to use generat…

2020-10-02 Thread GitBox
chia7712 commented on a change in pull request #9318: URL: https://github.com/apache/kafka/pull/9318#discussion_r498936138 ## File path: core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala ## @@ -998,173 +997,13 @@ object GroupMetadataManager { val LoadTi

[GitHub] [kafka] mimaison merged pull request #9341: MINOR: Fix MirrorConnectorsIntegrationTest

2020-10-02 Thread GitBox
mimaison merged pull request #9341: URL: https://github.com/apache/kafka/pull/9341 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[jira] [Created] (KAFKA-10569) Running aggregate queries on KSQL client side is getting to ERROR Shutdown broker because all log dirs in ...

2020-10-02 Thread Petre Gordan (Jira)
Petre Gordan created KAFKA-10569: Summary: Running aggregate queries on KSQL client side is getting to ERROR Shutdown broker because all log dirs in ... Key: KAFKA-10569 URL: https://issues.apache.org/jira/browse/

[jira] [Updated] (KAFKA-10569) Running aggregate queries on KSQL client side is getting to ERROR Shutdown broker because all log dirs in ...

2020-10-02 Thread Petre Gordan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Petre Gordan updated KAFKA-10569: - Attachment: ksql-server.properties > Running aggregate queries on KSQL client side is getting to

[jira] [Updated] (KAFKA-10569) Running aggregate queries on KSQL client side is getting to ERROR Shutdown broker because all log dirs in ...

2020-10-02 Thread Petre Gordan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Petre Gordan updated KAFKA-10569: - Attachment: server.properties > Running aggregate queries on KSQL client side is getting to ERRO

[jira] [Updated] (KAFKA-10569) Running aggregate queries on KSQL client side is getting to ERROR Shutdown broker because all log dirs in ...

2020-10-02 Thread Petre Gordan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Petre Gordan updated KAFKA-10569: - Attachment: zookeeper.properties > Running aggregate queries on KSQL client side is getting to E

[jira] [Updated] (KAFKA-10569) Running aggregate queries on KSQL client side is getting to ERROR Shutdown broker because all log dirs in ...

2020-10-02 Thread Petre Gordan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Petre Gordan updated KAFKA-10569: - Attachment: zookeeper-server-start.bat > Running aggregate queries on KSQL client side is gettin

[jira] [Updated] (KAFKA-10569) Running aggregate queries on KSQL client side is getting to ERROR Shutdown broker because all log dirs in ...

2020-10-02 Thread Petre Gordan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Petre Gordan updated KAFKA-10569: - Attachment: kafka-server-start.bat > Running aggregate queries on KSQL client side is getting to

[jira] [Updated] (KAFKA-10569) Running aggregate queries on KSQL client side is getting to ERROR Shutdown broker because all log dirs in ...

2020-10-02 Thread Petre Gordan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Petre Gordan updated KAFKA-10569: - Attachment: ksql-server-start > Running aggregate queries on KSQL client side is getting to ERRO

[jira] [Updated] (KAFKA-10569) Running aggregate queries on KSQL client side is getting to ERROR Shutdown broker because all log dirs in ...

2020-10-02 Thread Petre Gordan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Petre Gordan updated KAFKA-10569: - Attachment: ksql > Running aggregate queries on KSQL client side is getting to ERROR Shutdown >

[jira] [Updated] (KAFKA-10569) Running aggregate queries on KSQL client side is getting to ERROR Shutdown broker because all log dirs in ...

2020-10-02 Thread Petre Gordan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Petre Gordan updated KAFKA-10569: - Description: Working on Windows 10 and I'm running locally: * in powershell, zookeeper with: *b

[jira] [Updated] (KAFKA-10569) Running aggregate queries on KSQL client side is getting to ERROR Shutdown broker because all log dirs in ...

2020-10-02 Thread Petre Gordan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Petre Gordan updated KAFKA-10569: - Description: Working on Windows 10 and confluent-5.5.0-2.12.zip and kafka_2.12-2.5.0. I'm runni

[jira] [Updated] (KAFKA-10564) Continuous logging about deleting obsolete state directories

2020-10-02 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-10564: Labels: beginner newbie (was: ) > Continuous logging about deleting obsolete state direct

[jira] [Updated] (KAFKA-10569) Running aggregate queries on KSQL client side is getting to ERROR Shutdown broker because all log dirs in ...

2020-10-02 Thread Petre Gordan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Petre Gordan updated KAFKA-10569: - Attachment: schema-registry.properties > Running aggregate queries on KSQL client side is gettin

[GitHub] [kafka] guozhangwang commented on a change in pull request #9361: KAFKA-10535: Split ProcessorContext into Processor/StateStore/Record Contexts

2020-10-02 Thread GitBox
guozhangwang commented on a change in pull request #9361: URL: https://github.com/apache/kafka/pull/9361#discussion_r498951242 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorContextImpl.java ## @@ -159,84 +157,123 @@ public StateStore

[GitHub] [kafka] chia7712 commented on a change in pull request #9318: KAFKA-10497 Convert group coordinator metadata schemas to use generat…

2020-10-02 Thread GitBox
chia7712 commented on a change in pull request #9318: URL: https://github.com/apache/kafka/pull/9318#discussion_r498957874 ## File path: core/src/main/scala/kafka/common/OffsetAndMetadata.scala ## @@ -45,8 +45,4 @@ object OffsetAndMetadata { def apply(offset: Long, metadata:

[GitHub] [kafka] vvcephei edited a comment on pull request #9346: KAFKA-10535: Split ProcessorContext into Processor/StateStore/RecordContext

2020-10-02 Thread GitBox
vvcephei edited a comment on pull request #9346: URL: https://github.com/apache/kafka/pull/9346#issuecomment-702209092 Closing POC in favor of new PR: https://github.com/apache/kafka/pull/9361 This is an automated message fro

[GitHub] [kafka] scanterog commented on a change in pull request #9313: [mm2] Fix consumer/producer properties override

2020-10-02 Thread GitBox
scanterog commented on a change in pull request #9313: URL: https://github.com/apache/kafka/pull/9313#discussion_r498971069 ## File path: connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorConnectorConfig.java ## @@ -199,8 +199,8 @@ protected static fina

[GitHub] [kafka] dielhennr edited a comment on pull request #9101: KAFKA-10325: KIP-649 implementation

2020-10-02 Thread GitBox
dielhennr edited a comment on pull request #9101: URL: https://github.com/apache/kafka/pull/9101#issuecomment-683076305 Hey @jsancio , I added some work in progress to this branch including a new RPC for this feature. Fitting user and client-id into the `DescribeConfigs` API was awk

[GitHub] [kafka] dielhennr edited a comment on pull request #9101: KAFKA-10325: KIP-649 implementation

2020-10-02 Thread GitBox
dielhennr edited a comment on pull request #9101: URL: https://github.com/apache/kafka/pull/9101#issuecomment-683076305 Hey @jsancio , I added some work in progress to this branch including a new RPC for this feature. Fitting user and client-id into the `DescribeConfigs` API was awk

[GitHub] [kafka] dielhennr edited a comment on pull request #9101: KAFKA-10325: KIP-649 implementation

2020-10-02 Thread GitBox
dielhennr edited a comment on pull request #9101: URL: https://github.com/apache/kafka/pull/9101#issuecomment-683076305 Hey @jsancio , I added some work in progress to this branch including a new RPC for this feature. Fitting user and client-id into the `DescribeConfigs` API was awk

[GitHub] [kafka] rhauch commented on pull request #9347: KAFKA-10531: Check for negative values to Thread.sleep call

2020-10-02 Thread GitBox
rhauch commented on pull request #9347: URL: https://github.com/apache/kafka/pull/9347#issuecomment-702915039 @soondenana if the goal is to minimize the changes, would it be sufficient to change the code to use `Time.sleep(...)` instead of `Thread.sleep(...)`, and then change the `SystemTi

[jira] [Created] (KAFKA-10570) Rename JMXReporter configs for KIP-629

2020-10-02 Thread Jira
Xavier Léauté created KAFKA-10570: - Summary: Rename JMXReporter configs for KIP-629 Key: KAFKA-10570 URL: https://issues.apache.org/jira/browse/KAFKA-10570 Project: Kafka Issue Type: Sub-task

[jira] [Created] (KAFKA-10571) replace occurrences of blackout with backoff

2020-10-02 Thread Jira
Xavier Léauté created KAFKA-10571: - Summary: replace occurrences of blackout with backoff Key: KAFKA-10571 URL: https://issues.apache.org/jira/browse/KAFKA-10571 Project: Kafka Issue Type: Su

[GitHub] [kafka] rhauch commented on a change in pull request #9347: KAFKA-10531: Check for negative values to Thread.sleep call

2020-10-02 Thread GitBox
rhauch commented on a change in pull request #9347: URL: https://github.com/apache/kafka/pull/9347#discussion_r499023599 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/util/KafkaBasedLog.java ## @@ -70,7 +70,7 @@ */ public class KafkaBasedLog { pr

[jira] [Updated] (KAFKA-10571) replace occurrences of blackout with backoff for KIP-629

2020-10-02 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-10571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xavier Léauté updated KAFKA-10571: -- Summary: replace occurrences of blackout with backoff for KIP-629 (was: replace occurrences o

[jira] [Updated] (KAFKA-10572) Rename mirrormaker 2 blacklist configs for KIP-629

2020-10-02 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-10572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xavier Léauté updated KAFKA-10572: -- Summary: Rename mirrormaker 2 blacklist configs for KIP-629 (was: rename mirrormaker 2 blackl

[jira] [Updated] (KAFKA-10571) Replace occurrences of blackout with backoff for KIP-629

2020-10-02 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-10571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xavier Léauté updated KAFKA-10571: -- Summary: Replace occurrences of blackout with backoff for KIP-629 (was: replace occurrences o

[jira] [Created] (KAFKA-10572) rename mirrormaker 2 blacklist configs for KIP-629

2020-10-02 Thread Jira
Xavier Léauté created KAFKA-10572: - Summary: rename mirrormaker 2 blacklist configs for KIP-629 Key: KAFKA-10572 URL: https://issues.apache.org/jira/browse/KAFKA-10572 Project: Kafka Issue Ty

[jira] [Created] (KAFKA-10573) Rename connect transform configs for KIP-629

2020-10-02 Thread Jira
Xavier Léauté created KAFKA-10573: - Summary: Rename connect transform configs for KIP-629 Key: KAFKA-10573 URL: https://issues.apache.org/jira/browse/KAFKA-10573 Project: Kafka Issue Type: Su

[GitHub] [kafka] soondenana commented on pull request #9347: KAFKA-10531: Check for negative values to Thread.sleep call

2020-10-02 Thread GitBox
soondenana commented on pull request #9347: URL: https://github.com/apache/kafka/pull/9347#issuecomment-702938936 > @soondenana if the goal is to minimize the changes, would it be sufficient to change the code to use `Time.sleep(...)` instead of `Thread.sleep(...)`, and then change the `Sy

[GitHub] [kafka] soondenana commented on a change in pull request #9347: KAFKA-10531: Check for negative values to Thread.sleep call

2020-10-02 Thread GitBox
soondenana commented on a change in pull request #9347: URL: https://github.com/apache/kafka/pull/9347#discussion_r499033230 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/util/KafkaBasedLog.java ## @@ -133,11 +133,14 @@ public void start() { Lis

[GitHub] [kafka] soondenana commented on a change in pull request #9347: KAFKA-10531: Check for negative values to Thread.sleep call

2020-10-02 Thread GitBox
soondenana commented on a change in pull request #9347: URL: https://github.com/apache/kafka/pull/9347#discussion_r499033111 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/util/KafkaBasedLog.java ## @@ -70,7 +70,7 @@ */ public class KafkaBasedLog {

[GitHub] [kafka] junrao commented on a change in pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

2020-10-02 Thread GitBox
junrao commented on a change in pull request #9001: URL: https://github.com/apache/kafka/pull/9001#discussion_r498959506 ## File path: core/src/main/scala/kafka/controller/KafkaController.scala ## @@ -272,6 +281,147 @@ class KafkaController(val config: KafkaConfig, } }

[GitHub] [kafka] junrao commented on a change in pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

2020-10-02 Thread GitBox
junrao commented on a change in pull request #9001: URL: https://github.com/apache/kafka/pull/9001#discussion_r498980025 ## File path: core/src/main/scala/kafka/controller/KafkaController.scala ## @@ -272,6 +281,147 @@ class KafkaController(val config: KafkaConfig, } }

[GitHub] [kafka] junrao commented on a change in pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

2020-10-02 Thread GitBox
junrao commented on a change in pull request #9001: URL: https://github.com/apache/kafka/pull/9001#discussion_r499036138 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/DescribeFeaturesResult.java ## @@ -0,0 +1,37 @@ +/* + * Licensed to the Apache Software F

[GitHub] [kafka] rhauch commented on pull request #9347: KAFKA-10531: Check for negative values to Thread.sleep call

2020-10-02 Thread GitBox
rhauch commented on pull request #9347: URL: https://github.com/apache/kafka/pull/9347#issuecomment-702944802 > Considering that I decided to rewrite the loop to fix all three issues. That makes sense, and I noticed the same when reviewing. > Good question on performance. It se

[GitHub] [kafka] xvrl opened a new pull request #9366: KAFKA-10571 Replace blackout with backoff for KIP-629

2020-10-02 Thread GitBox
xvrl opened a new pull request #9366: URL: https://github.com/apache/kafka/pull/9366 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Updated] (KAFKA-10572) Rename MirrorMaker 2 blacklist configs for KIP-629

2020-10-02 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-10572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xavier Léauté updated KAFKA-10572: -- Summary: Rename MirrorMaker 2 blacklist configs for KIP-629 (was: Rename mirrormaker 2 blackl

[jira] [Assigned] (KAFKA-10571) Replace occurrences of blackout with backoff for KIP-629

2020-10-02 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-10571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xavier Léauté reassigned KAFKA-10571: - Assignee: Xavier Léauté > Replace occurrences of blackout with backoff for KIP-629 > --

[jira] [Resolved] (KAFKA-10513) Newly added topic or partitions are not assigned to running consumer groups using static membership

2020-10-02 Thread Marlon Ou (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marlon Ou resolved KAFKA-10513. --- Resolution: Won't Fix > Newly added topic or partitions are not assigned to running consumer groups

[GitHub] [kafka] junrao commented on a change in pull request #9364: KAFKA-10471 Mark broker crash during log loading as unclean shutdown

2020-10-02 Thread GitBox
junrao commented on a change in pull request #9364: URL: https://github.com/apache/kafka/pull/9364#discussion_r499051238 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -244,7 +244,8 @@ class Log(@volatile private var _dir: File, val producerIdExpirationC

[jira] [Commented] (KAFKA-10569) Running aggregate queries on KSQL client side is getting to ERROR Shutdown broker because all log dirs in ...

2020-10-02 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17206536#comment-17206536 ] Matthias J. Sax commented on KAFKA-10569: - [~petregor...@gmail.com] – ksqlDB is

[GitHub] [kafka] soondenana commented on pull request #9347: KAFKA-10531: Check for negative values to Thread.sleep call

2020-10-02 Thread GitBox
soondenana commented on pull request #9347: URL: https://github.com/apache/kafka/pull/9347#issuecomment-702979275 > should we also change Utils.sleep(...) (called by SystemTime.sleep(...) that is now used above) to check and return immediately for a negative number of milliseconds to sleep

[GitHub] [kafka] xvrl opened a new pull request #9367: KAFKA-10570 Rename JMXReporter configs for KIP-629

2020-10-02 Thread GitBox
xvrl opened a new pull request #9367: URL: https://github.com/apache/kafka/pull/9367 * rename whitelist/blacklist to include/exclude * add utility methods to translate deprecated configs This is an automated message from t

[GitHub] [kafka] ijuma commented on a change in pull request #9347: KAFKA-10531: Check for negative values to Thread.sleep call

2020-10-02 Thread GitBox
ijuma commented on a change in pull request #9347: URL: https://github.com/apache/kafka/pull/9347#discussion_r499071998 ## File path: clients/src/main/java/org/apache/kafka/common/utils/Utils.java ## @@ -331,6 +331,11 @@ public static ByteBuffer wrapNullable(byte[] array) {

[jira] [Assigned] (KAFKA-10570) Rename JMXReporter configs for KIP-629

2020-10-02 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-10570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xavier Léauté reassigned KAFKA-10570: - Assignee: Xavier Léauté > Rename JMXReporter configs for KIP-629 >

[GitHub] [kafka] soondenana commented on a change in pull request #9347: KAFKA-10531: Check for negative values to Thread.sleep call

2020-10-02 Thread GitBox
soondenana commented on a change in pull request #9347: URL: https://github.com/apache/kafka/pull/9347#discussion_r499076318 ## File path: clients/src/main/java/org/apache/kafka/common/utils/Utils.java ## @@ -331,6 +331,11 @@ public static ByteBuffer wrapNullable(byte[] array)

[GitHub] [kafka] vvcephei commented on a change in pull request #9273: KAFKA-9331: changes for Streams uncaught exception handler

2020-10-02 Thread GitBox
vvcephei commented on a change in pull request #9273: URL: https://github.com/apache/kafka/pull/9273#discussion_r499019285 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -364,6 +368,62 @@ public void setUncaughtExceptionHandler(final Threa

[jira] [Commented] (KAFKA-10569) Running aggregate queries on KSQL client side is getting to ERROR Shutdown broker because all log dirs in ...

2020-10-02 Thread Almog Gavra (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17206551#comment-17206551 ] Almog Gavra commented on KAFKA-10569: - Hello [~petregor...@gmail.com] - I took a loo

[GitHub] [kafka] ijuma commented on a change in pull request #9347: KAFKA-10531: Check for negative values to Thread.sleep call

2020-10-02 Thread GitBox
ijuma commented on a change in pull request #9347: URL: https://github.com/apache/kafka/pull/9347#discussion_r499079604 ## File path: clients/src/main/java/org/apache/kafka/common/utils/Utils.java ## @@ -331,6 +331,11 @@ public static ByteBuffer wrapNullable(byte[] array) {

[GitHub] [kafka] ijuma commented on a change in pull request #9347: KAFKA-10531: Check for negative values to Thread.sleep call

2020-10-02 Thread GitBox
ijuma commented on a change in pull request #9347: URL: https://github.com/apache/kafka/pull/9347#discussion_r499079604 ## File path: clients/src/main/java/org/apache/kafka/common/utils/Utils.java ## @@ -331,6 +331,11 @@ public static ByteBuffer wrapNullable(byte[] array) {

[GitHub] [kafka] soondenana commented on a change in pull request #9347: KAFKA-10531: Check for negative values to Thread.sleep call

2020-10-02 Thread GitBox
soondenana commented on a change in pull request #9347: URL: https://github.com/apache/kafka/pull/9347#discussion_r499080376 ## File path: clients/src/main/java/org/apache/kafka/common/utils/Utils.java ## @@ -331,6 +331,11 @@ public static ByteBuffer wrapNullable(byte[] array)

[GitHub] [kafka] vvcephei commented on pull request #9361: KAFKA-10535: Split ProcessorContext into Processor/StateStore/Record Contexts

2020-10-02 Thread GitBox
vvcephei commented on pull request #9361: URL: https://github.com/apache/kafka/pull/9361#issuecomment-703003770 One unrelated failure: ``` Build / JDK 11 / org.apache.kafka.streams.integration.EosBetaUpgradeIntegrationTest.shouldUpgradeFromEosAlphaToEosBeta[true] failed ```

[GitHub] [kafka] vvcephei merged pull request #9361: KAFKA-10535: Split ProcessorContext into Processor/StateStore/Record Contexts

2020-10-02 Thread GitBox
vvcephei merged pull request #9361: URL: https://github.com/apache/kafka/pull/9361 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] guozhangwang commented on pull request #9020: KAFKA-10271 Performance regression while fetching a key from a single partition

2020-10-02 Thread GitBox
guozhangwang commented on pull request #9020: URL: https://github.com/apache/kafka/pull/9020#issuecomment-703020271 test this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] guozhangwang commented on a change in pull request #9020: KAFKA-10271 Performance regression while fetching a key from a single partition

2020-10-02 Thread GitBox
guozhangwang commented on a change in pull request #9020: URL: https://github.com/apache/kafka/pull/9020#discussion_r499101848 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/WrappingStoreProvider.java ## @@ -46,11 +46,22 @@ public void setStoreQue

[GitHub] [kafka] kowshik commented on a change in pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

2020-10-02 Thread GitBox
kowshik commented on a change in pull request #9001: URL: https://github.com/apache/kafka/pull/9001#discussion_r499102118 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/DescribeFeaturesResult.java ## @@ -0,0 +1,37 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] kowshik commented on a change in pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

2020-10-02 Thread GitBox
kowshik commented on a change in pull request #9001: URL: https://github.com/apache/kafka/pull/9001#discussion_r499102266 ## File path: clients/src/main/java/org/apache/kafka/common/feature/SupportedVersionRange.java ## @@ -17,9 +17,16 @@ package org.apache.kafka.common.featu

  1   2   >