Fleshgrinder commented on pull request #9370:
URL: https://github.com/apache/kafka/pull/9370#issuecomment-703439333
Hey @rondagostino 😊 we can equally well fix it in the other direction and
allow `null`. Let me update the PR and revert the doc changes.
chia7712 commented on pull request #9318:
URL: https://github.com/apache/kafka/pull/9318#issuecomment-703413622
@dajac I have addressed your comment. please take a look. The features of
auto-generated protocol is good to cleanup code :)
ning2008wisc commented on pull request #9224:
URL: https://github.com/apache/kafka/pull/9224#issuecomment-703412889
./gradlew connect:mirror:test
chia7712 commented on a change in pull request #9318:
URL: https://github.com/apache/kafka/pull/9318#discussion_r499348032
##
File path:
core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala
##
@@ -1211,37 +1033,30 @@ object GroupMetadataManager {
def offse
mikebin opened a new pull request #9373:
URL: https://github.com/apache/kafka/pull/9373
Avoid continuous repeated logging by not trying to clean empty task
directories, which are longer fully deleted during internal cleanup as of
https://issues.apache.org/jira/browse/KAFKA-6647.
###
chia7712 commented on a change in pull request #9372:
URL: https://github.com/apache/kafka/pull/9372#discussion_r499344010
##
File path: core/src/test/scala/integration/kafka/api/MetricsTest.scala
##
@@ -114,7 +115,8 @@ class MetricsTest extends IntegrationTestHarness with
Sas
guozhangwang commented on pull request #9020:
URL: https://github.com/apache/kafka/pull/9020#issuecomment-703387252
@dima5rr I tried to compile your branch but got a few compilation error like
the following:
```
/Users/guozhang/Workspace/github/guozhangwang/kafka-work/streams/src
guozhangwang commented on pull request #9020:
URL: https://github.com/apache/kafka/pull/9020#issuecomment-703380689
test this
This is an automated message from the Apache Git Service.
To respond to the message, please log on
rondagostino commented on pull request #9370:
URL: https://github.com/apache/kafka/pull/9370#issuecomment-703313051
@Fleshgrinder Thanks for the PR. I'll let others comment on the main gist
of it (`null` has probably wasted more than a billion dollars, so I'm generally
all for mitigating
dajac commented on a change in pull request #9318:
URL: https://github.com/apache/kafka/pull/9318#discussion_r499283449
##
File path:
core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala
##
@@ -1211,37 +1033,30 @@ object GroupMetadataManager {
def offsetCo
rondagostino commented on pull request #9356:
URL: https://github.com/apache/kafka/pull/9356#issuecomment-703308436
Yeah, we no longer contact the server if the client doesn't recognize the
SASL mechanism. The PR at https://github.com/apache/kafka/pull/9372 fixes this
test, which was usin
rondagostino opened a new pull request #9372:
URL: https://github.com/apache/kafka/pull/9372
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of test
kowshik edited a comment on pull request #9001:
URL: https://github.com/apache/kafka/pull/9001#issuecomment-703048608
@junrao Thanks for the review! I've addressed the comments, the PR is ready
for another pass. I've also fixed the compilation errors.
-
chia7712 commented on pull request #9356:
URL: https://github.com/apache/kafka/pull/9356#issuecomment-703297575
@rondagostino It seems ```MetricsTest.testMetrics``` start to fail after
this PR is merged. Could you take a look?
-
piotrrzysko opened a new pull request #9371:
URL: https://github.com/apache/kafka/pull/9371
This patch introduces server-side validation that checks if applying
requested reassignment won't lead to a situation where different partitions of
the same topic have different replication factors.
Fleshgrinder commented on pull request #9369:
URL: https://github.com/apache/kafka/pull/9369#issuecomment-703280878
Failed tests seem unrelated to me.
This is an automated message from the Apache Git Service.
To respond to th
Fleshgrinder opened a new pull request #9370:
URL: https://github.com/apache/kafka/pull/9370
This introduces a new **compile-only** dependency on [JetBrains Java
Annotations](https://github.com/JetBrains/java-annotations). I decided to go
for this particular dependency because it does not
[
https://issues.apache.org/jira/browse/KAFKA-5998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17207489#comment-17207489
]
Sandeep commented on KAFKA-5998:
I still see the issue in my application
Apache Kafka St
chia7712 commented on pull request #9162:
URL: https://github.com/apache/kafka/pull/9162#issuecomment-703261725
```
Build / JDK 8 /
org.apache.kafka.streams.integration.EosBetaUpgradeIntegrationTest.shouldUpgradeFromEosAlphaToEosBeta[true]
```
unrelated error. rebase
chia7712 commented on pull request #9318:
URL: https://github.com/apache/kafka/pull/9318#issuecomment-703261060
```
Build / JDK 15 /
org.apache.kafka.streams.integration.EosBetaUpgradeIntegrationTest.shouldUpgradeFromEosAlphaToEosBeta[true]
```
unrelated error. rebase to trigge
20 matches
Mail list logo
