[GitHub] [kafka] Fleshgrinder edited a comment on pull request #9374: MINOR: Fix NPE in KafkaAdminClient.describeUserScramCredentials

2020-10-05 Thread GitBox
Fleshgrinder edited a comment on pull request #9374: URL: https://github.com/apache/kafka/pull/9374#issuecomment-704057098 @chia7712 the server gets null right now, and the code you propose is more or less what I had originally. However, at least @rondagostino was directly confused by the

[GitHub] [kafka] Fleshgrinder commented on pull request #9374: MINOR: Fix NPE in KafkaAdminClient.describeUserScramCredentials

2020-10-05 Thread GitBox
Fleshgrinder commented on pull request #9374: URL: https://github.com/apache/kafka/pull/9374#issuecomment-704057098 @chia7712 the server gets null right now, and the code you propose is more or less what I had originally. However, at least @rondagostino was directly confused by the ternary

[GitHub] [kafka] lkokhreidze commented on a change in pull request #9237: KAFKA-10454 / Update copartitionSourceGroups when optimization algorithm is triggered

2020-10-05 Thread GitBox
lkokhreidze commented on a change in pull request #9237: URL: https://github.com/apache/kafka/pull/9237#discussion_r500023844 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/StreamTableJoinTopologyOptimizationIntegrationTest.java ## @@ -0,0 +1,256 @@ +

[GitHub] [kafka] chia7712 commented on pull request #9374: MINOR: Fix NPE in KafkaAdminClient.describeUserScramCredentials

2020-10-05 Thread GitBox
chia7712 commented on pull request #9374: URL: https://github.com/apache/kafka/pull/9374#issuecomment-704046977 Nice finding! Is there also a potential NPE in server-side? According to the protocol schema (https://github.com/apache/kafka/blob/trunk/clients/src/main/resources/common/

[jira] [Commented] (KAFKA-8318) Session Window Aggregations generate an extra tombstone

2020-10-05 Thread Ilia Pasynkov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208497#comment-17208497 ] Ilia Pasynkov commented on KAFKA-8318: -- Hello, [~vvcephei]. Right now I'm looking a

[GitHub] [kafka] guozhangwang commented on a change in pull request #8988: KAFKA-10199: Separate restore threads

2020-10-05 Thread GitBox
guozhangwang commented on a change in pull request #8988: URL: https://github.com/apache/kafka/pull/8988#discussion_r51027 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java ## @@ -659,13 +665,12 @@ void runOnce() {

[jira] [Updated] (KAFKA-10577) StreamThread should be able to process any processible tasks regardless of its state

2020-10-05 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-10577: Component/s: streams > StreamThread should be able to process any processible tasks regard

[jira] [Commented] (KAFKA-10555) Improve client state machine

2020-10-05 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208492#comment-17208492 ] Matthias J. Sax commented on KAFKA-10555: - {quote}I thought we were only conside

[jira] [Created] (KAFKA-10577) StreamThread should be able to process any processible tasks regardless of its state

2020-10-05 Thread Guozhang Wang (Jira)
Guozhang Wang created KAFKA-10577: - Summary: StreamThread should be able to process any processible tasks regardless of its state Key: KAFKA-10577 URL: https://issues.apache.org/jira/browse/KAFKA-10577

[GitHub] [kafka] mikebin commented on pull request #9373: KAFKA-10564: only process non-empty task directories when internally cleaning obsolete state stores

2020-10-05 Thread GitBox
mikebin commented on pull request #9373: URL: https://github.com/apache/kafka/pull/9373#issuecomment-704032434 Thanks for the review @ableegoldman! Added a unit test. And thanks @vvcephei for making it easier to cherry pick this fix back to 2.6. ---

[jira] [Updated] (KAFKA-10576) Different behavior of commitSync and commitAsync

2020-10-05 Thread Yuriy Badalyantc (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yuriy Badalyantc updated KAFKA-10576: - Description: It looks like {{commitSync}} and {{commitAsync}} consumer's methods have a

[jira] [Created] (KAFKA-10576) Different behavior of commitSync and commitAsync

2020-10-05 Thread Yuriy Badalyantc (Jira)
Yuriy Badalyantc created KAFKA-10576: Summary: Different behavior of commitSync and commitAsync Key: KAFKA-10576 URL: https://issues.apache.org/jira/browse/KAFKA-10576 Project: Kafka Issu

[GitHub] [kafka] ableegoldman commented on a change in pull request #9139: KAFKA-9929: Support backward iterator on SessionStore

2020-10-05 Thread GitBox
ableegoldman commented on a change in pull request #9139: URL: https://github.com/apache/kafka/pull/9139#discussion_r46879 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/CachingSessionStore.java ## @@ -359,7 +431,11 @@ private void getNextSegm

[jira] [Created] (KAFKA-10575) StateRestoreListener#onRestoreEnd should always be triggered

2020-10-05 Thread Guozhang Wang (Jira)
Guozhang Wang created KAFKA-10575: - Summary: StateRestoreListener#onRestoreEnd should always be triggered Key: KAFKA-10575 URL: https://issues.apache.org/jira/browse/KAFKA-10575 Project: Kafka

[GitHub] [kafka] ableegoldman commented on pull request #9373: KAFKA-10564: only process non-empty task directories when internally cleaning obsolete state stores

2020-10-05 Thread GitBox
ableegoldman commented on pull request #9373: URL: https://github.com/apache/kafka/pull/9373#issuecomment-704010744 By the way, John was so kind as to cherrypick the trunk PR that rearranged things in this method back to the 2.6 branch -- so we should be able to cherrypick this PR smoothly

[GitHub] [kafka] ableegoldman edited a comment on pull request #9373: KAFKA-10564: only process non-empty task directories when internally cleaning obsolete state stores

2020-10-05 Thread GitBox
ableegoldman edited a comment on pull request #9373: URL: https://github.com/apache/kafka/pull/9373#issuecomment-704010744 By the way, John was so kind as to cherrypick the trunk PR that rearranged things in this method back to the 2.6 branch -- so we should be able to cherrypick this PR s

[GitHub] [kafka] guozhangwang commented on a change in pull request #8988: KAFKA-10199: Separate restore threads

2020-10-05 Thread GitBox
guozhangwang commented on a change in pull request #8988: URL: https://github.com/apache/kafka/pull/8988#discussion_r499988582 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StateRestoreThread.java ## @@ -0,0 +1,263 @@ +/* + * Licensed to the

[GitHub] [kafka] vvcephei commented on a change in pull request #9368: KAFKA-9274: Add timeout handling for state restore

2020-10-05 Thread GitBox
vvcephei commented on a change in pull request #9368: URL: https://github.com/apache/kafka/pull/9368#discussion_r499812565 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/Task.java ## @@ -205,4 +207,9 @@ default boolean maybePunctuateSystemTime

[jira] [Resolved] (KAFKA-10439) Connect's Values class loses precision for integers, larger than 64 bits

2020-10-05 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis resolved KAFKA-10439. Resolution: Fixed Merged and back ported to the branches listed under "Fix

[jira] [Updated] (KAFKA-10439) Connect's Values class loses precision for integers, larger than 64 bits

2020-10-05 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis updated KAFKA-10439: --- Fix Version/s: 2.6.1 2.5.2 2.4.2

[GitHub] [kafka] kkonstantine opened a new pull request #9379: MINOR: Annotate test BlockingConnectorTest as integration test

2020-10-05 Thread GitBox
kkonstantine opened a new pull request #9379: URL: https://github.com/apache/kafka/pull/9379 Currently `BlockingConnectorTest` is incorrectly runs as a unit test. Categorize this test correctly as integration test by adding the appropriate annotation ### Committer Checklist (excl

[GitHub] [kafka] rondagostino opened a new pull request #9378: MINOR: ACLs for secured cluster system tests

2020-10-05 Thread GitBox
rondagostino opened a new pull request #9378: URL: https://github.com/apache/kafka/pull/9378 This PR adds missing broker ACLs required to create topics and SCRAM credentials when ACLs are enabled for a system test. These ACLs were missed for system tests in the PR for KAFKA-10131 (https

[GitHub] [kafka] gardnervickers commented on pull request #7929: KAFKA-9393: DeleteRecords may cause extreme lock contention for large partition directories

2020-10-05 Thread GitBox
gardnervickers commented on pull request #7929: URL: https://github.com/apache/kafka/pull/7929#issuecomment-703966954 @junrao I was able to get some more time to pick this back up, apologies for the long gap in time since my last update. In the most recent commit, I've moved away fro

[GitHub] [kafka] kkonstantine merged pull request #9320: KAFKA-10439: Connect's Values to parse BigInteger as Decimal with zero scale.

2020-10-05 Thread GitBox
kkonstantine merged pull request #9320: URL: https://github.com/apache/kafka/pull/9320 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] hachikuji commented on a change in pull request #9280: KAFKA-10186: Abort transaction with pending data with TransactionAbortedException

2020-10-05 Thread GitBox
hachikuji commented on a change in pull request #9280: URL: https://github.com/apache/kafka/pull/9280#discussion_r499939576 ## File path: clients/src/test/java/org/apache/kafka/clients/producer/internals/SenderTest.java ## @@ -2358,6 +2359,41 @@ public void testForceShutdownWi

[GitHub] [kafka] hachikuji merged pull request #9377: MINOR: Move `RaftRequestHandler` to `tools` package

2020-10-05 Thread GitBox
hachikuji merged pull request #9377: URL: https://github.com/apache/kafka/pull/9377 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] bbejeck commented on pull request #9099: KAFKA-6733: Printing additional ConsumerRecord fields in DefaultMessageFormatter

2020-10-05 Thread GitBox
bbejeck commented on pull request #9099: URL: https://github.com/apache/kafka/pull/9099#issuecomment-703947094 >Do I need to do anything on this? @badaiaqrandista, nope as soon as we can get a green build, I'll merge it. --

[GitHub] [kafka] badaiaqrandista commented on pull request #9099: KAFKA-6733: Printing additional ConsumerRecord fields in DefaultMessageFormatter

2020-10-05 Thread GitBox
badaiaqrandista commented on pull request #9099: URL: https://github.com/apache/kafka/pull/9099#issuecomment-703939623 @bbejeck Do I need to do anything on this? This is an automated message from the Apache Git Service. To re

[GitHub] [kafka] bbejeck commented on pull request #9099: KAFKA-6733: Printing additional ConsumerRecord fields in DefaultMessageFormatter

2020-10-05 Thread GitBox
bbejeck commented on pull request #9099: URL: https://github.com/apache/kafka/pull/9099#issuecomment-703928924 Java 11 and Java 15 passed. Java 8 failed with `org.apache.kafka.streams.integration.PurgeRepartitionTopicIntegrationTest.shouldRestoreState` known flaky test. --

[jira] [Commented] (KAFKA-10405) Flaky Test org.apache.kafka.streams.integration.PurgeRepartitionTopicIntegrationTest.shouldRestoreState

2020-10-05 Thread Bill Bejeck (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208393#comment-17208393 ] Bill Bejeck commented on KAFKA-10405: - Saw same error again -  https://github.com/ap

[GitHub] [kafka] bbejeck commented on pull request #9237: KAFKA-10454 / Update copartitionSourceGroups when optimization algorithm is triggered

2020-10-05 Thread GitBox
bbejeck commented on pull request #9237: URL: https://github.com/apache/kafka/pull/9237#issuecomment-703926657 Note the tests for JDK 11 passed (https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-9237/12/?cloudbees-analytics-link=scm-reporting%2Fstage%2Fpending) but the job isn't e

[GitHub] [kafka] bbejeck commented on a change in pull request #9237: KAFKA-10454 / Update copartitionSourceGroups when optimization algorithm is triggered

2020-10-05 Thread GitBox
bbejeck commented on a change in pull request #9237: URL: https://github.com/apache/kafka/pull/9237#discussion_r499908753 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/StreamTableJoinTopologyOptimizationIntegrationTest.java ## @@ -0,0 +1,256 @@ +/* +

[GitHub] [kafka] guozhangwang merged pull request #9342: MINOR: Update doc for raft state metrics

2020-10-05 Thread GitBox
guozhangwang merged pull request #9342: URL: https://github.com/apache/kafka/pull/9342 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] guozhangwang commented on pull request #9377: MINOR: Move `RaftRequestHandler` to `tools` package

2020-10-05 Thread GitBox
guozhangwang commented on pull request #9377: URL: https://github.com/apache/kafka/pull/9377#issuecomment-703906935 LGTM! This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[jira] [Commented] (KAFKA-7421) Deadlock in Kafka Connect

2020-10-05 Thread Kyle Leiby (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208344#comment-17208344 ] Kyle Leiby commented on KAFKA-7421: --- Hi all, we've been encountering a similar deadlock

[GitHub] [kafka] hachikuji opened a new pull request #9377: MINOR: Move `RaftRequestHandler` to `tools` package

2020-10-05 Thread GitBox
hachikuji opened a new pull request #9377: URL: https://github.com/apache/kafka/pull/9377 To avoid confusion since is only used by `TestRaftServer`, this PR moves `RaftRequestHandler` to the `tools` package. ### Committer Checklist (excluded from commit message) - [ ] Verify desig

[GitHub] [kafka] hachikuji merged pull request #9349: MINOR: add proper checks to KafkaConsumer.groupMetadata

2020-10-05 Thread GitBox
hachikuji merged pull request #9349: URL: https://github.com/apache/kafka/pull/9349 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Commented] (KAFKA-5998) /.checkpoint.tmp Not found exception

2020-10-05 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-5998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208316#comment-17208316 ] Sophie Blee-Goldman commented on KAFKA-5998: [~sandeep.lakdaw...@gmail.com] a

[GitHub] [kafka] hachikuji opened a new pull request #9376: MINOR: Remove `TargetVoters` from `DescribeQuorum`

2020-10-05 Thread GitBox
hachikuji opened a new pull request #9376: URL: https://github.com/apache/kafka/pull/9376 This field is leftover from the early days of the KIP when it covered reassignment. Since the API is not exposed yet, should be no harm updating the first version. ### Committer Checklist (excl

[GitHub] [kafka] wcarlson5 commented on a change in pull request #9273: KAFKA-9331: changes for Streams uncaught exception handler

2020-10-05 Thread GitBox
wcarlson5 commented on a change in pull request #9273: URL: https://github.com/apache/kafka/pull/9273#discussion_r499871426 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -364,6 +368,62 @@ public void setUncaughtExceptionHandler(final Thre

[GitHub] [kafka] wcarlson5 commented on a change in pull request #9273: KAFKA-9331: changes for Streams uncaught exception handler

2020-10-05 Thread GitBox
wcarlson5 commented on a change in pull request #9273: URL: https://github.com/apache/kafka/pull/9273#discussion_r499871031 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -436,6 +496,8 @@ private void maybeSetError() { }

[GitHub] [kafka] wcarlson5 commented on a change in pull request #9273: KAFKA-9331: changes for Streams uncaught exception handler

2020-10-05 Thread GitBox
wcarlson5 commented on a change in pull request #9273: URL: https://github.com/apache/kafka/pull/9273#discussion_r499868891 ## File path: streams/src/main/java/org/apache/kafka/streams/errors/StreamsUncaughtExceptionHandler.java ## @@ -0,0 +1,49 @@ +/* + * Licensed to the Apac

[GitHub] [kafka] vvcephei commented on pull request #8353: KAFKA-9764: Remove stream simple benchmark suite

2020-10-05 Thread GitBox
vvcephei commented on pull request #8353: URL: https://github.com/apache/kafka/pull/8353#issuecomment-703874939 Cherry-picked to 2.4 and 2.3 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] kowshik edited a comment on pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

2020-10-05 Thread GitBox
kowshik edited a comment on pull request #9001: URL: https://github.com/apache/kafka/pull/9001#issuecomment-703873486 @junrao Thanks for the review! I've addressed the latest comments in e55358fd1a00f12ef98fc4d2d649a297ddf146da . The PR is ready for another pass. -

[GitHub] [kafka] kowshik commented on pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

2020-10-05 Thread GitBox
kowshik commented on pull request #9001: URL: https://github.com/apache/kafka/pull/9001#issuecomment-703873486 @junrao Thanks for the review! I've addressed the latest comments in e55358fd1a00f12ef98fc4d2d649a297ddf146da . T

[GitHub] [kafka] vvcephei commented on pull request #8353: KAFKA-9764: Remove stream simple benchmark suite

2020-10-05 Thread GitBox
vvcephei commented on pull request #8353: URL: https://github.com/apache/kafka/pull/8353#issuecomment-703869908 cherry-picked to 2.5 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] vvcephei commented on pull request #9262: MINOR: Fix log message when tasks directory is cleaned manually

2020-10-05 Thread GitBox
vvcephei commented on pull request #9262: URL: https://github.com/apache/kafka/pull/9262#issuecomment-703867931 Cherry-picked to 2.6 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] vvcephei commented on pull request #9323: KAFKA-10514: Fix unit test for state directory cleanup

2020-10-05 Thread GitBox
vvcephei commented on pull request #9323: URL: https://github.com/apache/kafka/pull/9323#issuecomment-703867815 Cherry-picked to 2.6 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] kowshik commented on a change in pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

2020-10-05 Thread GitBox
kowshik commented on a change in pull request #9001: URL: https://github.com/apache/kafka/pull/9001#discussion_r499847021 ## File path: core/src/test/scala/unit/kafka/controller/ControllerIntegrationTest.scala ## @@ -715,7 +747,58 @@ class ControllerIntegrationTest extends Zo

[GitHub] [kafka] vvcephei commented on a change in pull request #9273: KAFKA-9331: changes for Streams uncaught exception handler

2020-10-05 Thread GitBox
vvcephei commented on a change in pull request #9273: URL: https://github.com/apache/kafka/pull/9273#discussion_r499843780 ## File path: streams/src/test/java/org/apache/kafka/streams/KafkaStreamsTest.java ## @@ -616,7 +616,7 @@ public void shouldThrowExceptionSettingUncaughtE

[GitHub] [kafka] vvcephei commented on a change in pull request #9273: KAFKA-9331: changes for Streams uncaught exception handler

2020-10-05 Thread GitBox
vvcephei commented on a change in pull request #9273: URL: https://github.com/apache/kafka/pull/9273#discussion_r499842547 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -436,6 +496,8 @@ private void maybeSetError() { }

[GitHub] [kafka] vvcephei commented on a change in pull request #9273: KAFKA-9331: changes for Streams uncaught exception handler

2020-10-05 Thread GitBox
vvcephei commented on a change in pull request #9273: URL: https://github.com/apache/kafka/pull/9273#discussion_r499842547 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -436,6 +496,8 @@ private void maybeSetError() { }

[GitHub] [kafka] vvcephei commented on a change in pull request #9273: KAFKA-9331: changes for Streams uncaught exception handler

2020-10-05 Thread GitBox
vvcephei commented on a change in pull request #9273: URL: https://github.com/apache/kafka/pull/9273#discussion_r499838819 ## File path: streams/src/main/java/org/apache/kafka/streams/errors/StreamsUncaughtExceptionHandler.java ## @@ -0,0 +1,49 @@ +/* + * Licensed to the Apach

[GitHub] [kafka] vvcephei commented on a change in pull request #9273: KAFKA-9331: changes for Streams uncaught exception handler

2020-10-05 Thread GitBox
vvcephei commented on a change in pull request #9273: URL: https://github.com/apache/kafka/pull/9273#discussion_r499836489 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -364,6 +368,62 @@ public void setUncaughtExceptionHandler(final Threa

[jira] [Updated] (KAFKA-10531) KafkaBasedLog can sleep for negative values

2020-10-05 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch updated KAFKA-10531: -- Fix Version/s: 2.5.2 2.7.0 > KafkaBasedLog can sleep for negative values >

[GitHub] [kafka] dima5rr commented on pull request #9020: KAFKA-10271 Performance regression while fetching a key from a single partition

2020-10-05 Thread GitBox
dima5rr commented on pull request #9020: URL: https://github.com/apache/kafka/pull/9020#issuecomment-703838454 Hi @guozhangwang can you trigger new build, looks like flaky tests? This is an automated message from the Apache G

[GitHub] [kafka] kowshik commented on a change in pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

2020-10-05 Thread GitBox
kowshik commented on a change in pull request #9001: URL: https://github.com/apache/kafka/pull/9001#discussion_r499816619 ## File path: core/src/test/scala/unit/kafka/server/UpdateFeaturesTest.scala ## @@ -0,0 +1,580 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] kowshik commented on a change in pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

2020-10-05 Thread GitBox
kowshik commented on a change in pull request #9001: URL: https://github.com/apache/kafka/pull/9001#discussion_r499816373 ## File path: core/src/test/scala/unit/kafka/server/UpdateFeaturesTest.scala ## @@ -0,0 +1,580 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] kowshik commented on a change in pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

2020-10-05 Thread GitBox
kowshik commented on a change in pull request #9001: URL: https://github.com/apache/kafka/pull/9001#discussion_r499812076 ## File path: core/src/test/scala/unit/kafka/server/UpdateFeaturesTest.scala ## @@ -0,0 +1,580 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] rhauch merged pull request #9347: KAFKA-10531: Check for negative values to Thread.sleep call

2020-10-05 Thread GitBox
rhauch merged pull request #9347: URL: https://github.com/apache/kafka/pull/9347 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] kowshik commented on a change in pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

2020-10-05 Thread GitBox
kowshik commented on a change in pull request #9001: URL: https://github.com/apache/kafka/pull/9001#discussion_r499811752 ## File path: core/src/test/scala/unit/kafka/cluster/BrokerEndPointTest.scala ## @@ -185,7 +185,7 @@ class BrokerEndPointTest { "endpoints":["CLIENT:

[GitHub] [kafka] kowshik commented on a change in pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

2020-10-05 Thread GitBox
kowshik commented on a change in pull request #9001: URL: https://github.com/apache/kafka/pull/9001#discussion_r499811265 ## File path: core/src/main/scala/kafka/controller/KafkaController.scala ## @@ -272,6 +281,161 @@ class KafkaController(val config: KafkaConfig, } }

[GitHub] [kafka] kowshik commented on a change in pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

2020-10-05 Thread GitBox
kowshik commented on a change in pull request #9001: URL: https://github.com/apache/kafka/pull/9001#discussion_r499810462 ## File path: core/src/main/scala/kafka/controller/KafkaController.scala ## @@ -272,6 +281,161 @@ class KafkaController(val config: KafkaConfig, } }

[jira] [Assigned] (KAFKA-10559) Don't shutdown the entire app upon TimeoutException during internal topic validation

2020-10-05 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sophie Blee-Goldman reassigned KAFKA-10559: --- Assignee: Sagar Rao > Don't shutdown the entire app upon TimeoutException d

[GitHub] [kafka] piotrrzysko commented on pull request #9371: KAFKA-10510: Validate replication factor consistency on reassignment

2020-10-05 Thread GitBox
piotrrzysko commented on pull request #9371: URL: https://github.com/apache/kafka/pull/9371#issuecomment-703823226 Hi @stanislavkozlovski, would you mind taking a look at this PR? This is an automated message from the Apache

[jira] [Commented] (KAFKA-10559) Don't shutdown the entire app upon TimeoutException during internal topic validation

2020-10-05 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208257#comment-17208257 ] Sophie Blee-Goldman commented on KAFKA-10559: - [~sagarrao] Yeah, go ahead! T

[GitHub] [kafka] soondenana commented on pull request #9347: KAFKA-10531: Check for negative values to Thread.sleep call

2020-10-05 Thread GitBox
soondenana commented on pull request #9347: URL: https://github.com/apache/kafka/pull/9347#issuecomment-703805880 There was an error when building `streams.examples`: ``` [2020-10-05T08:40:05.722Z] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-archetype-plugin:3.2.

[GitHub] [kafka] bbejeck commented on pull request #9237: KAFKA-10454 / Update copartitionSourceGroups when optimization algorithm is triggered

2020-10-05 Thread GitBox
bbejeck commented on pull request #9237: URL: https://github.com/apache/kafka/pull/9237#issuecomment-703803731 @lkokhreidze, thanks for the quick update. I'll make another pass soon. This is an automated message from the Apac

[GitHub] [kafka] junrao commented on a change in pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

2020-10-05 Thread GitBox
junrao commented on a change in pull request #9001: URL: https://github.com/apache/kafka/pull/9001#discussion_r499753420 ## File path: core/src/test/scala/unit/kafka/cluster/BrokerEndPointTest.scala ## @@ -185,7 +185,7 @@ class BrokerEndPointTest { "endpoints":["CLIENT:/

[jira] [Resolved] (KAFKA-9585) Flaky Test: LagFetchIntegrationTest#shouldFetchLagsDuringRebalancingWithOptimization

2020-10-05 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna resolved KAFKA-9585. -- Resolution: Cannot Reproduce > Flaky Test: > LagFetchIntegrationTest#shouldFetchLagsDuringReba

[jira] [Commented] (KAFKA-10555) Improve client state machine

2020-10-05 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208231#comment-17208231 ] Sophie Blee-Goldman commented on KAFKA-10555: - Just to clarify, I do agree w

[jira] [Resolved] (KAFKA-10530) kafka-streams-application-reset misses some internal topics

2020-10-05 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler resolved KAFKA-10530. -- Resolution: Duplicate Closing now, since this seems like a duplicate report, and visual code

[jira] [Updated] (KAFKA-10562) KIP-478: Delegate the store wrappers to the new init method

2020-10-05 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10562?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler updated KAFKA-10562: - Summary: KIP-478: Delegate the store wrappers to the new init method (was: Delegate the store w

[jira] [Updated] (KAFKA-10546) KIP-478: Deprecate old PAPI

2020-10-05 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler updated KAFKA-10546: - Component/s: streams > KIP-478: Deprecate old PAPI > --- > >

[jira] [Updated] (KAFKA-10544) Convert KTable aggregations to new PAPI

2020-10-05 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler updated KAFKA-10544: - Component/s: streams > Convert KTable aggregations to new PAPI > ---

[jira] [Updated] (KAFKA-10562) Delegate the store wrappers to the new init method

2020-10-05 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10562?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler updated KAFKA-10562: - Component/s: streams > Delegate the store wrappers to the new init method >

[jira] [Updated] (KAFKA-10539) Convert KStreamImpl joins to new PAPI

2020-10-05 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler updated KAFKA-10539: - Component/s: streams > Convert KStreamImpl joins to new PAPI > -

[jira] [Updated] (KAFKA-10538) Convert KStreamImpl maps to new PAPI

2020-10-05 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler updated KAFKA-10538: - Component/s: streams > Convert KStreamImpl maps to new PAPI > --

[jira] [Updated] (KAFKA-10540) Convert KStream aggregations to new PAPI

2020-10-05 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler updated KAFKA-10540: - Component/s: streams > Convert KStream aggregations to new PAPI > --

[jira] [Updated] (KAFKA-10542) Convert KTable maps to new PAPI

2020-10-05 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler updated KAFKA-10542: - Component/s: streams > Convert KTable maps to new PAPI > --- > >

[jira] [Updated] (KAFKA-10543) Convert KTable joins to new PAPI

2020-10-05 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler updated KAFKA-10543: - Component/s: streams > Convert KTable joins to new PAPI > > >

[jira] [Updated] (KAFKA-10541) Convert KTable filters to new PAPI

2020-10-05 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler updated KAFKA-10541: - Component/s: streams > Convert KTable filters to new PAPI > -- >

[jira] [Updated] (KAFKA-10537) Convert KStreamImpl filters to new PAPI

2020-10-05 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler updated KAFKA-10537: - Component/s: streams > Convert KStreamImpl filters to new PAPI > ---

[jira] [Updated] (KAFKA-10536) KIP-478: Implement KStream changes

2020-10-05 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler updated KAFKA-10536: - Fix Version/s: 2.7.0 > KIP-478: Implement KStream changes > -- >

[jira] [Updated] (KAFKA-10536) KIP-478: Implement KStream changes

2020-10-05 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10536?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler updated KAFKA-10536: - Component/s: streams > KIP-478: Implement KStream changes > -- >

[jira] [Updated] (KAFKA-10535) KIP-478: Implement StateStoreContext and Record

2020-10-05 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler updated KAFKA-10535: - Fix Version/s: 2.7.0 > KIP-478: Implement StateStoreContext and Record > ---

[jira] [Resolved] (KAFKA-10535) KIP-478: Implement StateStoreContext and Record

2020-10-05 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler resolved KAFKA-10535. -- Resolution: Fixed > KIP-478: Implement StateStoreContext and Record >

[jira] [Updated] (KAFKA-10437) KIP-478: Implement test-utils changes

2020-10-05 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler updated KAFKA-10437: - Fix Version/s: 2.7.0 > KIP-478: Implement test-utils changes > -

[jira] [Updated] (KAFKA-10535) KIP-478: Implement StateStoreContext and Record

2020-10-05 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler updated KAFKA-10535: - Component/s: streams > KIP-478: Implement StateStoreContext and Record > ---

[jira] [Updated] (KAFKA-10437) KIP-478: Implement test-utils changes

2020-10-05 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler updated KAFKA-10437: - Component/s: streams > KIP-478: Implement test-utils changes > -

[jira] [Updated] (KAFKA-10437) KIP-478: Implement test-utils changes

2020-10-05 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler updated KAFKA-10437: - Component/s: (was: streams-test-utils) > KIP-478: Implement test-utils changes > ---

[jira] [Updated] (KAFKA-10437) KIP-478: Implement test-utils changes

2020-10-05 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler updated KAFKA-10437: - Component/s: streams-test-utils > KIP-478: Implement test-utils changes > --

[jira] [Updated] (KAFKA-10436) Implement KIP-478 Topology changes

2020-10-05 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler updated KAFKA-10436: - Component/s: streams > Implement KIP-478 Topology changes > -- >

[GitHub] [kafka] C0urante commented on pull request #9375: KAFKA-10574: Fix infinite loop in Values::parseString

2020-10-05 Thread GitBox
C0urante commented on pull request #9375: URL: https://github.com/apache/kafka/pull/9375#issuecomment-703775022 Thanks @kkonstantine, I've added a comment and addressed the Checkstyle issues. This is an automated message fro

[GitHub] [kafka] C0urante commented on a change in pull request #9375: KAFKA-10574: Fix infinite loop in Values::parseString

2020-10-05 Thread GitBox
C0urante commented on a change in pull request #9375: URL: https://github.com/apache/kafka/pull/9375#discussion_r499754411 ## File path: connect/api/src/test/java/org/apache/kafka/connect/data/ValuesTest.java ## @@ -73,6 +76,15 @@ INT_LIST.add(-987654321); } +

[GitHub] [kafka] C0urante commented on a change in pull request #9375: KAFKA-10574: Fix infinite loop in Values::parseString

2020-10-05 Thread GitBox
C0urante commented on a change in pull request #9375: URL: https://github.com/apache/kafka/pull/9375#discussion_r499754411 ## File path: connect/api/src/test/java/org/apache/kafka/connect/data/ValuesTest.java ## @@ -73,6 +76,15 @@ INT_LIST.add(-987654321); } +

[GitHub] [kafka] kkonstantine commented on a change in pull request #9375: KAFKA-10574: Fix infinite loop in Values::parseString

2020-10-05 Thread GitBox
kkonstantine commented on a change in pull request #9375: URL: https://github.com/apache/kafka/pull/9375#discussion_r499750739 ## File path: connect/api/src/test/java/org/apache/kafka/connect/data/ValuesTest.java ## @@ -73,6 +76,15 @@ INT_LIST.add(-987654321); }

[jira] [Updated] (KAFKA-7334) Suggest changing config for state.dir in case of FileNotFoundException

2020-10-05 Thread Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sophie Blee-Goldman updated KAFKA-7334: --- Labels: newbie (was: ) > Suggest changing config for state.dir in case of FileNotFou

[jira] [Commented] (KAFKA-10559) Don't shutdown the entire app upon TimeoutException during internal topic validation

2020-10-05 Thread Sagar Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208194#comment-17208194 ] Sagar Rao commented on KAFKA-10559: --- hey [~ableegoldman], I can pick this one if neede

[GitHub] [kafka] lkokhreidze commented on a change in pull request #9237: KAFKA-10454 / Update copartitionSourceGroups when optimization algorithm is triggered

2020-10-05 Thread GitBox
lkokhreidze commented on a change in pull request #9237: URL: https://github.com/apache/kafka/pull/9237#discussion_r485886423 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/StreamTableJoinTopologyOptimizationIntegrationTest.java ## @@ -0,0 +1,242 @@ +

  1   2   >