chia7712 commented on pull request #9374:
URL: https://github.com/apache/kafka/pull/9374#issuecomment-705340299
this PR is to fix a critical bug. Maybe we should file a jira for it (and so
it can be in 2.7.0 release plan)
vvcephei commented on pull request #9139:
URL: https://github.com/apache/kafka/pull/9139#issuecomment-705319493
Jenkins is running again, so I'll let it finish and merge in the morning.
This is an automated message from the
vvcephei commented on pull request #9139:
URL: https://github.com/apache/kafka/pull/9139#issuecomment-705319349
Oh, ironically, there is a merge conflict with trunk, and it's due to one of
the only "extra" changes I left in: renaming Caching*StoreTest to
Caching*StoreTest and in the
vvcephei merged pull request #9388:
URL: https://github.com/apache/kafka/pull/9388
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
vvcephei commented on pull request #9388:
URL: https://github.com/apache/kafka/pull/9388#issuecomment-705316037
Looks like the java 11 build only had a couple of environmental failures:
```
00:52:22 org.gradle.internal.remote.internal.ConnectException: Could not
connect to server
vvcephei commented on pull request #9388:
URL: https://github.com/apache/kafka/pull/9388#issuecomment-705316202
Thanks for the review, @guozhangwang ! I'll go ahead and merge this, and
deal with the couple of cleanup issues in a follow-on PR.
vvcephei commented on a change in pull request #9388:
URL: https://github.com/apache/kafka/pull/9388#discussion_r501435613
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredWindowStore.java
##
@@ -122,7 +158,7 @@ public boolean
vvcephei commented on a change in pull request #9388:
URL: https://github.com/apache/kafka/pull/9388#discussion_r501433923
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredKeyValueStore.java
##
@@ -83,14 +85,40 @@
this.valueSerde =
vvcephei commented on a change in pull request #9388:
URL: https://github.com/apache/kafka/pull/9388#discussion_r501432967
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredKeyValueStore.java
##
@@ -83,14 +85,40 @@
this.valueSerde =
chia7712 commented on a change in pull request #9001:
URL: https://github.com/apache/kafka/pull/9001#discussion_r501432770
##
File path: clients/src/main/java/org/apache/kafka/clients/admin/Admin.java
##
@@ -1306,6 +1307,73 @@ default AlterUserScramCredentialsResult
vvcephei commented on a change in pull request #9388:
URL: https://github.com/apache/kafka/pull/9388#discussion_r501432866
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/InMemoryTimeOrderedKeyValueBuffer.java
##
@@ -29,7 +29,9 @@
import
vvcephei commented on pull request #9139:
URL: https://github.com/apache/kafka/pull/9139#issuecomment-705311946
Ok, I've pushed a couple of commits addressing my feedback.
I absolutely share the desire to clean up bad formatting in the codebase,
but when PRs are this extensive, I'd
chia7712 commented on pull request #9318:
URL: https://github.com/apache/kafka/pull/9318#issuecomment-705311185
```
Build / JDK 8 /
kafka.api.PlaintextAdminIntegrationTest.testAlterReplicaLogDirs
```
pass on my local. rebase to trigger QA
chia7712 commented on a change in pull request #9001:
URL: https://github.com/apache/kafka/pull/9001#discussion_r501418496
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java
##
@@ -4335,6 +4343,150 @@ void handleFailure(Throwable
vvcephei commented on a change in pull request #9139:
URL: https://github.com/apache/kafka/pull/9139#discussion_r501351457
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/InMemorySessionStore.java
##
@@ -382,9 +479,23 @@ private boolean
mjsax commented on pull request #9052:
URL: https://github.com/apache/kafka/pull/9052#issuecomment-705288742
@vvcephei -- Random thought: with this change, we still require people to
pass in `Properties` object. As it can be empty, I am wondering if we should do
a small KIP and add a
mjsax merged pull request #8130:
URL: https://github.com/apache/kafka/pull/8130
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
mjsax commented on pull request #8130:
URL: https://github.com/apache/kafka/pull/8130#issuecomment-705287643
Thanks for the PR @dongjinleekr! Merged to `trunk`.
This is an automated message from the Apache Git Service.
To
mjsax commented on a change in pull request #9380:
URL: https://github.com/apache/kafka/pull/9380#discussion_r501406765
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorStateManager.java
##
@@ -603,7 +603,11 @@ public void checkpoint()
ableegoldman commented on a change in pull request #9380:
URL: https://github.com/apache/kafka/pull/9380#discussion_r501394335
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StateDirectory.java
##
@@ -98,6 +98,10 @@ public
ableegoldman commented on a change in pull request #9380:
URL: https://github.com/apache/kafka/pull/9380#discussion_r501392266
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorStateManager.java
##
@@ -603,7 +603,11 @@ public void
ableegoldman commented on a change in pull request #9380:
URL: https://github.com/apache/kafka/pull/9380#discussion_r501393724
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorStateManager.java
##
@@ -603,7 +603,11 @@ public void
ableegoldman commented on a change in pull request #9380:
URL: https://github.com/apache/kafka/pull/9380#discussion_r501392266
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorStateManager.java
##
@@ -603,7 +603,11 @@ public void
mjsax commented on a change in pull request #9380:
URL: https://github.com/apache/kafka/pull/9380#discussion_r501386522
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorStateManager.java
##
@@ -603,7 +603,11 @@ public void checkpoint()
mjsax commented on a change in pull request #9380:
URL: https://github.com/apache/kafka/pull/9380#discussion_r501385841
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StateDirectory.java
##
@@ -98,6 +98,10 @@ public StateDirectory(final
mjsax commented on a change in pull request #9380:
URL: https://github.com/apache/kafka/pull/9380#discussion_r501385372
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImpl.java
##
@@ -446,7 +446,9 @@ public void checkpoint()
mjsax commented on a change in pull request #9380:
URL: https://github.com/apache/kafka/pull/9380#discussion_r501385024
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStateManagerImpl.java
##
@@ -446,7 +446,9 @@ public void checkpoint()
cmccabe commented on pull request #9390:
URL: https://github.com/apache/kafka/pull/9390#issuecomment-705253526
ok to test
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
cmccabe opened a new pull request #9390:
URL: https://github.com/apache/kafka/pull/9390
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
ableegoldman commented on pull request #9139:
URL: https://github.com/apache/kafka/pull/9139#issuecomment-705249059
Alright Jenkins is being wonky yet again, but I checked out this branch and
ran the tests locally to verify.
[
https://issues.apache.org/jira/browse/KAFKA-10559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17209929#comment-17209929
]
Sophie Blee-Goldman commented on KAFKA-10559:
-
Exactly, just rethrow the TimeoutException.
ableegoldman commented on pull request #9139:
URL: https://github.com/apache/kafka/pull/9139#issuecomment-705241380
test this please
This is an automated message from the Apache Git Service.
To respond to the message, please
ableegoldman commented on pull request #9139:
URL: https://github.com/apache/kafka/pull/9139#issuecomment-705240588
Retest this please
This is an automated message from the Apache Git Service.
To respond to the message,
mikebin commented on pull request #9373:
URL: https://github.com/apache/kafka/pull/9373#issuecomment-705235323
Thank you all!
This is an automated message from the Apache Git Service.
To respond to the message, please log on
guozhangwang commented on pull request #9373:
URL: https://github.com/apache/kafka/pull/9373#issuecomment-705233561
Cherry-picked to 2.6.
This is an automated message from the Apache Git Service.
To respond to the message,
guozhangwang merged pull request #9373:
URL: https://github.com/apache/kafka/pull/9373
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
guozhangwang commented on a change in pull request #9388:
URL: https://github.com/apache/kafka/pull/9388#discussion_r501347228
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredKeyValueStore.java
##
@@ -83,14 +85,40 @@
ableegoldman commented on a change in pull request #9139:
URL: https://github.com/apache/kafka/pull/9139#discussion_r501346943
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/CachingSessionStore.java
##
@@ -359,7 +431,11 @@ private void
xvrl commented on pull request #9366:
URL: https://github.com/apache/kafka/pull/9366#issuecomment-705225637
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please log
ableegoldman commented on a change in pull request #9383:
URL: https://github.com/apache/kafka/pull/9383#discussion_r50133
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java
##
@@ -212,6 +213,7 @@ public void
jeqo commented on a change in pull request #9139:
URL: https://github.com/apache/kafka/pull/9139#discussion_r501336253
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/CachingSessionStore.java
##
@@ -359,7 +431,11 @@ private void
jeqo commented on a change in pull request #9139:
URL: https://github.com/apache/kafka/pull/9139#discussion_r501334888
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/CachingSessionStore.java
##
@@ -270,25 +335,32 @@ public void close() {
lct45 commented on a change in pull request #9383:
URL: https://github.com/apache/kafka/pull/9383#discussion_r501329620
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java
##
@@ -212,6 +213,7 @@ public void
ableegoldman commented on a change in pull request #9383:
URL: https://github.com/apache/kafka/pull/9383#discussion_r501322300
##
File path:
streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignorTest.java
##
@@ -483,7 +485,7 @@ public void
scanterog commented on a change in pull request #9313:
URL: https://github.com/apache/kafka/pull/9313#discussion_r501326680
##
File path:
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorConnectorConfig.java
##
@@ -199,8 +199,8 @@
protected static
rondagostino commented on pull request #9378:
URL: https://github.com/apache/kafka/pull/9378#issuecomment-705196327
@rajinisivaram I ran some tests locally and found some issues, which I fixed
with an additional commit. I'll kick off a system test run -- I think we
should run everything
mjsax commented on a change in pull request #9368:
URL: https://github.com/apache/kafka/pull/9368#discussion_r501307743
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StoreChangelogReader.java
##
@@ -625,11 +670,16 @@ private void
mjsax commented on a change in pull request #9368:
URL: https://github.com/apache/kafka/pull/9368#discussion_r501306055
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/AbstractTask.java
##
@@ -148,7 +148,7 @@ public void update(final Set
Jun Rao created KAFKA-10584:
---
Summary: IndexSearchType should use sealed trait instead of
Enumeration
Key: KAFKA-10584
URL: https://issues.apache.org/jira/browse/KAFKA-10584
Project: Kafka
Issue
Adem Efe Gencer created KAFKA-10583:
---
Summary: Thread-safety of AdminClient is not documented
Key: KAFKA-10583
URL: https://issues.apache.org/jira/browse/KAFKA-10583
Project: Kafka
Issue
[
https://issues.apache.org/jira/browse/KAFKA-9930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adem Efe Gencer resolved KAFKA-9930.
Resolution: Fixed
> Prevent ReplicaFetcherThread from throwing
mcdonagj commented on pull request #6329:
URL: https://github.com/apache/kafka/pull/6329#issuecomment-705153525
@cmccabe, is there any update on the status of this issue?
This is an automated message from the Apache Git
mjsax merged pull request #9385:
URL: https://github.com/apache/kafka/pull/9385
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
lct45 commented on a change in pull request #9383:
URL: https://github.com/apache/kafka/pull/9383#discussion_r501225751
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java
##
@@ -212,6 +213,7 @@ public void
guozhangwang commented on pull request #9247:
URL: https://github.com/apache/kafka/pull/9247#issuecomment-705111866
Merged to trunk, thanks @DOJI45
This is an automated message from the Apache Git Service.
To respond to the
guozhangwang merged pull request #9247:
URL: https://github.com/apache/kafka/pull/9247
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
[
https://issues.apache.org/jira/browse/KAFKA-10362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guozhang Wang resolved KAFKA-10362.
---
Fix Version/s: 2.7.0
Resolution: Fixed
> When resuming Streams active task with EOS,
hachikuji commented on a change in pull request #9311:
URL: https://github.com/apache/kafka/pull/9311#discussion_r501204644
##
File path: core/src/test/scala/integration/kafka/api/TransactionsTest.scala
##
@@ -555,11 +555,11 @@ class TransactionsTest extends
[
https://issues.apache.org/jira/browse/KAFKA-10520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17209737#comment-17209737
]
Rajini Sivaram commented on KAFKA-10520:
[~ableegoldman] Yes, will try and get this done in time
[
https://issues.apache.org/jira/browse/KAFKA-10520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rajini Sivaram reassigned KAFKA-10520:
--
Assignee: Rajini Sivaram
> InitProducerId may be blocked if least loaded node is not
[
https://issues.apache.org/jira/browse/KAFKA-9497?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rajini Sivaram resolved KAFKA-9497.
---
Resolution: Duplicate
> Brokers start up even if SASL provider is not loaded and throw NPE
[
https://issues.apache.org/jira/browse/KAFKA-9497?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rajini Sivaram reassigned KAFKA-9497:
-
Assignee: Ron Dagostino (was: Rajini Sivaram)
> Brokers start up even if SASL provider
rajinisivaram commented on a change in pull request #9382:
URL: https://github.com/apache/kafka/pull/9382#discussion_r501199512
##
File path: core/src/main/scala/kafka/server/AbstractFetcherThread.scala
##
@@ -432,14 +455,22 @@ abstract class AbstractFetcherThread(name:
voffcheg109 closed pull request #9389:
URL: https://github.com/apache/kafka/pull/9389
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
voffcheg109 removed a comment on pull request #9380:
URL: https://github.com/apache/kafka/pull/9380#issuecomment-705089696
@mjsax, can you merge this pr?
@ableegoldman, I've also created pr for 2.6 -
https://github.com/apache/kafka/pull/9389
thake commented on pull request #9338:
URL: https://github.com/apache/kafka/pull/9338#issuecomment-705090582
@vvcephei This PR should fix the NPE mentioned in KAFKA-10515. Somehow there
are some failing tests that are totally unrelated. Can someone review this PR?
voffcheg109 commented on pull request #9380:
URL: https://github.com/apache/kafka/pull/9380#issuecomment-705089696
@mjsax, can you merge this pr?
@ableegoldman, I've also created pr for 2.6 -
https://github.com/apache/kafka/pull/9389
[
https://issues.apache.org/jira/browse/KAFKA-10582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Martin updated KAFKA-10582:
--
Description:
We are using Mirror Maker 2 from the 2.5.1 release for replication on some
[
https://issues.apache.org/jira/browse/KAFKA-10582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Martin updated KAFKA-10582:
--
Description:
We are using Mirror Maker 2 from the 2.5.1 release for replication on some
voffcheg109 opened a new pull request #9389:
URL: https://github.com/apache/kafka/pull/9389
When state.dir is left at default configuration, there is a chance that
certain files under the state directory are cleaned by OS since the default dir
starts with /tmp/kafka-streams.
I've
Robert Martin created KAFKA-10582:
-
Summary: Mirror Maker 2 not replicating new topics until restart
Key: KAFKA-10582
URL: https://issues.apache.org/jira/browse/KAFKA-10582
Project: Kafka
[
https://issues.apache.org/jira/browse/KAFKA-10338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rajini Sivaram updated KAFKA-10338:
---
Description:
We currently support only file-based JKS/PKCS12 format for SSL key stores and
ableegoldman commented on pull request #9380:
URL: https://github.com/apache/kafka/pull/9380#issuecomment-705083522
Ping @mjsax for merging responsibility. Can you cherrypick it back to 2.6 as
well?
This is an automated
[
https://issues.apache.org/jira/browse/KAFKA-10028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jun Rao resolved KAFKA-10028.
-
Fix Version/s: 2.7.0
Resolution: Fixed
merged the PR to trunk
> Implement write path for
junrao merged pull request #9001:
URL: https://github.com/apache/kafka/pull/9001
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
ableegoldman commented on pull request #9380:
URL: https://github.com/apache/kafka/pull/9380#issuecomment-705081376
Don't worry about the build, looks like only some unrelated known flaky
tests in `kafka.api` caused it to fail.
junrao commented on pull request #9001:
URL: https://github.com/apache/kafka/pull/9001#issuecomment-705079102
@kowshik : Thanks for following up. I will merged this PR as it is since the
system test failures are not new.
Also, in Scala, we prefer sealed traits over Enumeration
kowshik edited a comment on pull request #9001:
URL: https://github.com/apache/kafka/pull/9001#issuecomment-705073059
@junrao Thanks for the links! I had a look at the links. I found similar
stats in both links, with exactly 27 test failures in both links. I compared
the individual test
kowshik edited a comment on pull request #9001:
URL: https://github.com/apache/kafka/pull/9001#issuecomment-705073059
@junrao Thanks for the links! I had a look at the links. I found 27 test
failures in both links. I compared the individual test failures and found that
they have all
kowshik commented on pull request #9001:
URL: https://github.com/apache/kafka/pull/9001#issuecomment-705073059
@junrao Thanks for the links! I had a look at the links. I found 27 test
failures in both links. I compared the individual test failures and found that
they have all failed on
[
https://issues.apache.org/jira/browse/KAFKA-10122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guozhang Wang resolved KAFKA-10122.
---
Fix Version/s: 2.6.1
2.7.0
Resolution: Fixed
> Consumer should
[
https://issues.apache.org/jira/browse/KAFKA-10122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17209685#comment-17209685
]
Guozhang Wang commented on KAFKA-10122:
---
This ticket is resolved as a result of KAFKA-10134: when
abbccdda commented on a change in pull request #9311:
URL: https://github.com/apache/kafka/pull/9311#discussion_r501155923
##
File path:
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java
##
@@ -1198,18 +1209,23 @@ boolean canBumpEpoch()
hachikuji commented on a change in pull request #9311:
URL: https://github.com/apache/kafka/pull/9311#discussion_r501170471
##
File path: core/src/main/scala/kafka/server/KafkaApis.scala
##
@@ -2083,8 +2083,8 @@ class KafkaApis(val requestChannel: RequestChannel,
def
junrao commented on pull request #9001:
URL: https://github.com/apache/kafka/pull/9001#issuecomment-705068372
@kowshik : There are 27 system test failures with this PR.
hachikuji commented on a change in pull request #9311:
URL: https://github.com/apache/kafka/pull/9311#discussion_r501168361
##
File path: core/src/main/scala/kafka/server/KafkaApis.scala
##
@@ -2336,6 +2335,11 @@ class KafkaApis(val requestChannel: RequestChannel,
}
}
rondagostino commented on pull request #9378:
URL: https://github.com/apache/kafka/pull/9378#issuecomment-705060101
@rajinisivaram Thanks for the insightful feedback -- I think the latest
commit does much at address the clarity/refactoring issue as well as make the
extra ACLs optional
hachikuji commented on a change in pull request #9311:
URL: https://github.com/apache/kafka/pull/9311#discussion_r501158001
##
File path:
clients/src/main/java/org/apache/kafka/common/errors/TransactionTimeOutException.java
##
@@ -0,0 +1,30 @@
+/*
+ * Licensed to the Apache
guozhangwang merged pull request #9196:
URL: https://github.com/apache/kafka/pull/9196
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
guozhangwang commented on pull request #9196:
URL: https://github.com/apache/kafka/pull/9196#issuecomment-705058498
Merged to trunk, kudos to @nizhikov for the contribution!
This is an automated message from the Apache Git
[
https://issues.apache.org/jira/browse/KAFKA-10186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gustafson resolved KAFKA-10186.
-
Fix Version/s: 2.7.0
Resolution: Fixed
> Aborting transaction with pending data
hachikuji merged pull request #9280:
URL: https://github.com/apache/kafka/pull/9280
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
hachikuji merged pull request #9376:
URL: https://github.com/apache/kafka/pull/9376
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
wcarlson5 commented on a change in pull request #9273:
URL: https://github.com/apache/kafka/pull/9273#discussion_r501124504
##
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##
@@ -364,6 +370,73 @@ public void setUncaughtExceptionHandler(final
[
https://issues.apache.org/jira/browse/KAFKA-10559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17209647#comment-17209647
]
Sagar Rao commented on KAFKA-10559:
---
[~ableegoldman], i looked at the code today.. I see that,
dongjinleekr commented on pull request #8130:
URL: https://github.com/apache/kafka/pull/8130#issuecomment-705037008
@mjsax The failing test is now fixed with commit 9f7a73f and mistakenly
removed method is reverted in commit 6972309. Also, rebased onto the latest
trunk.
@guozhangwang
dongjinleekr commented on a change in pull request #7898:
URL: https://github.com/apache/kafka/pull/7898#discussion_r501060061
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/resources/LoggingResource.java
##
@@ -60,67 +66,62 @@
@GET
tombentley commented on pull request #9266:
URL: https://github.com/apache/kafka/pull/9266#issuecomment-704971958
Thanks for the update @ijuma, I'll prepare a KIP for 3.0.
This is an automated message from the Apache Git
dongjinleekr commented on a change in pull request #7898:
URL: https://github.com/apache/kafka/pull/7898#discussion_r501054972
##
File path:
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/resources/LoggingResource.java
##
@@ -133,20 +134,18 @@ public
ijuma commented on pull request #9266:
URL: https://github.com/apache/kafka/pull/9266#issuecomment-704966543
@tombentley Thanks for the explanation. I have reverted this change for now:
https://github.com/apache/kafka/commit/75e53585255a0c2737dee84ddbad39094c5e8500
1 - 100 of 131 matches
Mail list logo
