[GitHub] [kafka] iprithv commented on pull request #9204: KAFKA-6181 Examining log messages with {{--deep-iteration}} should show superset of fields

2020-11-08 Thread GitBox
iprithv commented on pull request #9204: URL: https://github.com/apache/kafka/pull/9204#issuecomment-723764315 Hi @chia7712 @hachikuji @cmccabe please review this. Thanks. This is an automated message from the Apache Git

[GitHub] [kafka] dengziming closed pull request #9575: MINOR: optimize lock operation

2020-11-08 Thread GitBox
dengziming closed pull request #9575: URL: https://github.com/apache/kafka/pull/9575 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] dengziming commented on a change in pull request #9575: MINOR: optimize lock operation

2020-11-08 Thread GitBox
dengziming commented on a change in pull request #9575: URL: https://github.com/apache/kafka/pull/9575#discussion_r519552611 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/internals/BufferPool.java ## @@ -112,12 +112,11 @@ public ByteBuffer allocate(int

[GitHub] [kafka] guozhangwang commented on a change in pull request #9531: KAFKA-10661; Add new resigned state for graceful shutdown/initialization

2020-11-08 Thread GitBox
guozhangwang commented on a change in pull request #9531: URL: https://github.com/apache/kafka/pull/9531#discussion_r519551394 ## File path: raft/src/main/java/org/apache/kafka/raft/QuorumState.java ## @@ -21,18 +21,21 @@ import org.slf4j.Logger; import

[GitHub] [kafka] guozhangwang commented on pull request #9531: KAFKA-10661; Add new resigned state for graceful shutdown/initialization

2020-11-08 Thread GitBox
guozhangwang commented on pull request #9531: URL: https://github.com/apache/kafka/pull/9531#issuecomment-723747753 > One thing I am strongly considering, however, is changing this state machine so that the resigned state is only for leaders. That would definitely simplify the logic. The

[GitHub] [kafka] abbccdda commented on pull request #9558: KAFKA-10342: migrate remaining RPCs to forwarding

2020-11-08 Thread GitBox
abbccdda commented on pull request #9558: URL: https://github.com/apache/kafka/pull/9558#issuecomment-723717007 @guozhangwang for a review This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Created] (KAFKA-10699) Add system test coverage for group coordinator emigration

2020-11-08 Thread Boyang Chen (Jira)
Boyang Chen created KAFKA-10699: --- Summary: Add system test coverage for group coordinator emigration Key: KAFKA-10699 URL: https://issues.apache.org/jira/browse/KAFKA-10699 Project: Kafka

[GitHub] [kafka] ijuma commented on pull request #9401: KAFKA-9628 Replace Produce request/response with automated protocol

2020-11-08 Thread GitBox
ijuma commented on pull request #9401: URL: https://github.com/apache/kafka/pull/9401#issuecomment-723675299 Can we summarize the regression here for a real world workload? This is an automated message from the Apache Git

[GitHub] [kafka] chia7712 commented on a change in pull request #9575: MINOR: optimize lock operation

2020-11-08 Thread GitBox
chia7712 commented on a change in pull request #9575: URL: https://github.com/apache/kafka/pull/9575#discussion_r519441272 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/internals/BufferPool.java ## @@ -112,12 +112,11 @@ public ByteBuffer allocate(int

[GitHub] [kafka] chia7712 commented on a change in pull request #9563: KAFKA-10684; Avoid additional envelope copies during network transmission

2020-11-08 Thread GitBox
chia7712 commented on a change in pull request #9563: URL: https://github.com/apache/kafka/pull/9563#discussion_r519343434 ## File path: generator/src/main/java/org/apache/kafka/message/MessageDataGenerator.java ## @@ -1579,58 +1566,58 @@ private void