[GitHub] [kafka] vergilchiu commented on pull request #9587: Fix memory leak in JmxReporter

vergilchiu commented on pull request #9587: URL: https://github.com/apache/kafka/pull/9587#issuecomment-725901574 > @vergilchiu The best way to resolve this issue you encountered is to upgrade your kafka to fixed version (maybe 1.1.0 at least). Is there a trouble of upgrading your kafka? I

[GitHub] [kafka] chia7712 commented on pull request #9587: Fix memory leak in JmxReporter

chia7712 commented on pull request #9587: URL: https://github.com/apache/kafka/pull/9587#issuecomment-725899531 @vergilchiu The best way to resolve this issue you encountered is to upgrade your kafka to fixed version (maybe 1.1.0 at least). Is there a trouble of upgrading your kafka? If so

[jira] [Updated] (KAFKA-10347) Deprecate Metadata ControllerId

[ https://issues.apache.org/jira/browse/KAFKA-10347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Boyang Chen updated KAFKA-10347: Description: When forwarding is enabled, we should not let client know the active controller locat

[jira] [Updated] (KAFKA-10347) Deprecate Metadata ControllerId

[ https://issues.apache.org/jira/browse/KAFKA-10347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Boyang Chen updated KAFKA-10347: Summary: Deprecate Metadata ControllerId (was: Redirect Create/DeleteTopics to the controller) >

[GitHub] [kafka] abbccdda merged pull request #9580: KAFKA-10350: add forwarding manager implementation with metrics

abbccdda merged pull request #9580: URL: https://github.com/apache/kafka/pull/9580 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] vergilchiu commented on pull request #9587: Fix memory leak in JmxReporter

vergilchiu commented on pull request #9587: URL: https://github.com/apache/kafka/pull/9587#issuecomment-725880502 @chia7712 I check the code of trunk branch , this bug has already fixed in commit 5d4965bad4ea4a64d798f1cc0271de8d4e3d4289 . But it does not work in branch 0.10.1 . Unfort

[jira] [Commented] (KAFKA-9613) orruptRecordException: Found record size 0 smaller than minimum record overhead

[ https://issues.apache.org/jira/browse/KAFKA-9613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17230378#comment-17230378 ] Sergey Ivanov commented on KAFKA-9613: -- Hi, We faced the similar issue with one of

[GitHub] [kafka] splett2 commented on a change in pull request #9386: KAFKA-10024: Add dynamic configuration and enforce quota for per-IP connection rate limits (KIP-612, part 2)

splett2 commented on a change in pull request #9386: URL: https://github.com/apache/kafka/pull/9386#discussion_r521856417 ## File path: core/src/main/scala/kafka/network/SocketServer.scala ## @@ -1324,7 +1401,59 @@ class ConnectionQuotas(config: KafkaConfig, time: Time, metric

[GitHub] [kafka] splett2 commented on a change in pull request #9386: KAFKA-10024: Add dynamic configuration and enforce quota for per-IP connection rate limits (KIP-612, part 2)

splett2 commented on a change in pull request #9386: URL: https://github.com/apache/kafka/pull/9386#discussion_r521856417 ## File path: core/src/main/scala/kafka/network/SocketServer.scala ## @@ -1324,7 +1401,59 @@ class ConnectionQuotas(config: KafkaConfig, time: Time, metric

[GitHub] [kafka] splett2 commented on a change in pull request #9386: KAFKA-10024: Add dynamic configuration and enforce quota for per-IP connection rate limits (KIP-612, part 2)

splett2 commented on a change in pull request #9386: URL: https://github.com/apache/kafka/pull/9386#discussion_r521856417 ## File path: core/src/main/scala/kafka/network/SocketServer.scala ## @@ -1324,7 +1401,59 @@ class ConnectionQuotas(config: KafkaConfig, time: Time, metric

[GitHub] [kafka] splett2 commented on a change in pull request #9386: KAFKA-10024: Add dynamic configuration and enforce quota for per-IP connection rate limits (KIP-612, part 2)

splett2 commented on a change in pull request #9386: URL: https://github.com/apache/kafka/pull/9386#discussion_r521856417 ## File path: core/src/main/scala/kafka/network/SocketServer.scala ## @@ -1324,7 +1401,59 @@ class ConnectionQuotas(config: KafkaConfig, time: Time, metric

[GitHub] [kafka] splett2 commented on a change in pull request #9386: KAFKA-10024: Add dynamic configuration and enforce quota for per-IP connection rate limits (KIP-612, part 2)

splett2 commented on a change in pull request #9386: URL: https://github.com/apache/kafka/pull/9386#discussion_r521856417 ## File path: core/src/main/scala/kafka/network/SocketServer.scala ## @@ -1324,7 +1401,59 @@ class ConnectionQuotas(config: KafkaConfig, time: Time, metric

[jira] [Assigned] (KAFKA-10698) Avoid casting BaseRecords to MemoryRecords

[ https://issues.apache.org/jira/browse/KAFKA-10698?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reassigned KAFKA-10698: -- Assignee: Chia-Ping Tsai > Avoid casting BaseRecords to MemoryRecords > -

[GitHub] [kafka] splett2 commented on a change in pull request #9386: KAFKA-10024: Add dynamic configuration and enforce quota for per-IP connection rate limits (KIP-612, part 2)

splett2 commented on a change in pull request #9386: URL: https://github.com/apache/kafka/pull/9386#discussion_r521856417 ## File path: core/src/main/scala/kafka/network/SocketServer.scala ## @@ -1324,7 +1401,59 @@ class ConnectionQuotas(config: KafkaConfig, time: Time, metric

[GitHub] [kafka] chia7712 commented on pull request #9587: Fix memory leak in JmxReporter

chia7712 commented on pull request #9587: URL: https://github.com/apache/kafka/pull/9587#issuecomment-725856285 @vergilchiu Thanks for your patch. 0.10.1 is EOL. Does this issue still exist in trunk branch? This is an automa

[GitHub] [kafka] splett2 commented on a change in pull request #9386: KAFKA-10024: Add dynamic configuration and enforce quota for per-IP connection rate limits (KIP-612, part 2)

splett2 commented on a change in pull request #9386: URL: https://github.com/apache/kafka/pull/9386#discussion_r521856417 ## File path: core/src/main/scala/kafka/network/SocketServer.scala ## @@ -1324,7 +1401,59 @@ class ConnectionQuotas(config: KafkaConfig, time: Time, metric

[GitHub] [kafka] splett2 commented on a change in pull request #9386: KAFKA-10024: Add dynamic configuration and enforce quota for per-IP connection rate limits (KIP-612, part 2)

splett2 commented on a change in pull request #9386: URL: https://github.com/apache/kafka/pull/9386#discussion_r521549126 ## File path: core/src/main/scala/kafka/network/SocketServer.scala ## @@ -538,14 +542,20 @@ private[kafka] class Acceptor(val endPoint: EndPoint,

[GitHub] [kafka] zhangyue19921010 commented on pull request #9586: MINOR: Fix documentation for Kafka Quick Start Demo Code

zhangyue19921010 commented on pull request #9586: URL: https://github.com/apache/kafka/pull/9586#issuecomment-725842776 Thanks for your review and merge! This is an automated message from the Apache Git Service. To respond to

[GitHub] [kafka] zhangyue19921010 edited a comment on pull request #9586: MINOR: Fix documentation for Kafka Quick Start Demo Code

zhangyue19921010 edited a comment on pull request #9586: URL: https://github.com/apache/kafka/pull/9586#issuecomment-725842776 @chia7712 Thanks for your review and merge! This is an automated message from the Apache Git Servi

[GitHub] [kafka] chia7712 commented on pull request #9401: KAFKA-9628 Replace Produce request/response with automated protocol

chia7712 commented on pull request #9401: URL: https://github.com/apache/kafka/pull/9401#issuecomment-725786213 @hachikuji @ijuma @lbradstreet Could you take a look? There are some follow-ups which can get back the performance we lose here and I'd like to work on them as soon as possible :

[GitHub] [kafka] chia7712 commented on a change in pull request #9563: KAFKA-10684; Avoid additional envelope copies during network transmission

chia7712 commented on a change in pull request #9563: URL: https://github.com/apache/kafka/pull/9563#discussion_r521762564 ## File path: clients/src/main/java/org/apache/kafka/common/requests/AbstractResponse.java ## @@ -88,16 +80,11 @@ protected void updateErrorCounts(Map er

[GitHub] [kafka] hachikuji commented on a change in pull request #9563: KAFKA-10684; Avoid additional envelope copies during network transmission

hachikuji commented on a change in pull request #9563: URL: https://github.com/apache/kafka/pull/9563#discussion_r521760083 ## File path: clients/src/main/java/org/apache/kafka/common/requests/AbstractResponse.java ## @@ -88,16 +80,11 @@ protected void updateErrorCounts(Map e

[jira] [Commented] (KAFKA-6793) Unnecessary warning log message

[ https://issues.apache.org/jira/browse/KAFKA-6793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17230219#comment-17230219 ] Dan Lipofsky commented on KAFKA-6793: - This is still a problem in kafka 2.6.0. Could

[GitHub] [kafka] splett2 commented on a change in pull request #9386: KAFKA-10024: Add dynamic configuration and enforce quota for per-IP connection rate limits (KIP-612, part 2)

splett2 commented on a change in pull request #9386: URL: https://github.com/apache/kafka/pull/9386#discussion_r521545712 ## File path: core/src/main/scala/kafka/network/SocketServer.scala ## @@ -1324,7 +1401,59 @@ class ConnectionQuotas(config: KafkaConfig, time: Time, metric

[GitHub] [kafka] splett2 commented on a change in pull request #9386: KAFKA-10024: Add dynamic configuration and enforce quota for per-IP connection rate limits (KIP-612, part 2)

splett2 commented on a change in pull request #9386: URL: https://github.com/apache/kafka/pull/9386#discussion_r521614527 ## File path: core/src/main/scala/kafka/network/SocketServer.scala ## @@ -1324,7 +1401,59 @@ class ConnectionQuotas(config: KafkaConfig, time: Time, metric

[GitHub] [kafka] splett2 commented on a change in pull request #9386: KAFKA-10024: Add dynamic configuration and enforce quota for per-IP connection rate limits (KIP-612, part 2)

splett2 commented on a change in pull request #9386: URL: https://github.com/apache/kafka/pull/9386#discussion_r521549126 ## File path: core/src/main/scala/kafka/network/SocketServer.scala ## @@ -538,14 +542,20 @@ private[kafka] class Acceptor(val endPoint: EndPoint,

[jira] [Updated] (KAFKA-10643) Static membership - repetitive PreparingRebalance with updating metadata for member reason

[ https://issues.apache.org/jira/browse/KAFKA-10643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eran Levy updated KAFKA-10643: -- Attachment: client-d-9-11-11-2020.csv > Static membership - repetitive PreparingRebalance with updatin

[jira] [Commented] (KAFKA-10643) Static membership - repetitive PreparingRebalance with updating metadata for member reason

[ https://issues.apache.org/jira/browse/KAFKA-10643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17230181#comment-17230181 ] Eran Levy commented on KAFKA-10643: --- It sometimes happens that the rebalances taking l

[jira] [Comment Edited] (KAFKA-10643) Static membership - repetitive PreparingRebalance with updating metadata for member reason

[ https://issues.apache.org/jira/browse/KAFKA-10643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17230181#comment-17230181 ] Eran Levy edited comment on KAFKA-10643 at 11/11/20, 7:39 PM:

[GitHub] [kafka] mumrah commented on a change in pull request #9580: KAFKA-10350: add forwarding manager implementation with metrics

mumrah commented on a change in pull request #9580: URL: https://github.com/apache/kafka/pull/9580#discussion_r521587658 ## File path: core/src/main/scala/kafka/server/ForwardingManager.scala ## @@ -0,0 +1,85 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [kafka] ijuma commented on pull request #9548: Disable inlining of Scala library methods.

ijuma commented on pull request #9548: URL: https://github.com/apache/kafka/pull/9548#issuecomment-725605462 @olafurpg I think you should keep this open. I think we may want to apply a change along the lines you submitted here given the example you gave. Even though it's relying on interna

[GitHub] [kafka] splett2 commented on a change in pull request #9386: KAFKA-10024: Add dynamic configuration and enforce quota for per-IP connection rate limits (KIP-612, part 2)

splett2 commented on a change in pull request #9386: URL: https://github.com/apache/kafka/pull/9386#discussion_r521566585 ## File path: core/src/test/scala/unit/kafka/network/ConnectionQuotasTest.scala ## @@ -633,18 +837,27 @@ class ConnectionQuotasTest {

[GitHub] [kafka] splett2 commented on a change in pull request #9386: KAFKA-10024: Add dynamic configuration and enforce quota for per-IP connection rate limits (KIP-612, part 2)

splett2 commented on a change in pull request #9386: URL: https://github.com/apache/kafka/pull/9386#discussion_r521564771 ## File path: core/src/test/scala/unit/kafka/network/ConnectionQuotasTest.scala ## @@ -477,6 +568,99 @@ class ConnectionQuotasTest { assertTrue("Expect

[GitHub] [kafka] splett2 commented on a change in pull request #9386: KAFKA-10024: Add dynamic configuration and enforce quota for per-IP connection rate limits (KIP-612, part 2)

splett2 commented on a change in pull request #9386: URL: https://github.com/apache/kafka/pull/9386#discussion_r521549126 ## File path: core/src/main/scala/kafka/network/SocketServer.scala ## @@ -538,14 +542,20 @@ private[kafka] class Acceptor(val endPoint: EndPoint,

[GitHub] [kafka] splett2 commented on a change in pull request #9386: KAFKA-10024: Add dynamic configuration and enforce quota for per-IP connection rate limits (KIP-612, part 2)

splett2 commented on a change in pull request #9386: URL: https://github.com/apache/kafka/pull/9386#discussion_r521545712 ## File path: core/src/main/scala/kafka/network/SocketServer.scala ## @@ -1324,7 +1401,59 @@ class ConnectionQuotas(config: KafkaConfig, time: Time, metric

[GitHub] [kafka] viktorsomogyi edited a comment on pull request #9519: KAFKA-10650: Use Murmur3 instead of MD5 in SkimpyOffsetMap

viktorsomogyi edited a comment on pull request #9519: URL: https://github.com/apache/kafka/pull/9519#issuecomment-725539926 @ijuma I don't think I looked at it but will try it out soon, its speed seems promising. I haven't found a 128bit java implementation but I can try out the 64bit in l

[GitHub] [kafka] viktorsomogyi edited a comment on pull request #9519: KAFKA-10650: Use Murmur3 instead of MD5 in SkimpyOffsetMap

viktorsomogyi edited a comment on pull request #9519: URL: https://github.com/apache/kafka/pull/9519#issuecomment-725539926 @ijuma I don't think I looked at it but will try it out soon, its speed seems promising. I haven't found a 128bit java implementation but I can try out the 64bit in l

[GitHub] [kafka] viktorsomogyi edited a comment on pull request #9519: KAFKA-10650: Use Murmur3 instead of MD5 in SkimpyOffsetMap

viktorsomogyi edited a comment on pull request #9519: URL: https://github.com/apache/kafka/pull/9519#issuecomment-725539926 @ijuma I don't think I looked at it but will try it out soon, its speed seems promising. I haven't found a 128bit java implementation but the 64bit in lz4 can be trie

[GitHub] [kafka] viktorsomogyi commented on pull request #9519: KAFKA-10650: Use Murmur3 instead of MD5 in SkimpyOffsetMap

viktorsomogyi commented on pull request #9519: URL: https://github.com/apache/kafka/pull/9519#issuecomment-725539926 @ijuma I don't think I looked at it but will try it out soon, its speed seems promising. I haven't found a 128bit java implementation but the 64bit in lz4 can be tried out a

[GitHub] [kafka] dajac commented on a change in pull request #9386: KAFKA-10024: Add dynamic configuration and enforce quota for per-IP connection rate limits (KIP-612, part 2)

dajac commented on a change in pull request #9386: URL: https://github.com/apache/kafka/pull/9386#discussion_r521346721 ## File path: core/src/main/scala/kafka/network/SocketServer.scala ## @@ -538,14 +542,20 @@ private[kafka] class Acceptor(val endPoint: EndPoint,

[GitHub] [kafka] wcarlson5 commented on a change in pull request #9572: KAFKA-10500: Thread Cache Resizes

wcarlson5 commented on a change in pull request #9572: URL: https://github.com/apache/kafka/pull/9572#discussion_r521449419 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java ## @@ -589,6 +589,10 @@ private void subscribeConsumer

[GitHub] [kafka] vergilchiu opened a new pull request #9587: Fix memory leak in JmxReporter

vergilchiu opened a new pull request #9587: URL: https://github.com/apache/kafka/pull/9587 JmxReporter should remove the KafkaMbean from "mbeans" when it becomes empty metrics during metricRemoval,not only unregister the metrics. "mbeans" will grow bigger and bigger if not removing the

[jira] [Commented] (KAFKA-10683) Consumer.position() Ignores Transaction Marker with read_uncommitted

[ https://issues.apache.org/jira/browse/KAFKA-10683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17229992#comment-17229992 ] Gary Russell commented on KAFKA-10683: -- In my opinion, Kafka should "hide" this pse

[jira] [Created] (KAFKA-10708) Add "group-id" Tag to Kafka Consumer Metrics

Brian Wyka created KAFKA-10708: -- Summary: Add "group-id" Tag to Kafka Consumer Metrics Key: KAFKA-10708 URL: https://issues.apache.org/jira/browse/KAFKA-10708 Project: Kafka Issue Type: Improvem

[GitHub] [kafka] nizhikov commented on pull request #9585: MINOR: commit method doesn't exists for Consumer, but `commitSync` does.

nizhikov commented on pull request #9585: URL: https://github.com/apache/kafka/pull/9585#issuecomment-725385050 @chia7712 Thanks for the review and merge! This is an automated message from the Apache Git Service. To respond t

[GitHub] [kafka] chia7712 merged pull request #9586: MINOR: Fix documentation for Kafka Quick Start Demo Code

chia7712 merged pull request #9586: URL: https://github.com/apache/kafka/pull/9586 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] chia7712 merged pull request #9585: MINOR: commit method doesn't exists for Consumer, but `commitSync` does.

chia7712 merged pull request #9585: URL: https://github.com/apache/kafka/pull/9585 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] chia7712 commented on pull request #9585: MINOR: commit method doesn't exists for Consumer, but `commitSync` does.

chia7712 commented on pull request #9585: URL: https://github.com/apache/kafka/pull/9585#issuecomment-725382001 Unrelated failure. Will merge it to trunk This is an automated message from the Apache Git Service. To respond to

[GitHub] [kafka] chia7712 commented on pull request #8826: KAFKA-10090 Misleading warnings: The configuration was supplied but i…

chia7712 commented on pull request #8826: URL: https://github.com/apache/kafka/pull/8826#issuecomment-725381294 ``` org.apache.kafka.streams.integration.StreamTableJoinTopologyOptimizationIntegrationTest.shouldDoStreamTableJoinWithDifferentNumberOfPartitions ``` unrelated error

[GitHub] [kafka] dajac commented on a change in pull request #9526: KAFKA-10525: Emit JSONs with new auto-generated schema

dajac commented on a change in pull request #9526: URL: https://github.com/apache/kafka/pull/9526#discussion_r521273910 ## File path: generator/src/main/java/org/apache/kafka/message/JsonConverterGenerator.java ## @@ -375,13 +385,36 @@ private void generateVariableLengthTarget

[jira] [Resolved] (KAFKA-10693) Tests instantiate QuotaManagers without closing the managers in teardown

[ https://issues.apache.org/jira/browse/KAFKA-10693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot resolved KAFKA-10693. - Fix Version/s: 2.8.0 Resolution: Fixed > Tests instantiate QuotaManagers without closing

[GitHub] [kafka] dajac merged pull request #9573: KAFKA-10693: Close quota managers created in tests

dajac merged pull request #9573: URL: https://github.com/apache/kafka/pull/9573 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] cadonna commented on a change in pull request #9572: KAFKA-10500: Thread Cache Resizes

cadonna commented on a change in pull request #9572: URL: https://github.com/apache/kafka/pull/9572#discussion_r521249074 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -806,6 +803,17 @@ private KafkaStreams(final InternalTopologyBuilder i

[jira] [Updated] (KAFKA-10707) Socks Proxy is not taking effect in Java API

[ https://issues.apache.org/jira/browse/KAFKA-10707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sasikumar Senthilnathan updated KAFKA-10707: Description: Am trying to establish a connection via SOCKS proxy(SOCKS5) f

[jira] [Updated] (KAFKA-10707) Socks Proxy is not taking effect in Java API

[ https://issues.apache.org/jira/browse/KAFKA-10707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sasikumar Senthilnathan updated KAFKA-10707: Description: Am trying to establish a connection via SOCKS proxy(SOCKS5) f

[jira] [Created] (KAFKA-10707) Socks Proxy is not taking effect in Java API

Sasikumar Senthilnathan created KAFKA-10707: --- Summary: Socks Proxy is not taking effect in Java API Key: KAFKA-10707 URL: https://issues.apache.org/jira/browse/KAFKA-10707 Project: Kafka

[GitHub] [kafka] olafurpg closed pull request #9548: Disable inlining of Scala library methods.

olafurpg closed pull request #9548: URL: https://github.com/apache/kafka/pull/9548 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] olafurpg commented on pull request #9548: Disable inlining of Scala library methods.

olafurpg commented on pull request #9548: URL: https://github.com/apache/kafka/pull/9548#issuecomment-725316222 @ijuma Thank you for the clarification! I wasn't aware that `KafkaEmbedded` is not a public API with no compatibility guarantees. I'm gonna close this PR since the current behavi

[GitHub] [kafka] tombentley commented on pull request #9549: KIP-145: Add SMTs, HeaderFrom, DropHeaders and InsertHeader

tombentley commented on pull request #9549: URL: https://github.com/apache/kafka/pull/9549#issuecomment-725301273 @C0urante thanks for the review, some really helpful comments there. This is an automated message from the Apac

[GitHub] [kafka] tombentley commented on a change in pull request #9549: KIP-145: Add SMTs, HeaderFrom, DropHeaders and InsertHeader

tombentley commented on a change in pull request #9549: URL: https://github.com/apache/kafka/pull/9549#discussion_r521215081 ## File path: connect/transforms/src/main/java/org/apache/kafka/connect/transforms/HeaderFrom.java ## @@ -0,0 +1,219 @@ +/* + * Licensed to the Apache S

[GitHub] [kafka] zhangyue19921010 opened a new pull request #9586: MINOR: Fix documentation for Kafka Quick Start Demo Code

zhangyue19921010 opened a new pull request #9586: URL: https://github.com/apache/kafka/pull/9586 In 1.3 Quick Start, STEP 7: PROCESS YOUR EVENTS WITH KAFKA STREAMS. There is a demo to implement the popular WordCount algorithm using Kafka Streams. But these code can't run directly, be

[GitHub] [kafka] nizhikov commented on pull request #9585: MINOR: commit method doesn't exists for Consumer, but `commitSync` does.

nizhikov commented on pull request #9585: URL: https://github.com/apache/kafka/pull/9585#issuecomment-725275797 Hello, @ableegoldman , @ijuma Can you, please, take a look at the very minor one line Javadoc fix. This i

[GitHub] [kafka] nizhikov opened a new pull request #9585: MINOR: commit method doesn't exists for Consumer, but `commitSync` does.

nizhikov opened a new pull request #9585: URL: https://github.com/apache/kafka/pull/9585 One liner fix for Javadoc. `commit` method doesn't exist for `KafkaConsumer`, we have `commitSync` instead. ### Committer Checklist (excluded from commit message) - [ ] Verify design and i