dongjinleekr commented on pull request #9414:
URL: https://github.com/apache/kafka/pull/9414#issuecomment-733525231
Retest this please.
This is an automated message from the Apache Git Service.
To respond to the message,
[
https://issues.apache.org/jira/browse/KAFKA-10717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17238576#comment-17238576
]
Stefan Bejan commented on KAFKA-10717:
--
We just tried the same scenariio using Kafka 2.6.0. Same
[
https://issues.apache.org/jira/browse/KAFKA-10765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
lqjacklee reassigned KAFKA-10765:
-
Assignee: lqjacklee
> Task :stream:test-utils:test FAILED
>
[
https://issues.apache.org/jira/browse/KAFKA-10765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17238553#comment-17238553
]
lqjacklee commented on KAFKA-10765:
---
[~xiaopenglei]
{code:java}
2119 ± : ./gradlew
lmr3796 commented on a change in pull request #9435:
URL: https://github.com/apache/kafka/pull/9435#discussion_r530139420
##
File path: core/src/test/scala/unit/kafka/server/KafkaApisTest.scala
##
@@ -107,6 +108,11 @@ class KafkaApisTest {
private val time = new MockTime
PengLei created KAFKA-10765:
---
Summary: Task :stream:test-utils:test FAILED
Key: KAFKA-10765
URL: https://issues.apache.org/jira/browse/KAFKA-10765
Project: Kafka
Issue Type: Sub-task
showuon commented on pull request #9627:
URL: https://github.com/apache/kafka/pull/9627#issuecomment-733498016
@abbccdda @guozhangwang , could you please help review this PR? Thanks.
This is an automated message from the
showuon opened a new pull request #9650:
URL: https://github.com/apache/kafka/pull/9650
Before:
![image](https://user-images.githubusercontent.com/43372967/100190205-b5c95500-2f28-11eb-9566-d8561f02e7e9.png)
After:
dengziming commented on pull request #9649:
URL: https://github.com/apache/kafka/pull/9649#issuecomment-733448084
@cmccabe hi, PTAL.
This is an automated message from the Apache Git Service.
To respond to the message,
dengziming commented on pull request #9622:
URL: https://github.com/apache/kafka/pull/9622#issuecomment-733441748
> @dengziming Looks pretty good so far to me! I think it would be useful to
write a few unit/integration tests to ensure the metadata snapshot behavior and
describe topics
chia7712 commented on pull request #9644:
URL: https://github.com/apache/kafka/pull/9644#issuecomment-733429060
@tombentley Thanks for your testing. Is it worth having a configuration to
disable/enable to print prompt? The check of ```System.console``` is useful and
the configuration make
ableegoldman commented on pull request #9648:
URL: https://github.com/apache/kafka/pull/9648#issuecomment-733428965
Cherrypicked to 2.6 cc/ @mimaison
This is an automated message from the Apache Git Service.
To respond to
[
https://issues.apache.org/jira/browse/KAFKA-10754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen updated KAFKA-10754:
--
Fix Version/s: 2.8.0
> Fix flaky shouldShutdownSingleThreadApplication test
>
ableegoldman commented on pull request #9648:
URL: https://github.com/apache/kafka/pull/9648#issuecomment-733420127
Cherrypicked to 2.7 cc @bbejeck
This is an automated message from the Apache Git Service.
To respond to the
ableegoldman merged pull request #9648:
URL: https://github.com/apache/kafka/pull/9648
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
ableegoldman commented on pull request #9648:
URL: https://github.com/apache/kafka/pull/9648#issuecomment-733412594
The Java 15 tests passed, Java 8 build failed with flaky
`TransactionsTest.testBumpTransactionalEpoch` and the Java 11 build failed with
ableegoldman commented on pull request #9609:
URL: https://github.com/apache/kafka/pull/9609#issuecomment-733408778
@mjsax it's not a bugfix PR, this is only going to trunk. Well technically
it is fixing a bug, but that bug was only merged to trunk a few weeks ago.
Otherwise I would
ableegoldman commented on a change in pull request #9609:
URL: https://github.com/apache/kafka/pull/9609#discussion_r530053365
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/CogroupedKStreamImpl.java
##
@@ -129,7 +129,7 @@
mjsax edited a comment on pull request #9609:
URL: https://github.com/apache/kafka/pull/9609#issuecomment-733353791
I don't want to spoil the party, but as this is a bug-fix PR, that we want
to back-port, we should not to massive renaming... Happy, do rename in follow
up for `trunk` (and
mjsax commented on pull request #9609:
URL: https://github.com/apache/kafka/pull/9609#issuecomment-733353791
I don't want to spoil the party, but as this is a bug-fix PR, that we want
to back-port, we should not to massive renaming... Happy, do rename in follow
up for `trunk` only.
mjsax commented on a change in pull request #9609:
URL: https://github.com/apache/kafka/pull/9609#discussion_r530028617
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/CogroupedKStreamImpl.java
##
@@ -129,7 +129,7 @@
ableegoldman commented on pull request #9609:
URL: https://github.com/apache/kafka/pull/9609#issuecomment-733283434
Also just FYI since the suggested renaming touched on a lot of files, the
only logical changes are to the SourceGraphNode, StreamSourceNode, and
StreamsBuilderTest classes
ableegoldman commented on pull request #9609:
URL: https://github.com/apache/kafka/pull/9609#issuecomment-733282299
@mjsax @cadonna I addressed your feedback, lmk if there's anything else (to
answer your question, Matthias, this fixes the problem because we use
`instanceof
ableegoldman commented on a change in pull request #9609:
URL: https://github.com/apache/kafka/pull/9609#discussion_r529974090
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/graph/SourceGraphNode.java
##
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the
ableegoldman commented on a change in pull request #9609:
URL: https://github.com/apache/kafka/pull/9609#discussion_r529971103
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/graph/SourceGraphNode.java
##
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the
ableegoldman commented on a change in pull request #9648:
URL: https://github.com/apache/kafka/pull/9648#discussion_r529932449
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/RegexSourceIntegrationTest.java
##
@@ -198,9 +200,16 @@ public void
ableegoldman commented on a change in pull request #9648:
URL: https://github.com/apache/kafka/pull/9648#discussion_r529928566
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorTopology.java
##
@@ -149,24 +149,30 @@ public boolean
ableegoldman commented on pull request #9629:
URL: https://github.com/apache/kafka/pull/9629#issuecomment-733257040
Merged to trunk
This is an automated message from the Apache Git Service.
To respond to the message, please
ableegoldman merged pull request #9629:
URL: https://github.com/apache/kafka/pull/9629
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
cadonna commented on a change in pull request #9615:
URL: https://github.com/apache/kafka/pull/9615#discussion_r529858401
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/AdjustStreamThreadCountTest.java
##
@@ -0,0 +1,104 @@
+/*
+ * Licensed to the
[
https://issues.apache.org/jira/browse/KAFKA-10384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17238230#comment-17238230
]
Gary Russell edited comment on KAFKA-10384 at 11/24/20, 8:20 PM:
-
Also
cadonna commented on a change in pull request #9648:
URL: https://github.com/apache/kafka/pull/9648#discussion_r529840078
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/RegexSourceIntegrationTest.java
##
@@ -198,9 +200,16 @@ public void
cadonna commented on a change in pull request #9648:
URL: https://github.com/apache/kafka/pull/9648#discussion_r529846543
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorTopology.java
##
@@ -149,24 +149,30 @@ public boolean
cadonna commented on a change in pull request #9648:
URL: https://github.com/apache/kafka/pull/9648#discussion_r529840078
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/RegexSourceIntegrationTest.java
##
@@ -198,9 +200,16 @@ public void
[
https://issues.apache.org/jira/browse/KAFKA-7918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17238334#comment-17238334
]
Matthias J. Sax commented on KAFKA-7918:
We decided to go with bytes-based in-memory stores,
mjsax commented on pull request #9634:
URL: https://github.com/apache/kafka/pull/9634#issuecomment-733178631
Cherry-picked to `2.7` branch.
This is an automated message from the Apache Git Service.
To respond to the message,
ableegoldman commented on a change in pull request #9648:
URL: https://github.com/apache/kafka/pull/9648#discussion_r529798216
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/RegexSourceIntegrationTest.java
##
@@ -198,9 +200,16 @@ public void
ableegoldman commented on a change in pull request #9648:
URL: https://github.com/apache/kafka/pull/9648#discussion_r529798140
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorTopology.java
##
@@ -149,24 +149,30 @@ public boolean
ableegoldman commented on a change in pull request #9648:
URL: https://github.com/apache/kafka/pull/9648#discussion_r529796474
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/RegexSourceIntegrationTest.java
##
@@ -198,9 +200,16 @@ public void
ijuma merged pull request #9643:
URL: https://github.com/apache/kafka/pull/9643
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
ijuma commented on pull request #9643:
URL: https://github.com/apache/kafka/pull/9643#issuecomment-733156772
Tests passed, merging.
This is an automated message from the Apache Git Service.
To respond to the message, please
[
https://issues.apache.org/jira/browse/KAFKA-10758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17238300#comment-17238300
]
Davide Icardi commented on KAFKA-10758:
---
[~ableegoldman] Thank you very much!
> Kafka Streams
[
https://issues.apache.org/jira/browse/KAFKA-10549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justine Olshan reassigned KAFKA-10549:
--
Assignee: (was: Justine Olshan)
> Add topic ID support to
[
https://issues.apache.org/jira/browse/KAFKA-10580?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justine Olshan reassigned KAFKA-10580:
--
Assignee: (was: Justine Olshan)
> Add topic ID support to Fetch request
>
[
https://issues.apache.org/jira/browse/KAFKA-10548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justine Olshan reassigned KAFKA-10548:
--
Assignee: (was: Justine Olshan)
> Implement deletion logic for
[
https://issues.apache.org/jira/browse/KAFKA-10764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justine Olshan reassigned KAFKA-10764:
--
Assignee: Justine Olshan
> Add support for returning topic IDs on create, supplying
Justine Olshan created KAFKA-10764:
--
Summary: Add support for returning topic IDs on create, supplying
topic IDs for delete
Key: KAFKA-10764
URL: https://issues.apache.org/jira/browse/KAFKA-10764
[
https://issues.apache.org/jira/browse/KAFKA-10550?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justine Olshan updated KAFKA-10550:
---
Description:
Change describe topics AdminClient method to expose and support topic IDs
[
https://issues.apache.org/jira/browse/KAFKA-10550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17238281#comment-17238281
]
Justine Olshan commented on KAFKA-10550:
Sounds good. I'll make a separate ticket for those two
wcarlson5 commented on a change in pull request #9615:
URL: https://github.com/apache/kafka/pull/9615#discussion_r529716169
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/AdjustStreamThreadCountTest.java
##
@@ -0,0 +1,115 @@
+/*
+ * Licensed to the
wcarlson5 commented on a change in pull request #9615:
URL: https://github.com/apache/kafka/pull/9615#discussion_r529713764
##
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##
@@ -894,19 +885,88 @@ private KafkaStreams(final
wcarlson5 commented on a change in pull request #9615:
URL: https://github.com/apache/kafka/pull/9615#discussion_r529709595
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/AdjustStreamThreadCountTest.java
##
@@ -0,0 +1,115 @@
+/*
+ * Licensed to the
wcarlson5 commented on pull request #9629:
URL: https://github.com/apache/kafka/pull/9629#issuecomment-733088175
These changes LGTM. WDYT @ableegoldman? thanks for the PR!
This is an automated message from the Apache Git
[
https://issues.apache.org/jira/browse/KAFKA-10384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17238230#comment-17238230
]
Gary Russell edited comment on KAFKA-10384 at 11/24/20, 4:00 PM:
-
Is
[
https://issues.apache.org/jira/browse/KAFKA-10384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17238230#comment-17238230
]
Gary Russell commented on KAFKA-10384:
--
Is there any change the provided scope can be removed in
vamossagar12 commented on a change in pull request #9539:
URL: https://github.com/apache/kafka/pull/9539#discussion_r529623275
##
File path: clients/src/main/resources/common/message/LeaderChangeMessage.json
##
@@ -22,7 +22,9 @@
{"name": "LeaderId", "type": "int32",
[
https://issues.apache.org/jira/browse/KAFKA-10315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17238187#comment-17238187
]
rameshkrishnan muthusamy commented on KAFKA-10315:
--
[~showuon] [~mjsax] this is an
jsancio commented on a change in pull request #9539:
URL: https://github.com/apache/kafka/pull/9539#discussion_r529572270
##
File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java
##
@@ -370,14 +370,23 @@ private void onBecomeLeader(long currentTimeMs) {
ijuma commented on pull request #9643:
URL: https://github.com/apache/kafka/pull/9643#issuecomment-733008676
I reverted the Scala 2.12.13 change, looks like this hasn't been published
to Maven yet.
This is an automated
ijuma commented on a change in pull request #9643:
URL: https://github.com/apache/kafka/pull/9643#discussion_r529585355
##
File path: core/src/main/scala/kafka/admin/ConsumerGroupCommand.scala
##
@@ -151,21 +149,22 @@ object ConsumerGroupCommand extends Logging {
ijuma merged pull request #9645:
URL: https://github.com/apache/kafka/pull/9645
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
ijuma commented on pull request #9645:
URL: https://github.com/apache/kafka/pull/9645#issuecomment-733001614
JDK 8 and 15 builds passed. JDK 11 had one flaky unrelated failure:
cadonna commented on a change in pull request #9615:
URL: https://github.com/apache/kafka/pull/9615#discussion_r529461975
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/AdjustStreamThreadCountTest.java
##
@@ -0,0 +1,115 @@
+/*
+ * Licensed to the
dengziming commented on pull request #9639:
URL: https://github.com/apache/kafka/pull/9639#issuecomment-732863217
ping @hachikuji to have a look.
This is an automated message from the Apache Git Service.
To respond to the
dengziming opened a new pull request #9649:
URL: https://github.com/apache/kafka/pull/9649
The content of the 3 top-level errors are identical, just merge them.
This is an automated message from the Apache Git Service.
To
tombentley commented on pull request #9644:
URL: https://github.com/apache/kafka/pull/9644#issuecomment-732818451
@chia7712 current behaviour:
![Screenshot from 2020-11-24
10-40-59](https://user-images.githubusercontent.com/879487/100084196-5db82300-2e42-11eb-9e81-0bfd864c8255.png)
cadonna commented on a change in pull request #9614:
URL: https://github.com/apache/kafka/pull/9614#discussion_r529313022
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/metrics/StreamsMetricsImpl.java
##
@@ -214,6 +215,20 @@ public
chia7712 commented on a change in pull request #9643:
URL: https://github.com/apache/kafka/pull/9643#discussion_r529325622
##
File path: core/src/main/scala/kafka/admin/ConsumerGroupCommand.scala
##
@@ -151,21 +149,22 @@ object ConsumerGroupCommand extends Logging {
cadonna commented on a change in pull request #9609:
URL: https://github.com/apache/kafka/pull/9609#discussion_r528847393
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/graph/SourceGraphNode.java
##
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the
cadonna commented on a change in pull request #9648:
URL: https://github.com/apache/kafka/pull/9648#discussion_r529280072
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorTopology.java
##
@@ -149,24 +149,30 @@ public boolean
[
https://issues.apache.org/jira/browse/KAFKA-10763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shao Wang updated KAFKA-10763:
--
Description:
In our production environment, upon start two KafkaConnect workers, during the
first
[
https://issues.apache.org/jira/browse/KAFKA-10763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shao Wang updated KAFKA-10763:
--
Description:
In our production environment, upon start two KafkaConnect workers, during the
first
Shao Wang created KAFKA-10763:
-
Summary: Task already exists error on same worker due to skip
removal of tasks
Key: KAFKA-10763
URL: https://issues.apache.org/jira/browse/KAFKA-10763
Project: Kafka
chia7712 commented on pull request #7409:
URL: https://github.com/apache/kafka/pull/7409#issuecomment-732732168
@ijuma Is this still active? All requests/responses are using auto-generated
protocol so it is time to get rid of `Struct` from serialization. If you are
busy with other works,
74 matches
Mail list logo