[GitHub] [kafka] dongjinleekr commented on pull request #9414: KAFKA-10585: Kafka Streams should clean up the state store directory from cleanup

2020-11-24 Thread GitBox
dongjinleekr commented on pull request #9414: URL: https://github.com/apache/kafka/pull/9414#issuecomment-733525231 Retest this please. This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Commented] (KAFKA-10717) ACL authorization log when consumer requires all topics

2020-11-24 Thread Stefan Bejan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17238576#comment-17238576 ] Stefan Bejan commented on KAFKA-10717: -- We just tried the same scenariio using Kafka 2.6.0. Same

[jira] [Assigned] (KAFKA-10765) Task :stream:test-utils:test FAILED

2020-11-24 Thread lqjacklee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lqjacklee reassigned KAFKA-10765: - Assignee: lqjacklee > Task :stream:test-utils:test FAILED >

[jira] [Commented] (KAFKA-10765) Task :stream:test-utils:test FAILED

2020-11-24 Thread lqjacklee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17238553#comment-17238553 ] lqjacklee commented on KAFKA-10765: --- [~xiaopenglei] {code:java} 2119 ± : ./gradlew

[GitHub] [kafka] lmr3796 commented on a change in pull request #9435: KAFKA-10606: Disable auto topic creation for fetch-all-topic-metadata request

2020-11-24 Thread GitBox
lmr3796 commented on a change in pull request #9435: URL: https://github.com/apache/kafka/pull/9435#discussion_r530139420 ## File path: core/src/test/scala/unit/kafka/server/KafkaApisTest.scala ## @@ -107,6 +108,11 @@ class KafkaApisTest { private val time = new MockTime

[jira] [Created] (KAFKA-10765) Task :stream:test-utils:test FAILED

2020-11-24 Thread PengLei (Jira)
PengLei created KAFKA-10765: --- Summary: Task :stream:test-utils:test FAILED Key: KAFKA-10765 URL: https://issues.apache.org/jira/browse/KAFKA-10765 Project: Kafka Issue Type: Sub-task

[GitHub] [kafka] showuon commented on pull request #9627: KAFKA-10746: Change to Warn logs when necessary to notify users

2020-11-24 Thread GitBox
showuon commented on pull request #9627: URL: https://github.com/apache/kafka/pull/9627#issuecomment-733498016 @abbccdda @guozhangwang , could you please help review this PR? Thanks. This is an automated message from the

[GitHub] [kafka] showuon opened a new pull request #9650: MINOR: Update vagrant readme

2020-11-24 Thread GitBox
showuon opened a new pull request #9650: URL: https://github.com/apache/kafka/pull/9650 Before: ![image](https://user-images.githubusercontent.com/43372967/100190205-b5c95500-2f28-11eb-9566-d8561f02e7e9.png) After:

[GitHub] [kafka] dengziming commented on pull request #9649: MINOR: Combine repeated top-level error test in AlterIsrManagerTest

2020-11-24 Thread GitBox
dengziming commented on pull request #9649: URL: https://github.com/apache/kafka/pull/9649#issuecomment-733448084 @cmccabe hi, PTAL. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] dengziming commented on pull request #9622: KAFKA-10547; add topicId in MetadataResp

2020-11-24 Thread GitBox
dengziming commented on pull request #9622: URL: https://github.com/apache/kafka/pull/9622#issuecomment-733441748 > @dengziming Looks pretty good so far to me! I think it would be useful to write a few unit/integration tests to ensure the metadata snapshot behavior and describe topics

[GitHub] [kafka] chia7712 commented on pull request #9644: KAFKA-10565: Only print console producer prompt with a tty

2020-11-24 Thread GitBox
chia7712 commented on pull request #9644: URL: https://github.com/apache/kafka/pull/9644#issuecomment-733429060 @tombentley Thanks for your testing. Is it worth having a configuration to disable/enable to print prompt? The check of ```System.console``` is useful and the configuration make

[GitHub] [kafka] ableegoldman commented on pull request #9648: KAFKA-10758: ProcessorTopology should only consider its own nodes when updating regex source topics

2020-11-24 Thread GitBox
ableegoldman commented on pull request #9648: URL: https://github.com/apache/kafka/pull/9648#issuecomment-733428965 Cherrypicked to 2.6 cc/ @mimaison This is an automated message from the Apache Git Service. To respond to

[jira] [Updated] (KAFKA-10754) Fix flaky shouldShutdownSingleThreadApplication test

2020-11-24 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen updated KAFKA-10754: -- Fix Version/s: 2.8.0 > Fix flaky shouldShutdownSingleThreadApplication test >

[GitHub] [kafka] ableegoldman commented on pull request #9648: KAFKA-10758: ProcessorTopology should only consider its own nodes when updating regex source topics

2020-11-24 Thread GitBox
ableegoldman commented on pull request #9648: URL: https://github.com/apache/kafka/pull/9648#issuecomment-733420127 Cherrypicked to 2.7 cc @bbejeck This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] ableegoldman merged pull request #9648: KAFKA-10758: ProcessorTopology should only consider its own nodes when updating regex source topics

2020-11-24 Thread GitBox
ableegoldman merged pull request #9648: URL: https://github.com/apache/kafka/pull/9648 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] ableegoldman commented on pull request #9648: KAFKA-10758: ProcessorTopology should only consider its own nodes when updating regex source topics

2020-11-24 Thread GitBox
ableegoldman commented on pull request #9648: URL: https://github.com/apache/kafka/pull/9648#issuecomment-733412594 The Java 15 tests passed, Java 8 build failed with flaky `TransactionsTest.testBumpTransactionalEpoch` and the Java 11 build failed with

[GitHub] [kafka] ableegoldman commented on pull request #9609: KAFKA-6687: restrict DSL to allow only Streams from the same source topics

2020-11-24 Thread GitBox
ableegoldman commented on pull request #9609: URL: https://github.com/apache/kafka/pull/9609#issuecomment-733408778 @mjsax it's not a bugfix PR, this is only going to trunk. Well technically it is fixing a bug, but that bug was only merged to trunk a few weeks ago. Otherwise I would

[GitHub] [kafka] ableegoldman commented on a change in pull request #9609: KAFKA-6687: restrict DSL to allow only Streams from the same source topics

2020-11-24 Thread GitBox
ableegoldman commented on a change in pull request #9609: URL: https://github.com/apache/kafka/pull/9609#discussion_r530053365 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/CogroupedKStreamImpl.java ## @@ -129,7 +129,7 @@

[GitHub] [kafka] mjsax edited a comment on pull request #9609: KAFKA-6687: restrict DSL to allow only Streams from the same source topics

2020-11-24 Thread GitBox
mjsax edited a comment on pull request #9609: URL: https://github.com/apache/kafka/pull/9609#issuecomment-733353791 I don't want to spoil the party, but as this is a bug-fix PR, that we want to back-port, we should not to massive renaming... Happy, do rename in follow up for `trunk` (and

[GitHub] [kafka] mjsax commented on pull request #9609: KAFKA-6687: restrict DSL to allow only Streams from the same source topics

2020-11-24 Thread GitBox
mjsax commented on pull request #9609: URL: https://github.com/apache/kafka/pull/9609#issuecomment-733353791 I don't want to spoil the party, but as this is a bug-fix PR, that we want to back-port, we should not to massive renaming... Happy, do rename in follow up for `trunk` only.

[GitHub] [kafka] mjsax commented on a change in pull request #9609: KAFKA-6687: restrict DSL to allow only Streams from the same source topics

2020-11-24 Thread GitBox
mjsax commented on a change in pull request #9609: URL: https://github.com/apache/kafka/pull/9609#discussion_r530028617 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/CogroupedKStreamImpl.java ## @@ -129,7 +129,7 @@

[GitHub] [kafka] ableegoldman commented on pull request #9609: KAFKA-6687: restrict DSL to allow only Streams from the same source topics

2020-11-24 Thread GitBox
ableegoldman commented on pull request #9609: URL: https://github.com/apache/kafka/pull/9609#issuecomment-733283434 Also just FYI since the suggested renaming touched on a lot of files, the only logical changes are to the SourceGraphNode, StreamSourceNode, and StreamsBuilderTest classes

[GitHub] [kafka] ableegoldman commented on pull request #9609: KAFKA-6687: restrict DSL to allow only Streams from the same source topics

2020-11-24 Thread GitBox
ableegoldman commented on pull request #9609: URL: https://github.com/apache/kafka/pull/9609#issuecomment-733282299 @mjsax @cadonna I addressed your feedback, lmk if there's anything else (to answer your question, Matthias, this fixes the problem because we use `instanceof

[GitHub] [kafka] ableegoldman commented on a change in pull request #9609: KAFKA-6687: restrict DSL to allow only Streams from the same source topics

2020-11-24 Thread GitBox
ableegoldman commented on a change in pull request #9609: URL: https://github.com/apache/kafka/pull/9609#discussion_r529974090 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/graph/SourceGraphNode.java ## @@ -0,0 +1,71 @@ +/* + * Licensed to the

[GitHub] [kafka] ableegoldman commented on a change in pull request #9609: KAFKA-6687: restrict DSL to allow only Streams from the same source topics

2020-11-24 Thread GitBox
ableegoldman commented on a change in pull request #9609: URL: https://github.com/apache/kafka/pull/9609#discussion_r529971103 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/graph/SourceGraphNode.java ## @@ -0,0 +1,71 @@ +/* + * Licensed to the

[GitHub] [kafka] ableegoldman commented on a change in pull request #9648: KAFKA-10758: ProcessorTopology should only consider its own nodes when updating regex source topics

2020-11-24 Thread GitBox
ableegoldman commented on a change in pull request #9648: URL: https://github.com/apache/kafka/pull/9648#discussion_r529932449 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/RegexSourceIntegrationTest.java ## @@ -198,9 +200,16 @@ public void

[GitHub] [kafka] ableegoldman commented on a change in pull request #9648: KAFKA-10758: ProcessorTopology should only consider its own nodes when updating regex source topics

2020-11-24 Thread GitBox
ableegoldman commented on a change in pull request #9648: URL: https://github.com/apache/kafka/pull/9648#discussion_r529928566 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorTopology.java ## @@ -149,24 +149,30 @@ public boolean

[GitHub] [kafka] ableegoldman commented on pull request #9629: KAFKA-10754: fix flaky tests by waiting kafka streams be in running state before assert

2020-11-24 Thread GitBox
ableegoldman commented on pull request #9629: URL: https://github.com/apache/kafka/pull/9629#issuecomment-733257040 Merged to trunk This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] ableegoldman merged pull request #9629: KAFKA-10754: fix flaky tests by waiting kafka streams be in running state before assert

2020-11-24 Thread GitBox
ableegoldman merged pull request #9629: URL: https://github.com/apache/kafka/pull/9629 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] cadonna commented on a change in pull request #9615: KAFKA-10500: Add thread option

2020-11-24 Thread GitBox
cadonna commented on a change in pull request #9615: URL: https://github.com/apache/kafka/pull/9615#discussion_r529858401 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/AdjustStreamThreadCountTest.java ## @@ -0,0 +1,104 @@ +/* + * Licensed to the

[jira] [Comment Edited] (KAFKA-10384) Separate converters from generated messages

2020-11-24 Thread Gary Russell (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17238230#comment-17238230 ] Gary Russell edited comment on KAFKA-10384 at 11/24/20, 8:20 PM: - Also

[GitHub] [kafka] cadonna commented on a change in pull request #9648: KAFKA-10758: ProcessorTopology should only consider its own nodes when updating regex source topics

2020-11-24 Thread GitBox
cadonna commented on a change in pull request #9648: URL: https://github.com/apache/kafka/pull/9648#discussion_r529840078 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/RegexSourceIntegrationTest.java ## @@ -198,9 +200,16 @@ public void

[GitHub] [kafka] cadonna commented on a change in pull request #9648: KAFKA-10758: ProcessorTopology should only consider its own nodes when updating regex source topics

2020-11-24 Thread GitBox
cadonna commented on a change in pull request #9648: URL: https://github.com/apache/kafka/pull/9648#discussion_r529846543 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorTopology.java ## @@ -149,24 +149,30 @@ public boolean

[GitHub] [kafka] cadonna commented on a change in pull request #9648: KAFKA-10758: ProcessorTopology should only consider its own nodes when updating regex source topics

2020-11-24 Thread GitBox
cadonna commented on a change in pull request #9648: URL: https://github.com/apache/kafka/pull/9648#discussion_r529840078 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/RegexSourceIntegrationTest.java ## @@ -198,9 +200,16 @@ public void

[jira] [Commented] (KAFKA-7918) Streams store cleanup: inline byte-store generic parameters

2020-11-24 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17238334#comment-17238334 ] Matthias J. Sax commented on KAFKA-7918: We decided to go with bytes-based in-memory stores,

[GitHub] [kafka] mjsax commented on pull request #9634: KAFKA-10755: Should consider commit latency when computing next commit timestamp

2020-11-24 Thread GitBox
mjsax commented on pull request #9634: URL: https://github.com/apache/kafka/pull/9634#issuecomment-733178631 Cherry-picked to `2.7` branch. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] ableegoldman commented on a change in pull request #9648: KAFKA-10758: ProcessorTopology should only consider its own nodes when updating regex source topics

2020-11-24 Thread GitBox
ableegoldman commented on a change in pull request #9648: URL: https://github.com/apache/kafka/pull/9648#discussion_r529798216 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/RegexSourceIntegrationTest.java ## @@ -198,9 +200,16 @@ public void

[GitHub] [kafka] ableegoldman commented on a change in pull request #9648: KAFKA-10758: ProcessorTopology should only consider its own nodes when updating regex source topics

2020-11-24 Thread GitBox
ableegoldman commented on a change in pull request #9648: URL: https://github.com/apache/kafka/pull/9648#discussion_r529798140 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorTopology.java ## @@ -149,24 +149,30 @@ public boolean

[GitHub] [kafka] ableegoldman commented on a change in pull request #9648: KAFKA-10758: ProcessorTopology should only consider its own nodes when updating regex source topics

2020-11-24 Thread GitBox
ableegoldman commented on a change in pull request #9648: URL: https://github.com/apache/kafka/pull/9648#discussion_r529796474 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/RegexSourceIntegrationTest.java ## @@ -198,9 +200,16 @@ public void

[GitHub] [kafka] ijuma merged pull request #9643: MINOR: Upgrade to Scala 2.13.4

2020-11-24 Thread GitBox
ijuma merged pull request #9643: URL: https://github.com/apache/kafka/pull/9643 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] ijuma commented on pull request #9643: MINOR: Upgrade to Scala 2.13.4

2020-11-24 Thread GitBox
ijuma commented on pull request #9643: URL: https://github.com/apache/kafka/pull/9643#issuecomment-733156772 Tests passed, merging. This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Commented] (KAFKA-10758) Kafka Streams consuming from a pattern goes to PENDING_SHUTDOWN when adding a new topic

2020-11-24 Thread Davide Icardi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17238300#comment-17238300 ] Davide Icardi commented on KAFKA-10758: --- [~ableegoldman] Thank you very much! > Kafka Streams

[jira] [Assigned] (KAFKA-10549) Add topic ID support to DeleteTopics,ListOffsets, OffsetForLeaders, StopReplica

2020-11-24 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justine Olshan reassigned KAFKA-10549: -- Assignee: (was: Justine Olshan) > Add topic ID support to

[jira] [Assigned] (KAFKA-10580) Add topic ID support to Fetch request

2020-11-24 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10580?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justine Olshan reassigned KAFKA-10580: -- Assignee: (was: Justine Olshan) > Add topic ID support to Fetch request >

[jira] [Assigned] (KAFKA-10548) Implement deletion logic for LeaderAndIsrRequests

2020-11-24 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justine Olshan reassigned KAFKA-10548: -- Assignee: (was: Justine Olshan) > Implement deletion logic for

[jira] [Assigned] (KAFKA-10764) Add support for returning topic IDs on create, supplying topic IDs for delete

2020-11-24 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justine Olshan reassigned KAFKA-10764: -- Assignee: Justine Olshan > Add support for returning topic IDs on create, supplying

[jira] [Created] (KAFKA-10764) Add support for returning topic IDs on create, supplying topic IDs for delete

2020-11-24 Thread Justine Olshan (Jira)
Justine Olshan created KAFKA-10764: -- Summary: Add support for returning topic IDs on create, supplying topic IDs for delete Key: KAFKA-10764 URL: https://issues.apache.org/jira/browse/KAFKA-10764

[jira] [Updated] (KAFKA-10550) Update AdminClient and kafka-topics.sh to support topic IDs

2020-11-24 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10550?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justine Olshan updated KAFKA-10550: --- Description: Change describe topics AdminClient method to expose and support topic IDs   

[jira] [Commented] (KAFKA-10550) Update AdminClient and kafka-topics.sh to support topic IDs

2020-11-24 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17238281#comment-17238281 ] Justine Olshan commented on KAFKA-10550: Sounds good. I'll make a separate ticket for those two

[GitHub] [kafka] wcarlson5 commented on a change in pull request #9615: KAFKA-10500: Add thread option

2020-11-24 Thread GitBox
wcarlson5 commented on a change in pull request #9615: URL: https://github.com/apache/kafka/pull/9615#discussion_r529716169 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/AdjustStreamThreadCountTest.java ## @@ -0,0 +1,115 @@ +/* + * Licensed to the

[GitHub] [kafka] wcarlson5 commented on a change in pull request #9615: KAFKA-10500: Add thread option

2020-11-24 Thread GitBox
wcarlson5 commented on a change in pull request #9615: URL: https://github.com/apache/kafka/pull/9615#discussion_r529713764 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -894,19 +885,88 @@ private KafkaStreams(final

[GitHub] [kafka] wcarlson5 commented on a change in pull request #9615: KAFKA-10500: Add thread option

2020-11-24 Thread GitBox
wcarlson5 commented on a change in pull request #9615: URL: https://github.com/apache/kafka/pull/9615#discussion_r529709595 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/AdjustStreamThreadCountTest.java ## @@ -0,0 +1,115 @@ +/* + * Licensed to the

[GitHub] [kafka] wcarlson5 commented on pull request #9629: KAFKA-10754: fix flaky tests by waiting kafka streams be in running state before assert

2020-11-24 Thread GitBox
wcarlson5 commented on pull request #9629: URL: https://github.com/apache/kafka/pull/9629#issuecomment-733088175 These changes LGTM. WDYT @ableegoldman? thanks for the PR! This is an automated message from the Apache Git

[jira] [Comment Edited] (KAFKA-10384) Separate converters from generated messages

2020-11-24 Thread Gary Russell (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17238230#comment-17238230 ] Gary Russell edited comment on KAFKA-10384 at 11/24/20, 4:00 PM: - Is

[jira] [Commented] (KAFKA-10384) Separate converters from generated messages

2020-11-24 Thread Gary Russell (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17238230#comment-17238230 ] Gary Russell commented on KAFKA-10384: -- Is there any change the provided scope can be removed in

[GitHub] [kafka] vamossagar12 commented on a change in pull request #9539: KAFKA-10634: Adding LeaderId to Voters list in LeaderChangeMessage

2020-11-24 Thread GitBox
vamossagar12 commented on a change in pull request #9539: URL: https://github.com/apache/kafka/pull/9539#discussion_r529623275 ## File path: clients/src/main/resources/common/message/LeaderChangeMessage.json ## @@ -22,7 +22,9 @@ {"name": "LeaderId", "type": "int32",

[jira] [Commented] (KAFKA-10315) Consider to throw exception for failed fetch requests

2020-11-24 Thread rameshkrishnan muthusamy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17238187#comment-17238187 ] rameshkrishnan muthusamy commented on KAFKA-10315: -- [~showuon] [~mjsax] this is an

[GitHub] [kafka] jsancio commented on a change in pull request #9539: KAFKA-10634: Adding LeaderId to Voters list in LeaderChangeMessage

2020-11-24 Thread GitBox
jsancio commented on a change in pull request #9539: URL: https://github.com/apache/kafka/pull/9539#discussion_r529572270 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -370,14 +370,23 @@ private void onBecomeLeader(long currentTimeMs) {

[GitHub] [kafka] ijuma commented on pull request #9643: MINOR: Upgrade to Scala 2.13.4

2020-11-24 Thread GitBox
ijuma commented on pull request #9643: URL: https://github.com/apache/kafka/pull/9643#issuecomment-733008676 I reverted the Scala 2.12.13 change, looks like this hasn't been published to Maven yet. This is an automated

[GitHub] [kafka] ijuma commented on a change in pull request #9643: MINOR: Upgrade to Scala 2.13.4

2020-11-24 Thread GitBox
ijuma commented on a change in pull request #9643: URL: https://github.com/apache/kafka/pull/9643#discussion_r529585355 ## File path: core/src/main/scala/kafka/admin/ConsumerGroupCommand.scala ## @@ -151,21 +149,22 @@ object ConsumerGroupCommand extends Logging {

[GitHub] [kafka] ijuma merged pull request #9645: MINOR: Update build and test dependencies

2020-11-24 Thread GitBox
ijuma merged pull request #9645: URL: https://github.com/apache/kafka/pull/9645 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] ijuma commented on pull request #9645: MINOR: Update build and test dependencies

2020-11-24 Thread GitBox
ijuma commented on pull request #9645: URL: https://github.com/apache/kafka/pull/9645#issuecomment-733001614 JDK 8 and 15 builds passed. JDK 11 had one flaky unrelated failure:

[GitHub] [kafka] cadonna commented on a change in pull request #9615: KAFKA-10500: Add thread option

2020-11-24 Thread GitBox
cadonna commented on a change in pull request #9615: URL: https://github.com/apache/kafka/pull/9615#discussion_r529461975 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/AdjustStreamThreadCountTest.java ## @@ -0,0 +1,115 @@ +/* + * Licensed to the

[GitHub] [kafka] dengziming commented on pull request #9639: KAFKA-10677; Complete fetches in purgatory immediately after resigning

2020-11-24 Thread GitBox
dengziming commented on pull request #9639: URL: https://github.com/apache/kafka/pull/9639#issuecomment-732863217 ping @hachikuji to have a look. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] dengziming opened a new pull request #9649: MINOR: combine repeated top level test of AlterIsrManagerTest

2020-11-24 Thread GitBox
dengziming opened a new pull request #9649: URL: https://github.com/apache/kafka/pull/9649 The content of the 3 top-level errors are identical, just merge them. This is an automated message from the Apache Git Service. To

[GitHub] [kafka] tombentley commented on pull request #9644: KAFKA-10565: Only print console producer prompt with a tty

2020-11-24 Thread GitBox
tombentley commented on pull request #9644: URL: https://github.com/apache/kafka/pull/9644#issuecomment-732818451 @chia7712 current behaviour: ![Screenshot from 2020-11-24 10-40-59](https://user-images.githubusercontent.com/879487/100084196-5db82300-2e42-11eb-9e81-0bfd864c8255.png)

[GitHub] [kafka] cadonna commented on a change in pull request #9614: KAFKA-10500: Add failed-stream-threads metric for adding + removing stream threads

2020-11-24 Thread GitBox
cadonna commented on a change in pull request #9614: URL: https://github.com/apache/kafka/pull/9614#discussion_r529313022 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/metrics/StreamsMetricsImpl.java ## @@ -214,6 +215,20 @@ public

[GitHub] [kafka] chia7712 commented on a change in pull request #9643: MINOR: Upgrade to Scala 2.13.4 and 2.12.13

2020-11-24 Thread GitBox
chia7712 commented on a change in pull request #9643: URL: https://github.com/apache/kafka/pull/9643#discussion_r529325622 ## File path: core/src/main/scala/kafka/admin/ConsumerGroupCommand.scala ## @@ -151,21 +149,22 @@ object ConsumerGroupCommand extends Logging {

[GitHub] [kafka] cadonna commented on a change in pull request #9609: KAFKA-6687: restrict DSL to allow only Streams from the same source topics

2020-11-24 Thread GitBox
cadonna commented on a change in pull request #9609: URL: https://github.com/apache/kafka/pull/9609#discussion_r528847393 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/graph/SourceGraphNode.java ## @@ -0,0 +1,71 @@ +/* + * Licensed to the

[GitHub] [kafka] cadonna commented on a change in pull request #9648: KAFKA-10758: ProcessorTopology should only consider its own nodes when updating regex source topics

2020-11-24 Thread GitBox
cadonna commented on a change in pull request #9648: URL: https://github.com/apache/kafka/pull/9648#discussion_r529280072 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorTopology.java ## @@ -149,24 +149,30 @@ public boolean

[jira] [Updated] (KAFKA-10763) Task already exists error on same worker due to skip removal of tasks

2020-11-24 Thread Shao Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shao Wang updated KAFKA-10763: -- Description: In our production environment, upon start two KafkaConnect workers, during the first

[jira] [Updated] (KAFKA-10763) Task already exists error on same worker due to skip removal of tasks

2020-11-24 Thread Shao Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shao Wang updated KAFKA-10763: -- Description: In our production environment, upon start two KafkaConnect workers, during the first

[jira] [Created] (KAFKA-10763) Task already exists error on same worker due to skip removal of tasks

2020-11-24 Thread Shao Wang (Jira)
Shao Wang created KAFKA-10763: - Summary: Task already exists error on same worker due to skip removal of tasks Key: KAFKA-10763 URL: https://issues.apache.org/jira/browse/KAFKA-10763 Project: Kafka

[GitHub] [kafka] chia7712 commented on pull request #7409: MINOR: Skip conversion to `Struct` when serializing generated requests/responses

2020-11-24 Thread GitBox
chia7712 commented on pull request #7409: URL: https://github.com/apache/kafka/pull/7409#issuecomment-732732168 @ijuma Is this still active? All requests/responses are using auto-generated protocol so it is time to get rid of `Struct` from serialization. If you are busy with other works,