[
https://issues.apache.org/jira/browse/KAFKA-10889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17256867#comment-17256867
]
Wenbing Shen commented on KAFKA-10889:
--
[~becket_qin] Hello,Qin,I found an internal theme that has
[
https://issues.apache.org/jira/browse/KAFKA-10889?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Wenbing Shen updated KAFKA-10889:
-
Attachment: 20201231-5.png
20201231-4.png
20201231-3.png
itantiger commented on pull request #9790:
URL: https://github.com/apache/kafka/pull/9790#issuecomment-752873484
> I'd like to address the following priority rule in this PR :)
>
> 1. command-lind
> 2. config file (consumer.config)
> 3. default value
Of course, I also
chia7712 commented on pull request #9790:
URL: https://github.com/apache/kafka/pull/9790#issuecomment-752873182
> Let me optimize it again and commit. Do you think it's necessary?
I'd like to address the following priority rule in this PR :)
1. command-lind
2. config file
itantiger commented on pull request #9790:
URL: https://github.com/apache/kafka/pull/9790#issuecomment-752872927
>>trunk? pardon me that I can't catch your point.
>
>That's my problem. hah
>
>>yep, the default value CAN overwrite the configs from either command-line
or config
itantiger removed a comment on pull request #9790:
URL: https://github.com/apache/kafka/pull/9790#issuecomment-752872756
> >trunk? pardon me that I can't catch your point.
> That's my problem. hah
>> yep, the default value CAN overwrite the configs from either command-line
or config
itantiger commented on pull request #9790:
URL: https://github.com/apache/kafka/pull/9790#issuecomment-752872756
> >trunk? pardon me that I can't catch your point.
> That's my problem. hah
>> yep, the default value CAN overwrite the configs from either command-line
or config file.
chia7712 commented on pull request #9790:
URL: https://github.com/apache/kafka/pull/9790#issuecomment-752870565
> I think the trunk also needs to be modified.
trunk? pardon me that I can't catch your point.
> Some config params would be overwritten by default value, WDYT?
itantiger commented on pull request #9790:
URL: https://github.com/apache/kafka/pull/9790#issuecomment-752870058
> I guess you are talking about "title". yes, the title need to be revised.
In addition, I think the trunk also needs to be modified.
Some config params would be
itantiger removed a comment on pull request #9790:
URL: https://github.com/apache/kafka/pull/9790#issuecomment-752869488
> I guess you are talking about "title". yes, the title need to be revised.
In addition, I think the trunk also needs to be modified.
Some config params would be
itantiger commented on pull request #9790:
URL: https://github.com/apache/kafka/pull/9790#issuecomment-752869488
> I guess you are talking about "title". yes, the title need to be revised.
In addition, I think the trunk also needs to be modified.
Some config params would be
chia7712 commented on pull request #9790:
URL: https://github.com/apache/kafka/pull/9790#issuecomment-752866046
> Do you think it needs to be revised?
I guess you are talking about "title". yes, the title need to be revised.
itantiger commented on pull request #9790:
URL: https://github.com/apache/kafka/pull/9790#issuecomment-752865674
Current priority, some config params would be overwritten by default value,
Do you think it needs to be revised?
itantiger commented on pull request #9790:
URL: https://github.com/apache/kafka/pull/9790#issuecomment-752864933
> > and then call `props.putIfAbsent` to set args from command-line only if
the prop is nonexistent in config file. Hence, the priority of config file is
higher than
itantiger closed pull request #9790:
URL: https://github.com/apache/kafka/pull/9790
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
chia7712 commented on a change in pull request #9802:
URL: https://github.com/apache/kafka/pull/9802#discussion_r550409107
##
File path: core/src/main/scala/kafka/server/MetadataCache.scala
##
@@ -266,8 +266,16 @@ class MetadataCache(brokerId: Int) extends Logging {
def
itantiger commented on pull request #9790:
URL: https://github.com/apache/kafka/pull/9790#issuecomment-752863384
> and then call `props.putIfAbsent` to set args from command-line only if
the prop is nonexistent in config file. Hence, the priority of config file is
higher than
chia7712 commented on pull request #9790:
URL: https://github.com/apache/kafka/pull/9790#issuecomment-752862049
> I think this priority is more better, and this PR is to do this.
We load the props from config file first.
showuon commented on pull request #9792:
URL: https://github.com/apache/kafka/pull/9792#issuecomment-752861871
@hachikuji , I've updated in this commit:
https://github.com/apache/kafka/pull/9792/commits/62c3c76ddb8b8d1163281b837c2b273824a9e1ec.
Please take a look. Thank you.
showuon commented on a change in pull request #9792:
URL: https://github.com/apache/kafka/pull/9792#discussion_r550408203
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java
##
@@ -658,6 +658,10 @@ public void
showuon commented on a change in pull request #9792:
URL: https://github.com/apache/kafka/pull/9792#discussion_r550408165
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java
##
@@ -658,6 +658,10 @@ public void
itantiger commented on pull request #9790:
URL: https://github.com/apache/kafka/pull/9790#issuecomment-752860409
> 1. command-lind
> 2. config file (consumer.config)
> 3. default value
I think this priority is more better, and this PR is to do this.
[
https://issues.apache.org/jira/browse/KAFKA-7870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17256844#comment-17256844
]
Suo L. commented on KAFKA-7870:
---
Recently I meet and fix a bug has similar exception like this. It was
chia7712 commented on pull request #9790:
URL: https://github.com/apache/kafka/pull/9790#issuecomment-752856869
@itantiger The priority of loading props is a bit chaos in this case. It
seems to me the property of loading properties is shown below.
1. command-lind
1. config file
chia7712 commented on pull request #9803:
URL: https://github.com/apache/kafka/pull/9803#issuecomment-752846372
> The stack trace for StateChangeFailedException is useless since the
exception is just used to propagate an error message to the state change logger.
dengziming commented on pull request #9649:
URL: https://github.com/apache/kafka/pull/9649#issuecomment-752820081
@chia7712 ,Thank you for your suggestion. In fact, I get the idea from
`AlterIsrManagerTest.testPartitionErrors` which test 3 errors in a method, so I
also merge the 3 top
chia7712 commented on a change in pull request #8852:
URL: https://github.com/apache/kafka/pull/8852#discussion_r550378570
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/Task.java
##
@@ -116,89 +112,100 @@ public boolean
hachikuji opened a new pull request #9804:
URL: https://github.com/apache/kafka/pull/9804
We missed this in the initial check-in of the `FetchSnapshot` API. We need
to pass through the version to the super constructor.
### Committer Checklist (excluded from commit message)
- [ ]
hachikuji commented on pull request #9803:
URL: https://github.com/apache/kafka/pull/9803#issuecomment-752783760
@ijuma @chia7712 Thoughts on this PR? I was getting tired of seeing these
useless traces in logging...
This is
hachikuji opened a new pull request #9803:
URL: https://github.com/apache/kafka/pull/9803
The stack trace for `StateChangeFailedException` is useless since the
exception is just used to propagate an error message to the state change
logger. This patch eliminates the stack trace which
jolshan commented on a change in pull request #9590:
URL: https://github.com/apache/kafka/pull/9590#discussion_r550349828
##
File path: core/src/main/scala/kafka/log/Log.scala
##
@@ -1306,7 +1309,7 @@ class Log(@volatile private var _dir: File,
// in an unclean manner
jolshan commented on a change in pull request #9590:
URL: https://github.com/apache/kafka/pull/9590#discussion_r550349748
##
File path: core/src/main/scala/kafka/log/Log.scala
##
@@ -1749,6 +1752,9 @@ class Log(@volatile private var _dir: File,
jolshan commented on pull request #9590:
URL: https://github.com/apache/kafka/pull/9590#issuecomment-752782513
Updated to not clean past high watermark. If this should be its own
ticket/PR, let me know.
This is an automated
hachikuji opened a new pull request #9802:
URL: https://github.com/apache/kafka/pull/9802
Previously offline replicas were included as `null` in the array of replicas
in `PartitionInfo` when populated by the `MetadataCache` for the purpose of the
client quota callback. This patch instead
mjsax commented on a change in pull request #9801:
URL: https://github.com/apache/kafka/pull/9801#discussion_r550342976
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/Task.java
##
@@ -98,17 +98,9 @@ public boolean isValidTransition(final
mjsax commented on a change in pull request #9801:
URL: https://github.com/apache/kafka/pull/9801#discussion_r550342917
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/Task.java
##
@@ -98,17 +98,9 @@ public boolean isValidTransition(final
mjsax commented on a change in pull request #9801:
URL: https://github.com/apache/kafka/pull/9801#discussion_r550342638
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/AbstractTask.java
##
@@ -124,11 +124,6 @@ public StateStore getStore(final
mjsax opened a new pull request #9801:
URL: https://github.com/apache/kafka/pull/9801
Not functional change. Pure code cleanup.
Call for review @vvcephei (cf. #8852 -- will split up the old PR into
multiple smaller ones to simplify reviewing)
mjsax commented on a change in pull request #8852:
URL: https://github.com/apache/kafka/pull/8852#discussion_r550337598
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/Task.java
##
@@ -116,89 +112,100 @@ public boolean isValidTransition(final
mjsax opened a new pull request #9800:
URL: https://github.com/apache/kafka/pull/9800
If EOS is enabled and the TX commit fails with a timeout,
we should not process more messages (what is ok for non-EOS)
because we don't really know the status of the TX.
If the commit was indeed
[
https://issues.apache.org/jira/browse/KAFKA-10894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gustafson updated KAFKA-10894:
Description:
I noticed an NPE in the client quota callback `updateClusterMetadata` due to
Jason Gustafson created KAFKA-10894:
---
Summary: Null replica nodes included in client quota callback
Cluster
Key: KAFKA-10894
URL: https://issues.apache.org/jira/browse/KAFKA-10894
Project: Kafka
mjsax commented on pull request #9107:
URL: https://github.com/apache/kafka/pull/9107#issuecomment-752730961
Maybe I miss-understood you question. I thought the build fails because we
are using some deprecated method -- for this case, we can make the build pass
by suppressing the warning.
[
https://issues.apache.org/jira/browse/KAFKA-10522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Lambertus updated KAFKA-10522:
Reporter: Luigi Berrettini (was: Luigi Berrettini)
> Duplicate detection and
[
https://issues.apache.org/jira/browse/KAFKA-10523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Lambertus updated KAFKA-10523:
Reporter: Luigi Berrettini (was: Luigi Berrettini)
> Allow to provide producer ID
>
mumrah commented on pull request #9799:
URL: https://github.com/apache/kafka/pull/9799#issuecomment-752714250
Wrong remote/base branch
This is an automated message from the Apache Git Service.
To respond to the message,
mumrah closed pull request #9799:
URL: https://github.com/apache/kafka/pull/9799
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
mumrah opened a new pull request #9799:
URL: https://github.com/apache/kafka/pull/9799
This PR adds support for handling QuotaRecord metadata in the broker. It
also includes a new QuotaCache class for efficient lookups of the quotas.
hachikuji commented on a change in pull request #9792:
URL: https://github.com/apache/kafka/pull/9792#discussion_r550271098
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java
##
@@ -658,6 +658,10 @@ public void
bertber commented on a change in pull request #9761:
URL: https://github.com/apache/kafka/pull/9761#discussion_r550262431
##
File path:
clients/src/test/java/org/apache/kafka/common/utils/ByteBufferInputStreamTest.java
##
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the Apache
chia7712 merged pull request #9784:
URL: https://github.com/apache/kafka/pull/9784
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
C0urante commented on pull request #9784:
URL: https://github.com/apache/kafka/pull/9784#issuecomment-752650790
@chia7712 sure, here's an example:
```
[2020-12-30 09:56:35,481] ERROR [test-connector|worker] [Worker
clientId=connect-1, groupId=connect-cluster] Failed to start
chia7712 opened a new pull request #9798:
URL: https://github.com/apache/kafka/pull/9798
If we run system tests by container, the soft link created by ```ducktape```
references to path inside container. This PR adds a tiny function to correct
soft link.
### Committer Checklist
[
https://issues.apache.org/jira/browse/KAFKA-10891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Wenbing Shen updated KAFKA-10891:
-
Component/s: (was: core)
> The control plane needs to force the validation of requests from
[
https://issues.apache.org/jira/browse/KAFKA-10891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Wenbing Shen updated KAFKA-10891:
-
Component/s: network
> The control plane needs to force the validation of requests from the
>
wenbingshen commented on pull request #9789:
URL: https://github.com/apache/kafka/pull/9789#issuecomment-752579504
@showuon Thank you,Luke,I did accidentally use the formatting tool.I
submitted the latest code.Thank you very much for your help.
itantiger commented on a change in pull request #9790:
URL: https://github.com/apache/kafka/pull/9790#discussion_r550151238
##
File path: core/src/test/scala/unit/kafka/tools/ConsumerPerformanceTest.scala
##
@@ -96,6 +97,28 @@ class ConsumerPerformanceTest {
chia7712 commented on pull request #9784:
URL: https://github.com/apache/kafka/pull/9784#issuecomment-752402354
@C0urante Could you share the updated error message to me?
This is an automated message from the Apache Git
chia7712 commented on pull request #9525:
URL: https://github.com/apache/kafka/pull/9525#issuecomment-752399751
@dajac Could you please take a look?
This is an automated message from the Apache Git Service.
To respond to
chia7712 commented on pull request #9775:
URL: https://github.com/apache/kafka/pull/9775#issuecomment-752396505
@showuon Is it a potential bug which can slowdown the consumer in this test
case? Or this bug is caused by busy Jenkins?
showuon commented on a change in pull request #9789:
URL: https://github.com/apache/kafka/pull/9789#discussion_r550066877
##
File path: core/src/test/scala/unit/kafka/network/SocketServerTest.scala
##
@@ -1352,7 +1369,7 @@ class SocketServerTest {
private def
showuon commented on a change in pull request #9789:
URL: https://github.com/apache/kafka/pull/9789#discussion_r550066382
##
File path: core/src/main/scala/kafka/network/SocketServer.scala
##
@@ -1331,24 +1352,34 @@ object ConnectionQuotas {
private case class
showuon commented on a change in pull request #9789:
URL: https://github.com/apache/kafka/pull/9789#discussion_r550066090
##
File path: core/src/main/scala/kafka/network/SocketServer.scala
##
@@ -1089,9 +1107,9 @@ private[kafka] class Processor(val id: Int,
}
private
showuon commented on a change in pull request #9789:
URL: https://github.com/apache/kafka/pull/9789#discussion_r550065738
##
File path: core/src/main/scala/kafka/network/SocketServer.scala
##
@@ -61,17 +61,17 @@ import scala.util.control.ControlThrowable
* - data-plane :
showuon commented on a change in pull request #9789:
URL: https://github.com/apache/kafka/pull/9789#discussion_r550064975
##
File path: core/src/main/scala/kafka/network/SocketServer.scala
##
@@ -988,60 +994,72 @@ private[kafka] class Processor(val id: Int,
}
}
+
inponomarev commented on pull request #9107:
URL: https://github.com/apache/kafka/pull/9107#issuecomment-752382595
As far as I can judge from the name, `@nowarn` is not for deprecation, but
rather for a warning suppression 樂 apparently we need to mirror the changes in
Java `KStream`
chia7712 opened a new pull request #9797:
URL: https://github.com/apache/kafka/pull/9797
issue: https://issues.apache.org/jira/browse/KAFKA-10893
The expected size is 340 and the throttle is 1 msg/sec so the
expected minimal run time of one consumer/producer is about 6 mins.
Chia-Ping Tsai created KAFKA-10893:
--
Summary: Increase target_messages_per_sec of ReplicaScaleTest to
reduce the run time
Key: KAFKA-10893
URL: https://issues.apache.org/jira/browse/KAFKA-10893
68 matches
Mail list logo
