[jira] [Resolved] (KAFKA-10768) Make ByteBufferInputStream.read(byte[], int, int) to follow the contract

2021-01-02 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-10768. Fix Version/s: 2.8.0 Resolution: Fixed > Make ByteBufferInputStream.read(byte[], in

[GitHub] [kafka] chia7712 merged pull request #9761: KAFKA-10768 Make ByteBufferInputStream.read(byte[], int, int) to follow the contract

2021-01-02 Thread GitBox
chia7712 merged pull request #9761: URL: https://github.com/apache/kafka/pull/9761 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[jira] [Commented] (KAFKA-10769) Remove JoinGroupRequest#containsValidPattern as it is duplicate to Topic#containsValidPattern

2021-01-02 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17257678#comment-17257678 ] Chia-Ping Tsai commented on KAFKA-10769: [~high.lee] Feel free to take over this

[GitHub] [kafka] unlizhao opened a new pull request #9817: MINOR: Producer's BufferPool closing check

2021-01-02 Thread GitBox
unlizhao opened a new pull request #9817: URL: https://github.com/apache/kafka/pull/9817 According to the idea of #7967, it made BufferPool support closing. Now, there are two places in the BufferPool#allocate() method to judge the 'closed' flag. One is when 'lock' is acquired, and the o

[jira] [Commented] (KAFKA-10694) Implement zero copy for FetchSnapshot

2021-01-02 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17257632#comment-17257632 ] Jose Armando Garcia Sancio commented on KAFKA-10694: Thanks for work

[GitHub] [kafka] jsancio opened a new pull request #9816: KAFKA-10761: Kafka Raft update log start offset

2021-01-02 Thread GitBox
jsancio opened a new pull request #9816: URL: https://github.com/apache/kafka/pull/9816 WIP *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary o

[GitHub] [kafka] gwenshap opened a new pull request #9815: Minor: Fixed two properties in EOS example plus some thread cleanup

2021-01-02 Thread GitBox
gwenshap opened a new pull request #9815: URL: https://github.com/apache/kafka/pull/9815 Changes: * Passing the latches into the consumer/producer wrappers seemed a bit unclean. I removed the latches and used futures to wait on producer/consumer execution. * Consumer that is part of

[GitHub] [kafka] jolshan commented on a change in pull request #9684: KAFKA-10764: Add support for returning topic IDs on create, supplying topic IDs for delete

2021-01-02 Thread GitBox
jolshan commented on a change in pull request #9684: URL: https://github.com/apache/kafka/pull/9684#discussion_r550906325 ## File path: core/src/main/scala/kafka/zk/KafkaZkClient.scala ## @@ -621,10 +621,10 @@ class KafkaZkClient private[zk] (zooKeeperClient: ZooKeeperClient,

[GitHub] [kafka] jolshan opened a new pull request #9814: KAFKA-10869: Gate topic IDs behind IBP 2.8

2021-01-02 Thread GitBox
jolshan opened a new pull request #9814: URL: https://github.com/apache/kafka/pull/9814 Topics processed by the controller and topics newly created will only be given topic IDs if the inter-broker protocol version is greater than 2.8. This PR also adds a kafka config to specify whether the

[GitHub] [kafka] jolshan commented on a change in pull request #9622: KAFKA-10547; add topicId in MetadataResp

2021-01-02 Thread GitBox
jolshan commented on a change in pull request #9622: URL: https://github.com/apache/kafka/pull/9622#discussion_r550906054 ## File path: clients/src/main/java/org/apache/kafka/common/Cluster.java ## @@ -327,6 +346,14 @@ public Node controller() { return controller;

[GitHub] [kafka] jolshan commented on a change in pull request #9684: KAFKA-10764: Add support for returning topic IDs on create, supplying topic IDs for delete

2021-01-02 Thread GitBox
jolshan commented on a change in pull request #9684: URL: https://github.com/apache/kafka/pull/9684#discussion_r550905654 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -1981,29 +1986,39 @@ class KafkaApis(val requestChannel: RequestChannel, val resul

[GitHub] [kafka] jolshan commented on a change in pull request #9684: KAFKA-10764: Add support for returning topic IDs on create, supplying topic IDs for delete

2021-01-02 Thread GitBox
jolshan commented on a change in pull request #9684: URL: https://github.com/apache/kafka/pull/9684#discussion_r550905278 ## File path: clients/src/main/java/org/apache/kafka/common/requests/DeleteTopicsRequest.java ## @@ -39,8 +45,25 @@ public Builder(DeleteTopicsRequestData

[GitHub] [kafka] jolshan commented on a change in pull request #9684: KAFKA-10764: Add support for returning topic IDs on create, supplying topic IDs for delete

2021-01-02 Thread GitBox
jolshan commented on a change in pull request #9684: URL: https://github.com/apache/kafka/pull/9684#discussion_r550905106 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java ## @@ -1623,6 +1625,32 @@ public DeleteTopicsResult deleteTopics(f

[GitHub] [kafka] jolshan commented on a change in pull request #9684: KAFKA-10764: Add support for returning topic IDs on create, supplying topic IDs for delete

2021-01-02 Thread GitBox
jolshan commented on a change in pull request #9684: URL: https://github.com/apache/kafka/pull/9684#discussion_r550905081 ## File path: clients/src/main/resources/common/message/DeleteTopicsRequest.json ## @@ -23,10 +23,17 @@ // // Version 5 adds ErrorMessage in the respo

[GitHub] [kafka] jolshan commented on a change in pull request #9684: KAFKA-10764: Add support for returning topic IDs on create, supplying topic IDs for delete

2021-01-02 Thread GitBox
jolshan commented on a change in pull request #9684: URL: https://github.com/apache/kafka/pull/9684#discussion_r550904963 ## File path: core/src/main/scala/kafka/zk/KafkaZkClient.scala ## @@ -621,10 +621,10 @@ class KafkaZkClient private[zk] (zooKeeperClient: ZooKeeperClient,

[jira] [Commented] (KAFKA-2729) Cached zkVersion not equal to that in zookeeper, broker not recovering.

2021-01-02 Thread Victor Garcia (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-2729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17257448#comment-17257448 ] Victor Garcia commented on KAFKA-2729: -- Yes, it seems this issue is not yet fixed. T

[jira] [Assigned] (KAFKA-10694) Implement zero copy for FetchSnapshot

2021-01-02 Thread dengziming (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dengziming reassigned KAFKA-10694: -- Assignee: dengziming > Implement zero copy for FetchSnapshot > --