[GitHub] [kafka] chia7712 commented on a change in pull request #9712: KAFKA-10822 Force some stdout from system tests for Travis

chia7712 commented on a change in pull request #9712: URL: https://github.com/apache/kafka/pull/9712#discussion_r551751195 ## File path: tests/kafkatest/tests/core/downgrade_test.py ## @@ -120,11 +120,11 @@ def test_upgrade_and_downgrade(self, version, compression_types, secur

[GitHub] [kafka] chia7712 commented on a change in pull request #9712: KAFKA-10822 Force some stdout from system tests for Travis

chia7712 commented on a change in pull request #9712: URL: https://github.com/apache/kafka/pull/9712#discussion_r551704491 ## File path: tests/kafkatest/tests/core/downgrade_test.py ## @@ -120,11 +120,11 @@ def test_upgrade_and_downgrade(self, version, compression_types, secur

[GitHub] [kafka] dengziming commented on a change in pull request #9649: MINOR: Combine repeated top-level error test in AlterIsrManagerTest

dengziming commented on a change in pull request #9649: URL: https://github.com/apache/kafka/pull/9649#discussion_r551722375 ## File path: core/src/test/scala/unit/kafka/server/AlterIsrManagerTest.scala ## @@ -174,13 +172,24 @@ class AlterIsrManagerTest { } @Test - def

[GitHub] [kafka] dengziming commented on a change in pull request #9649: MINOR: Combine repeated top-level error test in AlterIsrManagerTest

dengziming commented on a change in pull request #9649: URL: https://github.com/apache/kafka/pull/9649#discussion_r551722375 ## File path: core/src/test/scala/unit/kafka/server/AlterIsrManagerTest.scala ## @@ -174,13 +172,24 @@ class AlterIsrManagerTest { } @Test - def

[GitHub] [kafka] dengziming commented on a change in pull request #9649: MINOR: Combine repeated top-level error test in AlterIsrManagerTest

dengziming commented on a change in pull request #9649: URL: https://github.com/apache/kafka/pull/9649#discussion_r551719940 ## File path: core/src/test/scala/unit/kafka/server/AlterIsrManagerTest.scala ## @@ -174,13 +172,24 @@ class AlterIsrManagerTest { } @Test - def

[GitHub] [kafka] ijuma commented on a change in pull request #9712: KAFKA-10822 Force some stdout from system tests for Travis

ijuma commented on a change in pull request #9712: URL: https://github.com/apache/kafka/pull/9712#discussion_r551719004 ## File path: tests/kafkatest/tests/core/downgrade_test.py ## @@ -120,11 +120,11 @@ def test_upgrade_and_downgrade(self, version, compression_types, security

[GitHub] [kafka] chia7712 commented on a change in pull request #9712: KAFKA-10822 Force some stdout from system tests for Travis

chia7712 commented on a change in pull request #9712: URL: https://github.com/apache/kafka/pull/9712#discussion_r551704491 ## File path: tests/kafkatest/tests/core/downgrade_test.py ## @@ -120,11 +120,11 @@ def test_upgrade_and_downgrade(self, version, compression_types, secur

[GitHub] [kafka] chia7712 commented on a change in pull request #9802: KAFKA-10894; Ensure PartitionInfo replicas are not null in client quota callback

chia7712 commented on a change in pull request #9802: URL: https://github.com/apache/kafka/pull/9802#discussion_r551688940 ## File path: core/src/main/scala/kafka/server/MetadataCache.scala ## @@ -266,8 +266,16 @@ class MetadataCache(brokerId: Int) extends Logging { def ge

[GitHub] [kafka] chia7712 commented on a change in pull request #9649: MINOR: Combine repeated top-level error test in AlterIsrManagerTest

chia7712 commented on a change in pull request #9649: URL: https://github.com/apache/kafka/pull/9649#discussion_r551683555 ## File path: core/src/test/scala/unit/kafka/server/AlterIsrManagerTest.scala ## @@ -174,13 +172,24 @@ class AlterIsrManagerTest { } @Test - def t

[GitHub] [kafka] chia7712 merged pull request #9818: MINOR: refactor FetchResponse#toMessage to avoid creating a lot of un…

chia7712 merged pull request #9818: URL: https://github.com/apache/kafka/pull/9818 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[jira] [Updated] (KAFKA-10899) Closing check Before Producer's BufferPool allocat memory

[ https://issues.apache.org/jira/browse/KAFKA-10899?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lizhao updated KAFKA-10899: --- Priority: Major (was: Minor) > Closing check Before Producer's BufferPool allocat memory > ---

[GitHub] [kafka] jolshan commented on pull request #9684: KAFKA-10764: Add support for returning topic IDs on create, supplying topic IDs for delete

jolshan commented on pull request #9684: URL: https://github.com/apache/kafka/pull/9684#issuecomment-754342275 I'm planning on adding one more test, but that test is blocked on https://github.com/apache/kafka/pull/9814 This

[GitHub] [kafka] showuon commented on pull request #9788: KAFKA-10671: improve the partition.assignment.strategy docs

showuon commented on pull request #9788: URL: https://github.com/apache/kafka/pull/9788#issuecomment-754334067 @ableegoldman , thanks for your comments. I've updated in this commit: https://github.com/apache/kafka/pull/9788/commits/7f44a41900eb526b850283372e1a25d002ba2994. Thank you. ---

[GitHub] [kafka] hachikuji commented on pull request #9802: KAFKA-10894; Ensure PartitionInfo replicas are not null in client quota callback

hachikuji commented on pull request #9802: URL: https://github.com/apache/kafka/pull/9802#issuecomment-754302596 @chia7712 Good question about `leader()`. I looked into usage and it seems we do not have consistent `isEmpty` checks, so I'm a little concerned about compatibility if we change

[GitHub] [kafka] hachikuji commented on a change in pull request #9802: KAFKA-10894; Ensure PartitionInfo replicas are not null in client quota callback

hachikuji commented on a change in pull request #9802: URL: https://github.com/apache/kafka/pull/9802#discussion_r551641235 ## File path: core/src/main/scala/kafka/server/MetadataCache.scala ## @@ -266,8 +266,16 @@ class MetadataCache(brokerId: Int) extends Logging { def g

[GitHub] [kafka] jolshan commented on a change in pull request #9769: KAFKA-10774; Support Describe topic using topic IDs

jolshan commented on a change in pull request #9769: URL: https://github.com/apache/kafka/pull/9769#discussion_r551633181 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java ## @@ -1816,7 +1823,103 @@ void handleFailure(Throwable throwable)

[GitHub] [kafka] jolshan commented on a change in pull request #9769: KAFKA-10774; Support Describe topic using topic IDs

jolshan commented on a change in pull request #9769: URL: https://github.com/apache/kafka/pull/9769#discussion_r551607061 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -1238,8 +1239,21 @@ class KafkaApis(val requestChannel: RequestChannel, val metada

[GitHub] [kafka] jolshan commented on a change in pull request #9769: KAFKA-10774; Support Describe topic using topic IDs

jolshan commented on a change in pull request #9769: URL: https://github.com/apache/kafka/pull/9769#discussion_r551607061 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -1238,8 +1239,21 @@ class KafkaApis(val requestChannel: RequestChannel, val metada

[GitHub] [kafka] hachikuji merged pull request #9792: KAFKA-10870: handle REBALANCE_IN_PROGRESS error in JoinGroup

hachikuji merged pull request #9792: URL: https://github.com/apache/kafka/pull/9792 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] wcarlson5 commented on pull request #9695: KAFKA-10500: Remove thread

wcarlson5 commented on pull request #9695: URL: https://github.com/apache/kafka/pull/9695#issuecomment-754252489 @ableegoldman I addressed your concern about the list synchronization with the iterator and I added some tests. I think it is good the merge WDYT?

[GitHub] [kafka] wcarlson5 commented on a change in pull request #9695: KAFKA-10500: Remove thread

wcarlson5 commented on a change in pull request #9695: URL: https://github.com/apache/kafka/pull/9695#discussion_r551597471 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -924,22 +924,64 @@ private StreamThread createStreamThread(final long

[GitHub] [kafka] bbejeck edited a comment on pull request #9774: MINOR: Add 2.7.0 release to broker and client compat tests

bbejeck edited a comment on pull request #9774: URL: https://github.com/apache/kafka/pull/9774#issuecomment-754240203 @ijuma, I've updated and kicked off [a new round of system tests](https://jenkins.confluent.io/job/system-test-kafka-branch-builder/4335/). When the system tests pass

[GitHub] [kafka] bbejeck commented on pull request #9774: MINOR: Add 2.7.0 release to broker and client compat tests

bbejeck commented on pull request #9774: URL: https://github.com/apache/kafka/pull/9774#issuecomment-754240203 @ijuma, I've updated and kicked off a new round of system tests. When the system tests pass, I'll merge the PR -

[jira] [Comment Edited] (KAFKA-10091) Improve task idling

[ https://issues.apache.org/jira/browse/KAFKA-10091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17244326#comment-17244326 ] John Roesler edited comment on KAFKA-10091 at 1/4/21, 7:51 PM: ---

[GitHub] [kafka] ableegoldman commented on a change in pull request #9788: KAFKA-10671: improve the partition.assignment.strategy docs

ableegoldman commented on a change in pull request #9788: URL: https://github.com/apache/kafka/pull/9788#discussion_r551512362 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerConfig.java ## @@ -108,17 +108,18 @@ */ public static final S

[GitHub] [kafka] wcarlson5 commented on a change in pull request #9720: KAFKA-10555: Improve client state machine

wcarlson5 commented on a change in pull request #9720: URL: https://github.com/apache/kafka/pull/9720#discussion_r551458558 ## File path: streams/src/test/java/org/apache/kafka/streams/KafkaStreamsTest.java ## @@ -524,9 +460,6 @@ public void testStateThreadClose() throws Except

[GitHub] [kafka] ijuma commented on a change in pull request #9712: KAFKA-10822 Force some stdout from system tests for Travis

ijuma commented on a change in pull request #9712: URL: https://github.com/apache/kafka/pull/9712#discussion_r551480985 ## File path: tests/kafkatest/tests/core/downgrade_test.py ## @@ -120,11 +120,11 @@ def test_upgrade_and_downgrade(self, version, compression_types, security

[GitHub] [kafka] jolshan commented on a change in pull request #9684: KAFKA-10764: Add support for returning topic IDs on create, supplying topic IDs for delete

jolshan commented on a change in pull request #9684: URL: https://github.com/apache/kafka/pull/9684#discussion_r551475961 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -1981,29 +1986,39 @@ class KafkaApis(val requestChannel: RequestChannel, val resul

[jira] [Commented] (KAFKA-5892) Connector property override does not work unless setting ALL converter properties

[ https://issues.apache.org/jira/browse/KAFKA-5892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17258368#comment-17258368 ] Randall Hauch commented on KAFKA-5892: -- [~jsahu], yes, you can start working on this

[GitHub] [kafka] g1geordie commented on a change in pull request #9778: KAFKA-10874 Fix flaky ClientQuotasRequestTest.testAlterIpQuotasRequest

g1geordie commented on a change in pull request #9778: URL: https://github.com/apache/kafka/pull/9778#discussion_r551467279 ## File path: core/src/test/scala/unit/kafka/server/ClientQuotasRequestTest.scala ## @@ -212,7 +214,9 @@ class ClientQuotasRequestTest extends BaseRequest

[GitHub] [kafka] abbccdda commented on a change in pull request #9800: KAFKA-9274: Fix commit-TimeoutException handling for EOS

abbccdda commented on a change in pull request #9800: URL: https://github.com/apache/kafka/pull/9800#discussion_r551462812 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java ## @@ -633,6 +636,10 @@ public boolean isProcessable(fina

[jira] [Resolved] (KAFKA-10701) First line of detailed stats from consumer-perf-test.sh incorrect

[ https://issues.apache.org/jira/browse/KAFKA-10701?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Liju resolved KAFKA-10701. -- Resolution: Fixed PR is merged to the trunk , marking the issue resolved > First line of detailed stats from

[GitHub] [kafka] gharris1727 commented on a change in pull request #9765: KAFKA-10763: Fix incomplete cooperative rebalances preventing connector/task revocations

gharris1727 commented on a change in pull request #9765: URL: https://github.com/apache/kafka/pull/9765#discussion_r551448513 ## File path: connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/DistributedHerderTest.java ## @@ -566,6 +566,112 @@ public Boo

[jira] [Created] (KAFKA-10900) Add metrics enumerated in KIP-630

Jose Armando Garcia Sancio created KAFKA-10900: -- Summary: Add metrics enumerated in KIP-630 Key: KAFKA-10900 URL: https://issues.apache.org/jira/browse/KAFKA-10900 Project: Kafka

[GitHub] [kafka] chia7712 commented on a change in pull request #9758: MINOR: remove FetchResponse.AbortedTransaction and redundant construc…

chia7712 commented on a change in pull request #9758: URL: https://github.com/apache/kafka/pull/9758#discussion_r551441782 ## File path: clients/src/main/java/org/apache/kafka/common/requests/FetchResponse.java ## @@ -59,136 +60,140 @@ */ public class FetchResponse extends

[jira] [Resolved] (KAFKA-10893) Increase target_messages_per_sec of ReplicaScaleTest to reduce the run time

[ https://issues.apache.org/jira/browse/KAFKA-10893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-10893. Fix Version/s: 2.8.0 Resolution: Fixed > Increase target_messages_per_sec of Replic

[GitHub] [kafka] chia7712 merged pull request #9797: KAFKA-10893 Increase target_messages_per_sec of ReplicaScaleTest to r…

chia7712 merged pull request #9797: URL: https://github.com/apache/kafka/pull/9797 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] chia7712 commented on pull request #9797: KAFKA-10893 Increase target_messages_per_sec of ReplicaScaleTest to r…

chia7712 commented on pull request #9797: URL: https://github.com/apache/kafka/pull/9797#issuecomment-754072342 @mumrah Thanks for your reviews. Merge it to trunk This is an automated message from the Apache Git Service. To r

[GitHub] [kafka] ijuma commented on a change in pull request #9758: MINOR: remove FetchResponse.AbortedTransaction and redundant construc…

ijuma commented on a change in pull request #9758: URL: https://github.com/apache/kafka/pull/9758#discussion_r551412139 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java ## @@ -733,11 +733,11 @@ void resetOffsetIfNeeded(TopicPartition

[GitHub] [kafka] mumrah commented on a change in pull request #9649: MINOR: Combine repeated top-level error test in AlterIsrManagerTest

mumrah commented on a change in pull request #9649: URL: https://github.com/apache/kafka/pull/9649#discussion_r551414004 ## File path: core/src/test/scala/unit/kafka/server/AlterIsrManagerTest.scala ## @@ -127,26 +127,24 @@ class AlterIsrManagerTest { @Test def testAuth

[GitHub] [kafka] chia7712 commented on a change in pull request #9818: MINOR: refactor FetchResponse#toMessage to avoid creating a lot of un…

chia7712 commented on a change in pull request #9818: URL: https://github.com/apache/kafka/pull/9818#discussion_r551410221 ## File path: clients/src/main/java/org/apache/kafka/common/requests/FetchResponse.java ## @@ -331,28 +331,32 @@ public int sessionId() { private sta

[GitHub] [kafka] ijuma commented on a change in pull request #9818: MINOR: refactor FetchResponse#toMessage to avoid creating a lot of un…

ijuma commented on a change in pull request #9818: URL: https://github.com/apache/kafka/pull/9818#discussion_r551407113 ## File path: clients/src/main/java/org/apache/kafka/common/requests/FetchResponse.java ## @@ -331,28 +331,32 @@ public int sessionId() { private static

[GitHub] [kafka] g1geordie commented on a change in pull request #9778: KAFKA-10874 Fix flaky ClientQuotasRequestTest.testAlterIpQuotasRequest

g1geordie commented on a change in pull request #9778: URL: https://github.com/apache/kafka/pull/9778#discussion_r551408267 ## File path: core/src/test/scala/unit/kafka/server/ClientQuotasRequestTest.scala ## @@ -212,7 +214,9 @@ class ClientQuotasRequestTest extends BaseRequest

[GitHub] [kafka] ijuma commented on a change in pull request #9774: MINOR: Add 2.7.0 release to broker and client compat tests

ijuma commented on a change in pull request #9774: URL: https://github.com/apache/kafka/pull/9774#discussion_r551392400 ## File path: tests/kafkatest/tests/core/upgrade_test.py ## @@ -76,10 +76,14 @@ def perform_upgrade(self, from_kafka_version, to_message_format_version=None)

[GitHub] [kafka] bbejeck commented on pull request #9774: MINOR: Add 2.7.0 release to broker and client compat tests

bbejeck commented on pull request #9774: URL: https://github.com/apache/kafka/pull/9774#issuecomment-754009374 ping @ijuma for review. It would be good to have a pair of eyes from core to review this This is an automated me

[jira] [Commented] (KAFKA-10701) First line of detailed stats from consumer-perf-test.sh incorrect

[ https://issues.apache.org/jira/browse/KAFKA-10701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17258236#comment-17258236 ] Cenk Uyan commented on KAFKA-10701: --- It maybe totally the case that I'm missing someth

[GitHub] [kafka] chia7712 commented on pull request #9712: KAFKA-10822 Force some stdout from system tests for Travis

chia7712 commented on pull request #9712: URL: https://github.com/apache/kafka/pull/9712#issuecomment-753982409 The timeout of "no output" is caused by only ```replica_scale_test.py```. will go back here if #9797 get merged. ---

[GitHub] [kafka] vitojeng commented on pull request #9821: KAFKA-5876: Apply UnknownStateStoreException for Interactive Queries

vitojeng commented on pull request #9821: URL: https://github.com/apache/kafka/pull/9821#issuecomment-753967421 @mjsax Sorry for the long pause, please take a look. :) This is an automated message from the Apache Git Service.

[GitHub] [kafka] dajac commented on a change in pull request #9778: KAFKA-10874 Fix flaky ClientQuotasRequestTest.testAlterIpQuotasRequest

dajac commented on a change in pull request #9778: URL: https://github.com/apache/kafka/pull/9778#discussion_r551298159 ## File path: core/src/test/scala/unit/kafka/server/ClientQuotasRequestTest.scala ## @@ -212,7 +214,9 @@ class ClientQuotasRequestTest extends BaseRequestTest

[jira] [Updated] (KAFKA-10899) Closing check Before Producer's BufferPool allocat memory

[ https://issues.apache.org/jira/browse/KAFKA-10899?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lizhao updated KAFKA-10899: --- Description: [#9817|https://github.com/apache/kafka/pull/9817]    According to the idea of [#7967|https://g

[jira] [Updated] (KAFKA-10899) Closing check Before Producer's BufferPool allocat memory

[ https://issues.apache.org/jira/browse/KAFKA-10899?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] lizhao updated KAFKA-10899: --- Description: [#9817|https://github.com/apache/kafka/pull/9817]   Closing check Before Producer's BufferPool

[jira] [Created] (KAFKA-10899) Closing check Before Producer's BufferPool allocat memory

lizhao created KAFKA-10899: -- Summary: Closing check Before Producer's BufferPool allocat memory Key: KAFKA-10899 URL: https://issues.apache.org/jira/browse/KAFKA-10899 Project: Kafka Issue Type: Im

[GitHub] [kafka] wenbingshen commented on pull request #9789: KAFKA-10891:The control plane needs to force the validation of requests from the controller

wenbingshen commented on pull request #9789: URL: https://github.com/apache/kafka/pull/9789#issuecomment-753883978 @chia7712 Thanks for your guidance. I will apply for KIP permissions and learn how to create KIP. > @wenbingshen see https://cwiki.apache.org/confluence/display/KAFKA/

[GitHub] [kafka] chia7712 commented on pull request #9789: KAFKA-10891:The control plane needs to force the validation of requests from the controller

chia7712 commented on pull request #9789: URL: https://github.com/apache/kafka/pull/9789#issuecomment-753880276 @wenbingshen see https://cwiki.apache.org/confluence/display/KAFKA/Kafka+Improvement+Proposals for guidance. In short, you have to complete following tasks. 1. require KIP

[GitHub] [kafka] wenbingshen commented on pull request #9789: KAFKA-10891:The control plane needs to force the validation of requests from the controller

wenbingshen commented on pull request #9789: URL: https://github.com/apache/kafka/pull/9789#issuecomment-753878181 @chia7712 Thanks for your comment.I'm sorry that I forgot to reply to the first question. During my use, I found no other way to cause this problem except to define the config

[GitHub] [kafka] chia7712 commented on pull request #9789: KAFKA-10891:The control plane needs to force the validation of requests from the controller

chia7712 commented on pull request #9789: URL: https://github.com/apache/kafka/pull/9789#issuecomment-753867976 @wenbingshen Thanks for your response. > I think we just need to completely separate control requests from data requests, and provide the user with an optional configurati

[jira] [Commented] (KAFKA-10759) ARM support for Kafka

[ https://issues.apache.org/jira/browse/KAFKA-10759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17258099#comment-17258099 ] Martin Tzvetanov Grigorov commented on KAFKA-10759: --- [~xiaopenglei] Th

[GitHub] [kafka] martin-g commented on pull request #9794: Add a job to build on ARM64 at Amazon Graviton2 nodes

martin-g commented on pull request #9794: URL: https://github.com/apache/kafka/pull/9794#issuecomment-753865203 https://issues.apache.org/jira/browse/KAFKA-10759 This is an automated message from the Apache Git Service. To re

[GitHub] [kafka] wenbingshen commented on pull request #9789: KAFKA-10891:The control plane needs to force the validation of requests from the controller

wenbingshen commented on pull request #9789: URL: https://github.com/apache/kafka/pull/9789#issuecomment-753859484 @chia7712 Thanks for your comments and questions.I think we just need to completely separate control requests from data requests, and provide the user with an optional config

[GitHub] [kafka] chia7712 commented on a change in pull request #9805: MINOR: Remove outdated comment in Connect's WorkerCoordinator

chia7712 commented on a change in pull request #9805: URL: https://github.com/apache/kafka/pull/9805#discussion_r551189138 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/WorkerCoordinator.java ## @@ -50,7 +50,6 @@ * to workers. */