chia7712 commented on pull request #9516:
URL: https://github.com/apache/kafka/pull/9516#issuecomment-757434663
hi @dengziming
> I have a question, why not also replace ScatteringByteChannel in Receive
with a similar class?
```TransportLayer``` is a heavy interface so it may
chia7712 commented on a change in pull request #9850:
URL: https://github.com/apache/kafka/pull/9850#discussion_r554525446
##
File path: core/src/main/scala/kafka/server/KafkaApis.scala
##
@@ -3242,6 +3209,133 @@ class KafkaApis(val requestChannel: RequestChannel,
}
}
dengziming commented on pull request #9516:
URL: https://github.com/apache/kafka/pull/9516#issuecomment-757433441
@chia7712 Hello, I have a question, why not also replace
`ScatteringByteChannel` in `Receive` with a similar class?
---
dengziming opened a new pull request #9852:
URL: https://github.com/apache/kafka/pull/9852
*More detailed description of your change*
This is a suggestion of IDEA
*Summary of testing strategy (including rationale)*
QA
### Committer Checklist (excluded from commit message)
chia7712 commented on pull request #9520:
URL: https://github.com/apache/kafka/pull/9520#issuecomment-757429406
fix conflicting files
This is an automated message from the Apache Git Service.
To respond to the message, please
[
https://issues.apache.org/jira/browse/KAFKA-10878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-10878.
Fix Version/s: 2.8.0
Reviewer: Chia-Ping Tsai
Resolution: Fixed
> testRead
chia7712 merged pull request #9776:
URL: https://github.com/apache/kafka/pull/9776
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
[
https://issues.apache.org/jira/browse/KAFKA-10887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-10887.
Fix Version/s: 2.8.0
Reviewer: Chia-Ping Tsai
Resolution: Fixed
> Migrate
chia7712 merged pull request #9785:
URL: https://github.com/apache/kafka/pull/9785
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
chia7712 commented on a change in pull request #9785:
URL: https://github.com/apache/kafka/pull/9785#discussion_r554520668
##
File path: build.gradle
##
@@ -1782,8 +1782,8 @@ project(':log4j-appender') {
compile libs.slf4jlog4j
testCompile project(':clients').source
ijuma commented on pull request #9520:
URL: https://github.com/apache/kafka/pull/9520#issuecomment-757426244
I would do the minimal set of changes to make the test suite pass with JUnit
5.
This is an automated message from t
[
https://issues.apache.org/jira/browse/KAFKA-12169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
zou shengfu updated KAFKA-12169:
Description:
Background:
Kafka consumer services run with static membership and cooperative reba
chia7712 commented on pull request #9851:
URL: https://github.com/apache/kafka/pull/9851#issuecomment-757424644
@abbccdda Could we reuse the code
(https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/common/internals/Topic.java#L36)
to do the validation for sta
chia7712 commented on pull request #9851:
URL: https://github.com/apache/kafka/pull/9851#issuecomment-757423842
@highluck Thanks for your patch.
The check of static group id
(https://github.com/apache/kafka/blob/trunk/clients/src/main/java/org/apache/kafka/common/requests/JoinGroupRe
[
https://issues.apache.org/jira/browse/KAFKA-10551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
dengziming reassigned KAFKA-10551:
--
Assignee: dengziming
> Support topic IDs in Produce request
> ---
zou shengfu created KAFKA-12169:
---
Summary: Consumer can not know paritions chage when client leader
restart with static membership protocol
Key: KAFKA-12169
URL: https://issues.apache.org/jira/browse/KAFKA-12169
dengziming commented on a change in pull request #9814:
URL: https://github.com/apache/kafka/pull/9814#discussion_r554514560
##
File path: core/src/main/scala/kafka/zk/AdminZkClient.scala
##
@@ -90,11 +92,13 @@ class AdminZkClient(zkClient: KafkaZkClient) extends
Logging {
chia7712 commented on pull request #9520:
URL: https://github.com/apache/kafka/pull/9520#issuecomment-757421003
> Will you do the core conversion to JUnit 5 next?
of course. Should we keep using ```ScalaTest``` and ```hamcrest```? They are
not in conflict with Junit 5 but it results
cadonna commented on pull request #9848:
URL: https://github.com/apache/kafka/pull/9848#issuecomment-756937909
Call for review: @ableegoldman @guozhangwang @lct45 @wcarlson5
This is an automated message from the Apache Git S
highluck commented on pull request #9640:
URL: https://github.com/apache/kafka/pull/9640#issuecomment-757098111
@ableegoldman
please review!
thanks!
This is an automated message from the Apache Git Service.
To respond
vvcephei commented on pull request #9107:
URL: https://github.com/apache/kafka/pull/9107#issuecomment-756855647
Hey @inponomarev and @mjsax ! I'm glad to see this is moving along.
Regarding https://github.com/apache/kafka/pull/9107#issuecomment-751922810 :
My understanding was
ableegoldman commented on pull request #9568:
URL: https://github.com/apache/kafka/pull/9568#issuecomment-757068928
Cherrypicked to 2.7
This is an automated message from the Apache Git Service.
To respond to the message, plea
highluck commented on pull request #9851:
URL: https://github.com/apache/kafka/pull/9851#issuecomment-757097869
@chia7712
Please review! thanks!
This is an automated message from the Apache Git Service.
To respond to the m
ableegoldman commented on pull request #9583:
URL: https://github.com/apache/kafka/pull/9583#issuecomment-757068919
Cherrypicked to 2.7
This is an automated message from the Apache Git Service.
To respond to the message, plea
ijuma commented on pull request #9485:
URL: https://github.com/apache/kafka/pull/9485#issuecomment-756982595
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
hachikuji merged pull request #9838:
URL: https://github.com/apache/kafka/pull/9838
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
junrao commented on a change in pull request #9838:
URL: https://github.com/apache/kafka/pull/9838#discussion_r554150718
##
File path: core/src/main/scala/kafka/log/Log.scala
##
@@ -2124,17 +2130,28 @@ class Log(@volatile private var _dir: File,
time = time,
cyrusv closed pull request #9845:
URL: https://github.com/apache/kafka/pull/9845
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
gharris1727 commented on pull request #9806:
URL: https://github.com/apache/kafka/pull/9806#issuecomment-756853770
> Presumably, if some client application is using the JVM-global JAAS
config, it's because it wants to pick up on mutations to that config. ...in the
case of the basic auth RE
dajac merged pull request #9846:
URL: https://github.com/apache/kafka/pull/9846
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
d8tltanc commented on pull request #9485:
URL: https://github.com/apache/kafka/pull/9485#issuecomment-75698
Sure. Could someone point me to the release note page so I can edit it?
This is an automated message from the Apa
ableegoldman commented on pull request #9489:
URL: https://github.com/apache/kafka/pull/9489#issuecomment-757068925
Cherrypicked to 2.7
This is an automated message from the Apache Git Service.
To respond to the message, plea
hachikuji commented on a change in pull request #9749:
URL: https://github.com/apache/kafka/pull/9749#discussion_r554105440
##
File path: core/src/main/scala/kafka/server/AlterIsrManager.scala
##
@@ -122,43 +121,47 @@ class DefaultAlterIsrManager(
override def start(): Uni
mumrah commented on a change in pull request #9749:
URL: https://github.com/apache/kafka/pull/9749#discussion_r554113195
##
File path: core/src/main/scala/kafka/server/AlterIsrManager.scala
##
@@ -122,43 +121,47 @@ class DefaultAlterIsrManager(
override def start(): Unit =
hachikuji commented on pull request #9850:
URL: https://github.com/apache/kafka/pull/9850#issuecomment-757032600
cc @abbccdda
This is an automated message from the Apache Git Service.
To respond to the message, please log on
hachikuji commented on pull request #9839:
URL: https://github.com/apache/kafka/pull/9839#issuecomment-757040327
@chia7712 Thanks for reviews. Take one more look at the updates when you
have time.
This is an automated messa
mimaison commented on pull request #9844:
URL: https://github.com/apache/kafka/pull/9844#issuecomment-756831838
Artifacts are now in maven:
https://repo1.maven.org/maven2/org/apache/kafka/kafka-clients/2.6.1/
This is an auto
dengziming commented on pull request #9809:
URL: https://github.com/apache/kafka/pull/9809#issuecomment-757410251
@cmccabe @mumrah , Hi, I want to hear from your opinion, thank you.
This is an automated message from the Apach
ijuma commented on pull request #9520:
URL: https://github.com/apache/kafka/pull/9520#issuecomment-756800352
Looking at the test results, it looks like there are some real failures. For
example:
`Build / JDK 8 /
kafka.utils.QuotaUtilsTest.testBoundedThrottleTimeThrowsExceptionIfProv
C0urante commented on pull request #9806:
URL: https://github.com/apache/kafka/pull/9806#issuecomment-756841881
@gharris1727 thanks for taking a look. It's an interesting question about
isolating plugins in that way... I have to wonder if it's possible to do that
in a way that doesn't brea
hachikuji commented on a change in pull request #9838:
URL: https://github.com/apache/kafka/pull/9838#discussion_r554224946
##
File path: core/src/main/scala/kafka/log/Log.scala
##
@@ -2124,17 +2130,28 @@ class Log(@volatile private var _dir: File,
time = time,
jiameixie commented on pull request #8943:
URL: https://github.com/apache/kafka/pull/8943#issuecomment-756635561
@chia7712 I have updated it. Add function addOptionVersion in ToolsUtils. To
call ToolsUtils.addOptionVersion(parser) is to add option '--version'.
---
dajac merged pull request #9827:
URL: https://github.com/apache/kafka/pull/9827
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
cadonna commented on a change in pull request #9695:
URL: https://github.com/apache/kafka/pull/9695#discussion_r553988171
##
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##
@@ -1432,7 +1480,9 @@ public void cleanUp() {
validateIsRunningOr
dajac commented on pull request #9846:
URL: https://github.com/apache/kafka/pull/9846#issuecomment-756705292
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
zydzjy commented on pull request #9697:
URL: https://github.com/apache/kafka/pull/9697#issuecomment-756615836
what can i do with replace new thread?Can i skip the current offset in
exception handler,cause the exception occured by the data with current offset?
-
tombentley commented on pull request #9847:
URL: https://github.com/apache/kafka/pull/9847#issuecomment-756716765
@cmccabe grateful if you could take a look at this.
Strictly speaking, making throw ConfigResource is not entirely backwards
compatible, but invalid instances could never
jordilaforge commented on pull request #8967:
URL: https://github.com/apache/kafka/pull/8967#issuecomment-756767068
Dear Kafka developer is there any news on this? The state of a consumer if
the connection is lost is still RUNNING.
dajac commented on pull request #9746:
URL: https://github.com/apache/kafka/pull/9746#issuecomment-756705826
@chia7712 Sorry for the delay. I will take a look at it next week.
This is an automated message from the Apache Git
chia7712 commented on pull request #9527:
URL: https://github.com/apache/kafka/pull/9527#issuecomment-756653400
> Something like https://github.com/scala/scala/pull/9423/files should fix
this issue without making our code less readable.
@ijuma Your comment encourage me to check the `
tombentley commented on pull request #9846:
URL: https://github.com/apache/kafka/pull/9846#issuecomment-756677031
@chia7712 please could you take a look?
cc @bdbyrne
This is an automated message from the Apache Git Se
chia7712 commented on pull request #9842:
URL: https://github.com/apache/kafka/pull/9842#issuecomment-756648435
@tombentley Thanks for your feedback!
> Or did you have some other idea about how this could be done?
no, I don't have idea for simple/compatible solution :(
I
tombentley commented on pull request #9842:
URL: https://github.com/apache/kafka/pull/9842#issuecomment-756637958
@chia7712 thanks for taking a look. I agree that documenting it isn't a
great solution.
Generally speaking, it's an anti-pattern for the user to go running blocking
code
53 matches
Mail list logo
