ijuma commented on a change in pull request #9856:
URL: https://github.com/apache/kafka/pull/9856#discussion_r554820416
##
File path:
streams/test-utils/src/test/java/org/apache/kafka/streams/TopologyTestDriverTest.java
##
@@ -125,25 +124,20 @@
chia7712 opened a new pull request #9856:
URL: https://github.com/apache/kafka/pull/9856
issue: https://issues.apache.org/jira/browse/KAFKA-12171
1. replace ```org.junit.Assert``` by ```org.junit.jupiter.api.Assertions```
1. replace ```org.junit``` by ```org.junit.jupiter.api```
[
https://issues.apache.org/jira/browse/KAFKA-12171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai reassigned KAFKA-12171:
--
Assignee: Chia-Ping Tsai
> Migrate streams:test-utils module to JUnit 5
>
Chia-Ping Tsai created KAFKA-12171:
--
Summary: Migrate streams:test-utils module to JUnit 5
Key: KAFKA-12171
URL: https://issues.apache.org/jira/browse/KAFKA-12171
Project: Kafka
Issue Type:
[
https://issues.apache.org/jira/browse/KAFKA-12156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-12156.
Fix Version/s: 2.8.0
Reviewer: Chia-Ping Tsai
Resolution: Fixed
>
chia7712 merged pull request #9842:
URL: https://github.com/apache/kafka/pull/9842
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
chia7712 merged pull request #9853:
URL: https://github.com/apache/kafka/pull/9853
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
[
https://issues.apache.org/jira/browse/KAFKA-10759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17262352#comment-17262352
]
PengLei edited comment on KAFKA-10759 at 1/11/21, 2:48 AM:
---
[~junrao] and
[
https://issues.apache.org/jira/browse/KAFKA-10759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17262352#comment-17262352
]
PengLei commented on KAFKA-10759:
-
[~junrao] and Kafka devs，I have donated an arm vm to the apache
ijuma commented on a change in pull request #9855:
URL: https://github.com/apache/kafka/pull/9855#discussion_r554628355
##
File path:
core/src/test/scala/integration/kafka/admin/BrokerApiVersionsCommandTest.scala
##
@@ -19,24 +19,25 @@ package kafka.admin
import
chia7712 opened a new pull request #9855:
URL: https://github.com/apache/kafka/pull/9855
issue: https://issues.apache.org/jira/browse/KAFKA-7341
This PR includes following changes.
1. replace ```org.junit.Assert``` by ```org.junit.jupiter.api.Assertions```
1. replace
dajac merged pull request #9852:
URL: https://github.com/apache/kafka/pull/9852
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
jolshan commented on a change in pull request #9814:
URL: https://github.com/apache/kafka/pull/9814#discussion_r554600025
##
File path: core/src/main/scala/kafka/zk/AdminZkClient.scala
##
@@ -90,11 +92,13 @@ class AdminZkClient(zkClient: KafkaZkClient) extends
Logging {
*
jolshan commented on a change in pull request #9814:
URL: https://github.com/apache/kafka/pull/9814#discussion_r554600025
##
File path: core/src/main/scala/kafka/zk/AdminZkClient.scala
##
@@ -90,11 +92,13 @@ class AdminZkClient(zkClient: KafkaZkClient) extends
Logging {
*
jolshan commented on a change in pull request #9814:
URL: https://github.com/apache/kafka/pull/9814#discussion_r554600025
##
File path: core/src/main/scala/kafka/zk/AdminZkClient.scala
##
@@ -90,11 +92,13 @@ class AdminZkClient(zkClient: KafkaZkClient) extends
Logging {
*
jolshan commented on a change in pull request #9814:
URL: https://github.com/apache/kafka/pull/9814#discussion_r554599936
##
File path: core/src/main/scala/kafka/zk/AdminZkClient.scala
##
@@ -153,16 +157,17 @@ class AdminZkClient(zkClient: KafkaZkClient) extends
Logging {
g1geordie opened a new pull request #9854:
URL: https://github.com/apache/kafka/pull/9854
`assertDoesNotThrow(.)` in the last line
Above is unnecessary noise in my commit .
Please let me revert it .
Discuss from
g1geordie commented on a change in pull request #9785:
URL: https://github.com/apache/kafka/pull/9785#discussion_r554593025
##
File path:
log4j-appender/src/test/java/org/apache/kafka/log4jappender/KafkaLog4jAppenderTest.java
##
@@ -130,55 +116,51 @@ public void
g1geordie commented on a change in pull request #9785:
URL: https://github.com/apache/kafka/pull/9785#discussion_r554590943
##
File path: build.gradle
##
@@ -1782,8 +1782,8 @@ project(':log4j-appender') {
compile libs.slf4jlog4j
testCompile
chia7712 commented on a change in pull request #9785:
URL: https://github.com/apache/kafka/pull/9785#discussion_r554589317
##
File path:
log4j-appender/src/test/java/org/apache/kafka/log4jappender/KafkaLog4jAppenderTest.java
##
@@ -130,55 +116,51 @@ public void
ijuma commented on a change in pull request #9785:
URL: https://github.com/apache/kafka/pull/9785#discussion_r554586805
##
File path:
log4j-appender/src/test/java/org/apache/kafka/log4jappender/KafkaLog4jAppenderTest.java
##
@@ -130,55 +116,51 @@ public void
ijuma commented on pull request #9849:
URL: https://github.com/apache/kafka/pull/9849#issuecomment-757498578
Yeah, this is not complete yet (hence the draft status). :)
This is an automated message from the Apache Git
[
https://issues.apache.org/jira/browse/KAFKA-12170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sven Erik Knop updated KAFKA-12170:
---
Summary: Connect Cast cannot deal with fields of type "bytes" correctly
(was: Connect Cast
highluck edited a comment on pull request #9851:
URL: https://github.com/apache/kafka/pull/9851#issuecomment-757480066
@chia7712, @abbccdda
The code was modified
How about the following?
This is an automated message
highluck commented on pull request #9851:
URL: https://github.com/apache/kafka/pull/9851#issuecomment-757480066
@chia7712
The code was modified.
How about the following?
This is an automated message from the Apache
chia7712 commented on pull request #9520:
URL: https://github.com/apache/kafka/pull/9520#issuecomment-757469199
@ijuma Thanks for all your great reviews!
This is an automated message from the Apache Git Service.
To respond
chia7712 merged pull request #9520:
URL: https://github.com/apache/kafka/pull/9520
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
tang7526 opened a new pull request #9853:
URL: https://github.com/apache/kafka/pull/9853
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade
Sven Erik Knop created KAFKA-12170:
--
Summary: Connect Cast cannot deal with Bytes correctly
Key: KAFKA-12170
URL: https://issues.apache.org/jira/browse/KAFKA-12170
Project: Kafka
Issue
[
https://issues.apache.org/jira/browse/KAFKA-7748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17262127#comment-17262127
]
Sari Alalem commented on KAFKA-7748:
Hi [~vvcephei],
I'm interested in having this in, I believe it
chia7712 commented on pull request #9849:
URL: https://github.com/apache/kafka/pull/9849#issuecomment-757436731
https://github.com/apache/kafka/blob/trunk/gradle/wrapper/gradle-wrapper.properties#L3
need to be updated as well.
31 matches
Mail list logo
