[jira] [Commented] (KAFKA-12205) Delete snapshots if it's end offset is less than the log start offset

2021-01-30 Thread dengziming (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17275793#comment-17275793 ] dengziming commented on KAFKA-12205: Here is my understanding about when to delete a snapshot, first

[GitHub] [kafka] rohitrmd commented on a change in pull request #9744: KAFKA-10062: Add a method to retrieve the current timestamp as known by the Streams app

2021-01-30 Thread GitBox
rohitrmd commented on a change in pull request #9744: URL: https://github.com/apache/kafka/pull/9744#discussion_r567356968 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/AbstractProcessorContext.java ## @@ -45,7 +45,6 @@ private boolean

[jira] [Resolved] (KAFKA-12236) Add version 1 of meta.properties for KIP-500

2021-01-30 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-12236. - Resolution: Fixed > Add version 1 of meta.properties for KIP-500 >

[GitHub] [kafka] hachikuji merged pull request #9967: KAFKA-12236; New meta.properties logic for KIP-500

2021-01-30 Thread GitBox
hachikuji merged pull request #9967: URL: https://github.com/apache/kafka/pull/9967 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] hachikuji commented on pull request #9967: KAFKA-12236; New meta.properties logic for KIP-500

2021-01-30 Thread GitBox
hachikuji commented on pull request #9967: URL: https://github.com/apache/kafka/pull/9967#issuecomment-770307353 One test failure fixed by https://github.com/apache/kafka/pull/10006. Merging to trunk. This is an automated

[GitHub] [kafka] hachikuji edited a comment on pull request #10006: KAFKA-12245; Fix flaky `FetcherTest.testEarlierOffsetResetArrivesLate`

2021-01-30 Thread GitBox
hachikuji edited a comment on pull request #10006: URL: https://github.com/apache/kafka/pull/10006#issuecomment-770119487 @abbccdda See for example this trace, which is often found in an unrelated test case (https://github.com/apache/kafka/runs/1794689847): ```

[jira] [Assigned] (KAFKA-12260) PartitionsFor should not return null value

2021-01-30 Thread Boyang Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Boyang Chen reassigned KAFKA-12260: --- Assignee: Boyang Chen > PartitionsFor should not return null value >

[jira] [Created] (KAFKA-12260) PartitionsFor should not return null value

2021-01-30 Thread Boyang Chen (Jira)
Boyang Chen created KAFKA-12260: --- Summary: PartitionsFor should not return null value Key: KAFKA-12260 URL: https://issues.apache.org/jira/browse/KAFKA-12260 Project: Kafka Issue Type:

[GitHub] [kafka] rondagostino commented on a change in pull request #10005: Add ConfigRepository, use in Partition and KafkaApis

2021-01-30 Thread GitBox
rondagostino commented on a change in pull request #10005: URL: https://github.com/apache/kafka/pull/10005#discussion_r567315872 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -3008,7 +3107,8 @@ class KafkaApis(val requestChannel: RequestChannel,

[GitHub] [kafka] hachikuji commented on pull request #9967: KAFKA-12236; New meta.properties logic for KIP-500

2021-01-30 Thread GitBox
hachikuji commented on pull request #9967: URL: https://github.com/apache/kafka/pull/9967#issuecomment-770279434 @ijuma Yep, got a little lazy verifying the case class conversion. Hopefully fixed now. We were in fact relying on the `equals`, but I modified the test case.

[GitHub] [kafka] rondagostino commented on a change in pull request #10005: Add ConfigRepository, use in Partition and KafkaApis

2021-01-30 Thread GitBox
rondagostino commented on a change in pull request #10005: URL: https://github.com/apache/kafka/pull/10005#discussion_r567313320 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -249,6 +270,7 @@ class KafkaApis(val requestChannel: RequestChannel, }

[GitHub] [kafka] ijuma commented on pull request #9967: KAFKA-12236; New meta.properties logic for KIP-500

2021-01-30 Thread GitBox
ijuma commented on pull request #9967: URL: https://github.com/apache/kafka/pull/9967#issuecomment-770276918 I think the case class change caused a compiler error, we probably need to make the field accessible. This is an

[GitHub] [kafka] hachikuji commented on a change in pull request #9967: KAFKA-12236; New meta.properties logic for KIP-500

2021-01-30 Thread GitBox
hachikuji commented on a change in pull request #9967: URL: https://github.com/apache/kafka/pull/9967#discussion_r567309420 ## File path: clients/src/main/java/org/apache/kafka/common/Uuid.java ## @@ -106,6 +106,9 @@ public String toString() { */ public static Uuid

[GitHub] [kafka] hachikuji commented on a change in pull request #9967: KAFKA-12236; New meta.properties logic for KIP-500

2021-01-30 Thread GitBox
hachikuji commented on a change in pull request #9967: URL: https://github.com/apache/kafka/pull/9967#discussion_r567306870 ## File path: core/src/main/scala/kafka/server/BrokerMetadataCheckpoint.scala ## @@ -21,38 +21,203 @@ import java.io._ import java.nio.file.{Files,

[GitHub] [kafka] ijuma commented on a change in pull request #9967: KAFKA-12236; New meta.properties logic for KIP-500

2021-01-30 Thread GitBox
ijuma commented on a change in pull request #9967: URL: https://github.com/apache/kafka/pull/9967#discussion_r566168366 ## File path: core/src/main/scala/kafka/server/BrokerMetadataCheckpoint.scala ## @@ -21,38 +21,203 @@ import java.io._ import java.nio.file.{Files,

[GitHub] [kafka] hachikuji commented on pull request #9739: KAFKA-10636 Bypass log validation for writes to raft log

2021-01-30 Thread GitBox
hachikuji commented on pull request #9739: URL: https://github.com/apache/kafka/pull/9739#issuecomment-770267814 @feyman2016 I can help getting this over the line if you don't have time. I think it's just a couple small changes after rebasing.

[GitHub] [kafka] hachikuji commented on a change in pull request #9967: KAFKA-12236; New meta.properties logic for KIP-500

2021-01-30 Thread GitBox
hachikuji commented on a change in pull request #9967: URL: https://github.com/apache/kafka/pull/9967#discussion_r567301638 ## File path: core/src/main/scala/kafka/server/BrokerMetadataCheckpoint.scala ## @@ -21,38 +21,203 @@ import java.io._ import java.nio.file.{Files,

[GitHub] [kafka] rondagostino commented on a change in pull request #10005: Add ConfigRepository, use in Partition and KafkaApis

2021-01-30 Thread GitBox
rondagostino commented on a change in pull request #10005: URL: https://github.com/apache/kafka/pull/10005#discussion_r567300660 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -1654,6 +1702,7 @@ class KafkaApis(val requestChannel: RequestChannel,

[GitHub] [kafka] rondagostino commented on a change in pull request #10005: Add ConfigRepository, use in Partition and KafkaApis

2021-01-30 Thread GitBox
rondagostino commented on a change in pull request #10005: URL: https://github.com/apache/kafka/pull/10005#discussion_r567300510 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -2609,14 +2672,27 @@ class KafkaApis(val requestChannel: RequestChannel,

[GitHub] [kafka] rondagostino commented on a change in pull request #10005: Add ConfigRepository, use in Partition and KafkaApis

2021-01-30 Thread GitBox
rondagostino commented on a change in pull request #10005: URL: https://github.com/apache/kafka/pull/10005#discussion_r567300461 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -150,7 +167,11 @@ class KafkaApis(val requestChannel: RequestChannel, }

[GitHub] [kafka] chia7712 commented on a change in pull request #9967: KAFKA-12236; New meta.properties logic for KIP-500

2021-01-30 Thread GitBox
chia7712 commented on a change in pull request #9967: URL: https://github.com/apache/kafka/pull/9967#discussion_r567254453 ## File path: core/src/main/scala/kafka/server/BrokerMetadataCheckpoint.scala ## @@ -21,38 +21,203 @@ import java.io._ import java.nio.file.{Files,

[jira] [Closed] (KAFKA-10555) Improve client state machine

2021-01-30 Thread Walker Carlson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Walker Carlson closed KAFKA-10555. -- > Improve client state machine > > > Key:

[jira] [Updated] (KAFKA-12227) Add method "Producer#produce" to return CompletionStage instead of Future

2021-01-30 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-12227: --- Parent: KAFKA-10733 Issue Type: Sub-task (was: Improvement) > Add method

[GitHub] [kafka] chia7712 merged pull request #10001: MINOR: AbstractCoordinatorTest should close coordinator explicitly

2021-01-30 Thread GitBox
chia7712 merged pull request #10001: URL: https://github.com/apache/kafka/pull/10001 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] chia7712 commented on pull request #10001: MINOR: AbstractCoordinatorTest should close coordinator explicitly

2021-01-30 Thread GitBox
chia7712 commented on pull request #10001: URL: https://github.com/apache/kafka/pull/10001#issuecomment-770201214 the flaky is traced by #9777 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] dengziming edited a comment on pull request #9769: KAFKA-10774; Support Describe topic using topic IDs

2021-01-30 Thread GitBox
dengziming edited a comment on pull request #9769: URL: https://github.com/apache/kafka/pull/9769#issuecomment-770140196 The 2 failures in https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-9769/22/#showFailuresLink seem to be related to Mockito, maybe #10006 will fix it.