g1geordie commented on a change in pull request #9906:
URL: https://github.com/apache/kafka/pull/9906#discussion_r571824452
##
File path:
clients/src/test/java/org/apache/kafka/common/record/MemoryRecordsBuilderTest.java
##
@@ -22,47 +22,56 @@
import
ijuma commented on a change in pull request #10069:
URL: https://github.com/apache/kafka/pull/10069#discussion_r571818172
##
File path: core/src/test/scala/unit/kafka/server/RaftReplicaManagerTest.scala
##
@@ -0,0 +1,76 @@
+/**
+ * Licensed to the Apache Software Foundation
ijuma commented on a change in pull request #10069:
URL: https://github.com/apache/kafka/pull/10069#discussion_r571818015
##
File path: core/src/main/scala/kafka/server/ReplicaManager.scala
##
@@ -439,71 +414,85 @@ class ReplicaManager(val config: KafkaConfig,
ijuma commented on a change in pull request #10069:
URL: https://github.com/apache/kafka/pull/10069#discussion_r571817474
##
File path: core/src/main/scala/kafka/server/ReplicaManager.scala
##
@@ -439,71 +414,85 @@ class ReplicaManager(val config: KafkaConfig,
ijuma commented on a change in pull request #9906:
URL: https://github.com/apache/kafka/pull/9906#discussion_r571815170
##
File path:
clients/src/test/java/org/apache/kafka/common/record/MemoryRecordsBuilderTest.java
##
@@ -22,47 +22,56 @@
import
ijuma commented on pull request #10024:
URL: https://github.com/apache/kafka/pull/10024#issuecomment-774908206
@chia7712 Do you know why this started happening more often?
This is an automated message from the Apache Git
chia7712 commented on pull request #10024:
URL: https://github.com/apache/kafka/pull/10024#issuecomment-774893964
another related build
(https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-10012/5/console)
This is an
ijuma commented on a change in pull request #10080:
URL: https://github.com/apache/kafka/pull/10080#discussion_r571791073
##
File path: core/src/main/scala/kafka/server/KafkaBroker.scala
##
@@ -71,8 +70,11 @@ object KafkaBroker {
}
trait KafkaBroker extends
[
https://issues.apache.org/jira/browse/KAFKA-12306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17280744#comment-17280744
]
GeordieMai edited comment on KAFKA-12306 at 2/8/21, 4:21 AM:
-
[~Vicky Zhang]
[
https://issues.apache.org/jira/browse/KAFKA-12306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17280744#comment-17280744
]
GeordieMai commented on KAFKA-12306:
[~Vicky Zhang] hello .
I think the hard-coded text `Password`
chia7712 commented on pull request #10017:
URL: https://github.com/apache/kafka/pull/10017#issuecomment-774852045
@abbccdda Thanks for updating code. Two minor comments are left.
1. The docs of ```KafkaConsumer#partitionsFor(String topic, Duration
timeout)``` is not updated.
1.
chia7712 commented on a change in pull request #10080:
URL: https://github.com/apache/kafka/pull/10080#discussion_r57179
##
File path: core/src/main/scala/kafka/server/KafkaBroker.scala
##
@@ -71,8 +70,11 @@ object KafkaBroker {
}
trait KafkaBroker extends
feyman2016 commented on pull request #10076:
URL: https://github.com/apache/kafka/pull/10076#issuecomment-774830538
Build failed because of Fan-out complexity exceeded 50 for
`StreamThread.java`, will refactor it out.
This
ijuma commented on pull request #10080:
URL: https://github.com/apache/kafka/pull/10080#issuecomment-774813556
cc @rondagostino
This is an automated message from the Apache Git Service.
To respond to the message, please log
ijuma opened a new pull request #10080:
URL: https://github.com/apache/kafka/pull/10080
We don't need or use the additional functionality provided by
AtomicReference.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify
dengziming opened a new pull request #10079:
URL: https://github.com/apache/kafka/pull/10079
*More detailed description of your change*
1. Replace hard-code charset
2. remove UnsupportCharsetException
*Summary of testing strategy (including rationale)*
run test locally
[
https://issues.apache.org/jira/browse/KAFKA-12310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ismael Juma resolved KAFKA-12310.
-
Resolution: Fixed
> Update zookeeper to 3.5.9
> -
>
>
[
https://issues.apache.org/jira/browse/KAFKA-12310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ismael Juma updated KAFKA-12310:
Fix Version/s: 2.4.2
> Update zookeeper to 3.5.9
> -
>
>
[
https://issues.apache.org/jira/browse/KAFKA-12310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ismael Juma updated KAFKA-12310:
Fix Version/s: 2.6.2
2.7.1
2.8.0
2.5.2
>
[
https://issues.apache.org/jira/browse/KAFKA-12310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17280695#comment-17280695
]
Ismael Juma commented on KAFKA-12310:
-
PR: https://github.com/apache/kafka/pull/9977
> Update
Ismael Juma created KAFKA-12310:
---
Summary: Update zookeeper to 3.5.9
Key: KAFKA-12310
URL: https://issues.apache.org/jira/browse/KAFKA-12310
Project: Kafka
Issue Type: Improvement
ijuma commented on pull request #10039:
URL: https://github.com/apache/kafka/pull/10039#issuecomment-774790663
Merged to trunk and 2.8 branches.
This is an automated message from the Apache Git Service.
To respond to the
ijuma merged pull request #10039:
URL: https://github.com/apache/kafka/pull/10039
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
ijuma commented on pull request #10039:
URL: https://github.com/apache/kafka/pull/10039#issuecomment-774790209
The JDK 8 build had unrelated flaky test failures this time while JDK 11 and
15 terminated before completion (again unrelated). Will go ahead and merge.
rondagostino commented on pull request #10039:
URL: https://github.com/apache/kafka/pull/10039#issuecomment-774777518
Latest changes LGTM
This is an automated message from the Apache Git Service.
To respond to the message,
ijuma commented on pull request #10039:
URL: https://github.com/apache/kafka/pull/10039#issuecomment-774775433
One unrelated flaky failure:
`Build / JDK 15 /
kafka.controller.ControllerIntegrationTest.testPartitionReassignmentToBrokerWithOfflineLogDir()`
One of the builds exited
ijuma commented on a change in pull request #10039:
URL: https://github.com/apache/kafka/pull/10039#discussion_r571672398
##
File path: core/src/test/scala/unit/kafka/cluster/PartitionLockTest.scala
##
@@ -305,15 +304,6 @@ class PartitionLockTest extends Logging {
ijuma commented on pull request #10069:
URL: https://github.com/apache/kafka/pull/10069#issuecomment-774732997
All builds are green!
This is an automated message from the Apache Git Service.
To respond to the message, please
chia7712 opened a new pull request #10078:
URL: https://github.com/apache/kafka/pull/10078
inspired by #10068
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify
ramesh-muthusamy removed a comment on pull request #10054:
URL: https://github.com/apache/kafka/pull/10054#issuecomment-774705638
@chia7712 i will check this , can you let me know if this is the JIRA for
the same . KAFKA-12283 and
chia7712 merged pull request #10068:
URL: https://github.com/apache/kafka/pull/10068
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
rgroothuijsen commented on a change in pull request #9078:
URL: https://github.com/apache/kafka/pull/9078#discussion_r571647298
##
File path:
clients/src/main/java/org/apache/kafka/common/metrics/JmxReporter.java
##
@@ -272,8 +272,16 @@ public MBeanInfo getMBeanInfo() {
chia7712 commented on pull request #10068:
URL: https://github.com/apache/kafka/pull/10068#issuecomment-774708473
@dengziming Nice patch!
This is an automated message from the Apache Git Service.
To respond to the message,
[
https://issues.apache.org/jira/browse/KAFKA-12309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
rameshkrishnan muthusamy reassigned KAFKA-12309:
Assignee: Chia-Ping Tsai (was: rameshkrishnan muthusamy)
> The
ramesh-muthusamy edited a comment on pull request #10054:
URL: https://github.com/apache/kafka/pull/10054#issuecomment-774705638
@chia7712 i will check this , can you let me know if this is the JIRA for
the same . KAFKA-12283 and
ramesh-muthusamy removed a comment on pull request #10054:
URL: https://github.com/apache/kafka/pull/10054#issuecomment-774705507
Hi Chia,
I will check this .
Thanks
Ramesh
On Sun, 7 Feb 2021 at 9:54 PM, Chia-Ping Tsai
wrote:
> close this PR as there are
ramesh-muthusamy commented on pull request #10054:
URL: https://github.com/apache/kafka/pull/10054#issuecomment-774705638
@chia7712 i will check this , can you let me know if this is the JIRA for
the same . KAFKA-12283
This
ramesh-muthusamy commented on pull request #10054:
URL: https://github.com/apache/kafka/pull/10054#issuecomment-774705507
Hi Chia,
I will check this .
Thanks
Ramesh
On Sun, 7 Feb 2021 at 9:54 PM, Chia-Ping Tsai
wrote:
> close this PR as there are different
[
https://issues.apache.org/jira/browse/KAFKA-12309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
rameshkrishnan muthusamy reassigned KAFKA-12309:
Assignee: rameshkrishnan muthusamy (was: Chia-Ping Tsai)
> The
chia7712 commented on pull request #10024:
URL: https://github.com/apache/kafka/pull/10024#issuecomment-774704488
@ijuma any feedback for this PR? It happens occasionally on our jenkins (for
example:
rondagostino commented on a change in pull request #10039:
URL: https://github.com/apache/kafka/pull/10039#discussion_r571642788
##
File path: core/src/main/scala/kafka/log/LogManager.scala
##
@@ -118,8 +116,6 @@ class LogManager(logDirs: Seq[File],
logDirsSet
}
-
chia7712 commented on a change in pull request #10077:
URL: https://github.com/apache/kafka/pull/10077#discussion_r571642581
##
File path:
connect/runtime/src/test/java/org/apache/kafka/connect/integration/RebalanceSourceConnectorsIntegrationTest.java
##
@@ -359,7 +359,9 @@
chia7712 opened a new pull request #10077:
URL: https://github.com/apache/kafka/pull/10077
issue: https://issues.apache.org/jira/browse/KAFKA-12309
### Assignments:
"W0" -> 8 connectors/tasks
"W1" -> 8 connectors/tasks
(New) "W2" -> 0 connectors/tasks
### Revoked
ijuma commented on a change in pull request #10039:
URL: https://github.com/apache/kafka/pull/10039#discussion_r571642087
##
File path: core/src/main/scala/kafka/log/LogManager.scala
##
@@ -118,8 +116,6 @@ class LogManager(logDirs: Seq[File],
logDirsSet
}
-
chia7712 closed pull request #10054:
URL: https://github.com/apache/kafka/pull/10054
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
Chia-Ping Tsai created KAFKA-12309:
--
Summary: The revocation algorithm produces uneven distributions
Key: KAFKA-12309
URL: https://issues.apache.org/jira/browse/KAFKA-12309
Project: Kafka
chia7712 commented on pull request #10054:
URL: https://github.com/apache/kafka/pull/10054#issuecomment-774702573
close this PR as there are different issues for the flaky
This is an automated message from the Apache Git
ijuma commented on pull request #10069:
URL: https://github.com/apache/kafka/pull/10069#issuecomment-774696381
@rondagostino Looks like a file is missing the license:
> 19:18:36 Execution failed for task ':rat'.
> 19:18:36 > Found 1 files with unknown licenses.
MarcoLotz commented on pull request #10042:
URL: https://github.com/apache/kafka/pull/10042#issuecomment-774675817
@jeqo changed to seekLatest and aligned with UNKOWN_OFFSET recommendation.
This is an automated message from
MarcoLotz commented on a change in pull request #10042:
URL: https://github.com/apache/kafka/pull/10042#discussion_r571617491
##
File path: core/src/main/scala/kafka/tools/StreamsResetter.java
##
@@ -503,7 +505,15 @@ private void resetToDatetime(final Consumer client,
50 matches
Mail list logo
