[GitHub] [kafka] chia7712 commented on a change in pull request #10123: KAFKA-12327: Remove MethodHandle usage in CompressionType

2021-02-13 Thread GitBox
chia7712 commented on a change in pull request #10123: URL: https://github.com/apache/kafka/pull/10123#discussion_r575764462 ## File path: checkstyle/import-control.xml ## @@ -144,15 +155,14 @@ - + Review comment: make sense. --

[jira] [Updated] (KAFKA-9295) KTableKTableForeignKeyInnerJoinMultiIntegrationTest#shouldInnerJoinMultiPartitionQueryable

2021-02-13 Thread dengziming (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dengziming updated KAFKA-9295: -- Attachment: (was: image.png) > KTableKTableForeignKeyInnerJoinMultiIntegrationTest#shouldInnerJoinM

[jira] [Updated] (KAFKA-9295) KTableKTableForeignKeyInnerJoinMultiIntegrationTest#shouldInnerJoinMultiPartitionQueryable

2021-02-13 Thread dengziming (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] dengziming updated KAFKA-9295: -- Attachment: image.png > KTableKTableForeignKeyInnerJoinMultiIntegrationTest#shouldInnerJoinMultiPartiti

[jira] [Comment Edited] (KAFKA-12326) MM2 fails to start to due missing required configuration "bootstrap.servers"

2021-02-13 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17284039#comment-17284039 ] Randall Hauch edited comment on KAFKA-12326 at 2/14/21, 3:34 AM: -

[GitHub] [kafka] rhauch commented on pull request #10122: KAFKA-12326: Corrected regresion in MirrorMaker 2 executable introduced with KAFKA-10021

2021-02-13 Thread GitBox
rhauch commented on pull request #10122: URL: https://github.com/apache/kafka/pull/10122#issuecomment-778717408 @dajac thanks for the prompt. Yes, I've backported this to the `2.8` branch. This is an automated message from th

[GitHub] [kafka] ijuma commented on a change in pull request #10123: KAFKA-12327: Remove MethodHandle usage in CompressionType

2021-02-13 Thread GitBox
ijuma commented on a change in pull request #10123: URL: https://github.com/apache/kafka/pull/10123#discussion_r575719316 ## File path: checkstyle/import-control.xml ## @@ -69,6 +69,17 @@ + + + + + + + + Review commen

[GitHub] [kafka] ijuma commented on a change in pull request #10123: KAFKA-12327: Remove MethodHandle usage in CompressionType

2021-02-13 Thread GitBox
ijuma commented on a change in pull request #10123: URL: https://github.com/apache/kafka/pull/10123#discussion_r575719312 ## File path: checkstyle/import-control.xml ## @@ -144,15 +155,14 @@ - + Review comment: This affects a lot of files and I

[GitHub] [kafka] yeralin commented on pull request #6592: KAFKA-8326: Introduce List Serde

2021-02-13 Thread GitBox
yeralin commented on pull request #6592: URL: https://github.com/apache/kafka/pull/6592#issuecomment-778674831 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [kafka] ijuma commented on pull request #10123: KAFKA-12327: Remove MethodHandle usage in CompressionType

2021-02-13 Thread GitBox
ijuma commented on pull request #10123: URL: https://github.com/apache/kafka/pull/10123#issuecomment-77877 @chia7712 Both solutions should behave the same at runtime. At compile time, the previous solution did not require snappy libraries in the classpath (but it did require lz4 and zs

[GitHub] [kafka] ijuma commented on a change in pull request #10123: KAFKA-12327: Remove MethodHandle usage in CompressionType

2021-02-13 Thread GitBox
ijuma commented on a change in pull request #10123: URL: https://github.com/apache/kafka/pull/10123#discussion_r575703770 ## File path: checkstyle/import-control.xml ## @@ -144,15 +155,14 @@ - + Review comment: Possibly. Let me see what other i

[GitHub] [kafka] ijuma commented on a change in pull request #10123: KAFKA-12327: Remove MethodHandle usage in CompressionType

2021-02-13 Thread GitBox
ijuma commented on a change in pull request #10123: URL: https://github.com/apache/kafka/pull/10123#discussion_r575703615 ## File path: checkstyle/import-control.xml ## @@ -69,6 +69,17 @@ + + + + + + + + Review commen

[GitHub] [kafka] chia7712 commented on a change in pull request #10123: KAFKA-12327: Remove MethodHandle usage in CompressionType

2021-02-13 Thread GitBox
chia7712 commented on a change in pull request #10123: URL: https://github.com/apache/kafka/pull/10123#discussion_r575697037 ## File path: checkstyle/import-control.xml ## @@ -144,15 +155,14 @@ - + Review comment: Could we move `CompressionType

[jira] [Resolved] (KAFKA-12297) Implementation of MockProducer contradicts documentation of Callback for async send

2021-02-13 Thread Manikumar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar resolved KAFKA-12297. --- Fix Version/s: 3.0.0 Reviewer: Manikumar Resolution: Fixed > Implementation of MockP

[GitHub] [kafka] omkreddy closed pull request #10110: KAFKA-12297 - Make MockProducer return RecordMetadata with values as per contract

2021-02-13 Thread GitBox
omkreddy closed pull request #10110: URL: https://github.com/apache/kafka/pull/10110 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [GitHub] [kafka] hachikuji merged pull request #10107: MINOR: Improve confusing admin client shutdown logging

2021-02-13 Thread Ran Lupovich
Unsubscribe בתאריך יום ו׳, 12 בפבר׳ 2021, 01:12, מאת GitBox ‏: > > hachikuji merged pull request #10107: > URL: https://github.com/apache/kafka/pull/10107 > > > > > > > This is an automated message from the Apache Git Service. > To

[jira] [Updated] (KAFKA-12327) Remove MethodHandle usage in CompressionType

2021-02-13 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-12327: Fix Version/s: 2.8.0 > Remove MethodHandle usage in CompressionType >

[GitHub] [kafka] ijuma commented on pull request #10123: KAFKA-12327: Remove MethodHandle usage in CompressionType

2021-02-13 Thread GitBox
ijuma commented on pull request #10123: URL: https://github.com/apache/kafka/pull/10123#issuecomment-778637526 @chia7712 Thoughts on this change? This is an automated message from the Apache Git Service. To respond to the mes

[jira] [Commented] (KAFKA-7025) Android client support

2021-02-13 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17284234#comment-17284234 ] Ismael Juma commented on KAFKA-7025: I submitted a PR that removes method handle usag

[GitHub] [kafka] ijuma opened a new pull request #10123: KAFKA-12327: Remove MethodHandle usage in CompressionType

2021-02-13 Thread GitBox
ijuma opened a new pull request #10123: URL: https://github.com/apache/kafka/pull/10123 We don't really need it and it causes problems in older Android versions and GraalVM usage. Move the logic to separate classes that are only invoked when the relevant compression library is a

[jira] [Created] (KAFKA-12327) Remove MethodHandle usage in CompressionType

2021-02-13 Thread Ismael Juma (Jira)
Ismael Juma created KAFKA-12327: --- Summary: Remove MethodHandle usage in CompressionType Key: KAFKA-12327 URL: https://issues.apache.org/jira/browse/KAFKA-12327 Project: Kafka Issue Type: Improv

[jira] [Assigned] (KAFKA-7025) Android client support

2021-02-13 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma reassigned KAFKA-7025: -- Assignee: (was: Ismael Juma) > Android client support > -- > >

[jira] [Assigned] (KAFKA-7025) Android client support

2021-02-13 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma reassigned KAFKA-7025: -- Assignee: Ismael Juma > Android client support > -- > > Ke

[GitHub] [kafka] ijuma merged pull request #10120: MINOR: Update zstd and use classes with no finalizers

2021-02-13 Thread GitBox
ijuma merged pull request #10120: URL: https://github.com/apache/kafka/pull/10120 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[jira] [Commented] (KAFKA-10360) Disabling JmxReporter registration

2021-02-13 Thread Jaikiran Pai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17284208#comment-17284208 ] Jaikiran Pai commented on KAFKA-10360: -- I think this would be a useful enhancement.

[GitHub] [kafka] vamossagar12 commented on a change in pull request #10052: KAFKA-12289: Adding test cases for prefix scan in InMemoryKeyValueStore

2021-02-13 Thread GitBox
vamossagar12 commented on a change in pull request #10052: URL: https://github.com/apache/kafka/pull/10052#discussion_r575662025 ## File path: streams/src/test/java/org/apache/kafka/streams/state/internals/InMemoryKeyValueStoreTest.java ## @@ -60,4 +67,22 @@ public void should

[jira] [Commented] (KAFKA-6500) Can not build aggregatedJavadoc

2021-02-13 Thread Jyotinder Singh (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-6500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17284162#comment-17284162 ] Jyotinder Singh commented on KAFKA-6500: I'm pretty late to this thread, but I wa

[GitHub] [kafka] dajac commented on pull request #10122: KAFKA-12326: Corrected regresion in MirrorMaker 2 executable introduced with KAFKA-10021

2021-02-13 Thread GitBox
dajac commented on pull request #10122: URL: https://github.com/apache/kafka/pull/10122#issuecomment-778592209 @rhauch Should we backport it to 2.8 branch as well? This is an automated message from the Apache Git Service. To