[
https://issues.apache.org/jira/browse/KAFKA-12384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kamal Chandraprakash reassigned KAFKA-12384:
Assignee: Kamal Chandraprakash
> Flaky Test
guozhangwang opened a new pull request #10231:
URL: https://github.com/apache/kafka/pull/10231
@ableegoldman @rodesai
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify
chia7712 commented on a change in pull request #9758:
URL: https://github.com/apache/kafka/pull/9758#discussion_r584225973
##
File path:
clients/src/main/java/org/apache/kafka/common/requests/FetchResponse.java
##
@@ -304,58 +115,12 @@ public int sessionId() {
public Map
Chia-Ping Tsai created KAFKA-12387:
--
Summary: Avoid unnecessary copy of FetchResponse data in
handleFetchRequest
Key: KAFKA-12387
URL: https://issues.apache.org/jira/browse/KAFKA-12387
Project:
chia7712 commented on a change in pull request #9758:
URL: https://github.com/apache/kafka/pull/9758#discussion_r584224981
##
File path: core/src/main/scala/kafka/server/KafkaApis.scala
##
@@ -761,76 +754,80 @@ class KafkaApis(val requestChannel: RequestChannel,
chia7712 commented on a change in pull request #9758:
URL: https://github.com/apache/kafka/pull/9758#discussion_r584224855
##
File path: core/src/main/scala/kafka/server/KafkaApis.scala
##
@@ -761,76 +754,80 @@ class KafkaApis(val requestChannel: RequestChannel,
chia7712 commented on a change in pull request #9758:
URL: https://github.com/apache/kafka/pull/9758#discussion_r584224750
##
File path: core/src/main/scala/kafka/server/KafkaApis.scala
##
@@ -761,76 +754,80 @@ class KafkaApis(val requestChannel: RequestChannel,
chia7712 commented on a change in pull request #9758:
URL: https://github.com/apache/kafka/pull/9758#discussion_r584224693
##
File path: core/src/main/scala/kafka/server/KafkaApis.scala
##
@@ -761,76 +754,80 @@ class KafkaApis(val requestChannel: RequestChannel,
chia7712 commented on a change in pull request #9758:
URL: https://github.com/apache/kafka/pull/9758#discussion_r584222449
##
File path:
jmh-benchmarks/src/main/java/org/apache/kafka/jmh/fetchsession/FetchSessionBenchmark.java
##
@@ -70,24 +70,25 @@ public void setUp() {
chia7712 commented on a change in pull request #9758:
URL: https://github.com/apache/kafka/pull/9758#discussion_r584222409
##
File path:
jmh-benchmarks/src/main/java/org/apache/kafka/jmh/common/FetchResponseBenchmark.java
##
@@ -78,19 +78,25 @@ public void setup() {
chia7712 commented on a change in pull request #9758:
URL: https://github.com/apache/kafka/pull/9758#discussion_r584222186
##
File path:
jmh-benchmarks/src/main/java/org/apache/kafka/jmh/fetcher/ReplicaFetcherThreadBenchmark.java
##
@@ -174,8 +173,14 @@ public int
chia7712 commented on a change in pull request #9758:
URL: https://github.com/apache/kafka/pull/9758#discussion_r584221983
##
File path: core/src/main/scala/kafka/server/AbstractFetcherThread.scala
##
@@ -734,7 +730,7 @@ abstract class AbstractFetcherThread(name: String,
chia7712 commented on a change in pull request #9758:
URL: https://github.com/apache/kafka/pull/9758#discussion_r584221805
##
File path: core/src/main/scala/kafka/server/AbstractFetcherThread.scala
##
@@ -340,7 +336,8 @@ abstract class AbstractFetcherThread(name: String,
chia7712 commented on a change in pull request #9758:
URL: https://github.com/apache/kafka/pull/9758#discussion_r584221661
##
File path:
clients/src/main/java/org/apache/kafka/common/requests/FetchResponse.java
##
@@ -365,17 +123,70 @@ public int sessionId() {
* @param
chia7712 commented on a change in pull request #9758:
URL: https://github.com/apache/kafka/pull/9758#discussion_r584221036
##
File path:
clients/src/main/java/org/apache/kafka/common/requests/FetchResponse.java
##
@@ -365,17 +123,70 @@ public int sessionId() {
* @param
ahuja0007 closed pull request #10230:
URL: https://github.com/apache/kafka/pull/10230
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
ahuja0007 opened a new pull request #10230:
URL: https://github.com/apache/kafka/pull/10230
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of
ijuma commented on a change in pull request #9758:
URL: https://github.com/apache/kafka/pull/9758#discussion_r584172530
##
File path:
clients/src/main/java/org/apache/kafka/common/requests/FetchResponse.java
##
@@ -365,17 +123,70 @@ public int sessionId() {
* @param
[
https://issues.apache.org/jira/browse/KAFKA-12386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ismael Juma updated KAFKA-12386:
Description:
We could strengthen the guarantees kafka provides after an unclean shutdown by
ijuma commented on a change in pull request #8812:
URL: https://github.com/apache/kafka/pull/8812#discussion_r584167690
##
File path: core/src/main/scala/kafka/log/Log.scala
##
@@ -826,8 +832,16 @@ class Log(@volatile private var _dir: File,
preallocate =
Ismael Juma created KAFKA-12386:
---
Summary: Flush unflushed segments during recovery
Key: KAFKA-12386
URL: https://issues.apache.org/jira/browse/KAFKA-12386
Project: Kafka
Issue Type:
chia7712 commented on a change in pull request #9758:
URL: https://github.com/apache/kafka/pull/9758#discussion_r584165033
##
File path:
clients/src/main/java/org/apache/kafka/common/requests/FetchResponse.java
##
@@ -57,238 +56,39 @@
* the fetch offset after the index
Chia-Ping Tsai created KAFKA-12385:
--
Summary: Remove FetchResponse#responseData
Key: KAFKA-12385
URL: https://issues.apache.org/jira/browse/KAFKA-12385
Project: Kafka
Issue Type: Bug
chia7712 commented on a change in pull request #10203:
URL: https://github.com/apache/kafka/pull/10203#discussion_r584164200
##
File path: build.gradle
##
@@ -1104,33 +1127,24 @@ project(':generator') {
project(':clients') {
archivesBaseName = "kafka-clients"
-
jolshan edited a comment on pull request #10223:
URL: https://github.com/apache/kafka/pull/10223#issuecomment-787106214
It also seems like this part of KafkaApis is completely rewritten in
https://github.com/apache/kafka/pull/10184. So maybe any changes to KafkaApis
should be addressed in
jolshan commented on pull request #10223:
URL: https://github.com/apache/kafka/pull/10223#issuecomment-787106214
It also seems like this code is completely rewritten in
https://github.com/apache/kafka/pull/10184. So maybe any changes to KafkaApis
should be addressed in that PR?
jolshan commented on a change in pull request #10184:
URL: https://github.com/apache/kafka/pull/10184#discussion_r584162388
##
File path: core/src/main/scala/kafka/server/ControllerApis.scala
##
@@ -154,6 +163,162 @@ class ControllerApis(val requestChannel: RequestChannel,
jolshan commented on a change in pull request #10223:
URL: https://github.com/apache/kafka/pull/10223#discussion_r584161936
##
File path: core/src/main/scala/kafka/server/KafkaApis.scala
##
@@ -1884,20 +1884,24 @@ class KafkaApis(val requestChannel: RequestChannel,
val
jolshan commented on a change in pull request #10184:
URL: https://github.com/apache/kafka/pull/10184#discussion_r584161583
##
File path: core/src/main/scala/kafka/server/ControllerApis.scala
##
@@ -154,6 +161,147 @@ class ControllerApis(val requestChannel: RequestChannel,
jolshan commented on a change in pull request #10184:
URL: https://github.com/apache/kafka/pull/10184#discussion_r584161583
##
File path: core/src/main/scala/kafka/server/ControllerApis.scala
##
@@ -154,6 +161,147 @@ class ControllerApis(val requestChannel: RequestChannel,
ijuma commented on pull request #10203:
URL: https://github.com/apache/kafka/pull/10203#issuecomment-787104240
@mjsax @guozhangwang @vvcephei Can one of you review the build changes for
the stream modules and check if they all make sense?
ijuma commented on a change in pull request #10203:
URL: https://github.com/apache/kafka/pull/10203#discussion_r584160401
##
File path: build.gradle
##
@@ -2026,52 +2043,53 @@ project(':connect:runtime') {
archivesBaseName = "connect-runtime"
dependencies {
-
-
ijuma commented on a change in pull request #10203:
URL: https://github.com/apache/kafka/pull/10203#discussion_r584160375
##
File path: build.gradle
##
@@ -1401,33 +1416,35 @@ project(':streams') {
ext.buildStreamsVersionFileName = "kafka-streams-version.properties"
ijuma commented on a change in pull request #10203:
URL: https://github.com/apache/kafka/pull/10203#discussion_r584159269
##
File path: build.gradle
##
@@ -1104,33 +1127,24 @@ project(':generator') {
project(':clients') {
archivesBaseName = "kafka-clients"
-
ijuma commented on a change in pull request #9758:
URL: https://github.com/apache/kafka/pull/9758#discussion_r584151716
##
File path:
clients/src/main/java/org/apache/kafka/common/requests/FetchResponse.java
##
@@ -57,238 +56,39 @@
* the fetch offset after the index
chia7712 commented on a change in pull request #9758:
URL: https://github.com/apache/kafka/pull/9758#discussion_r584148817
##
File path:
clients/src/main/java/org/apache/kafka/common/requests/FetchResponse.java
##
@@ -57,238 +56,39 @@
* the fetch offset after the index
chia7712 commented on a change in pull request #10203:
URL: https://github.com/apache/kafka/pull/10203#discussion_r584141982
##
File path: build.gradle
##
@@ -1401,33 +1416,35 @@ project(':streams') {
ext.buildStreamsVersionFileName = "kafka-streams-version.properties"
hachikuji commented on a change in pull request #10223:
URL: https://github.com/apache/kafka/pull/10223#discussion_r584145063
##
File path: core/src/main/scala/kafka/server/KafkaApis.scala
##
@@ -1884,20 +1884,24 @@ class KafkaApis(val requestChannel: RequestChannel,
ijuma commented on a change in pull request #9758:
URL: https://github.com/apache/kafka/pull/9758#discussion_r584142186
##
File path:
clients/src/main/java/org/apache/kafka/common/requests/FetchResponse.java
##
@@ -57,238 +56,39 @@
* the fetch offset after the index
ijuma commented on a change in pull request #9758:
URL: https://github.com/apache/kafka/pull/9758#discussion_r584142074
##
File path:
clients/src/main/java/org/apache/kafka/common/requests/FetchResponse.java
##
@@ -57,238 +56,39 @@
* the fetch offset after the index
ijuma commented on a change in pull request #9758:
URL: https://github.com/apache/kafka/pull/9758#discussion_r584141887
##
File path:
clients/src/main/java/org/apache/kafka/common/requests/FetchResponse.java
##
@@ -57,238 +56,39 @@
* the fetch offset after the index
ijuma commented on pull request #10184:
URL: https://github.com/apache/kafka/pull/10184#issuecomment-787089355
@cmccabe I pushed a commit that removes a bunch of unnecessary `asScala`
conversions (even though these don't copy the collection, they add a shallow
allocation and indirection
chia7712 commented on a change in pull request #10184:
URL: https://github.com/apache/kafka/pull/10184#discussion_r584139776
##
File path: core/src/main/scala/kafka/server/ControllerApis.scala
##
@@ -154,6 +163,162 @@ class ControllerApis(val requestChannel: RequestChannel,
chia7712 commented on a change in pull request #10184:
URL: https://github.com/apache/kafka/pull/10184#discussion_r584139113
##
File path: core/src/main/scala/kafka/server/ControllerApis.scala
##
@@ -154,6 +163,162 @@ class ControllerApis(val requestChannel: RequestChannel,
ijuma commented on a change in pull request #10203:
URL: https://github.com/apache/kafka/pull/10203#discussion_r584139127
##
File path: build.gradle
##
@@ -2026,52 +2043,53 @@ project(':connect:runtime') {
archivesBaseName = "connect-runtime"
dependencies {
-
-
sknop commented on pull request #9950:
URL: https://github.com/apache/kafka/pull/9950#issuecomment-787084819
Thank you @rhauch. Just to make sure I understand this correctly - the types
mentioned in the cast string are the _target_ casts, not the source tasks. The
current code does not
chia7712 commented on pull request #10223:
URL: https://github.com/apache/kafka/pull/10223#issuecomment-787081242
Not sure whether it is possible to have a helper method to process this
complicated code for both `KafkaApis` and `ControllApis`.
chia7712 commented on a change in pull request #10223:
URL: https://github.com/apache/kafka/pull/10223#discussion_r584123786
##
File path: core/src/main/scala/kafka/server/KafkaApis.scala
##
@@ -1874,7 +1874,7 @@ class KafkaApis(val requestChannel: RequestChannel,
if
dengziming commented on a change in pull request #10223:
URL: https://github.com/apache/kafka/pull/10223#discussion_r584100885
##
File path: core/src/test/scala/unit/kafka/server/KafkaApisTest.scala
##
@@ -3479,6 +3481,161 @@ class KafkaApisTest {
dajac commented on a change in pull request #10223:
URL: https://github.com/apache/kafka/pull/10223#discussion_r584092454
##
File path: core/src/main/scala/kafka/server/KafkaApis.scala
##
@@ -1884,20 +1884,24 @@ class KafkaApis(val requestChannel: RequestChannel,
val
[
https://issues.apache.org/jira/browse/KAFKA-10526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17291485#comment-17291485
]
Sagar Rao edited comment on KAFKA-10526 at 2/27/21, 8:15 AM:
-
[~hachikuji],
omkreddy commented on pull request #10059:
URL: https://github.com/apache/kafka/pull/10059#issuecomment-787034333
@dpoldrugo Currently we don't have plan for 2.5.2 release. also we normally
backport only critical/blocker fixes. not sure if this comes under this
category.
52 matches
Mail list logo
