dajac commented on a change in pull request #10234:
URL: https://github.com/apache/kafka/pull/10234#discussion_r586188217
##
File path:
clients/src/main/java/org/apache/kafka/common/requests/LeaderAndIsrRequest.java
##
@@ -145,24 +145,22 @@ public LeaderAndIsrResponse getError
chia7712 commented on a change in pull request #10184:
URL: https://github.com/apache/kafka/pull/10184#discussion_r586131042
##
File path: core/src/main/scala/kafka/server/ControllerApis.scala
##
@@ -154,17 +162,164 @@ class ControllerApis(val requestChannel: RequestChannel,
satishd commented on pull request #10173:
URL: https://github.com/apache/kafka/pull/10173#issuecomment-789442937
@junrao thanks for the comment, added all public classes to javadoc section
in build.gradle.
This is an automa
satishd commented on a change in pull request #10173:
URL: https://github.com/apache/kafka/pull/10173#discussion_r586119132
##
File path:
clients/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogMetadataManager.java
##
@@ -0,0 +1,196 @@
+/*
+ * Licensed to the
[
https://issues.apache.org/jira/browse/KAFKA-10340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17294278#comment-17294278
]
A. Sophie Blee-Goldman edited comment on KAFKA-10340 at 3/3/21, 4:58 AM:
-
hachikuji opened a new pull request #10252:
URL: https://github.com/apache/kafka/pull/10252
This patch implements additional handling logic for `RemoveTopic` records:
- Update `MetadataPartitions` to ensure addition of deleted partitions to
`localRemoved` set
- Ensure topic config
[
https://issues.apache.org/jira/browse/KAFKA-10340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17294278#comment-17294278
]
A. Sophie Blee-Goldman commented on KAFKA-10340:
Temporarily removed 2.6
[
https://issues.apache.org/jira/browse/KAFKA-10340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. Sophie Blee-Goldman updated KAFKA-10340:
---
Fix Version/s: (was: 2.6.2)
> Source connectors should report error when
[
https://issues.apache.org/jira/browse/KAFKA-12400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Manikumar resolved KAFKA-12400.
---
Resolution: Fixed
Issue resolved by pull request 10245
[https://github.com/apache/kafka/pull/10245]
omkreddy closed pull request #10245:
URL: https://github.com/apache/kafka/pull/10245
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
chia7712 merged pull request #10250:
URL: https://github.com/apache/kafka/pull/10250
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
chia7712 commented on pull request #10250:
URL: https://github.com/apache/kafka/pull/10250#issuecomment-789420972
> do you want to merge this? We should also cherrypick it all the way back
to 2.6
Sure. will merge and backport this patch.
---
ableegoldman commented on pull request #10250:
URL: https://github.com/apache/kafka/pull/10250#issuecomment-789420651
@chia7712 do you want to merge this? We should also cherrypick it all the
way back to 2.6
This is an auto
ableegoldman commented on pull request #10250:
URL: https://github.com/apache/kafka/pull/10250#issuecomment-789420529
One unrelated test failure which is known to be flaky:
`TransactionsBounceTest.testWithGroupMetadata`
This
ableegoldman commented on a change in pull request #10251:
URL: https://github.com/apache/kafka/pull/10251#discussion_r586100402
##
File path: docs/ops.html
##
@@ -2356,6 +2356,26 @@
[
https://issues.apache.org/jira/browse/KAFKA-12389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Manikumar resolved KAFKA-12389.
---
Fix Version/s: 2.8.0
2.6.2
2.7.1
Resolution: Fixed
Issu
dongjinleekr commented on pull request #10235:
URL: https://github.com/apache/kafka/pull/10235#issuecomment-789416305
@ableegoldman FYI. :smiley:
This is an automated message from the Apache Git Service.
To respond to the me
ableegoldman commented on pull request #10251:
URL: https://github.com/apache/kafka/pull/10251#issuecomment-789415834
call for review @cadonna @vvcephei @guozhangwang -- in theory we should
cherrypick this back to 2.8 at least, but I can prepare a separate PR against
`kafka-site` if we don
ableegoldman opened a new pull request #10251:
URL: https://github.com/apache/kafka/pull/10251
I missed updating the documentation for these metrics since I didn't notice
we had Streams metrics docs outside of the usual Streams docs.
---
omkreddy closed pull request #10235:
URL: https://github.com/apache/kafka/pull/10235
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
chia7712 commented on a change in pull request #10193:
URL: https://github.com/apache/kafka/pull/10193#discussion_r586082468
##
File path:
clients/src/main/java/org/apache/kafka/common/protocol/types/Type.java
##
@@ -320,7 +320,7 @@ public Long validate(Object item) {
abbccdda commented on pull request #10240:
URL: https://github.com/apache/kafka/pull/10240#issuecomment-789380164
After offline sync with @hachikuji , we decided that the invalid replication
factor check would be redundant to be performed on the forwarding broker. Will
remove that logic to
dengziming commented on pull request #10250:
URL: https://github.com/apache/kafka/pull/10250#issuecomment-789374413
@ableegoldman PTAL.
This is an automated message from the Apache Git Service.
To respond to the message, plea
dengziming opened a new pull request #10250:
URL: https://github.com/apache/kafka/pull/10250
*More detailed description of your change*
Found that the `fatalException` is always null when calling `log.info("xxx",
fatalException)`, maybe we should first assign a value to it.
*S
dengziming closed pull request #10247:
URL: https://github.com/apache/kafka/pull/10247
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
dengziming commented on a change in pull request #10247:
URL: https://github.com/apache/kafka/pull/10247#discussion_r586046025
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java
##
@@ -860,7 +860,7 @@ public void onSuccess(
[
https://issues.apache.org/jira/browse/KAFKA-10251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17294210#comment-17294210
]
Luke Chen commented on KAFKA-10251:
---
Interesting. Let me check it. Thanks.
> Flaky Te
rondagostino commented on pull request #10184:
URL: https://github.com/apache/kafka/pull/10184#issuecomment-789350896
```
[2021-03-02T22:42:17.438Z] [ant:checkstyle] [ERROR]
/home/jenkins/jenkins-agent/workspace/Kafka_kafka-pr_PR-10184/metadata/src/main/java/org/apache/kafka/controller/R
dongjinleekr commented on pull request #10245:
URL: https://github.com/apache/kafka/pull/10245#issuecomment-789347793
@ableegoldman I think this should be a blocker, since it is security
vulnerability.
This is an automated m
ableegoldman commented on pull request #10215:
URL: https://github.com/apache/kafka/pull/10215#issuecomment-789326289
Merged to trunk and cherrypicked to 2.8 cc @vvcephei
This is an automated message from the Apache Git Serv
ableegoldman merged pull request #10215:
URL: https://github.com/apache/kafka/pull/10215
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
ableegoldman commented on pull request #10215:
URL: https://github.com/apache/kafka/pull/10215#issuecomment-789323390
One unrelated failure `TransactionsBounceTest.testWithGroupId() ` (known to
be flaky, see KAFKA-10251)
Thi
[
https://issues.apache.org/jira/browse/KAFKA-10251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. Sophie Blee-Goldman reopened KAFKA-10251:
Looks like it's still failing – saw at least one test failure on a build which
[
https://issues.apache.org/jira/browse/KAFKA-12254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rajini Sivaram updated KAFKA-12254:
---
Fix Version/s: (was: 3.0.0)
> MirrorMaker 2.0 creates destination topic with default con
ableegoldman commented on pull request #10245:
URL: https://github.com/apache/kafka/pull/10245#issuecomment-789260883
What's the status here? Is this a blocker for the 2.6.2 release?
This is an automated message from the Apac
cmccabe commented on pull request #10184:
URL: https://github.com/apache/kafka/pull/10184#issuecomment-789256987
Thanks for the reviews! I reworked the authentication, validation, and
de-duplication code a lot. The new logic should take into account the issues
pointed out here. I resolved
hachikuji commented on pull request #10184:
URL: https://github.com/apache/kafka/pull/10184#issuecomment-789254543
@rondagostino I believe that error will be fixed by
https://issues.apache.org/jira/browse/KAFKA-12403.
This i
cmccabe commented on a change in pull request #10184:
URL: https://github.com/apache/kafka/pull/10184#discussion_r585942960
##
File path:
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java
##
@@ -809,6 +824,27 @@ private QuorumController(LogContext logCon
cmccabe commented on a change in pull request #10184:
URL: https://github.com/apache/kafka/pull/10184#discussion_r585942730
##
File path:
metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java
##
@@ -349,6 +357,16 @@ public void replay(PartitionChang
[
https://issues.apache.org/jira/browse/KAFKA-3988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17294009#comment-17294009
]
Ewen Cheslack-Postava commented on KAFKA-3988:
--
[~pachima...@gmail.com] It's
junrao commented on a change in pull request #10173:
URL: https://github.com/apache/kafka/pull/10173#discussion_r585934097
##
File path:
clients/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogMetadataManager.java
##
@@ -0,0 +1,196 @@
+/*
+ * Licensed to the
rondagostino commented on pull request #10184:
URL: https://github.com/apache/kafka/pull/10184#issuecomment-789243745
The below, if added as `tests/kafkatest/sanity_checks/test_delete_topic.py`,
fails for the Raft cases on this PR branch as of this moment because the broker
fails to shutdo
[
https://issues.apache.org/jira/browse/KAFKA-3988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17294004#comment-17294004
]
Laxman Pachimadla commented on KAFKA-3988:
--
[~ewencp] Hi Ewen, do you have any l
rondagostino commented on a change in pull request #10227:
URL: https://github.com/apache/kafka/pull/10227#discussion_r585924508
##
File path: KIP-500.md
##
@@ -0,0 +1,131 @@
+KIP-500 Early Access Release
+
+
+# Introduction
+It is now possible to ru
[
https://issues.apache.org/jira/browse/KAFKA-12377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17293992#comment-17293992
]
Matthias J. Sax commented on KAFKA-12377:
-
Failed again.
> Flaky Test SaslAuthe
[
https://issues.apache.org/jira/browse/KAFKA-12177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jun Rao resolved KAFKA-12177.
-
Fix Version/s: 3.0.0
Assignee: Lucas Bradstreet
Resolution: Fixed
merged the PR to trunk
junrao merged pull request #10216:
URL: https://github.com/apache/kafka/pull/10216
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
[
https://issues.apache.org/jira/browse/KAFKA-12238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gustafson updated KAFKA-12238:
Fix Version/s: 2.8.0
> Implement DescribeProducers API
> ---
>
[
https://issues.apache.org/jira/browse/KAFKA-12267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gustafson updated KAFKA-12267:
Fix Version/s: 3.0.0
> Implement DescribeTransactions API
> --
[
https://issues.apache.org/jira/browse/KAFKA-12369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gustafson resolved KAFKA-12369.
-
Fix Version/s: 3.0.0
Resolution: Fixed
> Implement ListTransactions API
> ---
hachikuji merged pull request #10206:
URL: https://github.com/apache/kafka/pull/10206
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
ijuma commented on a change in pull request #10141:
URL: https://github.com/apache/kafka/pull/10141#discussion_r585901281
##
File path: core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala
##
@@ -812,6 +812,26 @@ object ReassignPartitionsCommand extends Logging {
ijuma commented on a change in pull request #10141:
URL: https://github.com/apache/kafka/pull/10141#discussion_r585900837
##
File path: core/src/main/scala/kafka/admin/ReassignPartitionsCommand.scala
##
@@ -812,6 +812,26 @@ object ReassignPartitionsCommand extends Logging {
ijuma commented on a change in pull request #10193:
URL: https://github.com/apache/kafka/pull/10193#discussion_r585899128
##
File path:
clients/src/main/java/org/apache/kafka/common/protocol/types/Type.java
##
@@ -320,7 +320,7 @@ public Long validate(Object item) {
ijuma commented on a change in pull request #10193:
URL: https://github.com/apache/kafka/pull/10193#discussion_r585897929
##
File path:
clients/src/main/java/org/apache/kafka/common/protocol/types/Type.java
##
@@ -320,7 +320,7 @@ public Long validate(Object item) {
jolshan commented on a change in pull request #10184:
URL: https://github.com/apache/kafka/pull/10184#discussion_r585895209
##
File path: core/src/main/scala/kafka/server/ControllerApis.scala
##
@@ -154,6 +161,147 @@ class ControllerApis(val requestChannel: RequestChannel,
jolshan commented on a change in pull request #10184:
URL: https://github.com/apache/kafka/pull/10184#discussion_r585895209
##
File path: core/src/main/scala/kafka/server/ControllerApis.scala
##
@@ -154,6 +161,147 @@ class ControllerApis(val requestChannel: RequestChannel,
ijuma commented on a change in pull request #10203:
URL: https://github.com/apache/kafka/pull/10203#discussion_r585894119
##
File path: build.gradle
##
@@ -1586,15 +1605,17 @@ project(':streams:test-utils') {
archivesBaseName = "kafka-streams-test-utils"
dependencies {
cmccabe commented on a change in pull request #10184:
URL: https://github.com/apache/kafka/pull/10184#discussion_r585891911
##
File path: core/src/main/scala/kafka/server/ControllerApis.scala
##
@@ -154,6 +161,147 @@ class ControllerApis(val requestChannel: RequestChannel,
ijuma commented on a change in pull request #10203:
URL: https://github.com/apache/kafka/pull/10203#discussion_r585891145
##
File path: release.py
##
@@ -631,7 +631,7 @@ def select_gpg_key():
contents = f.read()
if not user_ok("Going to build and upload mvn artifacts base
rondagostino opened a new pull request #10249:
URL: https://github.com/apache/kafka/pull/10249
The KIP-500 early access release will not support creating a partition with
a manual partition assignment that includes a broker that is not currently
online. This patch disables system tests fo
[
https://issues.apache.org/jira/browse/KAFKA-12403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gustafson updated KAFKA-12403:
Labels: kip-500 (was: )
> Broker handling of delete topic events
> --
ableegoldman merged pull request #10163:
URL: https://github.com/apache/kafka/pull/10163
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
ableegoldman commented on pull request #10163:
URL: https://github.com/apache/kafka/pull/10163#issuecomment-789174791
Java11 failed with unrelated flaky
`kafka.server.ListOffsetsRequestTest.testResponseIncludesLeaderEpoch`, Java15
failed with `Execution failed for task ':streams:test-utils
Jason Gustafson created KAFKA-12403:
---
Summary: Broker handling of delete topic events
Key: KAFKA-12403
URL: https://issues.apache.org/jira/browse/KAFKA-12403
Project: Kafka
Issue Type: Impr
[
https://issues.apache.org/jira/browse/KAFKA-12254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
John Roesler updated KAFKA-12254:
-
Fix Version/s: 2.8.0
> MirrorMaker 2.0 creates destination topic with default configs
>
ableegoldman commented on a change in pull request #10163:
URL: https://github.com/apache/kafka/pull/10163#discussion_r585863461
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/ChangelogTopics.java
##
@@ -0,0 +1,132 @@
+/*
+ * Licensed to the A
[
https://issues.apache.org/jira/browse/KAFKA-10251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17293953#comment-17293953
]
A. Sophie Blee-Goldman commented on KAFKA-10251:
Merged [https://github.
ableegoldman merged pull request #10228:
URL: https://github.com/apache/kafka/pull/10228
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
ableegoldman commented on pull request #10228:
URL: https://github.com/apache/kafka/pull/10228#issuecomment-789166076
Since this test is failing pretty regularly, I think we should go ahead and
merge this now. A 30s timeout is pretty standard and if there is a real issue,
just bumping the
ableegoldman commented on a change in pull request #10247:
URL: https://github.com/apache/kafka/pull/10247#discussion_r585856635
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java
##
@@ -860,7 +860,7 @@ public void onSucces
ableegoldman commented on pull request #10228:
URL: https://github.com/apache/kafka/pull/10228#issuecomment-789162142
Three unrelated failures:
```
Build / JDK 15 /
org.apache.kafka.connect.integration.RebalanceSourceConnectorsIntegrationTest.testMultipleWorkersRejoining
Build / JD
sknop commented on pull request #9950:
URL: https://github.com/apache/kafka/pull/9950#issuecomment-789161208
Yes of course, totally agree.
This is an automated message from the Apache Git Service.
To respond to the message, p
rondagostino commented on a change in pull request #10237:
URL: https://github.com/apache/kafka/pull/10237#discussion_r585829658
##
File path: tests/kafkatest/services/security/security_config.py
##
@@ -374,7 +374,8 @@ def interbroker_sasl_mechanism(self):
def enabled_sasl
Ron Dagostino created KAFKA-12402:
-
Summary: client_sasl_mechanism should be an explicit list instead
of a .csv string
Key: KAFKA-12402
URL: https://issues.apache.org/jira/browse/KAFKA-12402
Project:
[
https://issues.apache.org/jira/browse/KAFKA-12319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17293926#comment-17293926
]
Matthias J. Sax commented on KAFKA-12319:
-
Failed again.
> Flaky test
> Connec
[
https://issues.apache.org/jira/browse/KAFKA-12394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jason Gustafson resolved KAFKA-12394.
-
Fix Version/s: 2.8.0
Resolution: Fixed
> Consider topic id existence and authoriz
[
https://issues.apache.org/jira/browse/KAFKA-10788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17293907#comment-17293907
]
Rohit Deshpande commented on KAFKA-10788:
-
thanks [~cadonna] makes sense to me.
hachikuji merged pull request #10223:
URL: https://github.com/apache/kafka/pull/10223
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
vanhoale commented on pull request #10239:
URL: https://github.com/apache/kafka/pull/10239#issuecomment-789110876
I ran my test, checkstyle and spotbugs successful at my local, but not sure
some checks failed here
This is an
hachikuji commented on a change in pull request #10206:
URL: https://github.com/apache/kafka/pull/10206#discussion_r585800691
##
File path:
core/src/test/scala/integration/kafka/api/AuthorizerIntegrationTest.scala
##
@@ -1813,17 +1813,25 @@ class AuthorizerIntegrationTest exte
[
https://issues.apache.org/jira/browse/KAFKA-10251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17293885#comment-17293885
]
Matthias J. Sax edited comment on KAFKA-10251 at 3/2/21, 6:11 PM:
Matthias J. Sax created KAFKA-12401:
---
Summary: Flaky Test
FeatureCommandTest#testUpgradeAllFeaturesSuccess
Key: KAFKA-12401
URL: https://issues.apache.org/jira/browse/KAFKA-12401
Project: Kafka
[
https://issues.apache.org/jira/browse/KAFKA-8003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17293889#comment-17293889
]
Matthias J. Sax commented on KAFKA-8003:
A third test method:
{quote}org.opentest
rhauch commented on pull request #9950:
URL: https://github.com/apache/kafka/pull/9950#issuecomment-789100759
If we don't clarify the documentation, then I think users will be very
confused. Can you take a stab at improving/expanding the documentation a bit to
clarify the input and output
[
https://issues.apache.org/jira/browse/KAFKA-10251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17293885#comment-17293885
]
Matthias J. Sax commented on KAFKA-10251:
-
One more.
> Flaky Test kafka.api.Tra
chia7712 commented on a change in pull request #10206:
URL: https://github.com/apache/kafka/pull/10206#discussion_r585784412
##
File path:
core/src/test/scala/integration/kafka/api/AuthorizerIntegrationTest.scala
##
@@ -1813,17 +1813,25 @@ class AuthorizerIntegrationTest exten
mumrah merged pull request #10224:
URL: https://github.com/apache/kafka/pull/10224
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
mumrah commented on a change in pull request #10237:
URL: https://github.com/apache/kafka/pull/10237#discussion_r585784850
##
File path: tests/kafkatest/services/security/security_config.py
##
@@ -374,7 +374,8 @@ def interbroker_sasl_mechanism(self):
def enabled_sasl_mecha
guozhangwang commented on pull request #9717:
URL: https://github.com/apache/kafka/pull/9717#issuecomment-789095693
LGTM. Merged to trunk and cherry-picked to 2.8 cc @vvcephei
This is an automated message from the Apache Git
guozhangwang merged pull request #9717:
URL: https://github.com/apache/kafka/pull/9717
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
guozhangwang commented on pull request #10052:
URL: https://github.com/apache/kafka/pull/10052#issuecomment-789094844
Cherry-picked to 2.8 as well cc @vvcephei
This is an automated message from the Apache Git Service.
To res
guozhangwang commented on pull request #10052:
URL: https://github.com/apache/kafka/pull/10052#issuecomment-789094199
LGTM. Thanks for the contribution @vamossagar12 !
This is an automated message from the Apache Git Service.
guozhangwang merged pull request #10052:
URL: https://github.com/apache/kafka/pull/10052
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
chia7712 opened a new pull request #10248:
URL: https://github.com/apache/kafka/pull/10248
This PR includes following changes
1. rename `UNSIGNED_INT32` to `UINT32` (consistent to `UINT16`)
1. make sure Type.toHtml shows `UINT16`, `UINT32` and `COMPACT_RECORDS`
### Committer
chia7712 commented on a change in pull request #10234:
URL: https://github.com/apache/kafka/pull/10234#discussion_r585723099
##
File path:
clients/src/main/java/org/apache/kafka/common/requests/LeaderAndIsrRequest.java
##
@@ -145,24 +145,22 @@ public LeaderAndIsrResponse getEr
chia7712 closed pull request #9128:
URL: https://github.com/apache/kafka/pull/9128
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
chia7712 closed pull request #10086:
URL: https://github.com/apache/kafka/pull/10086
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
hachikuji commented on pull request #10240:
URL: https://github.com/apache/kafka/pull/10240#issuecomment-789032940
Ok, I think I see what is going on now. The failing system test is verifying
what happens when inter-broker communication no longer works. This results in
different behavior b
wcarlson5 commented on a change in pull request #10215:
URL: https://github.com/apache/kafka/pull/10215#discussion_r585710809
##
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##
@@ -463,9 +464,8 @@ private void replaceStreamThread(final Throwable t
1 - 100 of 161 matches
Mail list logo
