[jira] [Commented] (KAFKA-12436) deprecate MirrorMaker v1

2021-03-06 Thread Ryanne Dolan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17296773#comment-17296773 ] Ryanne Dolan commented on KAFKA-12436: -- Thanks I'll update the ticket. > deprecate

[GitHub] [kafka] MarcoLotz commented on a change in pull request #10131: KAFKA-5146 / move kafka-streams example to a new module

2021-03-06 Thread GitBox
MarcoLotz commented on a change in pull request #10131: URL: https://github.com/apache/kafka/pull/10131#discussion_r588864401 ## File path: build.gradle ## @@ -1416,14 +1416,6 @@ project(':streams') { dependencies { api project(':clients') -// use `api` dependency

[GitHub] [kafka] ning2008wisc commented on pull request #9287: extract common functions from SourceConnector and SourceTask

2021-03-06 Thread GitBox
ning2008wisc commented on pull request #9287: URL: https://github.com/apache/kafka/pull/9287#issuecomment-792010390 thanks @mimaison @rajinisivaram or @rhauch for your attention to review This is an automated message from the

[GitHub] [kafka] ijuma commented on pull request #10272: MINOR: Various javadoc fixes

2021-03-06 Thread GitBox
ijuma commented on pull request #10272: URL: https://github.com/apache/kafka/pull/10272#issuecomment-791986296 You have to test with Java 8. I filed https://issues.apache.org/jira/browse/KAFKA-12435 for the Java 11 issue yesterday. It's not clear that there's an easy fix. ---

[jira] [Commented] (KAFKA-12436) deprecate MirrorMaker v1

2021-03-06 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17296585#comment-17296585 ] Ismael Juma commented on KAFKA-12436: - Removal would have to wait for 4.0 if depreca

[jira] [Created] (KAFKA-12436) deprecate MirrorMaker v1

2021-03-06 Thread Ryanne Dolan (Jira)
Ryanne Dolan created KAFKA-12436: Summary: deprecate MirrorMaker v1 Key: KAFKA-12436 URL: https://issues.apache.org/jira/browse/KAFKA-12436 Project: Kafka Issue Type: Improvement Co

[GitHub] [kafka] chia7712 commented on a change in pull request #10252: KAFKA-12403; Ensure local state deleted on `RemoveTopicRecord` received

2021-03-06 Thread GitBox
chia7712 commented on a change in pull request #10252: URL: https://github.com/apache/kafka/pull/10252#discussion_r52359 ## File path: core/src/main/scala/kafka/server/metadata/MetadataPartitions.scala ## @@ -171,25 +202,38 @@ class MetadataPartitionsBuilder(val brokerId: I

[GitHub] [kafka] chia7712 commented on a change in pull request #10252: KAFKA-12403; Ensure local state deleted on `RemoveTopicRecord` received

2021-03-06 Thread GitBox
chia7712 commented on a change in pull request #10252: URL: https://github.com/apache/kafka/pull/10252#discussion_r588878150 ## File path: core/src/main/scala/kafka/server/metadata/MetadataPartitions.scala ## @@ -171,25 +200,38 @@ class MetadataPartitionsBuilder(val brokerId: I

[GitHub] [kafka] chia7712 commented on a change in pull request #10272: MINOR: Various javadoc fixes

2021-03-06 Thread GitBox
chia7712 commented on a change in pull request #10272: URL: https://github.com/apache/kafka/pull/10272#discussion_r588876527 ## File path: build.gradle ## @@ -92,12 +92,6 @@ allprojects { } } - tasks.withType(Javadoc) { -// disable the crazy super-strict doclint

[GitHub] [kafka] chia7712 opened a new pull request #10274: MINOR: add missing space to errro message when setting uint16

2021-03-06 Thread GitBox
chia7712 opened a new pull request #10274: URL: https://github.com/apache/kafka/pull/10274 as title ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (includ

[GitHub] [kafka] MarcoLotz commented on a change in pull request #10131: KAFKA-5146 / move kafka-streams example to a new module

2021-03-06 Thread GitBox
MarcoLotz commented on a change in pull request #10131: URL: https://github.com/apache/kafka/pull/10131#discussion_r588864401 ## File path: build.gradle ## @@ -1416,14 +1416,6 @@ project(':streams') { dependencies { api project(':clients') -// use `api` dependency