[GitHub] [kafka] rohitrmd commented on pull request #10276: KAFKA-12253: Add tests that cover all of the cases for ReplicatedLog's validateOffsetAndEpoch

2021-03-13 Thread GitBox
rohitrmd commented on pull request #10276: URL: https://github.com/apache/kafka/pull/10276#issuecomment-798856850 @jsancio made changes as per review. This is an automated message from the Apache Git Service. To respond to th

[GitHub] [kafka] rohitrmd commented on a change in pull request #10276: KAFKA-12253: Add tests that cover all of the cases for ReplicatedLog's validateOffsetAndEpoch

2021-03-13 Thread GitBox
rohitrmd commented on a change in pull request #10276: URL: https://github.com/apache/kafka/pull/10276#discussion_r593859477 ## File path: core/src/test/scala/kafka/raft/KafkaMetadataLogTest.scala ## @@ -340,6 +340,124 @@ final class KafkaMetadataLogTest { batchBuilder.bui

[GitHub] [kafka] rohitrmd commented on a change in pull request #10276: KAFKA-12253: Add tests that cover all of the cases for ReplicatedLog's validateOffsetAndEpoch

2021-03-13 Thread GitBox
rohitrmd commented on a change in pull request #10276: URL: https://github.com/apache/kafka/pull/10276#discussion_r593859421 ## File path: core/src/test/scala/kafka/raft/KafkaMetadataLogTest.scala ## @@ -340,6 +340,124 @@ final class KafkaMetadataLogTest { batchBuilder.bui

[jira] [Updated] (KAFKA-12436) deprecate MirrorMaker v1

2021-03-13 Thread Ryanne Dolan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ryanne Dolan updated KAFKA-12436: - Description: Per KIP-382, the old MirrorMaker code (MM1) should be deprecated and subsequently r

[GitHub] [kafka] chia7712 commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

2021-03-13 Thread GitBox
chia7712 commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r593842004 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -661,11 +661,21 @@ class KafkaApis(val requestChannel: RequestChannel, val versio

[GitHub] [kafka] vamossagar12 commented on a change in pull request #10278: KAFKA-10526: leader fsync deferral on write

2021-03-13 Thread GitBox
vamossagar12 commented on a change in pull request #10278: URL: https://github.com/apache/kafka/pull/10278#discussion_r593840882 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -1876,7 +1876,7 @@ private long maybeAppendBatches(

[GitHub] [kafka] vamossagar12 commented on a change in pull request #10278: KAFKA-10526: leader fsync deferral on write

2021-03-13 Thread GitBox
vamossagar12 commented on a change in pull request #10278: URL: https://github.com/apache/kafka/pull/10278#discussion_r593840882 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -1876,7 +1876,7 @@ private long maybeAppendBatches(

[GitHub] [kafka] vamossagar12 commented on pull request #10278: KAFKA-10526: leader fsync deferral on write

2021-03-13 Thread GitBox
vamossagar12 commented on pull request #10278: URL: https://github.com/apache/kafka/pull/10278#issuecomment-798829853 > @vamossagar12 this PR only contains one commit that comments out `flushLeaderLog` is that intentional or is the PR missing other changes? Yeah @jsancio , this is ju

[jira] [Commented] (KAFKA-12396) Dedicated exception for kstreams when null key received

2021-03-13 Thread DV Singh (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17300957#comment-17300957 ] DV Singh commented on KAFKA-12396: -- I would like to work on this > Dedicated exception

[jira] [Resolved] (KAFKA-12398) Fix flaky test `ConsumerBounceTest.testClose`

2021-03-13 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot resolved KAFKA-12398. - Fix Version/s: 3.0.0 Resolution: Fixed > Fix flaky test `ConsumerBounceTest.testClose` >

[GitHub] [kafka] dajac merged pull request #10243: KAFKA-12398: Fix flaky test `ConsumerBounceTest.testClose`

2021-03-13 Thread GitBox
dajac merged pull request #10243: URL: https://github.com/apache/kafka/pull/10243 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [kafka] jolshan commented on pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

2021-03-13 Thread GitBox
jolshan commented on pull request #9944: URL: https://github.com/apache/kafka/pull/9944#issuecomment-798608479 > @jolshan Have you run both performance test and compatibility test? I've run jmh benchmarks before but not since the merge. I plan to do so again once I figure out how to

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

2021-03-13 Thread GitBox
jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r593772326 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -661,11 +661,21 @@ class KafkaApis(val requestChannel: RequestChannel, val version

[GitHub] [kafka] jolshan commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

2021-03-13 Thread GitBox
jolshan commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r593771946 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -661,11 +661,21 @@ class KafkaApis(val requestChannel: RequestChannel, val version

[GitHub] [kafka] ikdekker commented on pull request #10313: KAFKA-12456: Log "Listeners are not identical across brokers" message at WARN/INFO instead of ERROR

2021-03-13 Thread GitBox
ikdekker commented on pull request #10313: URL: https://github.com/apache/kafka/pull/10313#issuecomment-798355603 Hello Kafka Committers, this contribution is part of a university course. We would appreciate any kind of feedback. This initial PR is purposefully a very simple one for us t

[GitHub] [kafka] AsWali opened a new pull request #10313: KAFKA-12456: Log "Listeners are not identical across brokers" message at WARN/INFO instead of ERROR

2021-03-13 Thread GitBox
AsWali opened a new pull request #10313: URL: https://github.com/apache/kafka/pull/10313 Minor modification suggested in the following issue: https://issues.apache.org/jira/projects/KAFKA/issues/KAFKA-12456?filter=addedrecently ### Committer Checklist (excluded from commit message)

[GitHub] [kafka] chia7712 commented on a change in pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

2021-03-13 Thread GitBox
chia7712 commented on a change in pull request #9944: URL: https://github.com/apache/kafka/pull/9944#discussion_r593737385 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -661,11 +661,21 @@ class KafkaApis(val requestChannel: RequestChannel, val versio

[GitHub] [kafka] chia7712 merged pull request #10303: MINOR: Remove redundant inheritance from FilteringJmxReporter #onMetricRemoved

2021-03-13 Thread GitBox
chia7712 merged pull request #10303: URL: https://github.com/apache/kafka/pull/10303 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] chia7712 commented on pull request #10285: KAFKA-12442: Upgrade ZSTD JNI from 1.4.8-4 to 1.4.9-1

2021-03-13 Thread GitBox
chia7712 commented on pull request #10285: URL: https://github.com/apache/kafka/pull/10285#issuecomment-798047080 > worth cherry-picking to 2.8 if the aim is to align the versions with other projects that are releasing soon. done! ---

[jira] [Updated] (KAFKA-12454) Add ERROR logging on kafka-log-dirs when given brokerIds do not exist in current kafka cluster

2021-03-13 Thread Wenbing Shen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Wenbing Shen updated KAFKA-12454: - Affects Version/s: (was: 2.8.0) > Add ERROR logging on kafka-log-dirs when given brokerIds d