[GitHub] [kafka] dengziming opened a new pull request #10400: MINOR: fix package name in integration test

2021-03-24 Thread GitBox
dengziming opened a new pull request #10400: URL: https://github.com/apache/kafka/pull/10400 *More detailed description of your change* We set the package name to `kafka.xxx` in all other classes, so also reset the package name `IntegrationTestUtils` to `kafka.server` *Summary of

[jira] [Commented] (KAFKA-10575) StateRestoreListener#onRestoreEnd should always be triggered

2021-03-24 Thread highluck (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17308411#comment-17308411 ] highluck commented on KAFKA-10575: -- [~ableegoldman] Yes, I am willing to work. However

[GitHub] [kafka] kamalcph edited a comment on pull request #10202: KAFKA-12392: Deprecate the batch-size option in console producer

2021-03-24 Thread GitBox
kamalcph edited a comment on pull request #10202: URL: https://github.com/apache/kafka/pull/10202#issuecomment-806380925 @chia7712 @tombentley Can you comment/upvote on the KIP to deprecate this config? -- This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [kafka] kamalcph commented on pull request #10202: KAFKA-12392: Deprecate the batch-size option in console producer

2021-03-24 Thread GitBox
kamalcph commented on pull request #10202: URL: https://github.com/apache/kafka/pull/10202#issuecomment-806380925 @chia7712 Can you comment/upvote on the KIP to deprecate this config? -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[jira] [Commented] (KAFKA-12478) Consumer group may lose data for newly expanded partitions when add partitions for topic if the group is set to consume from the latest

2021-03-24 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17308383#comment-17308383 ] Guozhang Wang commented on KAFKA-12478: --- Hello [~hudeqi] Thanks for the updates. I

[jira] [Updated] (KAFKA-12549) Allow state stores to opt-in transactional support

2021-03-24 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-12549: -- Description: Right now Kafka Stream's EOS implementation does not make any assumptions about

[GitHub] [kafka] satishd commented on pull request #10218: KAFKA-12368: Added inmemory implementations for RemoteStorageManager and RemoteLogMetadataManager.

2021-03-24 Thread GitBox
satishd commented on pull request #10218: URL: https://github.com/apache/kafka/pull/10218#issuecomment-806359943 @kowshik I discussed the proposed changes in the call on 23rd, and I mentioned that PR is not updated with those changes. I will let you know once those changes are pushed into

[GitHub] [kafka] ijuma edited a comment on pull request #10399: MINOR: Use Java 11 for generating aggregated javadoc

2021-03-24 Thread GitBox
ijuma edited a comment on pull request #10399: URL: https://github.com/apache/kafka/pull/10399#issuecomment-806344373 JDK 8: ![image](https://user-images.githubusercontent.com/24747/112416216-78ac7e00-8ce2-11eb-9362-51dde3266dbe.png) JDK 11: ![image](https://user-images.github

[GitHub] [kafka] ijuma edited a comment on pull request #10399: MINOR: Use Java 11 for generating aggregated javadoc

2021-03-24 Thread GitBox
ijuma edited a comment on pull request #10399: URL: https://github.com/apache/kafka/pull/10399#issuecomment-806344373 JDK 8: ![image](https://user-images.githubusercontent.com/24747/112416216-78ac7e00-8ce2-11eb-9362-51dde3266dbe.png) JDK 11: ![image](https://user-images.github

[GitHub] [kafka] ijuma commented on pull request #10399: MINOR: Use Java 11 for generating aggregated javadoc

2021-03-24 Thread GitBox
ijuma commented on pull request #10399: URL: https://github.com/apache/kafka/pull/10399#issuecomment-806344373 ![image](https://user-images.githubusercontent.com/24747/112416216-78ac7e00-8ce2-11eb-9362-51dde3266dbe.png) ![image](https://user-images.githubusercontent.com/24747/112416

[jira] [Resolved] (KAFKA-12540) Sub-key support to avoid unnecessary rekey operations with new key is a compound key of the original key + sub-field

2021-03-24 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman resolved KAFKA-12540. Resolution: Duplicate > Sub-key support to avoid unnecessary rekey operati

[GitHub] [kafka] ijuma opened a new pull request #10399: MINOR: Use Java 11 for generating aggregated javadoc

2021-03-24 Thread GitBox
ijuma opened a new pull request #10399: URL: https://github.com/apache/kafka/pull/10399 Java 11 generates html5 pages with support for searching. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI buil

[GitHub] [kafka] ijuma merged pull request #10394: MINOR: Always apply the java-library gradle plugin

2021-03-24 Thread GitBox
ijuma merged pull request #10394: URL: https://github.com/apache/kafka/pull/10394 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please c

[jira] [Resolved] (KAFKA-12434) Admin API for DescribeProducers

2021-03-24 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-12434. - Resolution: Fixed > Admin API for DescribeProducers > --- >

[jira] [Updated] (KAFKA-12434) Admin API for DescribeProducers

2021-03-24 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson updated KAFKA-12434: Fix Version/s: 3.0.0 > Admin API for DescribeProducers > --- >

[GitHub] [kafka] hachikuji merged pull request #10275: KAFKA-12434; Admin support for `DescribeProducers` API

2021-03-24 Thread GitBox
hachikuji merged pull request #10275: URL: https://github.com/apache/kafka/pull/10275 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, plea

[GitHub] [kafka] hachikuji commented on pull request #10275: KAFKA-12434; Admin support for `DescribeProducers` API

2021-03-24 Thread GitBox
hachikuji commented on pull request #10275: URL: https://github.com/apache/kafka/pull/10275#issuecomment-806331897 Merging to trunk. @chia7712 Yeah, we should create some jiras. I was going to wait until the other use cases in KIP-664 had been fleshed out, but I guess there's no harm conve

[jira] [Commented] (KAFKA-12540) Sub-key support to avoid unnecessary rekey operations with new key is a compound key of the original key + sub-field

2021-03-24 Thread Antony Stubbs (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17308320#comment-17308320 ] Antony Stubbs commented on KAFKA-12540: --- Yes Sophie, I think having the links is g

[GitHub] [kafka] hachikuji opened a new pull request #10398: MINOR: Fix newly added flaky test `testClientSideTimeoutAfterFailureTest`

2021-03-24 Thread GitBox
hachikuji opened a new pull request #10398: URL: https://github.com/apache/kafka/pull/10398 I noticed this test hanging frequently locally. There is a race condition between the background thread calling `ready` and the call to `MockTime.sleep` in the test. If the call to `sleep` happens f

[jira] [Created] (KAFKA-12550) Introduce RESTORING state to the KafkaStreams FSM

2021-03-24 Thread A. Sophie Blee-Goldman (Jira)
A. Sophie Blee-Goldman created KAFKA-12550: -- Summary: Introduce RESTORING state to the KafkaStreams FSM Key: KAFKA-12550 URL: https://issues.apache.org/jira/browse/KAFKA-12550 Project: Kafka

[jira] [Commented] (KAFKA-9430) Tighten up lag estimates when source topic optimization is on

2021-03-24 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17308310#comment-17308310 ] A. Sophie Blee-Goldman commented on KAFKA-9430: --- Hey [~vinoth] are you stil

[jira] [Commented] (KAFKA-10575) StateRestoreListener#onRestoreEnd should always be triggered

2021-03-24 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17308309#comment-17308309 ] A. Sophie Blee-Goldman commented on KAFKA-10575: [~high.lee] have you be

[jira] [Commented] (KAFKA-12468) Initial offsets are copied from source to target cluster

2021-03-24 Thread Alan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17308308#comment-17308308 ] Alan commented on KAFKA-12468: -- I am seeing similar issue as well. I am also using a custom

[jira] [Resolved] (KAFKA-9846) Race condition can lead to severe lag underestimate for active tasks

2021-03-24 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman resolved KAFKA-9846. --- Resolution: Fixed Resolving since this is fixed in 2.6 > Race condition can

[jira] [Updated] (KAFKA-10532) Do not wipe state store under EOS when closing-dirty a RESTORING active or RUNNING standby task

2021-03-24 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman updated KAFKA-10532: --- Labels: newbie++ (was: ) > Do not wipe state store under EOS when closing-d

[jira] [Commented] (KAFKA-8165) Streams task causes Out Of Memory after connection issues and store restoration

2021-03-24 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17308302#comment-17308302 ] A. Sophie Blee-Goldman commented on KAFKA-8165: --- [~xmar] IIRC there actuall

[jira] [Resolved] (KAFKA-8042) Kafka Streams creates many segment stores on state restore

2021-03-24 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman resolved KAFKA-8042. --- Fix Version/s: 2.6.0 Resolution: Fixed I believe this issue should be

[jira] [Resolved] (KAFKA-7213) NullPointerException during state restoration in kafka streams

2021-03-24 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7213?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman resolved KAFKA-7213. --- Resolution: Fixed I think we can close this as the version is quite old now a

[jira] [Resolved] (KAFKA-5256) Non-checkpointed state stores should be deleted before restore

2021-03-24 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-5256?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman resolved KAFKA-5256. --- Resolution: Fixed Closing this since the described behavior is now implemente

[jira] [Commented] (KAFKA-12538) Global Threads should be able to be replaced like stream threads

2021-03-24 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17308289#comment-17308289 ] A. Sophie Blee-Goldman commented on KAFKA-12538: Note that this will be

[jira] [Commented] (KAFKA-12540) Sub-key support to avoid unnecessary rekey operations with new key is a compound key of the original key + sub-field

2021-03-24 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17308284#comment-17308284 ] A. Sophie Blee-Goldman commented on KAFKA-12540: Can we close this as a

[jira] [Assigned] (KAFKA-7606) Remove deprecated options from StreamsResetter

2021-03-24 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman reassigned KAFKA-7606: - Assignee: (was: Srinivas Reddy) > Remove deprecated options from Str

[jira] [Commented] (KAFKA-12419) Remove Deprecated APIs of Kafka Streams in 3.0

2021-03-24 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17308274#comment-17308274 ] A. Sophie Blee-Goldman commented on KAFKA-12419: [~guozhang] there are a

[jira] [Commented] (KAFKA-12526) Remove deprecated long ms overloads

2021-03-24 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17308251#comment-17308251 ] A. Sophie Blee-Goldman commented on KAFKA-12526: Cool thanks. I've pinge

[jira] [Commented] (KAFKA-12527) Remove deprecated "PartitionGrouper" interface

2021-03-24 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17308245#comment-17308245 ] Guozhang Wang commented on KAFKA-12527: --- Ah yes, thanks! > Remove deprecated "Par

[jira] [Commented] (KAFKA-12526) Remove deprecated long ms overloads

2021-03-24 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17308243#comment-17308243 ] Guozhang Wang commented on KAFKA-12526: --- Yes, I think this may be a subset of KAFK

[jira] [Commented] (KAFKA-10493) Ktable out-of-order updates are not being ignored

2021-03-24 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17308240#comment-17308240 ] A. Sophie Blee-Goldman commented on KAFKA-10493: What's the status here,

[jira] [Commented] (KAFKA-8531) Change default replication factor config

2021-03-24 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17308238#comment-17308238 ] A. Sophie Blee-Goldman commented on KAFKA-8531: --- Hey [~mjsax], are you plan

[jira] [Commented] (KAFKA-12463) Update default consumer partition assignor for sink tasks

2021-03-24 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17308235#comment-17308235 ] Chris Egerton commented on KAFKA-12463: --- Thanks [~kkonstantine]--I'll admit I was

[jira] [Commented] (KAFKA-12527) Remove deprecated "PartitionGrouper" interface

2021-03-24 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17308234#comment-17308234 ] A. Sophie Blee-Goldman commented on KAFKA-12527: Seems like a duplicate

[jira] [Updated] (KAFKA-12463) Update default consumer partition assignor for sink tasks

2021-03-24 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12463?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton updated KAFKA-12463: -- Labels: needs-kip (was: ) > Update default consumer partition assignor for sink tasks > -

[jira] [Assigned] (KAFKA-12527) Remove deprecated "PartitionGrouper" interface

2021-03-24 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman reassigned KAFKA-12527: -- Assignee: Guozhang Wang > Remove deprecated "PartitionGrouper" interf

[jira] [Commented] (KAFKA-12526) Remove deprecated long ms overloads

2021-03-24 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17308233#comment-17308233 ] A. Sophie Blee-Goldman commented on KAFKA-12526: [~guozhang] To clarify,

[jira] [Assigned] (KAFKA-7106) Remove segment/segmentInterval from Window definition

2021-03-24 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman reassigned KAFKA-7106: - Assignee: Guozhang Wang > Remove segment/segmentInterval from Window def

[GitHub] [kafka] jsancio commented on a change in pull request #10085: KAFKA-12154: Snapshot Loading API

2021-03-24 Thread GitBox
jsancio commented on a change in pull request #10085: URL: https://github.com/apache/kafka/pull/10085#discussion_r600926563 ## File path: raft/src/main/java/org/apache/kafka/raft/ReplicatedCounter.java ## @@ -87,6 +96,25 @@ public synchronized void handleCommit(BatchReader rea

[GitHub] [kafka] jsancio commented on a change in pull request #10085: KAFKA-12154: Snapshot Loading API

2021-03-24 Thread GitBox
jsancio commented on a change in pull request #10085: URL: https://github.com/apache/kafka/pull/10085#discussion_r600926104 ## File path: raft/src/main/java/org/apache/kafka/snapshot/SnapshotReader.java ## @@ -0,0 +1,153 @@ +/* + * Licensed to the Apache Software Foundation (AS

[jira] [Created] (KAFKA-12549) Allow state stores to opt-in transactional support

2021-03-24 Thread Guozhang Wang (Jira)
Guozhang Wang created KAFKA-12549: - Summary: Allow state stores to opt-in transactional support Key: KAFKA-12549 URL: https://issues.apache.org/jira/browse/KAFKA-12549 Project: Kafka Issue Ty

[GitHub] [kafka] jsancio commented on a change in pull request #10085: KAFKA-12154: Snapshot Loading API

2021-03-24 Thread GitBox
jsancio commented on a change in pull request #10085: URL: https://github.com/apache/kafka/pull/10085#discussion_r600925523 ## File path: raft/src/main/java/org/apache/kafka/raft/ReplicatedCounter.java ## @@ -87,6 +96,25 @@ public synchronized void handleCommit(BatchReader rea

[jira] [Comment Edited] (KAFKA-7025) Android client support

2021-03-24 Thread Nikolai Lubiagov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17308102#comment-17308102 ] Nikolai Lubiagov edited comment on KAFKA-7025 at 3/24/21, 10:24 PM: ---

[jira] [Updated] (KAFKA-12548) Invalid record error message is not getting sent to application

2021-03-24 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12548?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson updated KAFKA-12548: Summary: Invalid record error message is not getting sent to application (was: Invalid re

[jira] [Created] (KAFKA-12548) Invalid record error is not getting sent to application

2021-03-24 Thread Jason Gustafson (Jira)
Jason Gustafson created KAFKA-12548: --- Summary: Invalid record error is not getting sent to application Key: KAFKA-12548 URL: https://issues.apache.org/jira/browse/KAFKA-12548 Project: Kafka

[jira] [Commented] (KAFKA-8784) Remove default implementation of RocksDBConfigSetter#close

2021-03-24 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17308198#comment-17308198 ] A. Sophie Blee-Goldman commented on KAFKA-8784: --- Hey [~sbellapu], are you s

[jira] [Comment Edited] (KAFKA-10046) Deprecated PartitionGrouper config is ignored

2021-03-24 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17308197#comment-17308197 ] A. Sophie Blee-Goldman edited comment on KAFKA-10046 at 3/24/21, 9:52 PM:

[jira] [Updated] (KAFKA-10046) Deprecated PartitionGrouper config is ignored

2021-03-24 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman updated KAFKA-10046: --- Fix Version/s: 3.0.0 > Deprecated PartitionGrouper config is ignored > -

[jira] [Commented] (KAFKA-10046) Deprecated PartitionGrouper config is ignored

2021-03-24 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17308197#comment-17308197 ] A. Sophie Blee-Goldman commented on KAFKA-10046: We're removing this con

[GitHub] [kafka] ableegoldman commented on pull request #10302: KAFKA-7785: move internal DefaultPartitionGrouper

2021-03-24 Thread GitBox
ableegoldman commented on pull request #10302: URL: https://github.com/apache/kafka/pull/10302#issuecomment-806209047 Seems like we have two seemingly identical tickets & PRs for this -- https://github.com/apache/kafka/pull/10380 cc @guozhangwang @highluck -- This is an automated mes

[GitHub] [kafka] ableegoldman commented on pull request #10397: KAFKA-12508: Disable KIP-557

2021-03-24 Thread GitBox
ableegoldman commented on pull request #10397: URL: https://github.com/apache/kafka/pull/10397#issuecomment-806194636 Ah ok, I saw the KIP had included "any aggregation or repartition operation" in addition to the source KTable but I guess this just hasn't been implemented yet. Looks like

[jira] [Created] (KAFKA-12547) Drop idempotent updates for repartition operations

2021-03-24 Thread A. Sophie Blee-Goldman (Jira)
A. Sophie Blee-Goldman created KAFKA-12547: -- Summary: Drop idempotent updates for repartition operations Key: KAFKA-12547 URL: https://issues.apache.org/jira/browse/KAFKA-12547 Project: Kafka

[GitHub] [kafka] ijuma commented on a change in pull request #10173: KAFKA-9548 Added SPIs and public classes/interfaces introduced in KIP-405 for tiered storage feature in Kafka.

2021-03-24 Thread GitBox
ijuma commented on a change in pull request #10173: URL: https://github.com/apache/kafka/pull/10173#discussion_r600881585 ## File path: clients/src/main/java/org/apache/kafka/server/log/remote/storage/LogSegmentData.java ## @@ -0,0 +1,139 @@ +/* + * Licensed to the Apache Soft

[jira] [Created] (KAFKA-12546) Drop idempotent updates for aggregations

2021-03-24 Thread A. Sophie Blee-Goldman (Jira)
A. Sophie Blee-Goldman created KAFKA-12546: -- Summary: Drop idempotent updates for aggregations Key: KAFKA-12546 URL: https://issues.apache.org/jira/browse/KAFKA-12546 Project: Kafka

[GitHub] [kafka] ableegoldman commented on a change in pull request #10387: KAFKA-12537: get EOS corner case

2021-03-24 Thread GitBox
ableegoldman commented on a change in pull request #10387: URL: https://github.com/apache/kafka/pull/10387#discussion_r600875808 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -492,22 +492,18 @@ private void handleStreamsUncaughtException(f

[jira] [Commented] (KAFKA-9552) Stream should handle OutOfSequence exception thrown from Producer

2021-03-24 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17308175#comment-17308175 ] A. Sophie Blee-Goldman commented on KAFKA-9552: --- Hey guys, what's the curre

[jira] [Created] (KAFKA-12544) Particular partitions lagging and consumers intermittently reading

2021-03-24 Thread kevin j staiger (Jira)
kevin j staiger created KAFKA-12544: --- Summary: Particular partitions lagging and consumers intermittently reading Key: KAFKA-12544 URL: https://issues.apache.org/jira/browse/KAFKA-12544 Project: Kaf

[jira] [Updated] (KAFKA-12544) Particular partitions lagging and consumers intermittently reading

2021-03-24 Thread kevin j staiger (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12544?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] kevin j staiger updated KAFKA-12544: Description: Hi, we are experiencing a strange issue with a kafka topic where is seems lik

[GitHub] [kafka] jsancio commented on a change in pull request #10085: KAFKA-12154: Snapshot Loading API

2021-03-24 Thread GitBox
jsancio commented on a change in pull request #10085: URL: https://github.com/apache/kafka/pull/10085#discussion_r600789602 ## File path: raft/src/main/java/org/apache/kafka/raft/ReplicatedCounter.java ## @@ -87,6 +96,25 @@ public synchronized void handleCommit(BatchReader rea

[GitHub] [kafka] jsancio commented on a change in pull request #10085: KAFKA-12154: Snapshot Loading API

2021-03-24 Thread GitBox
jsancio commented on a change in pull request #10085: URL: https://github.com/apache/kafka/pull/10085#discussion_r600813565 ## File path: raft/src/test/java/org/apache/kafka/raft/MockLog.java ## @@ -418,48 +414,49 @@ public RawSnapshotWriter createSnapshot(OffsetAndEpoch snaps

[jira] [Created] (KAFKA-12545) Integrate snapshot in the shell tool

2021-03-24 Thread Jose Armando Garcia Sancio (Jira)
Jose Armando Garcia Sancio created KAFKA-12545: -- Summary: Integrate snapshot in the shell tool Key: KAFKA-12545 URL: https://issues.apache.org/jira/browse/KAFKA-12545 Project: Kafka

[jira] [Assigned] (KAFKA-10819) The freeze operation should validate the content of the snapshot

2021-03-24 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10819?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jose Armando Garcia Sancio reassigned KAFKA-10819: -- Assignee: (was: Jose Armando Garcia Sancio) > The freeze

[GitHub] [kafka] vvcephei commented on pull request #10397: KAFKA-12508: Disable KIP-557

2021-03-24 Thread GitBox
vvcephei commented on pull request #10397: URL: https://github.com/apache/kafka/pull/10397#issuecomment-806152365 Thanks, @ableegoldman ! As far as I know this was the only operator we updated to KIP-557. This is the only commit I find referencing the KIP: https://github.com/

[jira] [Assigned] (KAFKA-10800) Validate the snapshot id when the state machine creates a snapshot

2021-03-24 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10800?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jose Armando Garcia Sancio reassigned KAFKA-10800: -- Assignee: (was: Jose Armando Garcia Sancio) > Validate th

[GitHub] [kafka] ableegoldman commented on a change in pull request #10397: KAFKA-12508: Disable KIP-557

2021-03-24 Thread GitBox
ableegoldman commented on a change in pull request #10397: URL: https://github.com/apache/kafka/pull/10397#discussion_r600832696 ## File path: streams/src/test/java/org/apache/kafka/streams/kstream/internals/KTableSourceTest.java ## @@ -91,6 +92,7 @@ public void testKTable() {

[GitHub] [kafka] vvcephei commented on a change in pull request #10397: KAFKA-12508: Disable KIP-557

2021-03-24 Thread GitBox
vvcephei commented on a change in pull request #10397: URL: https://github.com/apache/kafka/pull/10397#discussion_r600834715 ## File path: streams/src/test/java/org/apache/kafka/streams/kstream/internals/KTableSourceTest.java ## @@ -91,6 +92,7 @@ public void testKTable() {

[jira] [Assigned] (KAFKA-4327) Move Reset Tool from core to streams

2021-03-24 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-4327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman reassigned KAFKA-4327: - Assignee: (was: Jorge Esteban Quilcate Otoya) > Move Reset Tool from

[jira] [Commented] (KAFKA-7870) Error sending fetch request (sessionId=1578860481, epoch=INITIAL) to node 2: java.io.IOException: Connection to 2 was disconnected before the response was read.

2021-03-24 Thread Tyran (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17308153#comment-17308153 ] Tyran commented on KAFKA-7870: -- Picked up a similar issue in 2.7 which causes the entire clu

[GitHub] [kafka] vvcephei merged pull request #10386: MINOR: fix aggregatedJavadoc dep on compileJava

2021-03-24 Thread GitBox
vvcephei merged pull request #10386: URL: https://github.com/apache/kafka/pull/10386 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, pleas

[jira] [Commented] (KAFKA-12513) Kafka zookeeper client can't connect when the first zookeeper server is offline

2021-03-24 Thread Krzysztof Piecuch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17308136#comment-17308136 ] Krzysztof Piecuch commented on KAFKA-12513: --- Looking at the ConnectStringParse

[GitHub] [kafka] dosvath commented on pull request #10375: KAFKA-12522: Cast SMT should allow null value records to pass through

2021-03-24 Thread GitBox
dosvath commented on pull request #10375: URL: https://github.com/apache/kafka/pull/10375#issuecomment-806084689 Thanks @kkonstantine I updated the branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [kafka] vvcephei merged pull request #10392: KAFKA-12435: Fix javadoc errors

2021-03-24 Thread GitBox
vvcephei merged pull request #10392: URL: https://github.com/apache/kafka/pull/10392 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, pleas

[jira] [Comment Edited] (KAFKA-7025) Android client support

2021-03-24 Thread Nikolai Lubiagov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17308102#comment-17308102 ] Nikolai Lubiagov edited comment on KAFKA-7025 at 3/24/21, 6:51 PM:

[GitHub] [kafka] vvcephei commented on pull request #10397: KAFKA-12508: Disable KIP-557

2021-03-24 Thread GitBox
vvcephei commented on pull request #10397: URL: https://github.com/apache/kafka/pull/10397#issuecomment-806071340 Hey @ableegoldman @cadonna, can you spare a quick review here? All I did was revert the KTableSourceProcessor to its state before the KIP-557 implementation. I just ignor

[GitHub] [kafka] vvcephei opened a new pull request #10397: KAFKA-12508: Disable KIP-557

2021-03-24 Thread GitBox
vvcephei opened a new pull request #10397: URL: https://github.com/apache/kafka/pull/10397 A major issue has been raised that this implementation of emit-on-change is vulnerable to a number of data-loss bugs in the presence of recovery with dirty state under at-least-once semantics.

[GitHub] [kafka] vvcephei commented on pull request #10392: KAFKA-12435: Fix javadoc errors

2021-03-24 Thread GitBox
vvcephei commented on pull request #10392: URL: https://github.com/apache/kafka/pull/10392#issuecomment-806067123 Ok, I've tested this fix locally, and it looks like, although we have some flaky test failures, the builds are still functioning. -- This is an automated message from the Apa

[jira] [Comment Edited] (KAFKA-7025) Android client support

2021-03-24 Thread Nikolai Lubiagov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17308102#comment-17308102 ] Nikolai Lubiagov edited comment on KAFKA-7025 at 3/24/21, 6:35 PM:

[jira] [Comment Edited] (KAFKA-7025) Android client support

2021-03-24 Thread Nikolai Lubiagov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17308102#comment-17308102 ] Nikolai Lubiagov edited comment on KAFKA-7025 at 3/24/21, 6:34 PM:

[jira] [Created] (KAFKA-12543) Re-design the ownership model for snapshots

2021-03-24 Thread Jose Armando Garcia Sancio (Jira)
Jose Armando Garcia Sancio created KAFKA-12543: -- Summary: Re-design the ownership model for snapshots Key: KAFKA-12543 URL: https://issues.apache.org/jira/browse/KAFKA-12543 Project: Kafka

[jira] [Comment Edited] (KAFKA-7025) Android client support

2021-03-24 Thread Nikolai Lubiagov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17308102#comment-17308102 ] Nikolai Lubiagov edited comment on KAFKA-7025 at 3/24/21, 6:31 PM:

[jira] [Commented] (KAFKA-7025) Android client support

2021-03-24 Thread Nikolai Lubiagov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7025?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17308102#comment-17308102 ] Nikolai Lubiagov commented on KAFKA-7025: - For me interested other question, how

[GitHub] [kafka] C0urante commented on pull request #10396: KAFKA-12474: Handle failure to write new session keys gracefully

2021-03-24 Thread GitBox
C0urante commented on pull request #10396: URL: https://github.com/apache/kafka/pull/10396#issuecomment-806057436 @gharris1727 @ncliang either of you care to take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [kafka] C0urante opened a new pull request #10396: KAFKA-12474: Handle failure to write new session keys gracefully

2021-03-24 Thread GitBox
C0urante opened a new pull request #10396: URL: https://github.com/apache/kafka/pull/10396 [Jira](https://issues.apache.org/jira/browse/KAFKA-12474) If a distributed worker fails to write (or read back) a new session key to/from the config topic, it dies. This fix softens the

[jira] [Commented] (KAFKA-12540) Sub-key support to avoid unnecessary rekey operations with new key is a compound key of the original key + sub-field

2021-03-24 Thread Antony Stubbs (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17308091#comment-17308091 ] Antony Stubbs commented on KAFKA-12540: --- Ah yes! Totally - thanks! Now we have the

[GitHub] [kafka] cmccabe merged pull request #10281: KAFKA-12432: AdminClient should time out nodes that are never ready

2021-03-24 Thread GitBox
cmccabe merged pull request #10281: URL: https://github.com/apache/kafka/pull/10281 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[jira] [Commented] (KAFKA-12508) Emit-on-change tables may lose updates on error or restart in at_least_once

2021-03-24 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17308063#comment-17308063 ] John Roesler commented on KAFKA-12508: -- Thanks [~cmaus] , I think you're right. Si

[jira] [Reopened] (KAFKA-12508) Emit-on-change tables may lose updates on error or restart in at_least_once

2021-03-24 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler reopened KAFKA-12508: -- Assignee: John Roesler (was: Bruno Cadonna) > Emit-on-change tables may lose updates on err

[jira] [Commented] (KAFKA-12542) Unknown Output topic when Filter Processor is returning false

2021-03-24 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17308053#comment-17308053 ] Guozhang Wang commented on KAFKA-12542: --- Hi [~sinhash] I cannot tell if `dlqTopic

[GitHub] [kafka] vvcephei commented on a change in pull request #10392: KAFKA-12435: Fix javadoc errors

2021-03-24 Thread GitBox
vvcephei commented on a change in pull request #10392: URL: https://github.com/apache/kafka/pull/10392#discussion_r600715320 ## File path: build.gradle ## @@ -1622,7 +1622,6 @@ project(':streams:test-utils') { javadoc { include "**/org/apache/kafka/streams/test/**" -

[GitHub] [kafka] spena commented on a change in pull request #10331: KAFKA-10847: Add a RocksDBTimeOrderedWindowStore to hold records using their timestamp as key prefix

2021-03-24 Thread GitBox
spena commented on a change in pull request #10331: URL: https://github.com/apache/kafka/pull/10331#discussion_r600706763 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/TimeOrderedWindowStoreBuilder.java ## @@ -0,0 +1,80 @@ +/* + * Licensed to the

[GitHub] [kafka] spena commented on pull request #10331: KAFKA-10847: Add a RocksDBTimeOrderedWindowStore to hold records using their timestamp as key prefix

2021-03-24 Thread GitBox
spena commented on pull request #10331: URL: https://github.com/apache/kafka/pull/10331#issuecomment-806018503 @guozhangwang I just replace this PR with only the changes for the `RocksDBTimeOrderedWindowStore`. I will create other PRs with your suggestions. -- This is an automated messag

[GitHub] [kafka] wcarlson5 commented on a change in pull request #10387: KAFKA-12537: get EOS corner case

2021-03-24 Thread GitBox
wcarlson5 commented on a change in pull request #10387: URL: https://github.com/apache/kafka/pull/10387#discussion_r600698092 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java ## @@ -631,6 +625,14 @@ public void setStreamsUncaug

[GitHub] [kafka] chia7712 commented on pull request #10389: MINOR: stabilize ListOffsetsRequestTest#testResponseIncludesLeaderEpoch

2021-03-24 Thread GitBox
chia7712 commented on pull request #10389: URL: https://github.com/apache/kafka/pull/10389#issuecomment-806010778 merge trunk to trigger QA again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] chia7712 commented on a change in pull request #10392: KAFKA-12435: Fix javadoc errors

2021-03-24 Thread GitBox
chia7712 commented on a change in pull request #10392: URL: https://github.com/apache/kafka/pull/10392#discussion_r600696771 ## File path: build.gradle ## @@ -1622,7 +1622,6 @@ project(':streams:test-utils') { javadoc { include "**/org/apache/kafka/streams/test/**" -

  1   2   >