satishd commented on pull request #10424:
URL: https://github.com/apache/kafka/pull/10424#issuecomment-809970485
@kowshik Addressed the comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
satishd commented on a change in pull request #10424:
URL: https://github.com/apache/kafka/pull/10424#discussion_r603835840
##
File path:
clients/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogSegmentMetadata.java
##
@@ -178,10 +178,10 @@ public long endOffs
dajac commented on pull request #10425:
URL: https://github.com/apache/kafka/pull/10425#issuecomment-809983371
One test failed but it is not related to changes in this PR. Merging it to
trunk.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
dajac merged pull request #10425:
URL: https://github.com/apache/kafka/pull/10425
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please c
[
https://issues.apache.org/jira/browse/KAFKA-12573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot resolved KAFKA-12573.
-
Fix Version/s: 3.0.0
Reviewer: Ismael Juma
Resolution: Fixed
> Removed deprecate
David Jacot created KAFKA-12577:
---
Summary: Remove deprecated `quota.producer.default` and
`quota.consumer.default` configurations
Key: KAFKA-12577
URL: https://issues.apache.org/jira/browse/KAFKA-12577
satishd commented on pull request #10173:
URL: https://github.com/apache/kafka/pull/10173#issuecomment-80112
@kowshik @ijuma thanks for your review. Raised
https://github.com/apache/kafka/pull/10424 to address your comments.
--
This is an automated message from the Apache Git Servic
Ismael Juma created KAFKA-12578:
---
Summary: Remove deprecated PrincipalBuilder
Key: KAFKA-12578
URL: https://issues.apache.org/jira/browse/KAFKA-12578
Project: Kafka
Issue Type: Task
Ismael Juma created KAFKA-12579:
---
Summary: Remove deprecated ExtendedSerializer/Deserializer
Key: KAFKA-12579
URL: https://issues.apache.org/jira/browse/KAFKA-12579
Project: Kafka
Issue Type: T
Ismael Juma created KAFKA-12580:
---
Summary: Remove deprecated close(long, TimeUnit)
Key: KAFKA-12580
URL: https://issues.apache.org/jira/browse/KAFKA-12580
Project: Kafka
Issue Type: Task
[
https://issues.apache.org/jira/browse/KAFKA-12578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ismael Juma updated KAFKA-12578:
Summary: Remove deprecated security classes/methods (was: Remove
deprecated PrincipalBuilder)
>
ijuma opened a new pull request #10435:
URL: https://github.com/apache/kafka/pull/10435
More specifically:
- Constants in SslConfigs
- Constants in SaslConfigs
- AclBinding constructor
- AclBindingFilter constructor
- PrincipalBuilder and DefaultPrincipalBuilder classes
dajac commented on pull request #10427:
URL: https://github.com/apache/kafka/pull/10427#issuecomment-810020286
@rajinisivaram @ijuma I propose to remove these two configurations that were
deprecated in 0.11. There is a clear alternative which consists in using the
default dynamic quotas. W
ijuma commented on pull request #10435:
URL: https://github.com/apache/kafka/pull/10435#issuecomment-810023871
I still need to update the upgrade notes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
chia7712 commented on pull request #9851:
URL: https://github.com/apache/kafka/pull/9851#issuecomment-810025163
@highluck Could you merge trunk to trigger QA again? It seems our jenkins
was on vacation before :)
--
This is an automated message from the Apache Git Service.
To respond to t
kowshik commented on pull request #10401:
URL: https://github.com/apache/kafka/pull/10401#issuecomment-810028238
@junrao The jenkins tests have finished. I checked the test failures, they
seem to be unrelated to this PR:
```
kafka.server.RaftClusterTest.testCreateClusterAndCreateL
dajac opened a new pull request #10436:
URL: https://github.com/apache/kafka/pull/10436
`ConfigEntry`'s constructor was deprecated in 1.1.0. It seems that we can
safely remove it now.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
dajac commented on pull request #10436:
URL: https://github.com/apache/kafka/pull/10436#issuecomment-810034992
I need to file a Jira and update the upgrade nodes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
dajac opened a new pull request #10437:
URL: https://github.com/apache/kafka/pull/10437
TODO
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upg
[
https://issues.apache.org/jira/browse/KAFKA-12579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ismael Juma updated KAFKA-12579:
Summary: Remove deprecated methods for consumer, producer and admin client
(was: Remove deprecate
[
https://issues.apache.org/jira/browse/KAFKA-12580?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ismael Juma resolved KAFKA-12580.
-
Fix Version/s: (was: 3.0.0)
Resolution: Duplicate
Duplicate of KAFKA-12579.
> Remove
ijuma opened a new pull request #10438:
URL: https://github.com/apache/kafka/pull/10438
TBD
(PR marked as Draft as there are still compiler errors)
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage an
wituss opened a new pull request #10439:
URL: https://github.com/apache/kafka/pull/10439
After this commit Predicate interface will be aligned as much as possible
with the java.util.function.Predicate API.
### Committer Checklist (excluded from commit message)
- [ ] Verify design
[
https://issues.apache.org/jira/browse/KAFKA-12579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ismael Juma updated KAFKA-12579:
Summary: Remove deprecated methods from consumer, producer (was: Remove
deprecated methods for co
[
https://issues.apache.org/jira/browse/KAFKA-12579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ismael Juma updated KAFKA-12579:
Summary: Remove deprecated methods for consumer, producer (was: Remove
deprecated methods for con
Ismael Juma created KAFKA-12581:
---
Summary: Remove deprecated Admin.electPreferredLeaders
Key: KAFKA-12581
URL: https://issues.apache.org/jira/browse/KAFKA-12581
Project: Kafka
Issue Type: Task
ijuma opened a new pull request #10440:
URL: https://github.com/apache/kafka/pull/10440
`Admin.electLeaders` is the replacement.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ]
[
https://issues.apache.org/jira/browse/KAFKA-12564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17311325#comment-17311325
]
Jessica Johann commented on KAFKA-12564:
[~mjsax] Thanks for your feedback. Woul
David Jacot created KAFKA-12582:
---
Summary: Remove deprecated `ConfigEntry` constructor
Key: KAFKA-12582
URL: https://issues.apache.org/jira/browse/KAFKA-12582
Project: Kafka
Issue Type: Improve
Iskuskov commented on pull request #9541:
URL: https://github.com/apache/kafka/pull/9541#issuecomment-810163709
@rhauch, could you take a look at this please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
[
https://issues.apache.org/jira/browse/KAFKA-12419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tomasz Nguyen reassigned KAFKA-12419:
-
Assignee: Tomasz Nguyen
> Remove Deprecated APIs of Kafka Streams in 3.0
>
swist opened a new pull request #10441:
URL: https://github.com/apache/kafka/pull/10441
This is part of the work tracked in
[KAFKA-12419](https://issues.apache.org/jira/browse/KAFKA-12419) as part of
pre-3.0
cleanup
*More detailed description of your change,
if necessary. The
chia7712 commented on a change in pull request #10435:
URL: https://github.com/apache/kafka/pull/10435#discussion_r604089974
##
File path:
clients/src/main/java/org/apache/kafka/common/security/authenticator/DefaultKafkaPrincipalBuilder.java
##
@@ -41,89 +39,39 @@
import java
swist commented on pull request #10441:
URL: https://github.com/apache/kafka/pull/10441#issuecomment-810262626
Dupe of #10421
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
swist closed pull request #10441:
URL: https://github.com/apache/kafka/pull/10441
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please c
showuon opened a new pull request #10442:
URL: https://github.com/apache/kafka/pull/10442
Saw this java doc error while tracing codes. We forgot to update it while
updating the method before:
https://github.com/apache/kafka/pull/2657/files#diff-d3539714f9c04947365bf02a4dac4183aaba88e70d83b
showuon commented on pull request #10442:
URL: https://github.com/apache/kafka/pull/10442#issuecomment-810274523
@ijuma , could you help review this simple PR? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
[
https://issues.apache.org/jira/browse/KAFKA-7077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17311554#comment-17311554
]
Alexandre Juma commented on KAFKA-7077:
---
Indeed this could greatly benefit Kafka Co
Dominique Mongelli created KAFKA-12583:
--
Summary: Upgrade of netty-codec due to CVE-2021-21295
Key: KAFKA-12583
URL: https://issues.apache.org/jira/browse/KAFKA-12583
Project: Kafka
Issu
[
https://issues.apache.org/jira/browse/KAFKA-12583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dominique Mongelli updated KAFKA-12583:
---
Fix Version/s: (was: 2.6.2)
(was: 2.7.1)
[
https://issues.apache.org/jira/browse/KAFKA-12583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dominique Mongelli updated KAFKA-12583:
---
Description:
Our security tool raised the following security flaw on kafka 2.7:
htt
[
https://issues.apache.org/jira/browse/KAFKA-12583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dominique Mongelli updated KAFKA-12583:
---
Description:
Our security tool raised the following security flaw on kafka 2.7:
[ht
ijuma commented on a change in pull request #10436:
URL: https://github.com/apache/kafka/pull/10436#discussion_r604171085
##
File path: docs/upgrade.html
##
@@ -28,6 +28,8 @@ Notable changes in 3
The Streams API removed all deprecated APIs that were deprecated in
version
ijuma commented on pull request #10437:
URL: https://github.com/apache/kafka/pull/10437#issuecomment-810327340
Makes sense. I assume you're planning to file a JIRA?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
ijuma edited a comment on pull request #10437:
URL: https://github.com/apache/kafka/pull/10437#issuecomment-810327340
Makes sense. I assume you're planning to file a JIRA and the upgrade note
still?
--
This is an automated message from the Apache Git Service.
To respond to the message, p
dajac commented on a change in pull request #10436:
URL: https://github.com/apache/kafka/pull/10436#discussion_r604176897
##
File path: docs/upgrade.html
##
@@ -28,6 +28,8 @@ Notable changes in 3
The Streams API removed all deprecated APIs that were deprecated in
version
dajac commented on pull request #10437:
URL: https://github.com/apache/kafka/pull/10437#issuecomment-810332800
@ijuma Yes, will do. The PR is not fully completed yet. I'll ping you once
it is ready.
--
This is an automated message from the Apache Git Service.
To respond to the message, p
ijuma commented on a change in pull request #10435:
URL: https://github.com/apache/kafka/pull/10435#discussion_r604182448
##
File path:
clients/src/main/java/org/apache/kafka/common/acl/AclBindingFilter.java
##
@@ -50,18 +48,6 @@ public AclBindingFilter(ResourcePatternFilter p
David Jacot created KAFKA-12584:
---
Summary: Remove deprecated `Sum` and `Total` classes
Key: KAFKA-12584
URL: https://issues.apache.org/jira/browse/KAFKA-12584
Project: Kafka
Issue Type: Improve
ijuma commented on a change in pull request #10436:
URL: https://github.com/apache/kafka/pull/10436#discussion_r604186633
##
File path: docs/upgrade.html
##
@@ -28,6 +28,8 @@ Notable changes in 3
The Streams API removed all deprecated APIs that were deprecated in
version
chia7712 commented on a change in pull request #10435:
URL: https://github.com/apache/kafka/pull/10435#discussion_r604187554
##
File path:
clients/src/main/java/org/apache/kafka/common/acl/AclBindingFilter.java
##
@@ -50,18 +48,6 @@ public AclBindingFilter(ResourcePatternFilte
ijuma commented on a change in pull request #10436:
URL: https://github.com/apache/kafka/pull/10436#discussion_r604187955
##
File path: docs/upgrade.html
##
@@ -28,6 +28,8 @@ Notable changes in 3
The Streams API removed all deprecated APIs that were deprecated in
version
ijuma commented on pull request #10435:
URL: https://github.com/apache/kafka/pull/10435#issuecomment-810345988
Updated @chia7712
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
dajac commented on a change in pull request #10436:
URL: https://github.com/apache/kafka/pull/10436#discussion_r604193906
##
File path: docs/upgrade.html
##
@@ -28,6 +28,8 @@ Notable changes in 3
The Streams API removed all deprecated APIs that were deprecated in
version
dajac opened a new pull request #10443:
URL: https://github.com/apache/kafka/pull/10443
The `kafka-preferred-replica-election` command was deprecated in 2.4. As we
removed the related APIs in the Admin client
(https://github.com/apache/kafka/pull/10440), we can also remove the command
lin
dajac commented on pull request #10443:
URL: https://github.com/apache/kafka/pull/10443#issuecomment-810349142
@ijuma What do you think about this one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
dajac commented on pull request #10436:
URL: https://github.com/apache/kafka/pull/10436#issuecomment-810350507
@ijuma Updated the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
ijuma commented on pull request #10443:
URL: https://github.com/apache/kafka/pull/10443#issuecomment-810368591
Good question. I think this script is more widely used since it has existed
for a lot longer than the admin commands we have removed in #10440. One
question: could the script just
vvcephei commented on a change in pull request #10404:
URL: https://github.com/apache/kafka/pull/10404#discussion_r604216817
##
File path:
clients/src/test/java/org/apache/kafka/clients/admin/AdminClientUnitTestEnv.java
##
@@ -113,6 +114,9 @@ public MockClient kafkaClient() {
[
https://issues.apache.org/jira/browse/KAFKA-12435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
John Roesler resolved KAFKA-12435.
--
Resolution: Fixed
> Several streams-test-utils classes missing from javadoc
>
chia7712 commented on pull request #10435:
URL: https://github.com/apache/kafka/pull/10435#issuecomment-810385150
Is `Resource` exposed to users? It appears that we don't create `Resource`
except for `Resource CLUSTER`. If `Resource` is not a kind of public APIs, I
feel it can be removed a
vvcephei commented on pull request #10404:
URL: https://github.com/apache/kafka/pull/10404#issuecomment-810405595
Confirmed that the tests still pass after that last small patch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
vvcephei merged pull request #10404:
URL: https://github.com/apache/kafka/pull/10404
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, pleas
[
https://issues.apache.org/jira/browse/KAFKA-12557?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
John Roesler resolved KAFKA-12557.
--
Resolution: Fixed
> org.apache.kafka.clients.admin.KafkaAdminClientTest#testClientSideTimeoutA
hachikuji commented on pull request #10404:
URL: https://github.com/apache/kafka/pull/10404#issuecomment-810415561
@vvcephei @guozhangwang @ijuma The new tests still have race conditions
which need to be fixed. I have a patch here:
https://github.com/apache/kafka/pull/10398.
--
This is
junrao merged pull request #10401:
URL: https://github.com/apache/kafka/pull/10401
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
mumrah commented on a change in pull request #10398:
URL: https://github.com/apache/kafka/pull/10398#discussion_r604267269
##
File path:
clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java
##
@@ -5325,12 +5326,23 @@ public void testClientSideTimeoutA
[
https://issues.apache.org/jira/browse/KAFKA-12552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jun Rao resolved KAFKA-12552.
-
Fix Version/s: 3.0.0
Resolution: Fixed
Merged the PR to trunk.
> Extract segments map out of Log
junrao commented on pull request #10426:
URL: https://github.com/apache/kafka/pull/10426#issuecomment-810421289
@kowshik : Do you know why the tests timed out? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
[
https://issues.apache.org/jira/browse/KAFKA-12574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17311648#comment-17311648
]
Guozhang Wang commented on KAFKA-12574:
---
I agree we should try to encourage users
junrao commented on a change in pull request #10424:
URL: https://github.com/apache/kafka/pull/10424#discussion_r604277850
##
File path:
clients/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogSegmentMetadata.java
##
@@ -82,26 +82,26 @@
/**
* Cre
guozhangwang commented on pull request #10407:
URL: https://github.com/apache/kafka/pull/10407#issuecomment-810429831
Thanks @ableegoldman !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
guozhangwang commented on pull request #10345:
URL: https://github.com/apache/kafka/pull/10345#issuecomment-810431786
Sounds great, will follow-up on KIP-726.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
[
https://issues.apache.org/jira/browse/KAFKA-12574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17311685#comment-17311685
]
A. Sophie Blee-Goldman commented on KAFKA-12574:
Yes, something like tha
[
https://issues.apache.org/jira/browse/KAFKA-12574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17311697#comment-17311697
]
Guozhang Wang commented on KAFKA-12574:
---
Yeah.. I also felt this procedure require
kowshik edited a comment on pull request #10280:
URL: https://github.com/apache/kafka/pull/10280#issuecomment-808514958
@junrao Just a heads up on the following. I'm working on the changes for the
following in separate PRs, these are related with refactoring the recovery
logic (KAFKA-12553
[
https://issues.apache.org/jira/browse/KAFKA-12574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. Sophie Blee-Goldman updated KAFKA-12574:
---
Labels: needs-kip (was: )
> Deprecate eos-alpha
> ---
>
>
[
https://issues.apache.org/jira/browse/KAFKA-12574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17311717#comment-17311717
]
A. Sophie Blee-Goldman commented on KAFKA-12574:
That SGTM -- if users b
[
https://issues.apache.org/jira/browse/KAFKA-12574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. Sophie Blee-Goldman updated KAFKA-12574:
---
Priority: Blocker (was: Major)
> Deprecate eos-alpha
> ---
kowshik commented on pull request #10426:
URL: https://github.com/apache/kafka/pull/10426#issuecomment-810485209
@junrao Jenkins doesn't seem to be starting up tests after I rebased this
morning. I'm not sure what's going on. I'll try again today.
--
This is an automated message from the
ableegoldman commented on pull request #10418:
URL: https://github.com/apache/kafka/pull/10418#issuecomment-810512151
Just some known flaky test failures:
`RaftClusterTest.testCreateClusterAndCreateListDeleteTopic()` and the timeout
we've been seeing lately
--
This is an automated messa
ableegoldman commented on pull request #10418:
URL: https://github.com/apache/kafka/pull/10418#issuecomment-810512500
Merged to trunk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
ableegoldman merged pull request #10418:
URL: https://github.com/apache/kafka/pull/10418
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, p
ableegoldman commented on a change in pull request #10342:
URL: https://github.com/apache/kafka/pull/10342#discussion_r604366210
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StateDirectory.java
##
@@ -444,22 +408,30 @@ public synchronized vo
[
https://issues.apache.org/jira/browse/KAFKA-12509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. Sophie Blee-Goldman resolved KAFKA-12509.
Resolution: Fixed
> Tighten up StateDirectory thread locking
> ---
[
https://issues.apache.org/jira/browse/KAFKA-12509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. Sophie Blee-Goldman updated KAFKA-12509:
---
Fix Version/s: 3.0.0
> Tighten up StateDirectory thread locking
> --
[
https://issues.apache.org/jira/browse/KAFKA-12574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17311750#comment-17311750
]
Ismael Juma commented on KAFKA-12574:
-
A few comments:
# I think eos-v2 would be a
[
https://issues.apache.org/jira/browse/KAFKA-12265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17311777#comment-17311777
]
Jose Armando Garcia Sancio commented on KAFKA-12265:
[~rohitdeshaws]
[
https://issues.apache.org/jira/browse/KAFKA-12574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17311787#comment-17311787
]
A. Sophie Blee-Goldman commented on KAFKA-12574:
> I think this is sligh
hachikuji merged pull request #10398:
URL: https://github.com/apache/kafka/pull/10398
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, plea
ableegoldman opened a new pull request #10444:
URL: https://github.com/apache/kafka/pull/10444
Minor followup to https://github.com/apache/kafka/pull/10407 -- we need to
extract the `rebalanceInProgress` check down into the
`commitAndFillInConsumedOffsetsAndMetadataPerTaskMap` method which
ableegoldman commented on a change in pull request #10444:
URL: https://github.com/apache/kafka/pull/10444#discussion_r604505465
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java
##
@@ -1013,28 +1016,34 @@ void addRecordsToTasks(
ableegoldman commented on pull request #10411:
URL: https://github.com/apache/kafka/pull/10411#issuecomment-810653716
Some unrelated failures:
`kafka.clients.admin.KafkaAdminClientTest.testClientSideTimeoutAfterFailureToReceiveResponse()`
(failed on all three builds)
`kafka.server.Ra
ableegoldman edited a comment on pull request #10411:
URL: https://github.com/apache/kafka/pull/10411#issuecomment-810653716
Some unrelated failures:
`kafka.clients.admin.KafkaAdminClientTest.testClientSideTimeoutAfterFailureToReceiveResponse()`
(failed on all three builds)
`kafka.se
ableegoldman commented on pull request #10342:
URL: https://github.com/apache/kafka/pull/10342#issuecomment-810654638
Some unrelated failures:
`streams.integration.EosIntegrationTest.shouldNotViolateEosIfOneTaskFailsWithState[exactly_once_beta]`
`kafka.clients.admin.KafkaAdminClientT
ableegoldman merged pull request #10342:
URL: https://github.com/apache/kafka/pull/10342
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, p
[
https://issues.apache.org/jira/browse/KAFKA-12288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. Sophie Blee-Goldman updated KAFKA-12288:
---
Fix Version/s: (was: 2.8.1)
(was: 2.7.2)
kowshik commented on pull request #10426:
URL: https://github.com/apache/kafka/pull/10426#issuecomment-810660718
@junrao The jenkins tests have finished. I checked the test failures, they
seem to be unrelated to this PR:
```
JDK 11:
org.apache.kafka.connect.integration.RebalanceS
Brian Hawkins created KAFKA-12585:
-
Summary: FencedInstanceIdException can cause heartbeat thread to
never be closed
Key: KAFKA-12585
URL: https://issues.apache.org/jira/browse/KAFKA-12585
Project: Ka
mjsax commented on a change in pull request #10411:
URL: https://github.com/apache/kafka/pull/10411#discussion_r604515864
##
File path: core/src/main/scala/kafka/tools/StreamsResetter.java
##
@@ -247,14 +246,10 @@ private void parseArguments(final String[] args) {
1 - 100 of 152 matches
Mail list logo
