[jira] [Updated] (KAFKA-12227) Add method "Producer#send" to return CompletionStage instead of Future

2021-03-30 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-12227: --- Summary: Add method "Producer#send" to return CompletionStage instead of Future (was: Add

[GitHub] [kafka] chia7712 opened a new pull request #10447: KAFKA-12587 Remove KafkaPrincipal#fromString for 3.0

2021-03-30 Thread GitBox
chia7712 opened a new pull request #10447: URL: https://github.com/apache/kafka/pull/10447 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgr

[jira] [Updated] (KAFKA-12587) Remove KafkaPrincipal#fromString for 3.0

2021-03-30 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-12587: --- Summary: Remove KafkaPrincipal#fromString for 3.0 (was: Remove KafkaPrincipal#fromString)

[GitHub] [kafka] chia7712 commented on pull request #10389: MINOR: stabilize ListOffsetsRequestTest#testResponseIncludesLeaderEpoch

2021-03-30 Thread GitBox
chia7712 commented on pull request #10389: URL: https://github.com/apache/kafka/pull/10389#issuecomment-810780261 > Please also update the status in KAFKA-12384. Thank you. oh, sorry that I did not notice the existent ticket. will update the jira :) -- This is an automated message

[jira] [Created] (KAFKA-12587) Remove KafkaPrincipal#fromString

2021-03-30 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-12587: -- Summary: Remove KafkaPrincipal#fromString Key: KAFKA-12587 URL: https://issues.apache.org/jira/browse/KAFKA-12587 Project: Kafka Issue Type: Task

[jira] [Assigned] (KAFKA-12384) Flaky Test ListOffsetsRequestTest.testResponseIncludesLeaderEpoch

2021-03-30 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen reassigned KAFKA-12384: - Assignee: Chia-Ping Tsai (was: Luke Chen) > Flaky Test ListOffsetsRequestTest.testResponseIncl

[jira] [Commented] (KAFKA-12574) Deprecate eos-alpha

2021-03-30 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17312069#comment-17312069 ] Ismael Juma commented on KAFKA-12574: - Sophie, we have seen these kinds of issues wi

[GitHub] [kafka] chia7712 commented on pull request #10410: KAFKA-12561: don't set timeout for future.get

2021-03-30 Thread GitBox
chia7712 commented on pull request #10410: URL: https://github.com/apache/kafka/pull/10410#issuecomment-810768203 @showuon thanks for this fix! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [kafka] chia7712 merged pull request #10410: KAFKA-12561: don't set timeout for future.get

2021-03-30 Thread GitBox
chia7712 merged pull request #10410: URL: https://github.com/apache/kafka/pull/10410 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, pleas

[GitHub] [kafka] chia7712 commented on pull request #10410: KAFKA-12561: don't set timeout for future.get

2021-03-30 Thread GitBox
chia7712 commented on pull request #10410: URL: https://github.com/apache/kafka/pull/10410#issuecomment-810766078 `kafka.server.ListOffsetsRequestTest.testResponseIncludesLeaderEpoch()` is traced by #10389 and `ConnectionQuotasTest.testListenerConnectionRateLimitWhenActualRateAboveLimit`

[GitHub] [kafka] ijuma merged pull request #10440: KAFKA-12581: Remove deprecated `Admin.electPreferredLeaders`

2021-03-30 Thread GitBox
ijuma merged pull request #10440: URL: https://github.com/apache/kafka/pull/10440 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please c

[GitHub] [kafka] ijuma merged pull request #10435: KAFKA-12578: Remove deprecated security classes/methods for 3.0

2021-03-30 Thread GitBox
ijuma merged pull request #10435: URL: https://github.com/apache/kafka/pull/10435 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please c

[GitHub] [kafka] chia7712 opened a new pull request #10446: MINOR: [ConfigEntry.class] add 'type' to 'toString' and 'hashCode'

2021-03-30 Thread GitBox
chia7712 opened a new pull request #10446: URL: https://github.com/apache/kafka/pull/10446 I noticed this issue when reviewing #10436. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status

[GitHub] [kafka] chia7712 merged pull request #10434: MINOR: Remove wrong suppress

2021-03-30 Thread GitBox
chia7712 merged pull request #10434: URL: https://github.com/apache/kafka/pull/10434 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, pleas

[jira] [Commented] (KAFKA-12574) Deprecate eos-alpha

2021-03-30 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17312027#comment-17312027 ] A. Sophie Blee-Goldman commented on KAFKA-12574: I would expect users wh

[GitHub] [kafka] chia7712 commented on pull request #10389: MINOR: stabilize ListOffsetsRequestTest#testResponseIncludesLeaderEpoch

2021-03-30 Thread GitBox
chia7712 commented on pull request #10389: URL: https://github.com/apache/kafka/pull/10389#issuecomment-810731206 @ijuma any suggestions? This test is still flaky :( -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [kafka] chia7712 commented on pull request #10443: KAFKA-8405; Remove deprecated `kafka-preferred-replica-election` command

2021-03-30 Thread GitBox
chia7712 commented on pull request #10443: URL: https://github.com/apache/kafka/pull/10443#issuecomment-810730462 +1 to get rid of it. Could you update `upgrade.html` to include the replacement of `kafka-preferred-replica-election`? -- This is an automated message from the Apache Git Ser

[GitHub] [kafka] showuon commented on pull request #10410: KAFKA-12561: don't set timeout for future.get

2021-03-30 Thread GitBox
showuon commented on pull request #10410: URL: https://github.com/apache/kafka/pull/10410#issuecomment-810727365 @chia7712 , merged the trunk and tests triggered. Let's see :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[jira] [Commented] (KAFKA-12574) Deprecate eos-alpha

2021-03-30 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17312002#comment-17312002 ] Ismael Juma commented on KAFKA-12574: - `4` seems a bit aggressive for Apache Kafka 3

[GitHub] [kafka] chia7712 commented on pull request #10410: KAFKA-12561: don't set timeout for future.get

2021-03-30 Thread GitBox
chia7712 commented on pull request #10410: URL: https://github.com/apache/kafka/pull/10410#issuecomment-810725264 @showuon Could you merge trunk to trigger QA again? I'd like to merge it if QA pass :) -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] chia7712 commented on pull request #10435: KAFKA-12578: Remove deprecated security classes/methods for 3.0

2021-03-30 Thread GitBox
chia7712 commented on pull request #10435: URL: https://github.com/apache/kafka/pull/10435#issuecomment-810724864 > Do you mind if we tackle this one separately? +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[jira] [Commented] (KAFKA-12574) Deprecate eos-alpha

2021-03-30 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17311995#comment-17311995 ] Guozhang Wang commented on KAFKA-12574: --- Yeah I think in 3.0 we would not remove t

[GitHub] [kafka] ijuma commented on pull request #10435: KAFKA-12578: Remove deprecated security classes/methods for 3.0

2021-03-30 Thread GitBox
ijuma commented on pull request #10435: URL: https://github.com/apache/kafka/pull/10435#issuecomment-810715188 @chia7712 `Resource` is public API, yes. But you're right that it may not be used via client facing APIs. Do you mind if we tackle this one separately? -- This is an automated m

[GitHub] [kafka] dengziming closed pull request #10368: [DO NOT MERGE] investigate flaky test

2021-03-30 Thread GitBox
dengziming closed pull request #10368: URL: https://github.com/apache/kafka/pull/10368 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, ple

[GitHub] [kafka] dengziming commented on pull request #10368: [DO NOT MERGE] investigate flaky test

2021-03-30 Thread GitBox
dengziming commented on pull request #10368: URL: https://github.com/apache/kafka/pull/10368#issuecomment-810713622 Refer to #10389 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[jira] [Commented] (KAFKA-12453) Guidance on whether a topology is eligible for optimisation

2021-03-30 Thread Patrick O'Keeffe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17311972#comment-17311972 ] Patrick O'Keeffe commented on KAFKA-12453: -- Thanks for following up on this [~m

[GitHub] [kafka] ableegoldman commented on a change in pull request #10411: KAFKA-7606: Remove deprecated options from StreamsResetter

2021-03-30 Thread GitBox
ableegoldman commented on a change in pull request #10411: URL: https://github.com/apache/kafka/pull/10411#discussion_r604547699 ## File path: core/src/main/scala/kafka/tools/StreamsResetter.java ## @@ -247,14 +247,13 @@ private void parseArguments(final String[] args) {

[GitHub] [kafka] dengziming commented on pull request #10400: MINOR: fix package name in integration test

2021-03-30 Thread GitBox
dengziming commented on pull request #10400: URL: https://github.com/apache/kafka/pull/10400#issuecomment-810705993 cc @mumrah since `IntegrationTestUtils` is created by you. 😉 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [kafka] ableegoldman commented on a change in pull request #10411: KAFKA-7606: Remove deprecated options from StreamsResetter

2021-03-30 Thread GitBox
ableegoldman commented on a change in pull request #10411: URL: https://github.com/apache/kafka/pull/10411#discussion_r604547699 ## File path: core/src/main/scala/kafka/tools/StreamsResetter.java ## @@ -247,14 +247,13 @@ private void parseArguments(final String[] args) {

[GitHub] [kafka] showuon commented on pull request #10410: KAFKA-12561: don't set timeout for future.get

2021-03-30 Thread GitBox
showuon commented on pull request #10410: URL: https://github.com/apache/kafka/pull/10410#issuecomment-810704441 @mumrah , @hachikuji , could you review this PR? It keeps failing recent builds. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [kafka] ableegoldman commented on pull request #10444: HOTFIX: move rebalanceInProgress check to skip commit during handleCorrupted

2021-03-30 Thread GitBox
ableegoldman commented on pull request #10444: URL: https://github.com/apache/kafka/pull/10444#issuecomment-810699741 Merged to trunk and cherrypicked to 2.8 cc @vvcephei -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[jira] [Commented] (KAFKA-8529) Flakey test ConsumerBounceTest#testCloseDuringRebalance

2021-03-30 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17311962#comment-17311962 ] A. Sophie Blee-Goldman commented on KAFKA-8529: --- {code:java} org.opentest4j

[jira] [Created] (KAFKA-12586) Admin API for DescribeTransactions

2021-03-30 Thread Jason Gustafson (Jira)
Jason Gustafson created KAFKA-12586: --- Summary: Admin API for DescribeTransactions Key: KAFKA-12586 URL: https://issues.apache.org/jira/browse/KAFKA-12586 Project: Kafka Issue Type: Sub-task

[GitHub] [kafka] ableegoldman merged pull request #10444: HOTFIX: move rebalanceInProgress check to skip commit during handleCorrupted

2021-03-30 Thread GitBox
ableegoldman merged pull request #10444: URL: https://github.com/apache/kafka/pull/10444 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, p

[GitHub] [kafka] ableegoldman commented on pull request #10444: HOTFIX: move rebalanceInProgress check to skip commit during handleCorrupted

2021-03-30 Thread GitBox
ableegoldman commented on pull request #10444: URL: https://github.com/apache/kafka/pull/10444#issuecomment-810697164 Two unrelated test failures: `org.apache.kafka.connect.integration.RebalanceSourceConnectorsIntegrationTest.testMultipleWorkersRejoining` `kafka.api.ConsumerBounceTest

[GitHub] [kafka] ijuma edited a comment on pull request #10443: KAFKA-8405; Remove deprecated `kafka-preferred-replica-election` command

2021-03-30 Thread GitBox
ijuma edited a comment on pull request #10443: URL: https://github.com/apache/kafka/pull/10443#issuecomment-810368591 Good question. I think this script is more widely used since it has existed for a lot longer than the admin commands we have removed in #10440. One question: could the scri

[GitHub] [kafka] hachikuji opened a new pull request #10445: KAFKA-12548; Propagate record error messages to application

2021-03-30 Thread GitBox
hachikuji opened a new pull request #10445: URL: https://github.com/apache/kafka/pull/10445 KIP-467 added a field in the produce response to allow the broker to indicate which specific records failed validation. This patch adds the logic to propagate this message up to the application.

[jira] [Commented] (KAFKA-9559) Change the default "default serde" from ByteArraySerde to null

2021-03-30 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17311954#comment-17311954 ] A. Sophie Blee-Goldman commented on KAFKA-9559: --- I don't think we can just

[GitHub] [kafka] mjsax commented on a change in pull request #10411: KAFKA-7606: Remove deprecated options from StreamsResetter

2021-03-30 Thread GitBox
mjsax commented on a change in pull request #10411: URL: https://github.com/apache/kafka/pull/10411#discussion_r604532122 ## File path: core/src/main/scala/kafka/tools/StreamsResetter.java ## @@ -247,14 +247,13 @@ private void parseArguments(final String[] args) {

[jira] [Commented] (KAFKA-12453) Guidance on whether a topology is eligible for optimisation

2021-03-30 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17311952#comment-17311952 ] Matthias J. Sax commented on KAFKA-12453: - Sweet! Thanks for digging it out [~ab

[jira] [Commented] (KAFKA-12419) Remove Deprecated APIs of Kafka Streams in 3.0

2021-03-30 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17311946#comment-17311946 ] Matthias J. Sax commented on KAFKA-12419: - [https://cwiki.apache.org/confluence/

[GitHub] [kafka] hachikuji commented on pull request #10443: KAFKA-8405; Remove deprecated `kafka-preferred-replica-election` command

2021-03-30 Thread GitBox
hachikuji commented on pull request #10443: URL: https://github.com/apache/kafka/pull/10443#issuecomment-810680451 I'm somewhat more inclined to just get rid of it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Commented] (KAFKA-9559) Change the default "default serde" from ByteArraySerde to null

2021-03-30 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17311945#comment-17311945 ] Matthias J. Sax commented on KAFKA-9559: {quote}Adding a check for NPE everywhere

[GitHub] [kafka] mjsax commented on a change in pull request #10411: KAFKA-7606: Remove deprecated options from StreamsResetter

2021-03-30 Thread GitBox
mjsax commented on a change in pull request #10411: URL: https://github.com/apache/kafka/pull/10411#discussion_r604528038 ## File path: core/src/main/scala/kafka/tools/StreamsResetter.java ## @@ -267,6 +266,10 @@ private void parseArguments(final String[] args) { C

[jira] [Commented] (KAFKA-12564) KTable#filter-method called twice after aggregation

2021-03-30 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12564?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17311943#comment-17311943 ] Matthias J. Sax commented on KAFKA-12564: - {quote}In the (stateless) filter-meth

[GitHub] [kafka] ableegoldman commented on a change in pull request #10411: KAFKA-7606: Remove deprecated options from StreamsResetter

2021-03-30 Thread GitBox
ableegoldman commented on a change in pull request #10411: URL: https://github.com/apache/kafka/pull/10411#discussion_r604523228 ## File path: core/src/main/scala/kafka/tools/StreamsResetter.java ## @@ -247,14 +247,13 @@ private void parseArguments(final String[] args) {

[jira] [Commented] (KAFKA-12574) Deprecate eos-alpha

2021-03-30 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17311939#comment-17311939 ] Matthias J. Sax commented on KAFKA-12574: - We discussed "auto-fall back" but the

[GitHub] [kafka] ableegoldman commented on a change in pull request #10411: KAFKA-7606: Remove deprecated options from StreamsResetter

2021-03-30 Thread GitBox
ableegoldman commented on a change in pull request #10411: URL: https://github.com/apache/kafka/pull/10411#discussion_r604521479 ## File path: core/src/main/scala/kafka/tools/StreamsResetter.java ## @@ -247,14 +247,13 @@ private void parseArguments(final String[] args) {

[GitHub] [kafka] satishd commented on pull request #10424: MINOR Replaced File with Path in LogSegmentData.

2021-03-30 Thread GitBox
satishd commented on pull request #10424: URL: https://github.com/apache/kafka/pull/10424#issuecomment-810666958 Thanks @junrao for the review. Addressed the comments in https://github.com/apache/kafka/commit/3c4d6e56220a85a5ed863cb634a2200408c4c0d5 commit. -- This is an automated messa

[GitHub] [kafka] mjsax commented on a change in pull request #10411: KAFKA-7606: Remove deprecated options from StreamsResetter

2021-03-30 Thread GitBox
mjsax commented on a change in pull request #10411: URL: https://github.com/apache/kafka/pull/10411#discussion_r604517220 ## File path: core/src/main/scala/kafka/tools/StreamsResetter.java ## @@ -247,14 +247,13 @@ private void parseArguments(final String[] args) {

[jira] [Resolved] (KAFKA-12571) Eliminate LeaderEpochFileCache constructor dependency on LogEndOffset

2021-03-30 Thread Jun Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao resolved KAFKA-12571. - Fix Version/s: 3.0.0 Resolution: Fixed merged the PR to trunk > Eliminate LeaderEpochFileCache c

[GitHub] [kafka] junrao merged pull request #10426: KAFKA-12571: Eliminate LeaderEpochFileCache constructor dependency on logEndOffset

2021-03-30 Thread GitBox
junrao merged pull request #10426: URL: https://github.com/apache/kafka/pull/10426 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [kafka] mjsax commented on a change in pull request #10411: KAFKA-7606: Remove deprecated options from StreamsResetter

2021-03-30 Thread GitBox
mjsax commented on a change in pull request #10411: URL: https://github.com/apache/kafka/pull/10411#discussion_r604515864 ## File path: core/src/main/scala/kafka/tools/StreamsResetter.java ## @@ -247,14 +246,10 @@ private void parseArguments(final String[] args) {

[jira] [Created] (KAFKA-12585) FencedInstanceIdException can cause heartbeat thread to never be closed

2021-03-30 Thread Brian Hawkins (Jira)
Brian Hawkins created KAFKA-12585: - Summary: FencedInstanceIdException can cause heartbeat thread to never be closed Key: KAFKA-12585 URL: https://issues.apache.org/jira/browse/KAFKA-12585 Project: Ka

[GitHub] [kafka] kowshik commented on pull request #10426: KAFKA-12571: Eliminate LeaderEpochFileCache constructor dependency on logEndOffset

2021-03-30 Thread GitBox
kowshik commented on pull request #10426: URL: https://github.com/apache/kafka/pull/10426#issuecomment-810660718 @junrao The jenkins tests have finished. I checked the test failures, they seem to be unrelated to this PR: ``` JDK 11: org.apache.kafka.connect.integration.RebalanceS

[jira] [Updated] (KAFKA-12288) Remove task-level filesystem locks

2021-03-30 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman updated KAFKA-12288: --- Fix Version/s: (was: 2.8.1) (was: 2.7.2)

[GitHub] [kafka] ableegoldman merged pull request #10342: KAFKA-12288: remove task-level filesystem locks

2021-03-30 Thread GitBox
ableegoldman merged pull request #10342: URL: https://github.com/apache/kafka/pull/10342 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, p

[GitHub] [kafka] ableegoldman commented on pull request #10342: KAFKA-12288: remove task-level filesystem locks

2021-03-30 Thread GitBox
ableegoldman commented on pull request #10342: URL: https://github.com/apache/kafka/pull/10342#issuecomment-810654638 Some unrelated failures: `streams.integration.EosIntegrationTest.shouldNotViolateEosIfOneTaskFailsWithState[exactly_once_beta]` `kafka.clients.admin.KafkaAdminClientT

[GitHub] [kafka] ableegoldman edited a comment on pull request #10411: KAFKA-7606: Remove deprecated options from StreamsResetter

2021-03-30 Thread GitBox
ableegoldman edited a comment on pull request #10411: URL: https://github.com/apache/kafka/pull/10411#issuecomment-810653716 Some unrelated failures: `kafka.clients.admin.KafkaAdminClientTest.testClientSideTimeoutAfterFailureToReceiveResponse()` (failed on all three builds) `kafka.se

[GitHub] [kafka] ableegoldman commented on pull request #10411: KAFKA-7606: Remove deprecated options from StreamsResetter

2021-03-30 Thread GitBox
ableegoldman commented on pull request #10411: URL: https://github.com/apache/kafka/pull/10411#issuecomment-810653716 Some unrelated failures: `kafka.clients.admin.KafkaAdminClientTest.testClientSideTimeoutAfterFailureToReceiveResponse()` (failed on all three builds) `kafka.server.Ra

[GitHub] [kafka] ableegoldman commented on a change in pull request #10444: HOTFIX: move rebalanceInProgress check to skip commit during handleCorrupted

2021-03-30 Thread GitBox
ableegoldman commented on a change in pull request #10444: URL: https://github.com/apache/kafka/pull/10444#discussion_r604505465 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -1013,28 +1016,34 @@ void addRecordsToTasks(

[GitHub] [kafka] ableegoldman opened a new pull request #10444: HOTFIX: move rebalanceInProgress check to skip commit during handleCorrupted

2021-03-30 Thread GitBox
ableegoldman opened a new pull request #10444: URL: https://github.com/apache/kafka/pull/10444 Minor followup to https://github.com/apache/kafka/pull/10407 -- we need to extract the `rebalanceInProgress` check down into the `commitAndFillInConsumedOffsetsAndMetadataPerTaskMap` method which

[GitHub] [kafka] hachikuji merged pull request #10398: MINOR: Fix newly added flaky test `testClientSideTimeoutAfterFailureTest`

2021-03-30 Thread GitBox
hachikuji merged pull request #10398: URL: https://github.com/apache/kafka/pull/10398 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, plea

[jira] [Commented] (KAFKA-12574) Deprecate eos-alpha

2021-03-30 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17311787#comment-17311787 ] A. Sophie Blee-Goldman commented on KAFKA-12574: > I think this is sligh

[jira] [Commented] (KAFKA-12265) Move the BatchAccumulator in KafkaRaftClient to LeaderState

2021-03-30 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17311777#comment-17311777 ] Jose Armando Garcia Sancio commented on KAFKA-12265: [~rohitdeshaws]

[jira] [Commented] (KAFKA-12574) Deprecate eos-alpha

2021-03-30 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17311750#comment-17311750 ] Ismael Juma commented on KAFKA-12574: - A few comments: # I think eos-v2 would be a

[jira] [Updated] (KAFKA-12509) Tighten up StateDirectory thread locking

2021-03-30 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman updated KAFKA-12509: --- Fix Version/s: 3.0.0 > Tighten up StateDirectory thread locking > --

[jira] [Resolved] (KAFKA-12509) Tighten up StateDirectory thread locking

2021-03-30 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman resolved KAFKA-12509. Resolution: Fixed > Tighten up StateDirectory thread locking > ---

[GitHub] [kafka] ableegoldman commented on a change in pull request #10342: KAFKA-12288: remove task-level filesystem locks

2021-03-30 Thread GitBox
ableegoldman commented on a change in pull request #10342: URL: https://github.com/apache/kafka/pull/10342#discussion_r604366210 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StateDirectory.java ## @@ -444,22 +408,30 @@ public synchronized vo

[GitHub] [kafka] ableegoldman merged pull request #10418: KAFKA-12509 Tighten up StateDirectory thread locking

2021-03-30 Thread GitBox
ableegoldman merged pull request #10418: URL: https://github.com/apache/kafka/pull/10418 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, p

[GitHub] [kafka] ableegoldman commented on pull request #10418: KAFKA-12509 Tighten up StateDirectory thread locking

2021-03-30 Thread GitBox
ableegoldman commented on pull request #10418: URL: https://github.com/apache/kafka/pull/10418#issuecomment-810512500 Merged to trunk -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [kafka] ableegoldman commented on pull request #10418: KAFKA-12509 Tighten up StateDirectory thread locking

2021-03-30 Thread GitBox
ableegoldman commented on pull request #10418: URL: https://github.com/apache/kafka/pull/10418#issuecomment-810512151 Just some known flaky test failures: `RaftClusterTest.testCreateClusterAndCreateListDeleteTopic()` and the timeout we've been seeing lately -- This is an automated messa

[GitHub] [kafka] kowshik commented on pull request #10426: KAFKA-12571: Eliminate LeaderEpochFileCache constructor dependency on logEndOffset

2021-03-30 Thread GitBox
kowshik commented on pull request #10426: URL: https://github.com/apache/kafka/pull/10426#issuecomment-810485209 @junrao Jenkins doesn't seem to be starting up tests after I rebased this morning. I'm not sure what's going on. I'll try again today. -- This is an automated message from the

[jira] [Updated] (KAFKA-12574) Deprecate eos-alpha

2021-03-30 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman updated KAFKA-12574: --- Priority: Blocker (was: Major) > Deprecate eos-alpha > ---

[jira] [Updated] (KAFKA-12574) Deprecate eos-alpha

2021-03-30 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman updated KAFKA-12574: --- Labels: needs-kip (was: ) > Deprecate eos-alpha > --- > >

[jira] [Commented] (KAFKA-12574) Deprecate eos-alpha

2021-03-30 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17311717#comment-17311717 ] A. Sophie Blee-Goldman commented on KAFKA-12574: That SGTM -- if users b

[GitHub] [kafka] kowshik edited a comment on pull request #10280: KAFKA-12554: Refactor Log layer

2021-03-30 Thread GitBox
kowshik edited a comment on pull request #10280: URL: https://github.com/apache/kafka/pull/10280#issuecomment-808514958 @junrao Just a heads up on the following. I'm working on the changes for the following in separate PRs, these are related with refactoring the recovery logic (KAFKA-12553

[jira] [Commented] (KAFKA-12574) Deprecate eos-alpha

2021-03-30 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17311697#comment-17311697 ] Guozhang Wang commented on KAFKA-12574: --- Yeah.. I also felt this procedure require

[jira] [Commented] (KAFKA-12574) Deprecate eos-alpha

2021-03-30 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17311685#comment-17311685 ] A. Sophie Blee-Goldman commented on KAFKA-12574: Yes, something like tha

[GitHub] [kafka] guozhangwang commented on pull request #10345: KAFKA-12477: dynamically upgrade rebalancing protocol based on selected assignor

2021-03-30 Thread GitBox
guozhangwang commented on pull request #10345: URL: https://github.com/apache/kafka/pull/10345#issuecomment-810431786 Sounds great, will follow-up on KIP-726. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [kafka] guozhangwang commented on pull request #10407: KAFKA-12523: handle TaskCorruption/TimeoutException during handleCorruption and handleRevocation

2021-03-30 Thread GitBox
guozhangwang commented on pull request #10407: URL: https://github.com/apache/kafka/pull/10407#issuecomment-810429831 Thanks @ableegoldman ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [kafka] junrao commented on a change in pull request #10424: MINOR Replaced File with Path in LogSegmentData.

2021-03-30 Thread GitBox
junrao commented on a change in pull request #10424: URL: https://github.com/apache/kafka/pull/10424#discussion_r604277850 ## File path: clients/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogSegmentMetadata.java ## @@ -82,26 +82,26 @@ /** * Cre

[jira] [Commented] (KAFKA-12574) Deprecate eos-alpha

2021-03-30 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17311648#comment-17311648 ] Guozhang Wang commented on KAFKA-12574: --- I agree we should try to encourage users

[GitHub] [kafka] junrao commented on pull request #10426: KAFKA-12571: Eliminate LeaderEpochFileCache constructor dependency on logEndOffset

2021-03-30 Thread GitBox
junrao commented on pull request #10426: URL: https://github.com/apache/kafka/pull/10426#issuecomment-810421289 @kowshik : Do you know why the tests timed out? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[jira] [Resolved] (KAFKA-12552) Extract segments map out of Log class into separate class

2021-03-30 Thread Jun Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jun Rao resolved KAFKA-12552. - Fix Version/s: 3.0.0 Resolution: Fixed Merged the PR to trunk. > Extract segments map out of Log

[GitHub] [kafka] mumrah commented on a change in pull request #10398: MINOR: Fix newly added flaky test `testClientSideTimeoutAfterFailureTest`

2021-03-30 Thread GitBox
mumrah commented on a change in pull request #10398: URL: https://github.com/apache/kafka/pull/10398#discussion_r604267269 ## File path: clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java ## @@ -5325,12 +5326,23 @@ public void testClientSideTimeoutA

[GitHub] [kafka] junrao merged pull request #10401: KAFKA-12552: Introduce LogSegments class abstracting the segments map

2021-03-30 Thread GitBox
junrao merged pull request #10401: URL: https://github.com/apache/kafka/pull/10401 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [kafka] hachikuji commented on pull request #10404: KAFKA-12557: Fix hanging KafkaAdminClientTest

2021-03-30 Thread GitBox
hachikuji commented on pull request #10404: URL: https://github.com/apache/kafka/pull/10404#issuecomment-810415561 @vvcephei @guozhangwang @ijuma The new tests still have race conditions which need to be fixed. I have a patch here: https://github.com/apache/kafka/pull/10398. -- This is

[jira] [Resolved] (KAFKA-12557) org.apache.kafka.clients.admin.KafkaAdminClientTest#testClientSideTimeoutAfterFailureToReceiveResponse intermittently hangs indefinitely

2021-03-30 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12557?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler resolved KAFKA-12557. -- Resolution: Fixed > org.apache.kafka.clients.admin.KafkaAdminClientTest#testClientSideTimeoutA

[GitHub] [kafka] vvcephei merged pull request #10404: KAFKA-12557: Fix hanging KafkaAdminClientTest

2021-03-30 Thread GitBox
vvcephei merged pull request #10404: URL: https://github.com/apache/kafka/pull/10404 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, pleas

[GitHub] [kafka] vvcephei commented on pull request #10404: KAFKA-12557: Fix hanging KafkaAdminClientTest

2021-03-30 Thread GitBox
vvcephei commented on pull request #10404: URL: https://github.com/apache/kafka/pull/10404#issuecomment-810405595 Confirmed that the tests still pass after that last small patch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [kafka] chia7712 commented on pull request #10435: KAFKA-12578: Remove deprecated security classes/methods for 3.0

2021-03-30 Thread GitBox
chia7712 commented on pull request #10435: URL: https://github.com/apache/kafka/pull/10435#issuecomment-810385150 Is `Resource` exposed to users? It appears that we don't create `Resource` except for `Resource CLUSTER`. If `Resource` is not a kind of public APIs, I feel it can be removed a

[jira] [Resolved] (KAFKA-12435) Several streams-test-utils classes missing from javadoc

2021-03-30 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler resolved KAFKA-12435. -- Resolution: Fixed > Several streams-test-utils classes missing from javadoc >

[GitHub] [kafka] vvcephei commented on a change in pull request #10404: KAFKA-12557: Fix hanging KafkaAdminClientTest

2021-03-30 Thread GitBox
vvcephei commented on a change in pull request #10404: URL: https://github.com/apache/kafka/pull/10404#discussion_r604216817 ## File path: clients/src/test/java/org/apache/kafka/clients/admin/AdminClientUnitTestEnv.java ## @@ -113,6 +114,9 @@ public MockClient kafkaClient() {

[GitHub] [kafka] ijuma commented on pull request #10443: KAFKA-8405; Remove deprecated `kafka-preferred-replica-election` command

2021-03-30 Thread GitBox
ijuma commented on pull request #10443: URL: https://github.com/apache/kafka/pull/10443#issuecomment-810368591 Good question. I think this script is more widely used since it has existed for a lot longer than the admin commands we have removed in #10440. One question: could the script just

[GitHub] [kafka] dajac commented on pull request #10436: KAFKA-12577; Remove deprecated ConfigEntry constructor

2021-03-30 Thread GitBox
dajac commented on pull request #10436: URL: https://github.com/apache/kafka/pull/10436#issuecomment-810350507 @ijuma Updated the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [kafka] dajac commented on pull request #10443: KAFKA-8405; Remove deprecated `kafka-preferred-replica-election` command

2021-03-30 Thread GitBox
dajac commented on pull request #10443: URL: https://github.com/apache/kafka/pull/10443#issuecomment-810349142 @ijuma What do you think about this one? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [kafka] dajac opened a new pull request #10443: KAFKA-8405; Remove deprecated `kafka-preferred-replica-election` command

2021-03-30 Thread GitBox
dajac opened a new pull request #10443: URL: https://github.com/apache/kafka/pull/10443 The `kafka-preferred-replica-election` command was deprecated in 2.4. As we removed the related APIs in the Admin client (https://github.com/apache/kafka/pull/10440), we can also remove the command lin

[GitHub] [kafka] dajac commented on a change in pull request #10436: KAFKA-12577; Remove deprecated ConfigEntry constructor

2021-03-30 Thread GitBox
dajac commented on a change in pull request #10436: URL: https://github.com/apache/kafka/pull/10436#discussion_r604193906 ## File path: docs/upgrade.html ## @@ -28,6 +28,8 @@ Notable changes in 3 The Streams API removed all deprecated APIs that were deprecated in version

[GitHub] [kafka] ijuma commented on pull request #10435: KAFKA-12578: Remove deprecated security classes/methods for 3.0

2021-03-30 Thread GitBox
ijuma commented on pull request #10435: URL: https://github.com/apache/kafka/pull/10435#issuecomment-810345988 Updated @chia7712 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

  1   2   >