[GitHub] [kafka] showuon commented on a change in pull request #10457: KAFKA-12588: remove --zookeeper option from topic command

2021-04-02 Thread GitBox
showuon commented on a change in pull request #10457: URL: https://github.com/apache/kafka/pull/10457#discussion_r606159844 ## File path: core/src/main/scala/kafka/admin/TopicCommand.scala ## @@ -739,16 +573,14 @@ object TopicCommand extends Logging {

[GitHub] [kafka] showuon commented on a change in pull request #10457: KAFKA-12588: remove --zookeeper option from topic command

2021-04-02 Thread GitBox
showuon commented on a change in pull request #10457: URL: https://github.com/apache/kafka/pull/10457#discussion_r606159713 ## File path: core/src/main/scala/kafka/admin/TopicCommand.scala ## @@ -670,9 +505,9 @@ object TopicCommand extends Logging { private val

[GitHub] [kafka] mjsax opened a new pull request #10464: MINOR: remove KTable.to from the docs

2021-04-02 Thread GitBox
mjsax opened a new pull request #10464: URL: https://github.com/apache/kafka/pull/10464 Call for review @bbejeck -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For

[GitHub] [kafka] showuon commented on pull request #10408: KAFKA-12283: disable flaky testMultipleWorkersRejoining to stabilize build

2021-04-02 Thread GitBox
showuon commented on pull request #10408: URL: https://github.com/apache/kafka/pull/10408#issuecomment-812398117 Per our discussion in KAFKA-12283

[jira] [Commented] (KAFKA-12283) Flaky Test RebalanceSourceConnectorsIntegrationTest#testMultipleWorkersRejoining

2021-04-02 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17313679#comment-17313679 ] Luke Chen commented on KAFKA-12283: --- [~kkonstantine], thanks for your response. OK, we can discuss for

[GitHub] [kafka] predatorray edited a comment on pull request #5858: KAFKA-7572: Producer should not send requests with negative partition id

2021-04-02 Thread GitBox
predatorray edited a comment on pull request #5858: URL: https://github.com/apache/kafka/pull/5858#issuecomment-812392791 Hi @viktorsomogyi. Any update on this pull request and the issue KAFKA-7572? It looks like the author's account has been deleted. Can i submit a new pull request on

[GitHub] [kafka] predatorray commented on pull request #5858: KAFKA-7572: Producer should not send requests with negative partition id

2021-04-02 Thread GitBox
predatorray commented on pull request #5858: URL: https://github.com/apache/kafka/pull/5858#issuecomment-812392791 Hi @viktorsomogyi. Any update on this pull request and the issue KAFKA-7572? It looks like the committer has been deleted. -- This is an automated message from the Apache

[GitHub] [kafka] dajac commented on a change in pull request #10446: MINOR: [ConfigEntry.class] add 'type' to 'toString' and 'hashCode'

2021-04-02 Thread GitBox
dajac commented on a change in pull request #10446: URL: https://github.com/apache/kafka/pull/10446#discussion_r606094276 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/ConfigEntry.java ## @@ -167,6 +169,8 @@ public int hashCode() { result = prime

[GitHub] [kafka] abbccdda commented on a change in pull request #10142: KAFKA-12294: forward auto topic request within envelope on behalf of clients

2021-04-02 Thread GitBox
abbccdda commented on a change in pull request #10142: URL: https://github.com/apache/kafka/pull/10142#discussion_r606089230 ## File path: core/src/test/scala/unit/kafka/server/AutoTopicCreationManagerTest.scala ## @@ -219,6 +225,146 @@ class AutoTopicCreationManagerTest {

<    1   2